On 05/07/2014 05:13 PM, Jasper St. Pierre wrote:
Looks mostly the same as Ander's patch here:
My patch didn't handle global remove properly, so I'd say we should go
with this one.
Ander
http://lists.freedesktop.org/archives/wayland-devel/2014-May/014658.html
Same review applies :)
On W
On 05/07/2014 05:27 PM, Neil Roberts wrote:
Oh no, I didn't notice this patch buried in the patch series and
implemented the same thing:
http://lists.freedesktop.org/archives/wayland-devel/2014-May/014690.html
Ander, it would be really helpful if you could leave a little note on
the bug report
On 05/07/2014 04:10 PM, Jasper St. Pierre wrote:
Hm, it seems to me that hiding a layer should cause all the regions it
occupied to be marked as needing repaint. Fixing the scene graph is
better than a one-off at the end of an animation.
I agree. I actually sent a patch in January to create a
On Wed, 07 May 2014 13:10:31 -0700
Bill Spitzak wrote:
> Good to see there is an actual bug on this, but I need to ask for our
> exact case:
No, there is not. The bug report was not a valid bug, and is now closed.
> Our app can be configured to have 2 (well actually any number) of
> windows.
Please always use reply-to-all, you have dropped a lot people from CC.
On Wed, 07 May 2014 11:02:56 -0700
Bill Spitzak wrote:
> On 05/07/2014 01:47 AM, Pekka Paalanen wrote:
>
> > It is for normal windows like registered with xdg_shell where
> > sub-surfaces are not suitable for tooltips. A sub
On Wed, 7 May 2014 16:21:24 +0200
Marek Chalupa wrote:
> When an error occurs, wl_display_get_error() does not
> provide any way of getting know if it was a local error or if it was
> an error event, respectively what object caused the error and what
> the error was.
>
> This patch introduces a
On Wed, May 7, 2014 at 9:31 PM, Jason Ekstrand wrote:
>
>
>
> On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre
> wrote:
>
>> This allows compositors to easily select a good display to listen on.
>> ---
>> src/wayland-server.c | 23 +++
>> src/wayland-server.h | 2 ++
>> 2
I won't claim to be an autotools expert, but this looks sane to me.
Probably something we want to take care of for 1.5.
Reviewed-by: Jason Ekstrand
On Wed, May 7, 2014 at 7:09 AM, Thierry Reding wrote:
> From: Thierry Reding
>
> The wayland-server-protocol.h and wayland-client-protocol.h head
Boyan,
By and large, this looks really good! I have just a few comments below.
As I said in another e-mail, I don't have any touch hardware I can test
this on, so I wasn't able to actually test it.
On Tue, May 6, 2014 at 9:46 PM, Boyan Ding wrote:
> Adding touch support to weston's nested wayl
Boyan,
Thanks for picking this up! I'm making some comments on the patches
themselves. Unfortunately, I don't have touch hardware to test it with,
but I hope my comments are helpful none the less.
--Jason Ekstrand
On Tue, May 6, 2014 at 9:46 PM, Boyan Ding wrote:
> The following two patches a
On Tue, May 6, 2014 at 9:46 PM, Boyan Ding wrote:
> ---
> shared/cairo-util.h | 3 +++
> shared/frame.c | 24
> 2 files changed, 27 insertions(+)
>
> diff --git a/shared/cairo-util.h b/shared/cairo-util.h
> index 4493b0d..7aebb65 100644
> --- a/shared/cairo-util.h
On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre wrote:
> This allows compositors to easily select a good display to listen on.
> ---
> src/wayland-server.c | 23 +++
> src/wayland-server.h | 2 ++
> 2 files changed, 25 insertions(+)
>
> diff --git a/src/wayland-server.c b/s
Comments below,
--Jason Ekstrand
On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre wrote:
> We'll use this to autodetect a good socket to open on.
> ---
> src/wayland-server.c | 40 +---
> 1 file changed, 25 insertions(+), 15 deletions(-)
>
> diff --git a/src/
Yeah, this looks good to me. It does change the order of a couple of
system calls, but it looks ok to me.
Reviewed-by: Jason Ekstrand
On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre wrote:
> ---
> src/wayland-server.c | 15 +++
> 1 file changed, 7 insertions(+), 8 deletions(-)
Hi,
I'm porting sddm (QtQuick based display manager) to Wayland, it's
still work in progress but close to be in a usable state and you can
find it here:
https://github.com/plfiorini/sddm/tree/wayland
There are some multiple screen issues specific to how sddm work
compared to wl_fullscreen_shell
Good to see there is an actual bug on this, but I need to ask for our
exact case:
Our app can be configured to have 2 (well actually any number) of
windows. Normally each window is maximized or fullscreen on a different
output. User expects to be able to rearrange the windows, change their
si
This fixes a few possible NULL deref's, too... not that it matters much
once you're in an OOM situation.
LGTM
-- U. Artie
> -Original Message-
> From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On
> Behalf Of Bryce W. Harrington
> Sent: Tuesday, May 06, 2014 7:13
On 7 May 2014 20:23, Bill Spitzak wrote:
> If a subsurface belongs to a different client than the parent surface,
> though, does this mean the child client will get events that have an xy
> position relative to the parent surface?
As a fundamental design point of the Wayland protocol is that cl
Sorry, what I meant was the surface id and xy location in events.
If a subsurface belongs to a different client than the parent surface,
though, does this mean the child client will get events that have an xy
position relative to the parent surface?
On 05/07/2014 11:05 AM, Jasper St. Pierre w
Free the theme configuration string right after wl_cursor_load_theme
since we're done using it. This fixes a leak when the cursor theme
could not be loaded.
Signed-off-by: U. Artie Eoff
---
src/compositor-wayland.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/comp
On 05/07/2014 03:04 AM, Pekka Paalanen wrote:
Maybe you forgot to set some of the environment variables from here:
http://wayland.freedesktop.org/building.html
Don't play with the foofoo_CFLAGS and foofoo_LIBS variables, it is much
better to fix pkg-config to find the right .pc files.
Thank y
Events aren't delivered to surfaces. They're delivered to clients.
On Wed, May 7, 2014 at 2:02 PM, Bill Spitzak wrote:
> On 05/07/2014 01:47 AM, Pekka Paalanen wrote:
>
> It is for normal windows like registered with xdg_shell where
>> sub-surfaces are not suitable for tooltips. A sub-surface
On 05/07/2014 01:47 AM, Pekka Paalanen wrote:
It is for normal windows like registered with xdg_shell where
sub-surfaces are not suitable for tooltips. A sub-surface is a part of
the window, not another window. A tooltip is not expected to change the
window geometry, but a sub-surface does count
Yes i'm working for embedded platform where with current desktop shell we
cant debug two overlays visually running same apps with same size.
Thanks You .
Rohit Nandan
On Wed, May 7, 2014 at 6:49 PM, Jasper St. Pierre wrote:
> The rationale explained in the bug by Pekka and Emilio sounds OK to
Oh no, I didn't notice this patch buried in the patch series and
implemented the same thing:
http://lists.freedesktop.org/archives/wayland-devel/2014-May/014690.html
Ander, it would be really helpful if you could leave a little note on
the bug report if you post a patch to reduce that chance that
---
src/compositor.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/compositor.c b/src/compositor.c
index 3d65e4c..1906441 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -4150,7 +4150,7 @@ int main(int argc, char *argv[])
char *server_socket = NULL, *e
---
src/wayland-server.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index e850d48..d0fd280 100644
--- a/src/wayland-server.c
+++ b/src/wayland-server.c
@@ -1061,12 +1061,6 @@ wl_display_add_socket(struct wl_displa
This allows compositors to easily select a good display to listen on.
---
src/wayland-server.c | 23 +++
src/wayland-server.h | 2 ++
2 files changed, 25 insertions(+)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index 6bc8dc3..5624199 100644
--- a/src/wayland-ser
We'll use this to autodetect a good socket to open on.
---
src/wayland-server.c | 40 +---
1 file changed, 25 insertions(+), 15 deletions(-)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index d0fd280..6bc8dc3 100644
--- a/src/wayland-server.c
+++ b/
v2 of my patch series. v1 was broken because I didn't test it properly.
This one should actually work. First patch also had a resource leak
fixed. Second patch is the same. Third patch takes a new approach.
Jasper St. Pierre (3):
server: Create the socket FD after taking the lock
server: Spli
On 5 May 2014 15:02, Pekka Paalanen wrote:
> On Wed, 30 Apr 2014 10:11:01 +0200
> Marek Chalupa wrote:
>
> > When an error occurs, wl_display_get_error() does not
> > provide any way of getting know if it was a local error or if it was
> > an error event, respectively what object caused the erro
When an error occurs, wl_display_get_error() does not
provide any way of getting know if it was a local error or if it was
an error event, respectively what object caused the error and what
the error was.
This patch introduces a new function wl_display_get_protocol_error()
which will return error
Looks mostly the same as Ander's patch here:
http://lists.freedesktop.org/archives/wayland-devel/2014-May/014658.html
Same review applies :)
On Wed, May 7, 2014 at 10:00 AM, Neil Roberts wrote:
> Previously simple-touch would only handle one seat. If there were
> multiple seats it would lose
Previously simple-touch would only handle one seat. If there were
multiple seats it would lose track of whether there is a touch device
available depending on what order the capability events arrive in.
This makes it keep a linked list of seats and to track a separate
touch device for each seat so
On Wed, 7 May 2014 09:07:27 -0400
"Jasper St. Pierre" wrote:
> ---
> src/compositor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compositor.c b/src/compositor.c
> index 120818f..85a75bf 100644
> --- a/src/compositor.c
> +++ b/src/compositor.c
> @@ -4306,7 +430
On Wed, 7 May 2014 09:07:26 -0400
"Jasper St. Pierre" wrote:
> This took me a few minutes to figure out, so document it for the
> next person who stumbles in here.
> ---
> src/compositor.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/compositor.c b/src/co
From: Pekka Paalanen
Again, load the shell plugin with full path, rather than possibly find an
old version from a previous installation.
Signed-off-by: Pekka Paalanen
---
tests/weston-tests-env | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/weston-tests-env b/tests/weston-tests-e
From: Pekka Paalanen
Useful for unit tests. If Weston finds a weston.ini during unit tests,
it will load it and all the modules it asks for. We need a way to
prevent loading arbitrary modules from the command line.
Signed-off-by: Pekka Paalanen
---
man/weston.man | 6 ++
src/compositor.c
I love the simple typos like this. LGTM.
On Tue, May 6, 2014 at 5:50 PM, U. Artie Eoff wrote:
> Signed-off-by: U. Artie Eoff
> ---
> src/compositor-wayland.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
> index 35e
From: Pekka Paalanen
Use --no-config to avoid loading arbitrary weston.ini files from unit
tests. It may affect the unit test results.
I actually hit the following case:
[13:34:04.636] Using config file '/home/pq/local/etc/weston.ini'
[13:34:04.636] Loading module '/home/pq/git/weston/.libs/hea
From: Pekka Paalanen
Hi,
random little things here. I mostly wanted to make the Xwayland
unit test work again. This patch series at least makes it run
the right thing, but it still fails.
Is the Xwayland test supposed to even work at all now?
Are there some requirements for the xserver ./config
From: Pekka Paalanen
If the test is named xwayland.weston, then the automake test harness
keys it off xwayland.log. Making xwayland.log runs the test.
The test harness has implicit rules to create a %.log from all of
%$TEST_EXTENSIONS. So we have implicit rules to create %.log from %.la
and %.log
From: Pekka Paalanen
If we do not specify the full path to xwayland.so, Weston can find an
old one installed in a $prefix and use that instead of the freshly built
one.
Signed-off-by: Pekka Paalanen
---
tests/weston-tests-env | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --
The rationale explained in the bug by Pekka and Emilio sounds OK to me.
Explaining a bit more about your use case with your data visualization app
might be helpful.
What kinds of systems do you want your app to be run on? Generic desktop
systems? If so, then you can't guarantee anything about util
I was wondering why you didn't move the pointer / keyboard fields to the
seat, before noticing that they were unused. It might make sense to have a
prereq patch that removes those unused fields.
This patch looks good, though.
On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira <
conselv.
Yep, looks good.
On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira <
conselv...@gmail.com> wrote:
> From: Ander Conselvan de Oliveira
>
> The check to avoid calling weston_keyboard_set_focus() for a seat that
> didn't have a keyboard in restore_focus_state() was cheking the wrong
> se
Hm, it seems to me that hiding a layer should cause all the regions it
occupied to be marked as needing repaint. Fixing the scene graph is better
than a one-off at the end of an animation.
On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira <
conselv...@gmail.com> wrote:
> From: Ander Co
Of course I mean WAYLAND_DISPLAY, not WAYLAND_SOCKET. Whoops.
On Wed, May 7, 2014 at 9:05 AM, Jasper St. Pierre wrote:
> This patch series implements a better fallback than a hardcoded
> "wayland-0" when a server socket has already been taken. This way,
> the code for searching for an appropriat
This took me a few minutes to figure out, so document it for the
next person who stumbles in here.
---
src/compositor.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/compositor.c b/src/compositor.c
index 3d65e4c..120818f 100644
--- a/src/compositor.c
+++ b/src/comp
---
src/compositor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compositor.c b/src/compositor.c
index 120818f..85a75bf 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -4306,7 +4306,7 @@ int main(int argc, char *argv[])
wl_client_add_destroy_list
This removes a small cleanup path.
---
src/wayland-server.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index e850d48..d299000 100644
--- a/src/wayland-server.c
+++ b/src/wayland-server.c
@@ -1061,12 +1061,6 @@ wl_d
We'll use this to autodetect a good socket to open on.
---
src/wayland-server.c | 40 +---
1 file changed, 25 insertions(+), 15 deletions(-)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index d299000..3390171 100644
--- a/src/wayland-server.c
+++ b/
Rather than just trying wayland-0 and bailing out if it's in use.
---
src/wayland-server.c | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index 3390171..ba13168 100644
--- a/src/wayland-server.c
+++ b/s
This patch series implements a better fallback than a hardcoded
"wayland-0" when a server socket has already been taken. This way,
the code for searching for an appropriate socket is shared between
all compositors.
The option to open an explicit socket still exists, if the client
specifies it.
Ja
From: Thierry Reding
The wayland-server-protocol.h and wayland-client-protocol.h headers are
currently being shipped in tarballs created using make dist. This causes
out-of-tree builds to fail since make will detect that the headers exist
by looking at the source directory (via VPATH) and not reg
Hi, Pq
>
> I meant this very simple example:
>
> There is only one output A.
>
> A
>
> Then I add output B to the left of A.
>
> B->A
>
> The position of A must not change. This means that B must get negative
> coordinates, and A's position stays at 0,0. In Weston, window positions are
> sto
From: Ander Conselvan de Oliveira
Moving a maximized surface with the pointer is already not possible,
so make the behavior with touch consistent.
https://bugs.freedesktop.org/show_bug.cgi?id=78208
---
desktop-shell/shell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/des
On Tue, 11 Mar 2014 18:11:43 +
"Bryce W. Harrington" wrote:
>
> Signed-off-by: Bryce Harrington
> ---
> .gitignore |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index e0a73c0..d3044a2 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -2,6 +2,7 @@
On Wed, 07 May 2014 09:37:45 +0530
Srivardhan Hebbar wrote:
> Signed-off-by: Srivardhan Hebbar
> ---
> src/wayland-server.c |9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/wayland-server.c b/src/wayland-server.c
> index f2b1b42..57b65ce 100644
> --- a/src/wayland-serve
On Tue, 06 May 2014 19:36:59 -0700
Bill Spitzak wrote:
> Okay, I am trying to build wayland again, from instructions, on a new
> machine.
>
> I am stuck trying to compile mesa:
>
> ./autogen.sh --prefix=$WLD --enable-gles2 --disable-gallium-egl
> --with-egl-platforms=x11,wayland,drm --enable-
On Wed, 07 May 2014 02:13:10 +
"Bryce W. Harrington" wrote:
> As per our discussion last week, here's patches to convert client code
> to using xmalloc, xzalloc, xcalloc, and xstrdup where appropriate.
>
> I opted not to change nested.c, because it looked like errors were
> being propagated
On Wed, 07 May 2014 01:11:07 +
"Bryce W. Harrington" wrote:
> Quells warning:
> clients/keyboard.c: In function ‘keyboard_handle_key.isra.5’:
> clients/keyboard.c:556:11: warning: ‘label’ may be used
> uninitialized in this function [-Wuninitialized]
>
> Signed-off-by: Bryce Harrington
Please go through this NOTABUG bug.
https://bugs.freedesktop.org/show_bug.cgi?id=78372
Rohit Nandan
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
On Wed, 7 May 2014 08:49:47 +
"Wang, Quanxian" wrote:
> > -Original Message-
> > From: Pekka Paalanen [mailto:ppaala...@gmail.com]
> > Sent: Wednesday, May 7, 2014 3:41 PM
> > To: Wang, Quanxian
> > Subject: Re: [Weston] More discussion about weston output relative
> > motion algorith
From: Ander Conselvan de Oliveira
If simple-touch ran on a compositor with multiple seats, and the first
one happened to have the touch capability while the second one didn't,
the handler for seat capabilities would destroy the wl_touch device it
created on the first call for the first seat when
From: Ander Conselvan de Oliveira
The check to avoid calling weston_keyboard_set_focus() for a seat that
didn't have a keyboard in restore_focus_state() was cheking the wrong
seat (the one from the previous loop). That caused a crash when
switching workspaces if there was an extra seat that didn'
From: Ander Conselvan de Oliveira
Views that extend past the bottom of the output are still visible after
the workspace animation ends but before its layer is hidden. When the
layer was hidden, nothing would cause those regions to be repainted,
leading to artifacts.
https://bugs.freedesktop.org/
> -Original Message-
> From: Pekka Paalanen [mailto:ppaala...@gmail.com]
> Sent: Wednesday, May 7, 2014 3:41 PM
> To: Wang, Quanxian
> Cc: Hardening (rdp.eff...@gmail.com); Bryce W. Harrington
> (b.harring...@samsung.com); wayland-devel@lists.freedesktop.org; Jason
> Ekstrand (ja...@jleks
On Tue, 6 May 2014 14:40:53 -0700
Kristian Høgsberg wrote:
> On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira
> wrote:
> > From: Ander Conselvan de Oliveira
> >
> >
> > Otherwise it might receive touch events.
>
> I think a better approach is to just hide the tooltip if it
On Wed, 7 May 2014 07:03:32 +
"Wang, Quanxian" wrote:
>
>
> > -Original Message-
> > From: Pekka Paalanen [mailto:ppaala...@gmail.com]
> > Sent: Wednesday, May 7, 2014 2:17 PM
> > To: Wang, Quanxian
> > Cc: Hardening (rdp.eff...@gmail.com); Bryce W. Harrington
> > (b.harring...@sams
> -Original Message-
> From: Pekka Paalanen [mailto:ppaala...@gmail.com]
> Sent: Wednesday, May 7, 2014 2:17 PM
> To: Wang, Quanxian
> Cc: Hardening (rdp.eff...@gmail.com); Bryce W. Harrington
> (b.harring...@samsung.com); wayland-devel@lists.freedesktop.org; Jason
> Ekstrand (ja...@jleks
71 matches
Mail list logo
