Re: [PATCH libinput v2] evdev-mt-touchpad: check calloc result

2014-04-29 Thread Peter Hutterer
On Tue, Apr 29, 2014 at 01:26:28AM +0200, Carlos Olmedo Escobar wrote: > Check the value returned by calloc. > > Signed-off-by: Carlos Olmedo Escobar pushed, with a minor change in the commit message. thanks. Cheers, Peter > --- > src/evdev-mt-touchpad.c | 2 ++ > 1 file changed, 2 inserti

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Bill Spitzak
On 04/29/2014 01:07 PM, Kristian Høgsberg wrote: I'd like to drop cairo-egl, but not in a way that makes window.c shm only. I'd like it to use GL by default and use cairo for rendering assets, for example, render the frame in cairo, but use gl to stretch and scale it and composite the title on

Re: [PATCH] desktop-shell: Properly handle seat hotplugging

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 21, 2014 at 07:42:58PM -0500, Jason Ekstrand wrote: > Previously, desktop-shell would only create its internal shell_seat object > for each seat available when the desktop-shell module is loaded. This is a > problem any time seats are created dynamically. In particular, the Wayland >

Re: [PATCH weston] desktop-shell: Properly handle lowered fullscreen surfaces

2014-04-29 Thread Kristian Høgsberg
On Thu, Jan 30, 2014 at 02:01:10PM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > lower_fullscreen_surface() was removing fullscreen surfaces from > the fullscreen layer and inserting them in the normal workspace > layer. However, those fullscreen surfaces were never put back

Re: [PATCH] Wrong bo handles can be referenced in func call, drmModeAddFB2 due to uninitialized array elements in handles[4]

2014-04-29 Thread David Herrmann
Hi On Tue, Apr 29, 2014 at 10:59 PM, Matt Roper wrote: > On Tue, Apr 29, 2014 at 01:24:31PM -0700, Kristian Høgsberg wrote: >> On Mon, Apr 28, 2014 at 03:26:18PM -0700, Dongwon Kim wrote: >> > Need all bo handles in the array, handles[4] to be initialized with >> > integer value that >> > indica

Re: [PATCH] Wrong bo handles can be referenced in func call, drmModeAddFB2 due to uninitialized array elements in handles[4]

2014-04-29 Thread Matt Roper
On Tue, Apr 29, 2014 at 01:24:31PM -0700, Kristian Høgsberg wrote: > On Mon, Apr 28, 2014 at 03:26:18PM -0700, Dongwon Kim wrote: > > Need all bo handles in the array, handles[4] to be initialized with integer > > value that > > indicates "NOT VALID handle" to prevent any of those uninitialized fr

Re: [PATCH weston 2/2] shell: Fix crash when a client is destroyed during the resize grab

2014-04-29 Thread Kristian Høgsberg
On Tue, Apr 29, 2014 at 05:54:03PM +0300, Ander Conselvan de Oliveira wrote: > If a client exists during a resize grab, the resource for the shell > surface being resized is destroyed. The shell surface is not destroyed > immediately, however, because of the window close animation. In that > case,

Re: [PATCH] terminal: Convert all *alloc's to x*alloc's.

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 06:44:08PM +, Bryce W. Harrington wrote: > This ensures the allocation results are checked for NULL (out of > memory), and terminates the program in such a case. > > Signed-off-by: Bryce Harrington Applied, thanks. Kristian > --- > clients/terminal.c |6 +++---

Re: [PATCH] Wrong bo handles can be referenced in func call, drmModeAddFB2 due to uninitialized array elements in handles[4]

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 03:26:18PM -0700, Dongwon Kim wrote: > Need all bo handles in the array, handles[4] to be initialized with integer > value that > indicates "NOT VALID handle" to prevent any of those uninitialized from being > processed as > "VALID" handles. The format code determines whi

Re: [PATCH 3/3] clients: Check zalloc return for out of memory situation

2014-04-29 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 06:43:43PM +, Bryce W. Harrington wrote: > On Thu, Apr 24, 2014 at 04:26:20PM +0300, Pekka Paalanen wrote: > > On Mon, 21 Apr 2014 23:51:03 + > > "Bryce W. Harrington" wrote: > > > terminal = xzalloc(sizeof *terminal); > > > + if (terminal == NULL) > > > +

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Jasper St. Pierre
Can we at least do this work independently of this patch? I was debugging EGL stack issues, so I figured I might as well give my envvar hack to debug SHM issues. On Tue, Apr 29, 2014 at 4:07 PM, Kristian Høgsberg wrote: > On Tue, Apr 29, 2014 at 5:35 AM, Pekka Paalanen > wrote: > > On Mon, 28 A

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Kristian Høgsberg
On Tue, Apr 29, 2014 at 5:35 AM, Pekka Paalanen wrote: > On Mon, 28 Apr 2014 11:19:32 -0400 > "Jasper St. Pierre" wrote: > >> --- >> clients/window.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/clients/window.c b/clients/window.c >> index d822af7..3897440 1006

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Jason Ekstrand
On Apr 29, 2014 5:35 AM, "Pekka Paalanen" wrote: > > On Mon, 28 Apr 2014 11:19:32 -0400 > "Jasper St. Pierre" wrote: > > > --- > > clients/window.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/clients/window.c b/clients/window.c > > index d822af7..3897440 10

Re: [PATCH weston] screen-share: Set new environment variable to identify server display

2014-04-29 Thread Andrew Wedgbury
Hi Jason, On Tue, 29 Apr 2014, Jason Ekstrand wrote: Andrew, I think it's probably reasonable to pass the original server's socket through to the subsidiary compositor.  However, we should not use WAYLAND_SERVER_DISPLAY.  Right now, WAYLAND_DISPLAY and WAYLAND_SOCKET pass the same thing: a wa

[PATCH weston 2/2] shell: Fix crash when a client is destroyed during the resize grab

2014-04-29 Thread Ander Conselvan de Oliveira
If a client exists during a resize grab, the resource for the shell surface being resized is destroyed. The shell surface is not destroyed immediately, however, because of the window close animation. In that case, the compositor would crash trying to send configure events to the surface being resiz

[PATCH weston 1/2] shell: Fix memory leaks caused by the window close animation

2014-04-29 Thread Ander Conselvan de Oliveira
In order to do the window close animation, a reference for a destroyed surface is kept. However, the reference count was also increased for unmapped surfaces, in which case the animation wouldn't run. Since the reference count was decremented in the animation done function, it would never be decrea

Re: [PATCH weston] screen-share: Set new environment variable to identify server display

2014-04-29 Thread Jason Ekstrand
On Apr 28, 2014 8:39 AM, "Andrew Wedgbury" wrote: > > Some background on this: I am writing a fullscreen shell implementation to > share Wayland displays over VNC, which can be launched in place of weston from > weston's screen-share module. > > In screen-share, variables WAYLAND_DISPLAY and WAYLA

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Jasper St. Pierre
On Mon, Apr 28, 2014 at 11:19 AM, Jasper St. Pierre wrote: > --- > clients/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/clients/window.c b/clients/window.c > index d822af7..3897440 100644 > --- a/clients/window.c > +++ b/clients/window.c > @@ -4338,11 +433

Re: [PATCH] terminal: Convert all *alloc's to x*alloc's.

2014-04-29 Thread Pekka Paalanen
On Tue, 29 Apr 2014 14:35:21 +0200 Michael Schellenberger Costa wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi all, > > i might be dumb again, but as zalloc is a one line function, why not > just add the check to zalloc instead of searching for all uses of it? Function naming

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-29 Thread Pekka Paalanen
On Mon, 28 Apr 2014 11:19:32 -0400 "Jasper St. Pierre" wrote: > --- > clients/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/clients/window.c b/clients/window.c > index d822af7..3897440 100644 > --- a/clients/window.c > +++ b/clients/window.c > @@ -4338,11

Re: [PATCH] terminal: Convert all *alloc's to x*alloc's.

2014-04-29 Thread Michael Schellenberger Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, i might be dumb again, but as zalloc is a one line function, why not just add the check to zalloc instead of searching for all uses of it? Would there be any use case where one would not check for out of memory? best wishes Michael On 29.0

Re: [PATCH 5/6] window: Clean up buffer type choosing

2014-04-29 Thread Pekka Paalanen
On Mon, 28 Apr 2014 11:19:31 -0400 "Jasper St. Pierre" wrote: > Extracting it to a function makes this cleaner and more > understandable. > --- > clients/window.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/clients/window.c b/clients/window.c >

Re: [PATCH 2/6] compositor: Remove the edges parameter from send_configure

2014-04-29 Thread Pekka Paalanen
On Mon, 28 Apr 2014 11:19:28 -0400 "Jasper St. Pierre" wrote: > send_configure was originally modelled after > wl_shell_surface::send_configure, which takes these arguments. However, > the X WM and xdg_surface::configure variants don't use these arguments. > > We already store the resize edges f

Re: [PATCH 1/6] compositor: Fix the documentation for surface->configure

2014-04-29 Thread Pekka Paalanen
On Mon, 28 Apr 2014 11:19:27 -0400 "Jasper St. Pierre" wrote: > It's called on commit, not on attach. Additionally, correct the > interface name to be wl_surface, not surface. > --- > src/compositor.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compositor.h

Re: [PATCH] terminal: Convert all *alloc's to x*alloc's.

2014-04-29 Thread Pekka Paalanen
On Mon, 28 Apr 2014 18:44:08 + "Bryce W. Harrington" wrote: > This ensures the allocation results are checked for NULL (out of > memory), and terminates the program in such a case. > > Signed-off-by: Bryce Harrington > --- > clients/terminal.c |6 +++--- > 1 file changed, 3 insertions(

Re: [PATCH 3/3] clients: Check zalloc return for out of memory situation

2014-04-29 Thread Pekka Paalanen
On Mon, 28 Apr 2014 18:43:43 + "Bryce W. Harrington" wrote: > On Thu, Apr 24, 2014 at 04:26:20PM +0300, Pekka Paalanen wrote: > > On Mon, 21 Apr 2014 23:51:03 + > > "Bryce W. Harrington" wrote: > > > terminal = xzalloc(sizeof *terminal); > > > + if (terminal == NULL) > > > + re