Re: [PATCH weston 3/4] evdev: Fix assertion error for unplugged output with paired touchscreen

On Thursday, April 24, 2014 03:11:16 PM Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > If the output a touchscreen is paired to is unplugged, events coming > from it should be ignored. Commit 17bccaed introduced logic for that > in evdev_flush_pending_damage(). However

RE: [PATCH weston v3 0/4] Input fixes

I tested these on Weston w/libinput and they seem to have fixed up the touch and input issues nicely. The only use-case I didn't test was the one described in bug 73950... I didn't have the right hardware setup for that. We'll be sure to hit that case in beta testing, however. Cheers, U. Ar

Re: [PATCH wayland] Use non-blocking timerfd to prevent blocking when updating timer event sources

On Fri, Apr 25, 2014 at 03:00:54PM +0100, Andrew Wedgbury wrote: > This implements a simple fix for the blocking problem that occurs when > updating a timer event source after the timer expires, but before its > callback is dispatched. This can happen when another event happens during the > same

Re: [PATCH weston] Simply the matrix calculation for zooming

I fully support any patch that removes the phrase "modelview". On Fri, Apr 25, 2014 at 5:07 PM, Kristian Høgsberg wrote: > On Fri, Apr 25, 2014 at 01:19:37PM +0100, Neil Roberts wrote: > > In order to apply the zoom transformation to the output matrix, Weston > was > > doing the following: > > >

Re: [PATCH weston] Simply the matrix calculation for zooming

On Fri, Apr 25, 2014 at 01:19:37PM +0100, Neil Roberts wrote: > In order to apply the zoom transformation to the output matrix, Weston was > doing the following: > > • Create a temporary matrix to hold the translation > • Invert the translation matrix using weston_matrix_invert into > another te

Re: [PATCH weston] clients/window: Don't remove the touch listener on a frame event

On Wed, Apr 23, 2014 at 06:02:47PM +0100, Neil Roberts wrote: > It looks like the handler for frame events from the wl_touch interface for > widgets may have been erroneously copied from the cancel handler so that it > removes all handlers as they are processed. I don't think this makes much > sen

Re: [PATCH] Use the correct width/height when transforming surfaces with viewports.

On Tue, Apr 22, 2014 at 09:51:53AM +0300, Pekka Paalanen wrote: > On Mon, 21 Apr 2014 20:56:46 -0500 > Jason Ekstrand wrote: > > > Previously, because of the wrong width/height, > > weston_surface_to_buffer_* would return the wrong values when > > wl_viewport was used in combination with wl_surfa

Re: [PATCH 1/3] Check zalloc return for out of memory situation

On Fri, Apr 25, 2014 at 1:18 PM, Kristian Høgsberg wrote: > On Mon, Apr 21, 2014 at 11:51:02PM +, Bryce W. Harrington wrote: >> Most zalloc calls in weston are checked, this fixes a handful that were >> being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` > > Thanks Bryce, applied wit

Re: [PATCH 2/3] xwayland: Check zalloc return for out of memory situation

On Mon, Apr 21, 2014 at 11:51:03PM +, Bryce W. Harrington wrote: > > Signed-off-by: Bryce Harrington > --- Applied, thanks. Kristian > xwayland/launcher.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xwayland/launcher.c b/xwayland/launcher.c > index ac692de..70703a4 1006

Re: [PATCH 3/3] clients: Check zalloc return for out of memory situation

On Mon, Apr 21, 2014 at 11:51:03PM +, Bryce W. Harrington wrote: > Checking for these errors in the clients is perhaps a bit gratuitous but > can't hurt. In the clients we use the x*alloc functions which abort on allocation failure. Kristian > Signed-off-by: Bryce Harrington > --- > client

Re: [PATCH 1/3] Check zalloc return for out of memory situation

On Mon, Apr 21, 2014 at 11:51:02PM +, Bryce W. Harrington wrote: > Most zalloc calls in weston are checked, this fixes a handful that were > being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` Thanks Bryce, applied with once change as mentioned below. Kristian > Signed-off-by: Bryc

Re: [PATCH weston-ivi-shell v4 1/9] ivi application protocol:

On Fri, 25 Apr 2014 22:34:27 +0900 Nobuhiko Tanibata wrote: > 2014-04-23 19:40 に Pekka Paalanen さんは書きました: > > This is looking good, mostly just some details in the wording > > to be tuned. :-) > > > > I will see if I can review more of the patches, but I would also > > suggest the following, in

Re: [PATCH weston] Simply the matrix calculation for zooming

On Apr 25, 2014 8:11 AM, "Pekka Paalanen" wrote: > > On Fri, 25 Apr 2014 13:19:37 +0100 > Neil Roberts wrote: > > > In order to apply the zoom transformation to the output matrix, Weston was > > doing the following: > > > > * Create a temporary matrix to hold the translation > > * Invert the tran

[PATCH wayland] Use non-blocking timerfd to prevent blocking when updating timer event sources

This implements a simple fix for the blocking problem that occurs when updating a timer event source after the timer expires, but before its callback is dispatched. This can happen when another event happens during the same epoll wakeup as the timer event, and causes the read() call in wl_event_

Re: [PATCH weston-ivi-shell v4 1/9] ivi application protocol:

2014-04-23 19:40 に Pekka Paalanen さんは書きました: Hi, it's been a long while since I have looked at this, but I got a bit of time to come back. I hope you haven't abandoned this effort yet. :-) I looked at the PDF from your post on March 6th, 2014, and some of my own comments I gave at that time to r

Re: [PATCH weston] Simply the matrix calculation for zooming

On Fri, 25 Apr 2014 13:19:37 +0100 Neil Roberts wrote: > In order to apply the zoom transformation to the output matrix, Weston was > doing the following: > > • Create a temporary matrix to hold the translation > • Invert the translation matrix using weston_matrix_invert into > another tempora

Re: [PATCH weston-ivi-shell v5 9/9] Modify example clients to support ivi-application.xml

On Tue, 18 Mar 2014 23:57:32 +0900 Nobuhiko Tanibata wrote: > Signed-off-by: Nobuhiko Tanibata > --- > > Changes for v2, v3 and v4 > - nothing. Version number aligned to the first patch > > Changes for v5 > - support weston-dnd-ivi to verify wl_pointer::set_cursor and > wl_data_device::st

[PATCH weston] Simply the matrix calculation for zooming

In order to apply the zoom transformation to the output matrix, Weston was doing the following: • Create a temporary matrix to hold the translation • Invert the translation matrix using weston_matrix_invert into another temporary matrix • Scale that matrix by the scale factor • Multiply the curr

Re: [PATCH weston-ivi-shell v5 6/9] A reference implementation of UI client how to use ivi-hmi-controller.

On Thu, 20 Mar 2014 16:00:57 +0900 Nobuhiko Tanibata wrote: > This is launched from hmi-controller by using hmi_client_start and create a > pthread. > > The basic flow is as followed, > 1/ create pthread > 2/ read configuration from weston.ini. > 3/ draw png file to surface according to configur

Re: [PATCH weston-ivi-shell v4 5/9] A reference implementation how to use weston-layout library.

On Mon, 17 Mar 2014 15:28:22 +0900 Nobuhiko Tanibata wrote: > The library is used to manage layout of surfaces/layers. Layout change is > triggered by ivi-hmi-controller protocol, ivi-hmi-controller.xml. A reference > how to use the protocol, see hmi-controller-homescreen. > > In-Vehicle Infotai

Re: [PATCH weston-ivi-shell v4 8/9] Add a reference of weston.ini for ivi-shell and ivi-hmi-controller.

On Mon, 17 Mar 2014 15:31:09 +0900 Nobuhiko Tanibata wrote: > Signed-off-by: Nobuhiko Tanibata > --- > > Changes for v2: > - squash Makefile to this patch > > Changes for v3 and v4 > - nothing. Version number aligned to the first patch > > ivi-shell/Makefile.am | 12 > ivi-shel

[PATCH wayland] test: Add test showing blocking problem when updating timers

I've noticed a blocking problem in Wayland's event-loop code when updating timer event sources. The problem occurs if you update the timer at a point after is has expired, but before it has been dispatched, i.e. from an event callback that happens during the same epoll wakeup. When the timer is

Re: [PATCH v3] shell: support window resizing using touchscreen

Ping On 04/23/2014 05:41 PM, Jason Ekstrand wrote: > > > > On Wed, Apr 23, 2014 at 1:02 AM, Stanislav Vorobiov > wrote: > > if the system doesn't have a pointer device > common_surface_resize will crash on > accessing seat->pointer->button_count. if

Re: [PATCH weston-ivi-shell v4 7/9] Add refernce image files for ivi-hmi-controller

On Mon, 17 Mar 2014 15:29:56 +0900 Nobuhiko Tanibata wrote: > Signed-off-by: Nobuhiko Tanibata > --- > > Changes for v2: > - squash Makefile to this patch > > Changes for v3 and v4 > - nothing. Version number aligned to the first patch > > data/Makefile.am | 14 +-

Re: [PATCH weston-ivi-shell v4 4/9] A reference protocol of ivi hmi controller to set up IVI style UI.

On Mon, 17 Mar 2014 15:27:46 +0900 Nobuhiko Tanibata wrote: > The reference protocol is used between hmi-controller and > hmi-controller-homescreen. A one paragraph explanation on what hmi-controller and hmi-controller-homescreen each are would be nice, maybe added to the XML itself. I'm a bit

Re: [PATCH weston-ivi-shell v4 3/9] ivi-shell supports a type of shell for In-Vehicle Infotainment system.

Hi, btw. pay attention to patch summaries (the email subject line). We use a "component: description" format. Some examples: "ivi application protocol:" -> protocol: add ivi application extension "The weston-layout library supports" -> ivi-shell: add weston-layout library "ivi-shell supports a

Re: [PATCH weston-ivi-shell v5 2/9] The weston-layout library supports

On Thu, 20 Mar 2014 15:59:34 +0900 Nobuhiko Tanibata wrote: > API set of controlling properties of surface and layer which groups > surfaces. An unique ID whose type is integer is required to create > surface and layer. With the unique ID, surface and layer are identified > to control them. The A

Re: [PATCH libinput 10/20] touchpad: Add tp_button_touch_active function

On Fri, Apr 25, 2014 at 08:27:17AM +0200, Hans de Goede wrote: > Hi, > > On 04/24/2014 09:16 PM, Jonas Ådahl wrote: > > On Tue, Apr 15, 2014 at 02:28:07PM +0200, Hans de Goede wrote: > >> We don't want touches in the button area to cause the pointer to move, add > >> a tp_button_touch_active funct