Re: [PATCH libinput 10/20] touchpad: Add tp_button_touch_active function

2014-04-24 Thread Hans de Goede
Hi, On 04/24/2014 09:16 PM, Jonas Ådahl wrote: > On Tue, Apr 15, 2014 at 02:28:07PM +0200, Hans de Goede wrote: >> We don't want touches in the button area to cause the pointer to move, add >> a tp_button_touch_active function which the main code in evdev-mt-touchpad >> can call to see if a touch

Re: [PATCH libinput 11/20] touchpad: Rework is_pointer handling

2014-04-24 Thread Jonas Ådahl
On Thu, Apr 24, 2014 at 03:28:26PM +1000, Peter Hutterer wrote: > On Tue, Apr 15, 2014 at 02:28:08PM +0200, Hans de Goede wrote: > > Move scanning for a suitable touch to be the pointer to tp_process_state > > and take tp_button_touch_active into account. > > > > Note this adds a tp_touch_active h

Re: [PATCH libinput 10/20] touchpad: Add tp_button_touch_active function

2014-04-24 Thread Jonas Ådahl
On Tue, Apr 15, 2014 at 02:28:07PM +0200, Hans de Goede wrote: > We don't want touches in the button area to cause the pointer to move, add > a tp_button_touch_active function which the main code in evdev-mt-touchpad > can call to see if a touch should be consider a candidate for being the > pointe

Re: [PATCH weston 3/4] evdev: Fix assertion error for unplugged output with paired touchscreen

2014-04-24 Thread Neil Roberts
I think I wrote the goto handled code. The advantage of that over putting the assert in the default handler is that if a new event type is added to the evdev_event_type enum then GCC will give a nice warning for that switch statement so we'd know we need to add a handler for it. I think I would pe

Re: [PATCH 1/3 v2] Check zalloc return for out of memory situation

2014-04-24 Thread Pekka Paalanen
On Tue, 22 Apr 2014 01:54:03 + "Bryce W. Harrington" wrote: > Most zalloc calls in weston are checked, this fixes a handful that were > being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` > > Update: Drop the chunk in screen-share.c; Hardening already fixed the > zalloc check in co

Re: [PATCH 3/3] clients: Check zalloc return for out of memory situation

2014-04-24 Thread Pekka Paalanen
On Mon, 21 Apr 2014 23:51:03 + "Bryce W. Harrington" wrote: > Checking for these errors in the clients is perhaps a bit gratuitous but > can't hurt. > > Signed-off-by: Bryce Harrington > --- > clients/gears.c|3 +++ > clients/terminal.c | 20 > 2 files change

Re: [PATCH] client: extend error handling

2014-04-24 Thread Pekka Paalanen
On Wed, 23 Apr 2014 14:39:48 +0200 Marek Chalupa wrote: > When an error occurres, than wl_display_get_error() do not ... occurs, [then] ... does not > provide any way of getting know if it was a local error or if it was > an error event, respectively what object caused the error and what > the

[PATCH weston 3/4] evdev: Fix assertion error for unplugged output with paired touchscreen

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If the output a touchscreen is paired to is unplugged, events coming from it should be ignored. Commit 17bccaed introduced logic for that in evdev_flush_pending_damage(). However, the break statements it introduced would cause the assertion after the switch state

[PATCH weston 4/4] input: Fix errors due to initializing input before creating outputs

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Make sure that we don't map a device to an invalid output pointer and intead remap devices when an output is created. v2: fix the error with libinput too. --- src/evdev.c | 2 +- src/libinput-device.c | 2 +- src/libinput-seat.c | 8 ++-- src/ud

[PATCH weston 2/4] evdev: Discard events from a touchscreen paired with an unplugged output

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Commit 17bccaed intended to make the events coming from a touchscreen paired with an unplugged output to be discarded, while an unpaired one would just choose a different output. However, the logic was inverted causing the opposite to happen. Later in commit 161

[PATCH weston 1/4] libinput: Don't process touch events for devices without a valid output

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira That would be the case of a touch screen mapped to an output that was unplugged. --- src/libinput-device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libinput-device.c b/src/libinput-device.c index 0ca6c4b..a67c119 100644 --- a/src/libinput-devic

Re: [PATCH weston 4/4] input: Fix errors due to initializing input before creating outputs

2014-04-24 Thread Ander Conselvan de Oliveira
On 04/23/2014 06:36 PM, Neil Roberts wrote: I think we accientally wrote nearly identical patches at the same time: http://lists.freedesktop.org/archives/wayland-devel/2014-April/014392.html However, I still get the crash with Ander's patch because it looks like it is missing the check for wl_l

[PATCH weston v3 0/4] Input fixes

2014-04-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Resend of the fixes update to cover libinput usage too. Ander Conselvan de Oliveira (4): libinput: Don't process touch events for devices without a valid output evdev: Discard events from a touchscreen paired with an unplugged output evdev: Fix ass

Re: [PATCH libinput 13/20] touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons

2014-04-24 Thread Hans de Goede
Hi, On 04/24/2014 07:34 AM, Peter Hutterer wrote: > On Tue, Apr 15, 2014 at 02:28:10PM +0200, Hans de Goede wrote: >> And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence. >> >> Signed-off-by: Hans de Goede >> Acked-by: Peter Hutterer > > I've gone through all patches again

[PATCH V4 1/7] weston: Add weston randr protocol

2014-04-24 Thread Quanxian Wang
Weston randr protocol will provide interfaces to 1) Scaling Scale the output to be more than 1. 2) Transform Rotate output to be 8 type of angles. 0, 90, 180, 270, flip-0, flip-90, flip-180, flip-270 3) Mode Set Fuzzy set: First matched, first active. Exact set: a) Exact Timing

[PATCH V4 4/7] Add new mode function in drm backend

2014-04-24 Thread Quanxian Wang
provide drm_output_new_mode interface to create new mode from outsite instead of only from edid or configure. Signed-off-by: Quanxian Wang --- src/compositor-drm.c | 92 1 file changed, 92 insertions(+) diff --git a/src/compositor-drm.c b/src

[PATCH V4 0/7] Add weston randr protocol

2014-04-24 Thread Quanxian Wang
It should be the final feature updates. Next I will focus on the comment from developers and send the updates. If more features are needed, it will be better to be implemented in next release. Sorry for thousands of code. Before submit, I have done strictly grammar check, coding style check and

[PATCH V4 2/7] weston: Add the weston randr support in compositor.h

2014-04-24 Thread Quanxian Wang
1) Add weston_randr definition and randr_backend intreface. 2) Export functions used in compositor.c so that module wrandr could use them. For example, weston_output_transform_scale_init. 3) Support new_mode backend interface in output structure. Signed-off-by: Quanxian Wang --- src/composito

[PATCH V4 3/7] weston: Add enable-wrandr option and export common functions

2014-04-24 Thread Quanxian Wang
When starting weston with parameter --enable-wrandr, it will automatically load wrandr.so module. This is for QA testing and Admin configuration. weston_output_transform_scale_init will be used by weston randr module. Signed-off-by: Quanxian Wang --- src/compositor.c | 35 ++

[PATCH V4 7/7] Apps: Add weston-randr application

2014-04-24 Thread Quanxian Wang
Functions implemented in this application 1) Query output mode list 2) Scaling and Transform Scale the output to be more than 1. Rotate output to be 8 type of angles. 0, 90, 180, 270, flip-0, flip-90, flip-180, flip-270 3) Mode Set Fuzzy set: First matched, first active. Exact set:

[PATCH V4 6/7] weston: Add configure to support wrandr.

2014-04-24 Thread Quanxian Wang
Signed-off-by: Quanxian Wang --- Makefile.am | 5 + configure.ac | 8 2 files changed, 13 insertions(+) diff --git a/Makefile.am b/Makefile.am index f22c542..254cde7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -6,11 +6,16 @@ if ENABLE_XWAYLAND xwayland_subdir = xwayland endif