On Tue, Apr 15, 2014 at 02:28:10PM +0200, Hans de Goede wrote:
> And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence.
>
> Signed-off-by: Hans de Goede
> Acked-by: Peter Hutterer
I've gone through all patches again and they're now all really
Reviewed-by: Peter Hutterer , ex
On Wed, Apr 23, 2014 at 11:36:05PM +0200, Jonas Ådahl wrote:
> On Tue, Apr 15, 2014 at 02:28:01PM +0200, Hans de Goede wrote:
> > From: Peter Hutterer
> >
> > Immediately set the state to DEAD, waiting for the tap release to go back to
> > idle.
>
> This will make it impossible to tap while for
On Tue, Apr 15, 2014 at 02:28:08PM +0200, Hans de Goede wrote:
> Move scanning for a suitable touch to be the pointer to tp_process_state
> and take tp_button_touch_active into account.
>
> Note this adds a tp_touch_active helper since we want to do the same checks in
> other places too (ie to see
On Tue, Apr 15, 2014 at 02:28:07PM +0200, Hans de Goede wrote:
> We don't want touches in the button area to cause the pointer to move, add
> a tp_button_touch_active function which the main code in evdev-mt-touchpad
> can call to see if a touch should be consider a candidate for being the
> pointe
On Tue, Apr 15, 2014 at 02:28:14PM +0200, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> Acked-by: Peter Hutterer
> ---
> src/evdev-mt-touchpad.c | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
> in
On Wed, Apr 23, 2014 at 11:35:35PM +0200, Jonas Ådahl wrote:
> On Tue, Apr 15, 2014 at 02:28:06PM +0200, Hans de Goede wrote:
> > From: Peter Hutterer
> >
> > This is a slightly fancier implementation than the simplest model and ported
> > over from libtouchpad. It implements a state machine for
On Tue, Apr 15, 2014 at 04:00:41PM +0200, Hans de Goede wrote:
> Hi,
>
> On 04/15/2014 03:44 PM, Daniel Stone wrote:
> > Hi,
> >
> > On 15 April 2014 13:28, Hans de Goede wrote:
> >
> >> Apple touchpads don't have visible markings for the software button areas
> >> that almost all other vendors
On Thu, Apr 24, 2014 at 07:31:10AM +1000, Peter Hutterer wrote:
> We depend on device creation on the host system, having the tests run in
> parallel runs a risk of random failure.
>
> Signed-off-by: Peter Hutterer
Reviewed-by: Jonas Ådahl
> ---
> This time the simple version instead of hackin
On Tue, Apr 15, 2014 at 02:28:01PM +0200, Hans de Goede wrote:
> From: Peter Hutterer
>
> Immediately set the state to DEAD, waiting for the tap release to go back to
> idle.
This will make it impossible to tap while for example holding a button
to keep a menu visible.
This currently works in X
On Tue, Apr 15, 2014 at 02:28:06PM +0200, Hans de Goede wrote:
> From: Peter Hutterer
>
> This is a slightly fancier implementation than the simplest model and ported
> over from libtouchpad. It implements a state machine for the software buttons
> with left and right buttons currently implemente
We depend on device creation on the host system, having the tests run in
parallel runs a risk of random failure.
Signed-off-by: Peter Hutterer
---
This time the simple version instead of hacking the AM_MAKEFLAGS.
test/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/Makefi
It looks like the handler for frame events from the wl_touch interface for
widgets may have been erroneously copied from the cancel handler so that it
removes all handlers as they are processed. I don't think this makes much sense
for the frame event. This was stopping the panel icons from being pu
I think we accientally wrote nearly identical patches at the same time:
http://lists.freedesktop.org/archives/wayland-devel/2014-April/014392.html
However, I still get the crash with Ander's patch because it looks like
it is missing the check for wl_list_empty in the libinput-seat.c version
of de
From: Ander Conselvan de Oliveira
Make sure that we don't map a device to an invalid output pointer and
intead remap devices when an output is created.
---
src/evdev.c | 2 +-
src/libinput-device.c | 2 +-
src/libinput-seat.c | 6 +-
src/udev-seat.c | 8 ++--
4 files ch
From: Ander Conselvan de Oliveira
If the output a touchscreen is paired to is unplugged, events coming
from it should be ignored. Commit 17bccaed introduced logic for that
in evdev_flush_pending_damage(). However, the break statements it
introduced would cause the assertion after the switch state
From: Ander Conselvan de Oliveira
Commit 17bccaed intended to make the events coming from a touchscreen
paired with an unplugged output to be discarded, while an unpaired one
would just choose a different output. However, the logic was inverted
causing the opposite to happen.
Later in commit 161
From: Ander Conselvan de Oliveira
That would be the case of a touch screen mapped to an output that was
unplugged.
---
src/libinput-device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/libinput-device.c b/src/libinput-device.c
index 0ca6c4b..a67c119 100644
--- a/src/libinput-devic
From: Ander Conselvan de Oliveira
Here's a second version of the input fixes I sent before, which new
patches and some changes.
The first patch makes libinput able to handle touch events on a
device without a paired output. The second one inverts the logic for
pairing a device on output disconne
On 04/22/2014 08:22 PM, Neil Roberts wrote:
It looks like this patch makes Weston crash on touch events.
The device_added functions in udev-seat.c and libinput-seat.c try to use
the output list in order to assign the output for the newly created
device. These functions get called via udev_input_
Commit 4ade0e4a29 changed the order of initialising the seats and outputs so
that the seats would be done before the outputs. However the device_added
function in libinput-seat and udev-seat which gets called during initialisation
was trying to use the output list to assign an output to the device.
On 04/23/2014 04:21 AM, Eoff, Ullysses A wrote:
Hmmm... I think there's more to reconcile for touch device pairing/mapping.
In device_added(), we assign a default output to a paired device when the
the requested output isn't found. That behavior just changed about a day
ago to fix another bug.
On Wed, Apr 23, 2014 at 1:02 AM, Stanislav Vorobiov
wrote:
> if the system doesn't have a pointer device
> common_surface_resize will crash on
> accessing seat->pointer->button_count. if the system
> does have a pointer device, but attempts to resize
> a window using touchscreen - nothing happens.
When an error occurres, than wl_display_get_error() do not
provide any way of getting know if it was a local error or if it was
an error event, respectively what object caused the error and what
the error was.
This patch introduces a new function wl_display_get_protocol_error()
which will return e
On 19 April 2014 10:22, Pekka Paalanen wrote:
> On Fri, 18 Apr 2014 12:27:59 +0200
> Marek Chalupa wrote:
>
> > On 15 April 2014 15:36, Pekka Paalanen wrote:
> >
> > > On Fri, 11 Apr 2014 11:39:13 +0200
> > > Marek Chalupa wrote:
> > >
> > > > When an error occures, than wl_display_get_error()
Check the value returned by calloc.
---
src/evdev-mt-touchpad.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 6355364..109441d 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -721,6 +721,8 @@ tp_init_slots(struct
Hi,
it's been a long while since I have looked at this, but I got a bit of
time to come back. I hope you haven't abandoned this effort yet. :-)
I looked at the PDF from your post on March 6th, 2014, and some of my
own comments I gave at that time to recall what this was about, but I
probably stil
26 matches
Mail list logo