[PATCH v3] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
Right, didn't see that theme_get_location can also return THEME_LOCATION_TITLEBAR, fixed that Stanislav Vorobiov (1): shell: support window resizing using touchscreen clients/window.c |5 +- desktop-shell/shell.c | 153 ++--- shared/cairo-u

[PATCH v3] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

Re: xserver git version?

2014-04-22 Thread Bill Spitzak
On 04/22/2014 08:08 PM, Jasper St. Pierre wrote: It looks OK, but the upstream is at https://github.com/anholt/libepoxy Thanks, fixing that. I had to add --disable-glx but I succeeded in getting xserver to compile. Like before there are a lot of bugs with the window borders. It often is miss

Re: xserver git version?

2014-04-22 Thread Jasper St. Pierre
It looks OK, but the upstream is at https://github.com/anholt/libepoxy On Tue, Apr 22, 2014 at 10:54 PM, Bill Spitzak wrote: > On 04/22/2014 05:34 PM, Peter Hutterer wrote: > > Config with --enable-xwayland is not working however: >>> >>> checking whether to build XWin DDX... no >>> checking d

Re: xserver git version?

2014-04-22 Thread Bill Spitzak
On 04/22/2014 05:34 PM, Peter Hutterer wrote: Config with --enable-xwayland is not working however: checking whether to build XWin DDX... no checking dependency style of $(CC)... none checking for DMXMODULES... no checking whether to build Xdmx DDX... no checking for XWAYLANDMODULES... no check

RE: [PATCH weston v2 2/5] libinput-seat: allow setting libinput log priority in weston

2014-04-22 Thread Eoff, Ullysses A
> -Original Message- > From: Peter Hutterer [mailto:peter.hutte...@who-t.net] > Sent: Tuesday, April 22, 2014 5:43 PM > To: Eoff, Ullysses A > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston v2 2/5] libinput-seat: allow setting libinput log > priority in weston > > On

Re: [PATCH libinput 5/6] tools: Add missing newline

2014-04-22 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:20:43PM +0200, Carlos Garnacho wrote: > Signed-off-by: Carlos Garnacho > --- > tools/event-debug.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/event-debug.c b/tools/event-debug.c > index c0a08a7..fb79be4 100644 > --- a/tools/event-d

RE: [PATCH weston 1/2] evdev: Discard events from a touchscreen paired with an unplugged output

2014-04-22 Thread Eoff, Ullysses A
Hmmm... I think there's more to reconcile for touch device pairing/mapping. In device_added(), we assign a default output to a paired device when the the requested output isn't found. That behavior just changed about a day ago to fix another bug. But perhaps I wasn't seeing the big picture at th

Re: [PATCH libinput] evdev-mt-touchpad: check calloc result

2014-04-22 Thread Peter Hutterer
On Tue, Apr 15, 2014 at 11:15:35PM +0200, Carlos Olmedo Escobar wrote: > Check the value returned by calloc. > --- > src/evdev-mt-touchpad.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c > index bbbd8f3..9ec1682 100644 > --- a/src/

Re: [PATCH weston v2 2/5] libinput-seat: allow setting libinput log priority in weston

2014-04-22 Thread Peter Hutterer
On Thu, Apr 17, 2014 at 07:53:23AM -0700, U. Artie Eoff wrote: > Look for WESTON_LIBINPUT_LOG_PRIORITY environment variable. If > it exists then use it to set the libinput log priority. > Otherwise, don't set the priority and get whatever libinput's > default priority is. > > Setting WESTON_LIBIN

Re: xserver git version?

2014-04-22 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 10:20:30PM -0700, Bill Spitzak wrote: > Okay that got a little further. > > I had to delete my xwayland checkout and make a new git clone to get > git to forget about the xwayland branch (there probably is a git > command to make it pull from master but I could not find it)

Re: [PATCH v2] shell: support window resizing using touchscreen

2014-04-22 Thread Jason Ekstrand
On Tue, Apr 22, 2014 at 12:55 PM, Stanislav Vorobiov wrote: > if the system doesn't have a pointer device > common_surface_resize will crash on > accessing seat->pointer->button_count. if the system > does have a pointer device, but attempts to resize > a window using touchscreen - nothing happen

[PATCH v2] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
Jason, I've fixed that. Also, I've fixed 2 other issue reported via IRC: * the "top-left resize" problem * the "mouse + touchscreen can't resize with mouse" problem latter is not tested, I don't have the environment for it Stanislav Vorobiov (1): shell: support window resizing using touchscreen

[PATCH v2] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

Re: [PATCH weston] compositor-drm: Fix crash when setting up seat constrained by an output

2014-04-22 Thread Neil Roberts
It looks like this patch makes Weston crash on touch events. The device_added functions in udev-seat.c and libinput-seat.c try to use the output list in order to assign the output for the newly created device. These functions get called via udev_input_init so I guess that means this function and c

[PATCH weston 1/2] evdev: Discard events from a touchscreen paired with an unplugged output

2014-04-22 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Commit 17bccaed intended to make the events coming from a touchscreen paired with an unplugged output to be discarded, while an unpaired one would just choose a different output. However, the logic was inverted causing the opposite to happen. --- src/evdev.c | 2

[PATCH weston 2/2] evdev: Fix assertion error for unplugged output with paired touchscreen

2014-04-22 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If the output a touchscreen is paired to is unplugged, events coming from it should be ignored. Commit 17bccaed introduced logic for that in evdev_flush_pending_damage(). However, the break statements it introduced would cause the assertion after the switch state

Re: [PATCH] shell: support window resizing using touchscreen

2014-04-22 Thread Jason Ekstrand
I don't have time to review the desktop-shell bits right now, but I do have a few comments on the frame.c bits. On Tue, Apr 22, 2014 at 9:32 AM, Stanislav Vorobiov wrote: > if the system doesn't have a pointer device > common_surface_resize will crash on > accessing seat->pointer->button_count.

[PATCH] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

Re: [PATCH wayland] connection: fix a format string typo in error message

2014-04-22 Thread Pekka Paalanen
On Tue, 22 Apr 2014 16:03:12 +0300 Giulio Camuffo wrote: > --- > src/connection.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/connection.c b/src/connection.c > index 63b0592..47ee556 100644 > --- a/src/connection.c > +++ b/src/connection.c > @@ -724,7 +724,7 @@

[PATCH wayland] connection: fix a format string typo in error message

2014-04-22 Thread Giulio Camuffo
--- src/connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/connection.c b/src/connection.c index 63b0592..47ee556 100644 --- a/src/connection.c +++ b/src/connection.c @@ -724,7 +724,7 @@ wl_connection_demarshal(struct wl_connection *connection,