Re: [PATCH] pixman-renderer: Use width/height_from_buffer for buffer transforms

On Mon, 21 Apr 2014 21:04:42 -0500 Jason Ekstrand wrote: > This fixes an issue in the pixman renderer where it would not render > surfaces correctly if both wl_viewport and wl_surface.set_buffer_transform > were used. > > Signed-off-by: Jason Ekstrand > --- > src/pixman-renderer.c | 4 ++-- >

Re: [PATCH] Use the correct width/height when transforming surfaces with viewports.

On Mon, 21 Apr 2014 20:56:46 -0500 Jason Ekstrand wrote: > Previously, because of the wrong width/height, > weston_surface_to_buffer_* would return the wrong values when > wl_viewport was used in combination with wl_surface.set_buffer_transform. > > Signed-off-by: Jason Ekstrand > --- > src/co

Re: xserver git version?

Okay that got a little further. I had to delete my xwayland checkout and make a new git clone to get git to forget about the xwayland branch (there probably is a git command to make it pull from master but I could not find it). After that I had to also check out and install fontsproto from gi

RE: help: is there any way to use integer 64 type in protocol?

From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Monday, April 21, 2014 10:29 PM To: Wang, Quanxian Cc: Pekka Paalanen; wayland-devel@lists.freedesktop.org Subject: Re: help: is there any way to use integer 64 type in protocol? On Sun, Apr 20, 2014 at 8:36 PM, Wang, Quanxian mailto:qu

[PATCH] pixman-renderer: Use width/height_from_buffer for buffer transforms

This fixes an issue in the pixman renderer where it would not render surfaces correctly if both wl_viewport and wl_surface.set_buffer_transform were used. Signed-off-by: Jason Ekstrand --- src/pixman-renderer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pixman-re

[PATCH] Use the correct width/height when transforming surfaces with viewports.

Previously, because of the wrong width/height, weston_surface_to_buffer_* would return the wrong values when wl_viewport was used in combination with wl_surface.set_buffer_transform. Signed-off-by: Jason Ekstrand --- src/compositor.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) d

Re: [PATCH 1/3 v2] Check zalloc return for out of memory situation

Most zalloc calls in weston are checked, this fixes a handful that were being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` Update: Drop the chunk in screen-share.c; Hardening already fixed the zalloc check in commit e57d1f21. Signed-off-by: Bryce Harrington --- src/compositor-wayland

Re: [PATCH libinput 0/24] Tablet support

On Mon, Apr 21, 2014 at 4:40 PM, Benjamin Tissoires wrote: > Hi Carlos, > > [Adding a few people to the conversation] > > I am working a little bit on the wacom.ko kernel driver and I can give > you some hints on the oddness around the events. > > On Mon, Apr 21, 2014 at 1:11 PM, Carlos Garnacho

[PATCH] desktop-shell: Properly handle seat hotplugging

Previously, desktop-shell would only create its internal shell_seat object for each seat available when the desktop-shell module is loaded. This is a problem any time seats are created dynamically. In particular, the Wayland and RDP backends create seats on an as-needed basis and they weren't get

[PATCH 1/3] Check zalloc return for out of memory situation

Most zalloc calls in weston are checked, this fixes a handful that were being ignored. As found by `grep -EIsr "[^x]zalloc\(" . -A1` Signed-off-by: Bryce Harrington --- src/compositor-wayland.c |6 ++ src/libinput-seat.c |2 +- src/screen-share.c |8 +++- src/scre

[PATCH 3/3] clients: Check zalloc return for out of memory situation

Checking for these errors in the clients is perhaps a bit gratuitous but can't hurt. Signed-off-by: Bryce Harrington --- clients/gears.c|3 +++ clients/terminal.c | 20 2 files changed, 23 insertions(+) diff --git a/clients/gears.c b/clients/gears.c index 93a86b4.

[PATCH 2/3] xwayland: Check zalloc return for out of memory situation

Signed-off-by: Bryce Harrington --- xwayland/launcher.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/xwayland/launcher.c b/xwayland/launcher.c index ac692de..70703a4 100644 --- a/xwayland/launcher.c +++ b/xwayland/launcher.c @@ -348,6 +348,8 @@ module_init(struct weston_compositor *c

Re: [PATCH libinput 0/24] Tablet support

Hi Carlos, [Adding a few people to the conversation] I am working a little bit on the wacom.ko kernel driver and I can give you some hints on the oddness around the events. On Mon, Apr 21, 2014 at 1:11 PM, Carlos Garnacho wrote: > Hey there!, > > Here's a few patches to have libinput handle eve

Re: [PATCH] Check malloc result

On Fri, Apr 11, 2014 at 09:06:58AM +0200, Hardening wrote: > This patch checks malloc was successfull and release resources if it > wasn't. Commmitted, thanks. Kristian > --- > src/screen-share.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/src/sc

Re: [PATCHv2 weston] gl-renderer: Remove gl_renderer_interface from gl-renderer.h

On Thu, Apr 10, 2014 at 08:05:17PM +0200, John Kåre Alsaker wrote: > The rationale here is, that this line would create an instance of > gl_renderer_interface in every compilation unit that included > gl-renderer.h. This is not necessary, and it can actually be harmful by > masking the real exporte

Re: [PATCH weston] weston-info: fix log message typo

On Fri, Apr 18, 2014 at 09:30:07AM -0700, U. Artie Eoff wrote: > Signed-off-by: U. Artie Eoff > --- Committed, thanks. Kristian > clients/weston-info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/clients/weston-info.c b/clients/weston-info.c > index 147dc48..df869

Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

On Fri, Apr 18, 2014 at 12:52:03PM +0200, Manuel Bachmann wrote: > This fixes : > https://bugs.freedesktop.org/show_bug.cgi?id=77496 > Yup, the patch looks good, thanks Manuel. Kristian > Regards, > Manuel > > > 2014-04-18 12:50 GMT+02:00 Manuel Bachmann < > manuel.bachm...@open.eurogiciel.or

Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

On Thu, Apr 17, 2014 at 06:20:37PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > If a message was too big to fit in the connection buffer, the code > in wl_buffer_put would just write past the end of it. > > I haven't seen any real world use case that would tr

Re: [PATCH weston v2 0/5] Input bug fixes

On Thu, Apr 17, 2014 at 07:53:21AM -0700, U. Artie Eoff wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77578 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77577 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77341 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77

Re: [PATCH] shell: display the input panel on the active output

On Thu, Apr 17, 2014 at 02:04:32PM +0200, Manuel Bachmann wrote: > We now dynamically move the input panel (i.e. virtual > keyboard) surface to the output containing the currently > focused surface. That works, but it does seem like we're missing a link from the input panel surface to the input co

Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

Hi Bill, > It looks like the text actually has the bytes "Enter" at the newlines, rather than, say, a '\n'? In fact, it is '\r' (carriage return) rather than '\n' (new line). In renders correctly with Pango, though, and would paste gracefully to other clients such as weston-terminal. The only pr

Re: [PATCH weston] compositor-drm: Fix crash when setting up seat constrained by an output

On Thu, Apr 17, 2014 at 01:08:45PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Commit 58e15865 changed the parameters for udev_get_seat_by_name() to > receive a struct udev_input. However, when this gets called from > create_output_from_connector() during ini

Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

It looks like the text actually has the bytes "Enter" at the newlines, rather than, say, a '\n'? On 04/18/2014 03:52 AM, Manuel Bachmann wrote: This fixes : https://bugs.freedesktop.org/show_bug.cgi?id=77496 Regards, Manuel 2014-04-18 12:50 GMT+02:00 Manuel Bachmann

[PATCH libinput 4/6] Fix doc typo

The infinitive reads a bit odd there. Signed-off-by: Carlos Garnacho --- src/libinput.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index 90e9fa4..57a10e4 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -798,7 +798,7 @@ libinput_pat

[PATCH libinput 3/6] Fix doc typo in function name

Signed-off-by: Carlos Garnacho --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 20bf574..90e9fa4 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -790,7 +790,7 @@ libinput_path_create_context(const struct libinput_int

[PATCH libinput 6/6] evdev: indentation fix

Signed-off-by: Carlos Garnacho --- src/evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 901b310..c14bfc5 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -594,7 +594,7 @@ evdev_configure_device(struct evdev_device *device) }

[PATCH libinput 2/6] Remove doc references to non-existing function

Signed-off-by: Carlos Garnacho --- src/libinput.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index 9b4f198..20bf574 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -784,7 +784,7 @@ libinput_path_create_context(const struct libinput

[PATCH libinput 5/6] tools: Add missing newline

Signed-off-by: Carlos Garnacho --- tools/event-debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/event-debug.c b/tools/event-debug.c index c0a08a7..fb79be4 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c @@ -221,8 +221,7 @@ print_event_header(struct li

[PATCH libinput 1/6] Fix doc typo

Signed-off-by: Carlos Garnacho --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 810a66c..9b4f198 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -59,7 +59,7 @@ enum libinput_log_priority { * * Capabilities on a de

Fixes for minor libinput typos/style issues

Hey, I've spotted a few typos and other minor docs/style glitches on libinput, here's some patches for those. Cheers, Carlos ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-deve

[PATCH libinput 09/24] Add LIBINPUT_EVENT_POINTER_TOOL_UPDATE event type

This event would be emitted whenever a device with LIBINPUT_DEVICE_CAP_STYLUS capabilities changes its tool type. When the tablet reaches proximity, the tool/serial will be updated to match the current physical stylus'. Likewise, when the stylus moves out of proximity, the tool will be reset to LI

[PATCH libinput 12/24] evdev: Add support for tablet devices

These devices will set the LIBINPUT_DEVICE_CAP_STYLUS flag, and may emit extra axis information, uncommon in mice and touchpads. These devices may also have different tool modes, notified in LIBINPUT_EVENT_POINTER_TOOL_UPDATE events. In this commit, only (unfiltered) motion tracking is implemented

[PATCH libinput 11/24] tools: Handle LIBINPUT_EVENT_POINTER_TOOL_UPDATE events in event-debug

Print out time, tool type and serial for those events. Signed-off-by: Carlos Garnacho --- tools/event-debug.c | 49 + 1 file changed, 49 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index 17dafe0..19a9321 100644 --- a/tools

[PATCH libinput 21/24] test: Add Wacom Intuos5 touch M Pen device definition

Signed-off-by: Carlos Garnacho --- test/Makefile.am | 1 + test/litest-wacom-intuos-tablet.c | 136 ++ test/litest.c | 2 + 3 files changed, 139 insertions(+) create mode 100644 test/litest-wacom-intuos-tablet.c diff -

[PATCH libinput 23/24] test: Add proximity tablet test

Signed-off-by: Carlos Garnacho --- test/Makefile.am | 6 + test/tablet.c| 82 2 files changed, 88 insertions(+) create mode 100644 test/tablet.c diff --git a/test/Makefile.am b/test/Makefile.am index 74d9a06..9c0f906 100644 --- a

[PATCH libinput 20/24] test: Add Wacom Cintiq 12WX device definition

Signed-off-by: Carlos Garnacho --- test/Makefile.am | 1 + test/litest-wacom-cintiq-tablet.c | 137 ++ test/litest.c | 2 + 3 files changed, 140 insertions(+) create mode 100644 test/litest-wacom-cintiq-tablet.c diff -

[PATCH libinput 18/24] test: Add infrastructure for testing tablet events.

no vfuncs are used, only input_event arrays. Signed-off-by: Carlos Garnacho --- test/litest-int.h | 8 + test/litest.c | 90 +++ test/litest.h | 14 + 3 files changed, 112 insertions(+) diff --git a/test/litest-int.h b/tes

[PATCH libinput 22/24] test: Add Wacom ISDv4 E6 Pen device definition

Signed-off-by: Carlos Garnacho --- test/Makefile.am | 1 + test/litest-wacom-isdv4-tablet.c | 99 test/litest.c| 2 + 3 files changed, 102 insertions(+) create mode 100644 test/litest-wacom-isdv4-tablet.c diff --git

[PATCH libinput 19/24] test: Add Wacom Bamboo 16FG 4x5 Pen device definition

Signed-off-by: Carlos Garnacho --- test/Makefile.am | 1 + test/litest-wacom-bamboo-tablet.c | 106 ++ test/litest.c | 2 + 3 files changed, 109 insertions(+) create mode 100644 test/litest-wacom-bamboo-tablet.c diff -

[PATCH libinput 24/24] test: Add motion event test for tablets

Signed-off-by: Carlos Garnacho --- test/tablet.c | 48 1 file changed, 48 insertions(+) diff --git a/test/tablet.c b/test/tablet.c index 591742a..08592c7 100644 --- a/test/tablet.c +++ b/test/tablet.c @@ -73,10 +73,58 @@ START_TEST(proximity_in_ou

[PATCH libinput 05/24] tools: Handle LIBINPUT_EVENT_POINTER_AXIS_FRAME in event-debug

This information has no coordinates itself, so only print out the event time. Signed-off-by: Carlos Garnacho --- tools/event-debug.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index c0a08a7..3a72bfa 100644 --- a/tools/event-debu

[PATCH libinput 15/24] tablet: Add infrastructure to store and notify axis states.

An axis_frame event is sent too to notify a set of simultaneous axis changes. Only the infrastructure is added, No axes are managed at the moment. Signed-off-by: Carlos Garnacho --- src/evdev-tablet.c | 107 + src/evdev-tablet.h | 10 + 2

[PATCH libinput 17/24] tablet: Emit axis events on distance/pressure changes

Those have been made mutually exclusive, to make sure only one or the other is notified when there is some uncertainty from the device. Signed-off-by: Carlos Garnacho --- src/evdev-tablet.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/evdev-tablet.c b/sr

[PATCH libinput 10/24] tools: Handle tablet axes in event-debug

Signed-off-by: Carlos Garnacho --- tools/event-debug.c | 12 1 file changed, 12 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index 3a72bfa..17dafe0 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c @@ -310,6 +310,18 @@ print_axis_event(struct libinpu

[PATCH libinput 13/24] tablet: Emit LIBINPUT_EVENT_POINTER_TOOL_UPDATE events on tool changes

Tracking is done of serial/tool type, so it is only really notified on tool changes. Signed-off-by: Carlos Garnacho --- src/evdev-tablet.c | 109 ++--- src/evdev-tablet.h | 10 + 2 files changed, 113 insertions(+), 6 deletions(-) diff --git a

[PATCH libinput 16/24] tablet: Emit axis events on v/h stylus tilt changes.

Those are normalized to be in the [-1..1] range. Signed-off-by: Carlos Garnacho --- src/evdev-tablet.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 70f3210..cc55c74 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tab

[PATCH libinput 07/24] Add extra libinput_pointer_axis values for tablets

distance/pressure/xtilt/ytilt are handled at the moment, this leaves wheels/strips out at the moment... Signed-off-by: Carlos Garnacho --- src/libinput.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 5b3d79e..05690a9 100644 --- a/s

[PATCH libinput 08/24] Add LIBINPUT_DEVICE_CAP_STYLUS libinput_device_capability value

This capability flag would be enabled when events are driven through a stylus, ie. on a tablet. Signed-off-by: Carlos Garnacho --- src/evdev.c| 2 ++ src/evdev.h| 3 ++- src/libinput.h | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index

[PATCH libinput 14/24] tablet: handle button events

This works for stylus tap and primary/secondary button, and pad buttons. Signed-off-by: Carlos Garnacho --- src/evdev-tablet.c | 104 + src/evdev-tablet.h | 3 ++ 2 files changed, 107 insertions(+) diff --git a/src/evdev-tablet.c b/src/evdev

[PATCH libinput 04/24] mt-touchpad: Use an axis_frame event to mark the end of scroll changes

If both v/h scroll axes change, users may process both changes at once when this event is received. Signed-off-by: Carlos Garnacho --- src/evdev-mt-touchpad.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index

[PATCH libinput 06/24] tests: drain events before testing scroll events in test-pointer

This is so LIBINPUT_EVENT_POINTER_AXIS_FRAME events remaining from previous tests are discarded. Signed-off-by: Carlos Garnacho --- test/pointer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index 59fe818..ecb7dbd 100644 --- a/test/pointer.c +++ b/test/p

[PATCH libinput 01/24] Add LIBINPUT_EVENT_POINTER_AXIS_FRAME event

This event marks the end of 1..N simultaneous axis changes. Will be useful to have users compress vscroll/hscroll processing in a single point, and will prove even more useful on devices with a higher number of axes, like tablets. Signed-off-by: Carlos Garnacho --- src/libinput-private.h | 4 ++

[PATCH libinput 0/24] Tablet support

Hey there!, Here's a few patches to have libinput handle events from tablets, these devices are basically pointer devices, with a varying range of extra buttons (either stylus or "pad" buttons), and extra ABS_* axes. These devices also often offer information about the stylus in use, and its BTN_T

[PATCH libinput 02/24] evdev: use an axis_frame event to mark the end of axis changes

It will be unlikely in this case to get both REL_WHEEL and REL_HWHEEL on a single EV_SYN, but for completeness. Signed-off-by: Carlos Garnacho --- src/evdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 901b310..94fe67b 100644 --- a/src/evdev.c +++ b

[PATCH libinput 03/24] touchpad: Use an axis_frame event to mark the end of scroll changes

If both v/h scroll axes change, users may process both changes at once when this event is received. Signed-off-by: Carlos Garnacho --- src/evdev-touchpad.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/evdev-touchpad.c b/src/evdev-touchpad.c index 1a48441..7312d11 100644 --- a/src/e

Re: help: is there any way to use integer 64 type in protocol?

On Sun, Apr 20, 2014 at 5:41 PM, Thiago Macieira wrote: > Em dom 20 abr 2014, às 17:31:48, Jason Ekstrand escreveu: > > Adding 64-bit types wouldn't be too hard. It would involve adding a > > int64_t an uint64_t types to wl_argument (I'd call them U and I > personally) > > and adding code throug

Re: help: is there any way to use integer 64 type in protocol?

On Sun, Apr 20, 2014 at 8:36 PM, Wang, Quanxian wrote: > > > > > *From:* Jason Ekstrand [mailto:ja...@jlekstrand.net] > *Sent:* Monday, April 21, 2014 6:32 AM > *To:* Pekka Paalanen > *Cc:* Wang, Quanxian; wayland-devel@lists.freedesktop.org > *Subject:* Re: help: is there any way to use integer 6