Re: [PATCH libinput 9/9] Add libinput_device_get_name() to advertise the kernel name

2014-04-08 Thread Peter Hutterer
On Tue, Apr 08, 2014 at 10:22:23PM +0200, Jonas Ådahl wrote: > On Fri, Mar 28, 2014 at 02:38:52PM +1000, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer > > --- > > Sorry, had forgotten about these, but have some comments (in a previous > e-mail and in this one). Anyhow, consider the patc

Re: [PATCH V3 0/7] Add weston randr protocol

2014-04-08 Thread Hardening
Le 08/04/2014 07:03, Quanxian Wang a écrit : Important Changes compared with V2: 1) Provide 2 methods to mode match for mode setting and mode delete. a) Exact mode number match Client selects the mode number according to query information. [...] 5) Add above and below move action o

Re: [PATCH V3 4/7] Add new mode function in drm backend

2014-04-08 Thread Hardening
Le 08/04/2014 07:03, Quanxian Wang a écrit : provide drm_output_new_mode interface to create new mode from outsite instead of only from edid or configure. Signed-off-by: Quanxian Wang --- src/compositor-drm.c | 76 1 file changed, 76 inser

Re: [PATCH] protocol: Correct typo 'suppot'

2014-04-08 Thread Jason Ekstrand
On Apr 8, 2014 4:05 PM, "Bryce W. Harrington" wrote: > > > Signed-off-by: Bryce Harrington > --- > protocol/fullscreen-shell.xml |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/protocol/fullscreen-shell.xml b/protocol/fullscreen-shell.xml > index 3c2cf3c..939c2ba 1006

Re: [PATCH weston] animation: Use fixed spring in weston_view_animation_run

2014-04-08 Thread Daiki Ueno
Kristian Høgsberg writes: > On Tue, Apr 08, 2014 at 03:54:43PM +0900, Daiki Ueno wrote: >> From: Daiki Ueno >> >> Since commit 3a869019, weston_view_animation_run initializes the >> spring with an arbitrary value range. This should be fine if the >> range is narrow enough, but if the range is

Re: [PATCH libinput 5/9] test: disable parallel build in test directory

2014-04-08 Thread Peter Hutterer
On Tue, Apr 08, 2014 at 09:55:30PM +0200, Jonas Ådahl wrote: > On Fri, Mar 28, 2014 at 02:38:48PM +1000, Peter Hutterer wrote: > > We depend on device creation on the host system, having the tests run in > > parallel runs a risk of random failure. > > > > Ideally we'd just disable for the actual r

[PATCH] protocol: Correct typo 'suppot'

2014-04-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington --- protocol/fullscreen-shell.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/fullscreen-shell.xml b/protocol/fullscreen-shell.xml index 3c2cf3c..939c2ba 100644 --- a/protocol/fullscreen-shell.xml +++ b/protocol/fullscreen-shell

Re: [PATCH libinput 9/9] Add libinput_device_get_name() to advertise the kernel name

2014-04-08 Thread Jonas Ådahl
On Fri, Mar 28, 2014 at 02:38:52PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- Sorry, had forgotten about these, but have some comments (in a previous e-mail and in this one). Anyhow, consider the patches in this series Reviewed-by: me. > I didn't end up needing this but i

Re: [PATCH] gl-renderer: Add flexible shader generation.

2014-04-08 Thread John Kåre Alsaker
I need to add lots of shader variants to do color conversions. On Tue, Apr 8, 2014 at 9:56 PM, Jasper St. Pierre wrote: > The code looks good, but I have one question: why? What's the motivation for > adding a generic shader generator? Does this fix any bugs? Add new hardware > support? Do you ha

Re: [PATCH libinput 5/9] test: disable parallel build in test directory

2014-04-08 Thread Jonas Ådahl
On Fri, Mar 28, 2014 at 02:38:48PM +1000, Peter Hutterer wrote: > We depend on device creation on the host system, having the tests run in > parallel runs a risk of random failure. > > Ideally we'd just disable for the actual run target, but I couldn't figure out > how to do that. What about the

[PATCH] gl-renderer: Remove gl_renderer_interface from gl-renderer.h

2014-04-08 Thread John Kåre Alsaker
--- src/gl-renderer.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gl-renderer.h b/src/gl-renderer.h index db42f6c..6cd5f54 100644 --- a/src/gl-renderer.h +++ b/src/gl-renderer.h @@ -101,4 +101,3 @@ struct gl_renderer_interface { void (*print_egl_error_state)(void); }; -struct

Re: [RFC PATCH 1/6] Add colorcorrection protocol

2014-04-08 Thread Pekka Paalanen
On Mon, 31 Mar 2014 13:13:40 +0200 Kai-Uwe Behrmann wrote: > Am 31.03.2014 11:43, schrieb Pekka Paalanen: > > On Mon, 31 Mar 2014 09:25:34 +0100 > > Richard Hughes wrote: > > > >> On 31 March 2014 08:46, Pekka Paalanen wrote: > >>> Is that a reasonable requirement for all compositors that suppo

Re: [PATCH fullscreen-shell v6 09/19] toytoolkit: Don't crash if wl_data_device_manager is not present

2014-04-08 Thread Bryce W. Harrington
On Wed, Apr 02, 2014 at 07:53:51PM -0500, Jason Ekstrand wrote: > This is primaraly to get weston-fullscreen to run on compositors that lack primarily > copy-paste support. > > Signed-off-by: Jason Ekstrand > --- > clients/window.c | 24 > 1 file changed, 16 insertions

Re: [PATCH fullscreen-shell v6 01/19] Add a fullscreen shell protocol

2014-04-08 Thread Bryce W. Harrington
Looks good, spotted one typo though. On Wed, Apr 02, 2014 at 07:53:43PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > protocol/fullscreen-shell.xml | 206 > ++ > 1 file changed, 206 insertions(+) > create mode 100644 protocol/fulls

Re: [PATCH weston] animation: Use fixed spring in weston_view_animation_run

2014-04-08 Thread Kristian Høgsberg
On Tue, Apr 08, 2014 at 03:54:43PM +0900, Daiki Ueno wrote: > From: Daiki Ueno > > Since commit 3a869019, weston_view_animation_run initializes the > spring with an arbitrary value range. This should be fine if the > range is narrow enough, but if the range is wide, the spring functions > conver

Re: [PATCH] terminal: Don't try to render RLE used as a placeholder

2014-04-08 Thread Kristian Høgsberg
On Tue, Apr 08, 2014 at 06:46:18PM +0900, Daiki Ueno wrote: > weston-terminal uses RLE (U+202B) as a placeholder of the right half > of a double width character. However, not all fonts include this > glyph and cairo renders it as .notdef (glyph index 0) in that case. > --- > A screenshot showing t

[PATCH] terminal: Don't try to render RLE used as a placeholder

2014-04-08 Thread Daiki Ueno
weston-terminal uses RLE (U+202B) as a placeholder of the right half of a double width character. However, not all fonts include this glyph and cairo renders it as .notdef (glyph index 0) in that case. --- A screenshot showing the problem: http://du-a.org/~ueno/junk/terminal-rle.png where a small

Re: [PATCH weston] Make sure config.h is included before any system headers

2014-04-08 Thread Andrew Wedgbury
On Mon, 7 Apr 2014, Kristian Høgsberg wrote: Thanks, patch applied. This patch was oddly messed up though, there was an extra space at the beginning of each line. git send-email is the only reliable way I know to send patches as email and it works with any smpt server you can access with your