RE: weston: weston randr protocol for testing and configuration

2014-03-22 Thread Wang, Quanxian
Hi, Pq Except the below comments. I want to mention several key points here. I have added the following request in protocol. 1) randr_commit (commit all requests in one shot) 2) randr_newmode (create mode with hdisplay, hsync_start, ... following weston.config definition to add custom mode) 3)

Re: How synchronisation works in Framebuffer backend

2014-03-22 Thread David Herrmann
Hi On Sat, Mar 22, 2014 at 6:33 PM, Sannu K wrote: > Hi, > > I was going through weston's framebuffer backend code. It does not call > FBIO_WAITFORVSYNC ioctl. > http://cgit.freedesktop.org/wayland/weston/tree/src/compositor-fbdev.c#n188 > says that it is not used intentionally. In this case, how

How synchronisation works in Framebuffer backend

2014-03-22 Thread Sannu K
Hi, I was going through weston's framebuffer backend code. It does not call FBIO_WAITFORVSYNC ioctl. http://cgit.freedesktop.org/wayland/weston/tree/src/compositor-fbdev.c#n188says that it is not used intentionally. In this case, how weston syncs frame with the framebuffer clock? How tearing is av

Re: [PATCH] compositor: Use weston_log rather than perror for error messages

2014-03-22 Thread Hardening
Le 22/03/2014 12:21, Pekka Paalanen a écrit : On Fri, 21 Mar 2014 05:54:02 + "Bryce W. Harrington" wrote: weston_log() seems to be the standard elsewhere in the codebase for errors. These are the only two instances where perror() is used instead, and their error messages aren't that infor

Re: weston: weston randr protocol for testing and configuration

2014-03-22 Thread Pekka Paalanen
Hi On Fri, 14 Mar 2014 11:18:48 +0800 Quanxian Wang wrote: > Objective: > With discussion in mail list, currently we have an agreement. Randr > interfaces will not be exposed public. > The objective will be only for testing and configuration. Thanks Pq, Jason, > Jasper, Hardening, and other's

Re: [PATCH] compositor: Use weston_log rather than perror for error messages

2014-03-22 Thread Pekka Paalanen
On Fri, 21 Mar 2014 05:54:02 + "Bryce W. Harrington" wrote: > weston_log() seems to be the standard elsewhere in the codebase for > errors. These are the only two instances where perror() is used > instead, and their error messages aren't that informative anyway. > > Signed-off-by: Bryce Ha