Re: [PATCH weston-ivi-shell 03/15] ivi-shell: Modified Makefile.am to build ivi-application protocol

2014-03-10 Thread Nobuhiko Tanibata
Hi pq, I will embed this patch to previous one. Regarding other patch, I also did the same thing, I will enclose update of Makefile to corresponding patch which update e.g. *.c. BR, Nobuhiko 2014-03-10 19:00 に Pekka Paalanen さんは書きました: On Thu, 6 Mar 2014 18:54:41 +0900 Nobuhiko Tanibata wro

Re: [PATCH weston-ivi-shell 04/15] ivi-shell supports a type of shell for In-Vehicle Infotainment system.

2014-03-10 Thread Nobuhiko Tanibata
2014-03-10 19:47 に Pekka Paalanen さんは書きました: On Thu, 6 Mar 2014 18:56:58 +0900 Nobuhiko Tanibata wrote: In-Vehicle Infotainment system traditionally manages surfaces with global identification. A protocol, ivi_application, supports such a feature by implementing a request, ivi_application::s

Re: [PATCH weston v4 15/15] Add a screen sharing plugin

2014-03-10 Thread Bryce W. Harrington
On Mon, Mar 10, 2014 at 08:42:41PM -0500, Jason Ekstrand wrote: > > > +static void > > > +ss_seat_handle_pointer_enter(void *data, struct wl_pointer *pointer, > > > + uint32_t serial, struct wl_surface *surface, > > > + wl_fixed_t x, wl_fixed_t y) >

Re: [PATCH] x11-backend: Add a --scale option

2014-03-10 Thread Bryce W. Harrington
LGTM Reviewed-by: Bryce Harrington On Fri, Mar 07, 2014 at 03:29:14PM -0600, Jason Ekstrand wrote: > From: Jason Ekstrand > > --- > man/weston.man | 4 > src/compositor-x11.c | 11 +++ > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/man/weston.man b/m

Re: [PATCH weston] Fix the pixman renderer with respect to output transforms

2014-03-10 Thread Bryce W. Harrington
On Tue, Feb 25, 2014 at 09:54:59PM -0600, Jason Ekstrand wrote: > Commit fa1b3055 introducted a regression in the pixman renderer. In > particular, it would not draw properly with any output transform other > than normal, 180, 180-flipped, or 270-flipped. This patch fixes this > regression. The

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
Thanks. Quanxian >> >binds with version 2 regardless of what the compositor advertised. >> > >> >You can compare to the "desktop_shell" global handling which seems >> >correct. >> [Wang, Quanxian] I will check and update that. The change will be >> like that 1293 output->output = >> 1294

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
>-Original Message- >From: Pekka Paalanen [mailto:ppaala...@gmail.com] >Sent: Monday, March 10, 2014 7:05 PM >To: Wang, Quanxian >Cc: wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH] Bug fix client apps because of output change > >On Mon, 10 Mar 2014 10:58:00 + >"Wang, Quanxi

Re: [PATCH weston v4 15/15] Add a screen sharing plugin

2014-03-10 Thread Bryce W. Harrington
Mostly just some spell checks. Reviewed-by: Bryce Harrington On Tue, Feb 25, 2014 at 07:26:47PM -0600, Jason Ekstrand wrote: > This adds a plugin called screen-share.so. If the screen-share.so module > is imported, it will add the CTRL+ALT+s keybinding to start a screen > sharing session. If y

[PATCH] tests: Fix build of noinst fixed-benchmark test

2014-03-10 Thread Bryce W. Harrington
Solves this build error: tests/fixed-benchmark.o: In function `benchmark': ./wayland/tests/fixed-benchmark.c:82: undefined reference to `clock_gettime' ./wayland/tests/fixed-benchmark.c:84: undefined reference to `clock_gettime' Signed-off-by: Bryce Harrington --- Makefile.am |1 + 1

Re: [PATCH wayland 1/4] build: depend on generated protocol headers

2014-03-10 Thread Kristian Høgsberg
On Mon, Mar 10, 2014 at 02:03:57PM +0200, Pekka Paalanen wrote: > From: Pekka Paalanen > > Fixes the build failure where the protocol headers were not generated at > all before compiling src/.libs/libwayland_server_la-wayland-server.o. > > The failure was reproducable by starting fresh with 'git

Re: [PATCH weston-ivi-shell v2 02/15] ivi application protocol:

2014-03-10 Thread Pekka Paalanen
On Fri, 7 Mar 2014 22:56:02 +0900 Nobuhiko Tanibata wrote: > Add interface ivi_application, which creates ivi_surface objects tied > to a given wl_surface with a given id. The given id can be used in a > shell to identify which application is assigned to a wl_surface and > layout the surface whe

[PATCH wayland 1/4] build: depend on generated protocol headers

2014-03-10 Thread Pekka Paalanen
From: Pekka Paalanen Fixes the build failure where the protocol headers were not generated at all before compiling src/.libs/libwayland_server_la-wayland-server.o. The failure was reproducable by starting fresh with 'git clean -dxf' and not having any wayland headers installed system-wide. Sign

[PATCH wayland 3/4] build: hide doxygen commands with AM_V_GEN

2014-03-10 Thread Pekka Paalanen
From: Pekka Paalanen I suppose the purpose was to print just one GEN line for each doxygen rule being executed, not print the doxygen command. Signed-off-by: Pekka Paalanen --- doc/doxygen/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/doxygen/Makefil

[PATCH wayland 2/4] doc: do not rebuild man pages if they are up to date

2014-03-10 Thread Pekka Paalanen
From: Pekka Paalanen The doxygen.man make target was not a real file that was generated, therefore the man page rule was ran on every make invocation. Replace it with a real file that is produced by the man page rule. Signed-off-by: Pekka Paalanen --- doc/doxygen/Makefile.am | 4 ++-- 1 file c

[PATCH wayland 4/4] update .gitignore

2014-03-10 Thread Pekka Paalanen
From: Pekka Paalanen Makes 'git status' clean again after a successful 'make distcheck'. Signed-off-by: Pekka Paalanen --- .gitignore | 22 ++ tests/.gitignore | 17 - 2 files changed, 22 insertions(+), 17 deletions(-) delete mode 100644 tests/.gitign

Re: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Pekka Paalanen
On Mon, 10 Mar 2014 10:58:00 + "Wang, Quanxian" wrote: > > > >-Original Message- > >From: Pekka Paalanen [mailto:ppaala...@gmail.com] > >Sent: Monday, March 10, 2014 5:58 PM > >To: Wang, Quanxian > >Cc: wayland-devel@lists.freedesktop.org > >Subject: Re: [PATCH] Bug fix client apps

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
>-Original Message- >From: Pekka Paalanen [mailto:ppaala...@gmail.com] >Sent: Monday, March 10, 2014 5:58 PM >To: Wang, Quanxian >Cc: wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH] Bug fix client apps because of output change > >On Mon, 10 Mar 2014 08:23:45 + >"Wang, Quanxi

Re: [PATCH weston-ivi-shell 04/15] ivi-shell supports a type of shell for In-Vehicle Infotainment system.

2014-03-10 Thread Pekka Paalanen
On Thu, 6 Mar 2014 18:56:58 +0900 Nobuhiko Tanibata wrote: > In-Vehicle Infotainment system traditionally manages surfaces with global > identification. A protocol, ivi_application, supports such a feature by > implementing a request, ivi_application::surface_creation defined in > ivi_applicatio

Re: [PATCH weston-ivi-shell v2 02/15] ivi application protocol:

2014-03-10 Thread Nobuhiko Tanibata
2014-03-10 17:41 に Pekka Paalanen さんは書きました: On Fri, 7 Mar 2014 10:39:44 -0600 Jason Ekstrand wrote: On Mar 7, 2014 7:56 AM, "Nobuhiko Tanibata" < nobuhiko_tanib...@xddp.denso.co.jp> wrote: > > Add interface ivi_application, which creates ivi_surface objects > tied to a given wl_surface with a

Re: [PATCH weston-ivi-shell 03/15] ivi-shell: Modified Makefile.am to build ivi-application protocol

2014-03-10 Thread Pekka Paalanen
On Thu, 6 Mar 2014 18:54:41 +0900 Nobuhiko Tanibata wrote: > Signed-off-by: Nobuhiko Tanibata > --- > protocol/Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/protocol/Makefile.am b/protocol/Makefile.am > index 5e331a7..9913f16 100644 > --- a/protocol/Ma

Re: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Pekka Paalanen
On Mon, 10 Mar 2014 08:23:45 + "Wang, Quanxian" wrote: > Thanks Pq. Comments below. ... > >> @@ -1145,6 +1154,45 @@ desktop_destroy_outputs(struct desktop > >> *desktop) } > >> > >> static void > >> +update_output(struct output *output) > >> +{ > >> + struct panel *panel = output->panel; >

Re: [PATCH weston-ivi-shell v2 02/15] ivi application protocol:

2014-03-10 Thread Pekka Paalanen
On Fri, 7 Mar 2014 10:39:44 -0600 Jason Ekstrand wrote: > On Mar 7, 2014 7:56 AM, "Nobuhiko Tanibata" < > nobuhiko_tanib...@xddp.denso.co.jp> wrote: > > > > Add interface ivi_application, which creates ivi_surface objects > > tied to a given wl_surface with a given id. The given id can be > > use

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
Thanks Pq. Comments below. >-Original Message- >From: wayland-devel-boun...@lists.freedesktop.org >[mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Pekka >Paalanen >Sent: Monday, March 10, 2014 3:47 PM >To: Wang, Quanxian >Cc: wayland-devel@lists.freedesktop.org >Subject:

Re: [PATCH weston-ivi-shell 01/15] This vfunc lets us read out a rectangle of pixels from the currently attached surface buffer.

2014-03-10 Thread Pekka Paalanen
On Thu, 6 Mar 2014 18:51:15 +0900 Nobuhiko Tanibata wrote: > From: Kristian Høgsberg > > --- > src/compositor.h | 3 +++ > src/gl-renderer.c | 54 > ++ 2 files > changed, 57 insertions(+) > > diff --git a/src/compositor.h b/src/compositor.

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
>-Original Message- >From: wayland-devel-boun...@lists.freedesktop.org >[mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Pekka >Paalanen >Sent: Monday, March 10, 2014 3:47 PM >To: Wang, Quanxian >Cc: wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH] Bug fix client

Re: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Pekka Paalanen
Hi, overall this looks fine now, but I still haven't tested it. I'm moving on to nitpick on the minor details. ;-) The patch title (topic line) is usually prefixed with the component the patch is affecting. Looking at the clients/desktop-shell.c history, the appropriate prefix would be "desktop-s