RE: [PATCH 0/6] Add weston randr protocol

2014-02-26 Thread Wang, Quanxian
Thanks Pq and Jason's comment. Regards Quanxian Wang -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Thursday, February 27, 2014 3:08 PM To: Wang, Quanxian Cc: Jason Ekstrand; Kristensen, Kristian H; Zhang, Xiong Y; wayland-devel@lists.freedesktop.org Subject

Re: [PATCH 1/6] Add weston randr protocol

2014-02-26 Thread Pekka Paalanen
On Thu, 27 Feb 2014 11:28:00 +0800 Quanxian Wang wrote: > Weston protocol wrandr will provide interface to > 1) set output mode > 2) set output transform > 3) move output to relative position > 4) provide disconnected display port information > > *Dynamic* mode setting is the main objective of t

Re: [PATCH 0/6] Add weston randr protocol

2014-02-26 Thread Pekka Paalanen
On Thu, 27 Feb 2014 05:30:21 + "Wang, Quanxian" wrote: > Hi, All > > From Jason's comment, about the security issue, I am not sure if I should > think about that in this protocol. For communication protocol between client > and server, it is hard to control the permission by single protoco

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-26 Thread Pekka Paalanen
On Wed, 26 Feb 2014 21:13:16 -0600 Jason Ekstrand wrote: > Technically, wl_surface.damage is supposed to be called between > wl_surface.attach and wl_surface.commit. However, I think Weston is fairly > forgiving on this point and it might work. The order between damage, attach, etc. must be irr

RE: [PATCH 0/6] Add weston randr protocol

2014-02-26 Thread Wang, Quanxian
Hi, All >From Jason's comment, about the security issue, I am not sure if I should >think about that in this protocol. For communication protocol between client >and server, it is hard to control the permission by single protocol. It is not >the same as directly call process that we can easily

RE: [PATCH 0/6] Add weston randr protocol

2014-02-26 Thread Wang, Quanxian
From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Thursday, February 27, 2014 11:29 AM To: Wang, Quanxian Cc: wayland-devel@lists.freedesktop.org; Zhang, Xiong Y Subject: Re: [PATCH 0/6] Add weston randr protocol Quanxian, I haven't looked through the code line-by-line, but I do have a fe

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-26 Thread Jasper St. Pierre
For what it's worth, mutter treats wl_surface.damage coordinates as buffer coordinates right now. So we're broken for buffer transformations, but doing the intuitive correct thing. Having them be in buffer coordinates is the intuitive thing to do here, and I think it's what most implementers do ri

Re: [PATCH 0/6] Add weston randr protocol

2014-02-26 Thread Jason Ekstrand
Quanxian, I haven't looked through the code line-by-line, but I do have a few general comments. First, please double-check your copyright blocks. One of your files is copyrighted Benjamin Franzke and another is copyrighted Collabora. I don't think that was intended. Second, it doesn't appear th

[PATCH 5/6] Add weston-randr application

2014-02-26 Thread Quanxian Wang
Signed-off-by: Quanxian Wang Reviewed-by: Zhang, Xiong Y --- clients/Makefile.am | 9 + clients/wrandr.c| 642 2 files changed, 651 insertions(+) create mode 100644 clients/wrandr.c diff --git a/clients/Makefile.am b/clients/Makefile.a

[PATCH 6/6] Change the size of Panel and Background after output's is changed

2014-02-26 Thread Quanxian Wang
Panel and background depend on the size of output, So they have to be bound with output change including mode, transform and scale. Before resize the panel and background window, their min_allocation has to be reset. Add window_set_min_allocation function Signed-off-by: Quanxian Wang Reviewed-by

[PATCH 1/6] Add weston randr protocol

2014-02-26 Thread Quanxian Wang
Weston protocol wrandr will provide interface to 1) set output mode 2) set output transform 3) move output to relative position 4) provide disconnected display port information *Dynamic* mode setting is the main objective of this protocol. Remember, it is one shot operation. For example, if settin

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-26 Thread Jason Ekstrand
Hi All, I talked to Kristian in IRC about this today. It turns out that damage isn't an issue in the case where we have an integer buffer_scale or a transform that's a multiple of 180 degress. This is because, in these cases, the buffer size is at least as large as the surface size and damaging b

[PATCH 2/6] Add weston_randr definition and randr_backend intreface

2014-02-26 Thread Quanxian Wang
Signed-off-by: Quanxian Wang Reviewed-by: Zhang, Xiong Y --- src/compositor.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/compositor.h b/src/compositor.h index 22a485f..6bc000f 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -172,6 +172,15 @@ enum weston_mode_

[PATCH 0/6] Add weston randr protocol

2014-02-26 Thread Quanxian Wang
These patches will provide weston randr protocol, its implementation and randr application. The idea is from xrandr provided by xserver. *Dynamic* mode setting is the main objective of this protocol. Remember, it is one shot operation. For example, if setting the mode, just call one request wl_ran

[PATCH 4/6] Initialize the randr interface in drm backend

2014-02-26 Thread Quanxian Wang
Function get_disoutputs is added in order to provide display port information embedded on the machine. Signed-off-by: Quanxian Wang Reviewed-by: Zhang, Xiong Y --- src/compositor-drm.c | 67 1 file changed, 67 insertions(+) diff --git a/src/

[PATCH 3/6] Add the detailed implementation of randr protocol

2014-02-26 Thread Quanxian Wang
1) add the initialization of randr protocol 2) add the randr request implementation Signed-off-by: Quanxian Wang Reviewed-by: Zhang, Xiong Y --- src/Makefile.am | 4 + src/compositor.c | 466 +-- 2 files changed, 423 insertions(+), 47 delet

Re: Summary of the security discussions around Wayland and privileged clients

2014-02-26 Thread Sebastian Wick
Hey Jasper, maybe I didn't understand what you're saying but why can't you use the application authorization mechanism you're talking about in a "WSM"? Wouldn't it make sense to make it independent of the compositor? Am 2014-02-26 23:05, schrieb Jasper St. Pierre: Hi Martin, My experience w

Re: Summary of the security discussions around Wayland and privileged clients

2014-02-26 Thread Jasper St. Pierre
Hi Martin, My experience with PAM and similar "pluggable security modules" is that they provide a subpar user experience, are hard to integrate properly into the system, and have large pain points that stem from having such flexibility. My compositor, mutter, will probably never call out to your

Re: Summary of the security discussions around Wayland and privileged clients

2014-02-26 Thread Martin Peres
Le 19/02/2014 17:11, Martin Peres a écrit : Wayland Security Modules As seen earlier, granting access to a restricted interface or not depends on the context of the client (how it was launched, previous actions). The expected behaviour should be defined by a security policy. As no conse

[ANNOUNCE] libinput 0.1

2014-02-26 Thread Jonas Ådahl
The first official release of libinput, 0.1, is now available. There is no API/ABI stability promised for this release, but what can be said is that there are no big changes planned, meaning a user of this library will not need to make large changes to support future versions of libinput. What is

[PATCH] FreeRds backend, simplifications and improvements take 2

2014-02-26 Thread Hardening
Sorry for the last mail that was badly rebased with an incorrect src/Makefile.am file (thanks to Mariusz Ceier who told me about that). FreeRDS is a FreeRDP based RDP server, the server handles incoming connections and talks RDP with the peers. FreeRds cooperates with an "out-service": the out-s

[PATCH] FreeRds backend, simplifications and improvements

2014-02-26 Thread Hardening
FreeRDS is a FreeRDP based RDP server, the server handles incoming connections and talks RDP with the peers. FreeRds cooperates with an "out-service": the out-service creates the content to display, and FreeRds will take care of encoding the content in the appropriate codec (raw, planar, remoteF

[PATCH 2/2] compositor: use Mod-Tab to show/raise minimized surfaces

2014-02-26 Thread Manuel Bachmann
Temporarily show minimized surfaces when switching between surfaces with the keyboard. If the final selected one was minimized, it will be restored. Signed-off-by: Manuel Bachmann --- desktop-shell/shell.c | 25 + 1 file changed, 25 insertions(+) diff --git a/desktop-s

[PATCH 1/2] compositor: implement xdg_surface_set_minimized()

2014-02-26 Thread Manuel Bachmann
We now handle the client-side xdg_surface_set_minimized() call, and eventually hide the target surface by moving it to a dedicated layer. Signed-off-by: Manuel Bachmann --- desktop-shell/shell.c | 64 - desktop-shell/shell.h |2 ++ 2 files ch

Re: [PATCH 3/5] shell: add managed_surface interface, request and events

2014-02-26 Thread Manuel Bachmann
Just some info regarding these taskbar patches ; I have some more patches fixing bugs experienced on certain cases (multiples outputs, DRM backend...). They are all available on GitHub, https://github.com/Tarnyko/weston-taskbar/commits/HEAD-taskbar. I could refactor and repost the whole set here.

Wayland presentation extension (video protocol) WIP after RFCv2

2014-02-26 Thread Pekka Paalanen
Hi all, I just wanted to mention where I am with this at the moment, as it seems like it will be some time before I can come back to this. The RFCv2 thread started at: http://lists.freedesktop.org/archives/wayland-devel/2014-January/012988.html Since then, there has been plenty of discussion, so

[PATCH weston 0/2] input-method: Make wl_input_method_context reactivatable

2014-02-26 Thread Daiki Ueno
While going through input-method.xml, I encountered this: Input method contexts do not keep state after deactivation and should be destroyed after deactivation is handled. This limitation seems a bit innatural, since the counterpart wl_text_input object can persist after deactivatio

[PATCH weston 1/2] input-method: Fix typo in description

2014-02-26 Thread Daiki Ueno
--- protocol/input-method.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/protocol/input-method.xml b/protocol/input-method.xml index 70afdcb..448440e 100644 --- a/protocol/input-method.xml +++ b/protocol/input-method.xml @@ -29,7 +29,7 @@ Corres

[PATCH weston 2/2] input-method: Make wl_input_method_context reactivatable

2014-02-26 Thread Daiki Ueno
Change the semantics of wl_input_method_context activation/deactivation mechanism, similar to what wl_text_input does. Previously, a wl_input_method_context object is created upon wl_input_method::activate event and cannot persist after deactivation, while the counterpart wl_text_input object pers