Re: Make safe double remove?

2014-01-28 Thread Pekka Paalanen
On Tue, 28 Jan 2014 21:45:14 + Jonathan Howard wrote: > More of a for argument as I see it. With unlinked state you can have > if desired a wl_list_unlinked function (identical to empty as used on > the head.) > > Changing wl_list_insert is a code breaker as it is used to initialise > at the

New renderer features (Re: [PATCH 2/2] compositor: add a masking mechanism to weston_layer)

2014-01-28 Thread Pekka Paalanen
On Tue, 28 Jan 2014 18:21:40 +0200 Ander Conselvan de Oliveira wrote: > On 01/27/2014 09:46 PM, Giulio Camuffo wrote: > > this adds a mechanism to mask the views belonging to a layer > > to an arbitrary rect, in the global space. The parts that don't fit > > in that rect will be clipped away. > >

libinput requirements for feature parity with X

2014-01-28 Thread Peter Hutterer
Here's a list of features I consider the minimum to get something akin to feature-parity with the current X.Org-based stack. This is not a wishlist for features, it's a list of minimum requirements that covers 90% of the user base. keyboard: I don't think there's much to do, keyboards are fairly s

[PATCH libinput 2/5] path: store the sysname, not the syspath, in the device

2014-01-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/path.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/path.c b/src/path.c index 3b09cbe..2553005 100644 --- a/src/path.c +++ b/src/path.c @@ -75,7 +75,7 @@ path_seat_create(struct path_input *input, static int path_

[PATCH libinput 1/5] Add COPYING file

2014-01-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- COPYING | 24 1 file changed, 24 insertions(+) create mode 100644 COPYING diff --git a/COPYING b/COPYING new file mode 100644 index 000..bedbc86 --- /dev/null +++ b/COPYING @@ -0,0 +1,24 @@ +Copyright © 2008-2012 Kristian Høgsberg +

[PATCH libinput 4/5] test: Make sure the sysname of a device is correct

2014-01-28 Thread Peter Hutterer
Currently this means start with "event" and don't contain /. Signed-off-by: Peter Hutterer --- test/path.c | 23 +++ test/udev.c | 34 ++ 2 files changed, 57 insertions(+) diff --git a/test/path.c b/test/path.c index 12787f6..875cd88 100644 --

[PATCH libinput 5/5] tools: add a tool for basic event debugging

2014-01-28 Thread Peter Hutterer
Simply prints the various events to make it easier to check what's coming out of libinput. Works for --udev (the default) or for --device /dev/input/event0. Example output: event7 DEVICE_ADDEDseat0 default event8 DEVICE_ADDEDseat0 default event4 POINTER_BUTTON +1.35s 272 pressed e

[PATCH libinput 3/5] path: print error when failing to open a device

2014-01-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/path.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/path.c b/src/path.c index 2553005..2b8f530 100644 --- a/src/path.c +++ b/src/path.c @@ -130,7 +130,8 @@ path_input_enable(struct libinput *libinput) fd = open_restricte

Re: [PATCH weston] desktop-shell: initialize children link

2014-01-28 Thread Bryce W. Harrington
On Tue, Jan 28, 2014 at 01:54:16PM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > Since commit 9046d2, when destroying a surface, we remove all the > links from its children. But when the child surfaces are destroyed, > those links will be removed again, but since they were no

Re: [PATCH 1/2] compositor: keep track of the weston_layer a weston_view is in

2014-01-28 Thread Bryce W. Harrington
On Mon, Jan 27, 2014 at 09:46:49PM +0200, Giulio Camuffo wrote: > This introduces a new struct, weston_layer_entry, which is now used > in place of wl_list to keep the link for the layer list in weston_view > and the head of the list in weston_layer. > weston_layer_entry also has a weston_layer*, w

[PATCH] web: Fix typo and grammar in testing documentation

2014-01-28 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington --- testing.html |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/testing.html b/testing.html index a65d8f4..21c0b7b 100644 --- a/testing.html +++ b/testing.html @@ -19,8 +19,8 @@ the tests directory. It leverages automake's specify

Re: Make safe double remove?

2014-01-28 Thread Jonathan Howard
More of a for argument as I see it. With unlinked state you can have if desired a wl_list_unlinked function (identical to empty as used on the head.) Changing wl_list_insert is a code breaker as it is used to initialise at the moment so can't inspect the element. There remains other unsafe ca

Re: Make safe double remove?

2014-01-28 Thread Jason Ekstrand
Jonathan, I have thought on multiple occations about doing this exact thing. If we do, we should probably also make wl_list_insert_list safe. The counter-argument for all this is that you have to keep track of whether or not your elements are in a list anyway to avoid corruption. For instance, y

Re: Orbital 0.1

2014-01-28 Thread Michael Hasselmann
> > [0]: http://min.us/m7qsx2pHqpImB > > [1]: http://www.youtube.com/watch?v=bd1hguj2bPE > > > > Giulio > > Looks great, thanks for sharing! Agree, good work. But what *is* orbit and the other thing, in a single sentence? Compiz-ng? ciao Michael ___ w

Make safe double remove?

2014-01-28 Thread Jonathan Howard
Code is already using wl_list_init to have the construction of unlinked items in a stable state so that they can be destroyed with wl_list_remove. A problem is it is easy to write code that calls wl_list_remove during the structures life and miss that you need to reset with wl_list_init for wh

Re: [PATCH 2/2] compositor: add a masking mechanism to weston_layer

2014-01-28 Thread Giulio Camuffo
2014-01-28 Ander Conselvan de Oliveira : > On 01/27/2014 09:46 PM, Giulio Camuffo wrote: >> >> this adds a mechanism to mask the views belonging to a layer >> to an arbitrary rect, in the global space. The parts that don't fit >> in that rect will be clipped away. >> Implemented in the gl and pixma

Re: [PATCH 2/2] compositor: add a masking mechanism to weston_layer

2014-01-28 Thread Ander Conselvan de Oliveira
On 01/27/2014 09:46 PM, Giulio Camuffo wrote: this adds a mechanism to mask the views belonging to a layer to an arbitrary rect, in the global space. The parts that don't fit in that rect will be clipped away. Implemented in the gl and pixman renderers only for now. --- src/compositor.c |

[PATCH weston] desktop-shell: initialize children link

2014-01-28 Thread pochu27
From: Emilio Pozuelo Monfort Since commit 9046d2, when destroying a surface, we remove all the links from its children. But when the child surfaces are destroyed, those links will be removed again, but since they were not properly initialized, weston will crash. Call shell_surface_set_parent ins

Re: weston-1.4.0: rpi-backend is broken

2014-01-28 Thread Pekka Paalanen
On Tue, 28 Jan 2014 00:49:06 +0100 "Yann E. MORIN" wrote: > Pekka, All, > > On 2014-01-26 21:15 +0100, Yann E. MORIN spake thusly: > > On 2014-01-26 21:51 +0200, Pekka Paalanen spake thusly: > > > On Sun, 26 Jan 2014 19:08:47 +0100 > > > "Yann E. MORIN" wrote: > > > > I'm trying to run wayland+

Re: [Mesa-dev] What use do swap interval > 1 and OML_sync_control divisor and remainder have?

2014-01-28 Thread Pekka Paalanen
Hi Ian and Jason On Mon, 27 Jan 2014 12:26:23 -0700 Ian Romanick wrote: > On 01/24/2014 04:32 AM, Pekka Paalanen wrote: > > Hi, > > > > I am investigating what kind of Wayland protocol extensions would be > > needed to support proper presentation timing. Looking at existing > > works, I am wond