Re: 1.4 Beta (1.3.92) Test Results

2014-01-21 Thread Bryce W. Harrington
On Mon, Jan 20, 2014 at 07:58:18PM +, Eoff, Ullysses A wrote: > ::Automated Test Results:: > > Passed: 99% (1254/1272) > Failed: 1% (18/1272) > > ::Issues Encountered (new and pre-existing):: > > SIGSEGV in ping_timeout_handler: > >

Re: weston crash in destroy_shell_surface

2014-01-21 Thread Neil Roberts
It looks like the rest of the code assumes that shsurf->children_link is always a consistent list. For example, shell_surface_set_parent resets children_link to the empty list after it unlinks a child from its parent. The destroy_shell_surface code just calls wl_list_remove which leaves the list no

weston crash in destroy_shell_surface

2014-01-21 Thread Dima Ryazanov
I haven't figured out how to fix the crash, but wanted to bring it up before the 1.4 release. It's pretty easy to reproduce it: 1. Open weston-terminal (or maybe another client) 2. Right-click the titlebar 3. Click "close" As far as I can tell, the problem is these lines in destroy_shell_surface