Re: [PATCH 2/2] Fix XWayland crashes when opening popups

2014-01-17 Thread Kristian Høgsberg
On Fri, Jan 17, 2014 at 12:26 PM, Jasper St. Pierre wrote: > If we respect the ICCCM, we need to map the child window when the client > asks for it to be mapped. If the WM_TRANSIENT_FOR hint specifies an invalid > window, we just ignore it. > > Looking through the mutter code, it seems that if we

Re: [PATCH 2/2] Fix XWayland crashes when opening popups

2014-01-17 Thread Jasper St. Pierre
If we respect the ICCCM, we need to map the child window when the client asks for it to be mapped. If the WM_TRANSIENT_FOR hint specifies an invalid window, we just ignore it. Looking through the mutter code, it seems that if we don't recognize a window specified in WM_TRANSIENT_FOR, we warn and i

Re: [PATCH 2/2] Fix XWayland crashes when opening popups

2014-01-17 Thread Kristian Høgsberg
On Sun, Jan 12, 2014 at 03:06:05PM +0100, Axel Davy wrote: > Signed-off-by: Axel Davy > --- > xwayland/window-manager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I don't think we have the right fix here, but I've applied the patch since we're too close to release right now. If a w

Re: [PATCH] gitignore: Generated files text-client-protocol.h, text-protocol.c

2014-01-17 Thread Kristian Høgsberg
On Wed, Jan 15, 2014 at 02:39:26AM +, Bryce W. Harrington wrote: Patch applied, thanks. Kristian > Signed-off-by: Bryce Harrington > --- > tests/.gitignore |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index 32a6492..dc4a71a 100644 > -

Re: [PATCH 2/2] Cleanup stray newline in a return statement

2014-01-17 Thread Kristian Høgsberg
On Tue, Jan 14, 2014 at 09:58:34PM +, Bryce W. Harrington wrote: > > Signed-off-by: Bryce Harrington Hehe, I wonder where that semi-colon was going. Thanks. Kristian > --- > src/libbacklight.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/libbacklight

Re: [PATCH 1/2] terminal: Only set title if asprintf succeeded

2014-01-17 Thread Kristian Høgsberg
On Tue, Jan 14, 2014 at 09:58:32PM +, Bryce W. Harrington wrote: > Handles potential out of memory situation by skipping the title update. > This fixes the following warning: > > terminal.c: In function ‘resize_handler’: > terminal.c:851:11: warning: ignoring return value of ‘asprintf’, >

Re: [PATCH] client: Include poll.h instead of sys/poll.h

2014-01-17 Thread Kristian Høgsberg
On Tue, Jan 14, 2014 at 06:38:59PM +0100, Jonas 'Sortie' Termansen wrote: > POSIX mandates the poll.h header as the standard location of poll(2). > --- > src/wayland-client.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) That looks correct. I think that maybe I copy and pasted a sys

Re: [PATCH wayland] protocol: Clarify semantics of sub-surface placement requests

2014-01-17 Thread Bill Spitzak
Jonas Ådahl wrote: For example one could queue the operations until commit, having a subsequent request replace a previous one, instead of executing them immediately relying on commit to take a snapshot. It could also be read as a subsequent request that now replaces a previous request to be in

Re: [PATCH] weston.ini.man: Fix some grammar

2014-01-17 Thread Kristian Høgsberg
On Fri, Jan 10, 2014 at 10:23:12PM +0100, Wieland Hoffmann wrote: > --- > man/weston.ini.man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied. Kristian > diff --git a/man/weston.ini.man b/man/weston.ini.man > index 6be90bf..ce3f928 100644 > --- a/man/weston.ini.man > +++

Re: [PATCH wayland] protocol: Clarify semantics of sub-surface placement requests

2014-01-17 Thread Jasper St. Pierre
Hey, This came up during the mutter implementation. See my questions here for what prompted this. I found the proposed phrasing a bit confusing as well... https://bugzilla.gnome.org/show_bug.cgi?id=705502#c16 On Fri, Jan 17, 2014 at 6:37 AM, Jonas Ådahl wrote: > On Fri, Jan 17, 2014 at 12:20:

Re: [PATCH wayland] protocol: Clarify semantics of sub-surface placement requests

2014-01-17 Thread Jonas Ådahl
On Fri, Jan 17, 2014 at 12:20:17PM +0200, Pekka Paalanen wrote: > Hi Jonas > > On Thu, 16 Jan 2014 23:27:07 +0100 > Jonas Ådahl wrote: > > > Clarify some semantics of wl_subsurface.place_below and > > wl_subsurface.place_below that were not specified. > > Below and below. ;-) > > > > > Signed

Re: [PATCH wayland] protocol: Clarify semantics of sub-surface placement requests

2014-01-17 Thread Pekka Paalanen
Hi Jonas On Thu, 16 Jan 2014 23:27:07 +0100 Jonas Ådahl wrote: > Clarify some semantics of wl_subsurface.place_below and > wl_subsurface.place_below that were not specified. Below and below. ;-) > > Signed-off-by: Jonas Ådahl > --- > > Hi, > > Implementing support for sub-surfaces in mutte