Re: [PATCH 2/2] shell: Handle the desktop shell client destroy signal

2013-12-20 Thread Jason Ekstrand
Looks like a good idea to me. --Jason On Dec 20, 2013 1:07 PM, "Ander Conselvan de Oliveira" wrote: > From: Ander Conselvan de Oliveira > > Set the internal pointer for the client to NULL. This fixes a > segmentation fault at shutdown, where the shell would hang up before > and cause libwayland

Re: [PATCH 1/2] compositor: Destroy renderer in weston_compositor_shutdown()

2013-12-20 Thread Jason Ekstrand
Ander, I don't neciserally disagree we with this change, but shouldn't the GL renderer clean up after itself better? --Jason On Dec 20, 2013 1:07 PM, "Ander Conselvan de Oliveira" wrote: > From: Ander Conselvan de Oliveira > > Currently we destroy the renderer before the outputs are destroyed, b

Re: [PATCH] compositor: Ensure views on hiden workspace are listening correct output

2013-12-20 Thread Ander Conselvan de Oliveira
On 12/19/2013 11:26 AM, Xiong Zhang wrote: The views on hiden workspace can't restored correctly when their output was unplugged. There are two reasons: First: the views on hiden workspace is restored through animation which will change y coordinate continually, if the y coordinate of invisible

[PATCH 1/2] compositor: Destroy renderer in weston_compositor_shutdown()

2013-12-20 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Currently we destroy the renderer before the outputs are destroyed, but that sometimes leads to an error since a reference to the renderer is necessary in order to destroy a gl_renderer_output. Since destroying the renderer is common among all backends, just mov

[PATCH 2/2] shell: Handle the desktop shell client destroy signal

2013-12-20 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Set the internal pointer for the client to NULL. This fixes a segmentation fault at shutdown, where the shell would hang up before and cause libwayland to call wl_client_destroy(). When the shell was destroyed later, another call to wl_client_destroy() would caus

Re: Improve shell window stacking ordering

2013-12-20 Thread Kristian Høgsberg
Hi Philip, I guess I never replied to you like I usually do when I merge patches, but I commited your patches Dec 2nd. If you have a few spare cycles, could you have a look at this bug that look like stacking regressions from those patches: https://bugs.freedesktop.org/show_bug.cgi?id=72547 tha

Re: Improve shell window stacking ordering

2013-12-20 Thread Philip Withnall
On Mon, 2013-12-02 at 15:22 -0800, Kristian Høgsberg wrote: > But we need to wait for Rafaels xdg-shell patches to land first. How far away from landing are they? Regardless of how far away they are, would it make sense to commit some of the more self-contained patches from my patchset (such as p

Re: [RFC] Global binding

2013-12-20 Thread Maarten Baert
On 20/12/13 17:24, Quentin Glidic wrote: > The first important point is here: the client only binds an *action*. > The action is a describing string and does not leak the key which is > bound. There would be a set of standard actions, some vendors ones, and > user custom ones (which application wou

[RFC] Global binding

2013-12-20 Thread Quentin Glidic
Hello, With the recent security concerns about the screenshoter interface, a sibling topic came back to surface: global keyboard/mouse listening. TL;DR: We need to have a global binding mechanism. I suggest a simple request to bind an *action* which is fully controlled by the compositor. The mu