Re: [PATCH] compositor-drm: free drm_mode in drm_output_destroy

2013-12-16 Thread Bryce W. Harrington
On Mon, Dec 16, 2013 at 03:23:43PM +0800, Xiong Zhang wrote: > When drm_output is destroyed, we should free drm_mode to avoid > memoey leakage. ^ 'memory' > Signed-off-by: Xiong Zhang Reviewed-by: Bryce Harrington > --- > src/compositor-drm.c | 7 +++ > 1 file changed, 7 insertions(+) >

Re: [PATCH] compositor-drm: consider the best mode of the mode_list as an option

2013-12-16 Thread Bryce W. Harrington
On Thu, Dec 12, 2013 at 05:13:56PM +0100, Fabien DESSENNE wrote: > This patch fixes an issue where Weston using the DRM backend, cannot start > the display. This happens in the following context: > - no video mode is set before weston starts (eg no "/dev/fb" set up) > - weston is not configured wit

Re: [PATCH weston] introduces a setting to give permission to any client to do screenshots

2013-12-16 Thread Bill Spitzak
Giulio Camuffo wrote: 2013/12/16 Bill Spitzak : Could an api be added so that one client can "give" access to an object to another client? This would allow a single secure client to implement all the rules for what is allowed to be a screen saver, rather than having the rules be in the composi

Re: [PATCH weston 10/11] configure.ac: Reorder common stuff

2013-12-16 Thread Kristian Høgsberg
On Sun, Dec 08, 2013 at 07:45:42PM +0100, Quentin Glidic wrote: > From: Quentin Glidic The "common stuff" is all wayland scanner related stuff. Maybe we can just add a comment above the scanner checks where they currently are? Kristian > Signed-off-by: Quentin Glidic > --- > configure.ac | 5

Re: [PATCH weston 09/11] configure.ac: Protect AC_PATH_PROG variables

2013-12-16 Thread Kristian Høgsberg
On Sun, Dec 08, 2013 at 07:45:41PM +0100, Quentin Glidic wrote: > From: Quentin Glidic The AC_ARG_VAR additions look useful, but again, I don't like the superfluous quoting. Kristian > Signed-off-by: Quentin Glidic > --- > configure.ac | 6 -- > 1 file changed, 4 insertions(+), 2 deletion

Re: [PATCH weston 07/11] configure.ac: m4-quote AM_CONDITIONAL tests

2013-12-16 Thread Kristian Høgsberg
On Sun, Dec 08, 2013 at 07:45:39PM +0100, Quentin Glidic wrote: > From: Quentin Glidic This currently works as is... why add more quoting? Kristian > Signed-off-by: Quentin Glidic > --- > configure.ac | 48 > 1 file changed, 24 insertions(+), 2

Re: [PATCH weston 05/11] configure.ac: Use consistent quoting

2013-12-16 Thread Kristian Høgsberg
On Sun, Dec 08, 2013 at 07:45:37PM +0100, Quentin Glidic wrote: > From: Quentin Glidic If we need to be consistent, can we not quote at all? Surely xyes doesn't need to be quoted. And what could ever set something like $enable_egl to something with spaces in it? Is there a real reason for this

Re: [PATCH weston 03/11] configure.ac: Correctly check for functions and libraries

2013-12-16 Thread Kristian Høgsberg
On Sun, Dec 08, 2013 at 07:45:35PM +0100, Quentin Glidic wrote: > From: Quentin Glidic > > AC_SEARCH_LIBS is preferred over AC_CHECK_FUNC and AC_CHECK_LIB > > Signed-off-by: Quentin Glidic > --- > configure.ac | 37 + > 1 file changed, 21 insertions(+), 16 d

Re: [PATCH weston] introduces a setting to give permission to any client to do screenshots

2013-12-16 Thread Giulio Camuffo
2013/12/16 Bill Spitzak : > Could an api be added so that one client can "give" access to an object to > another client? This would allow a single secure client to implement all the > rules for what is allowed to be a screen saver, rather than having the rules > be in the compositor. Yeah, it's po

Re: [PATCH weston] introduces a setting to give permission to any client to do screenshots

2013-12-16 Thread Bill Spitzak
Could an api be added so that one client can "give" access to an object to another client? This would allow a single secure client to implement all the rules for what is allowed to be a screen saver, rather than having the rules be in the compositor. What I thought was something like this: -

[PATCH] weston: Send xdg_surface_send_focused_[un]set when focusing surfaces

2013-12-16 Thread Jasper St. Pierre
--- desktop-shell/shell.c | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 9fbac00..52d82f6 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -176,6 +176,8 @@

Re: [PATCH weston] introduces a setting to give permission to any client to do screenshots

2013-12-16 Thread Pekka Paalanen
On Mon, 16 Dec 2013 01:51:20 +0100 Sebastian Wick wrote: > Am 2013-12-16 00:52, schrieb Timothée Ravier: > > polkit could also be used for the whole process of deciding whether > > a screenshot action is allowed or not: > > > > * The compositor would first request authorization for the > > scree