Re: [RFC weston] Add a release_type argument to weston_buffer_reference (the problem)

2013-12-04 Thread Pekka Paalanen
On Wed, 04 Dec 2013 20:24:34 -0800 Bill Spitzak wrote: > However there is no guarantee that repaint will release the old > buffers. It sounds like the Raspberry Pi does this. Also isn't this > true of overlay and fullscreen surfaces on some devices? On RaspberryPi, all surfaces are always on a "

ANNOUNCE: New Wayland Live CD Images

2013-12-04 Thread nerdopolis
Hi. I have released a new release of my Wayland Live CD project, which is named after my favorite celebrity. On this release I have: Wayland Master Weston 1.3 (for Orbital and Hawaii shell compatibility) Wayland enabled Clutter Wayland enabled SDL Wayland enabled GTK Wayland enable

Re: [RFC weston] Add a release_type argument to weston_buffer_reference

2013-12-04 Thread Bill Spitzak
Jason Ekstrand wrote: Third, input is handled after the repaint but before the frame callbacks are sent. Therefore, if the client is receiving any input, the input events will automatically flush out any pending buffer release events there may be. That is useful to know, as it reduces how o

[PATCH] Add a weston_surface_set_size function

2013-12-04 Thread Jason Ekstrand
Surfaces that are created by clients get their size automatically updated by the attach/commit. Surfaces created directly by shells (such as black surfaces) sometimes need to be manually resized. This function allows you to do that while being somewhat less messy than messing with the internals o

Re: [RFC weston] Add a release_type argument to weston_buffer_reference

2013-12-04 Thread Jason Ekstrand
Bill, I think there's something you're missing in here somewhere. First, "sending the release immediately if and only if another event has been (or is being) sent" is an extremely tall order. However, I think you will find that we are already doing this to the greatest extent possible. Allow me

Re: [PATCH Mesa] Enable throttling in SwapBuffers

2013-12-04 Thread Kristian Høgsberg
On Tue, Dec 03, 2013 at 05:04:10PM +0100, Axel Davy wrote: > flush_with_flags, when available, allows the driver to throttle. > Using this suppress input lag issues that can be observed in heavy > rendering situations on non-intel cards. > > Signed-off-by: Axel Davy That makes sense, we need to

RE: [PATCH] shell: Fix activate logic on surface map.

2013-12-04 Thread Eoff, Ullysses A
Tested and works good now... Thanks! U. Artie Eoff > -Original Message- > From: wayland-devel-boun...@lists.freedesktop.org > [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Rafael > Antognolli > Sent: Wednesday, December 04, 2013 11:50 AM > To: wayland-devel@lists.free

RE: [PATCH v2] shell: Add missing break to a case statement inside set_surface_type.

2013-12-04 Thread Eoff, Ullysses A
Tested and works for me :). Thanks! This fixes https://bugs.freedesktop.org/show_bug.cgi?id=72321 U. Artie Eoff > -Original Message- > From: wayland-devel-boun...@lists.freedesktop.org > [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Rafael > Antognolli > Sent: Wedne

[PATCH v2] shell: Add missing break to a case statement inside set_surface_type.

2013-12-04 Thread Rafael Antognolli
This should fix the surface not going back to its original position after unsetting fullscreen or maximized states. --- desktop-shell/shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..1b63430 100644 --- a/desktop-shell/shell.c

[PATCH] shell: Add missing break to a case statement inside set_surface_type.

2013-12-04 Thread Rafael Antognolli
This should fix the surface not going back to its original position after unsetting fullscreen or maximized states. --- desktop-shell/shell.c | 3 +++ src/compositor.c | 1 + 2 files changed, 4 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..d270c27 10

Re: [PATCH] Flush the wl_display at the end of SwapBuffers

2013-12-04 Thread Kristian Høgsberg
On Wed, Dec 04, 2013 at 02:36:05PM +, Neil Roberts wrote: > I think this is a good idea. Imagine a simple game main loop like this: > > while (TRUE) { > do_some_game_logic(); > redraw(); > eglSwapBuffers(); > } > > In that case it wouldn't flush the commit until the righ

Re: [PATCH v4] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-04 Thread Kristian Høgsberg
On Wed, Dec 04, 2013 at 08:31:37AM +0100, Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace

[PATCH] shell: Fix activate logic on surface map.

2013-12-04 Thread Rafael Antognolli
It should activate the newly mapped surface if not locked. --- desktop-shell/shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..05d7814 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -4860,7 +4

Re: [RFC weston] Add a release_type argument to weston_buffer_reference

2013-12-04 Thread Bill Spitzak
I think I am not explaining it correctly. Here is pseudo-code of what a compositor may do. The real implementation is more complex as there is more than one client and more than one surface: attach_request() { // attach message from client ... do the attach ... defer_release = reques

Re: [PATCH weston 1/4] gl: fix fallback definition of EGL_DEFAULT_DISPLAY

2013-12-04 Thread Kristian Høgsberg
On Wed, Dec 04, 2013 at 03:34:45PM +0200, ppaala...@gmail.com wrote: > From: Pekka Paalanen Thanks for the fixes, these 4 patches and the web update committed and pushed. Kristian > Compiling fbdev backend on RaspberryPi caused the following warning: > > compositor-fbdev.c: In function 'fbdev_

[PATCH weston] introduces a setting to give permission to any client to do screenshots

2013-12-04 Thread Sebastian Wick
This patch adds a screenshooter section with the "restrict-access" setting which is on by default and is the current behavior of weston. When turning it off, all clients can use the screenshooter protocol. This makes screen capturing for clients easier because they don't have to be started by westo

Re: [PATCH] Flush the wl_display at the end of SwapBuffers

2013-12-04 Thread Giulio Camuffo
2013/12/4 Neil Roberts : > I think this is a good idea. Imagine a simple game main loop like this: > > while (TRUE) { > do_some_game_logic(); > redraw(); > eglSwapBuffers(); > } > > In that case it wouldn't flush the commit until the right at the > beginning of each call to

Re: [PATCH] Flush the wl_display at the end of SwapBuffers

2013-12-04 Thread Neil Roberts
I think this is a good idea. Imagine a simple game main loop like this: while (TRUE) { do_some_game_logic(); redraw(); eglSwapBuffers(); } In that case it wouldn't flush the commit until the right at the beginning of each call to eglSwapBuffers when it waits for the frame

[PATCH weston v2] compositor: add a masking mechanism to weston_view

2013-12-04 Thread Giulio Camuffo
This adds a 'mask' pixman_region32 to weston_view::geometry and to weston_view::transform. A user, a shell probably, can set a view's geometry.mask to some region in the global space (e.g. the workspace area) and the view, and all its transform children, will be clipped to that region. weston_view:

RE: RFC: surface crop and scale protocol extension

2013-12-04 Thread Tanibata, Nobuhiko (ADITJ/SWG)
> -Original Message- > From: wayland-devel-boun...@lists.freedesktop.org > [mailto:wayland-devel-boun...@lists.freedesktop.org] On > Behalf Of Pekka Paalanen > Sent: Wednesday, December 04, 2013 5:30 PM > To: Ander Conselvan de Oliveira > Cc: Jonny Lamb; wayland-devel@lists.freedesktop.or

[PATCH wayland-web] rpi: update the build guide

2013-12-04 Thread ppaalanen
From: Pekka Paalanen Updates necessary for building and using Weston from upstream master branch. - note that recent raspberrypi.org images come with an old Weston - update the dependency list - update the env setup to match the general guide - libxkbcommon is available as packages, no need to b

[PATCH weston 2/4] rpi: compile in the common udev code

2013-12-04 Thread ppaalanen
From: Pekka Paalanen In a recent commit 37d38d932cea8a642e644d091747d0d9c046a00a, "rpi: Use common udev_input for input device handling", the rpi-backend was made to use the common udev code. It just forgot to actually build the common udev code into the rpi-backend. Cc: Jonas Ådahl Signed-off

[PATCH weston 4/4] rpi: launcher must init before udev-seat

2013-12-04 Thread ppaalanen
From: Pekka Paalanen udev-seat will call weston_launcher_open(), so we better init launcher first. Fixes a segfault. Cc: Jonas Ådahl Signed-off-by: Pekka Paalanen --- src/compositor-rpi.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/compos

[PATCH weston 3/4] rpi: seat quick fix

2013-12-04 Thread ppaalanen
From: Pekka Paalanen Fix the default seat name, so that we can find the input devices by default. This is just a quick fix. Further enhancement would be to make the default seat on rpi taken from a command line option like the other backends do. Furthermore, udev_input_init() should accept NULL

[PATCH weston 1/4] gl: fix fallback definition of EGL_DEFAULT_DISPLAY

2013-12-04 Thread ppaalanen
From: Pekka Paalanen Compiling fbdev backend on RaspberryPi caused the following warning: compositor-fbdev.c: In function 'fbdev_compositor_create': compositor-fbdev.c:929:6: warning: passing argument 2 of 'gl_renderer->create' makes integer from pointer without a cast [enabled by default] compo

Re: [PATCH weston 1/6] rpi: Use common udev_input for input device handling

2013-12-04 Thread Pekka Paalanen
On Mon, 2 Dec 2013 22:05:02 +0100 Jonas Ådahl wrote: > Hi, > > This patch is only compile tested. It should not be applied and > expected to work out of the box. > > However, the reason I created this patch is to remove all udev code > from weston replacing it (and evdev) with libinput. In ord

Re: [PATCH weston] compositor: add a masking mechanism to weston_view

2013-12-04 Thread Giulio Camuffo
2013/12/4 Pekka Paalanen : > On Tue, 3 Dec 2013 14:29:21 +0100 > Giulio Camuffo wrote: > >> This adds a 'mask' pixman_region32 to weston_view and to >> weston_view::geometry. A user, a shell probably, can set a view's >> mask to some region (e.g. the workspace area) and the view, and all >> its t

Re: RFC: surface crop and scale protocol extension

2013-12-04 Thread Pekka Paalanen
On Wed, 04 Dec 2013 10:06:54 +0200 Ander Conselvan de Oliveira wrote: > On 12/04/2013 09:20 AM, Pekka Paalanen wrote: > > On Thu, 28 Nov 2013 12:52:15 +0100 > > Jonny Lamb wrote: > > > >> Il giorno mar, 26/11/2013 alle 18.19 +0100, Jonny Lamb ha scritto: > >>> This is the initial version of the

Re: [RFC weston] make client isolation optional

2013-12-04 Thread Pekka Paalanen
Hi Sebastian On Wed, 4 Dec 2013 01:09:55 +0100 Sebastian Wick wrote: > This patch allows wayland clients to use protocols which give away > information about other clients without being started by the compositor. The > reason to denie access on those protocols is to make sure no information

Re: [RFC weston] Add a release_type argument to weston_buffer_reference

2013-12-04 Thread Pekka Paalanen
On Tue, 03 Dec 2013 23:57:36 -0800 Bill Spitzak wrote: > On 12/03/2013 10:35 PM, Pekka Paalanen wrote: > > On Tue, 03 Dec 2013 11:30:08 -0800 > > Bill Spitzak wrote: > > > >> What about my idea of sending the release immediately if and only if > >> another event has been (or is being) sent since

Re: [PATCH weston 4/8] protocol: crop & scale RFC v3

2013-12-04 Thread Bill Spitzak
On 12/03/2013 11:13 PM, Pekka Paalanen wrote: Ookay, so far it is just me vs. Daniel on the wl_fixed_t issue. Any other opinions for/against changing wl_fixed_t to just int? The source rectangle has to be fractional so that a particular scale can be chosen. Otherwise the scale will change i

Re: RFC: surface crop and scale protocol extension

2013-12-04 Thread Ander Conselvan de Oliveira
On 12/04/2013 09:20 AM, Pekka Paalanen wrote: On Thu, 28 Nov 2013 12:52:15 +0100 Jonny Lamb wrote: Il giorno mar, 26/11/2013 alle 18.19 +0100, Jonny Lamb ha scritto: This is the initial version of the weston implementation of the wl_scaler protocol extension for surface cropping and scaling.