Re: [PATCH] Remove the weston_view.geometry.width/height fields

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 02, 2013 at 09:01:53PM -0600, Jason Ekstrand wrote: > This has a couple of additional implications for the internal weston API: > 1) weston_view_configure no longer exists. Use weston_view_set_position > instead. > 2) The weston_surface.configure callback no longer takes a width

[PATCH 2/3] shell: restore app on default and unplugged output

2013-12-02 Thread Xiong Zhang
if the unplugged output is the first default output, the second output will move to the first working as default output. Mark the surface on unplaugged output as dirty, so on the next output repaint, these views will reassign output and get the right output. when we move output, the views on moved

[PATCH 3/3] shell: restore app when workspace_num > 1 on unplugged output

2013-12-02 Thread Xiong Zhang
when workspace_num > 1, the view on hiden workspace is moved beyond any output through animation, but view->output point to the last output of weston_compositor->output_list in weston_surface_assign_output(). So surface->output may point to a wrong output which isn't the output the surface belonged

[PATCH 1/3] shell: restore app on non default and unplugged output

2013-12-02 Thread Xiong Zhang
if the unplugged output isn't the default output, move cursor and APP widow to default output Signed-off-by: Xiong Zhang --- src/shell.c | 190 ++-- 1 file changed, 186 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c i

[PATCH] Remove the weston_view.geometry.width/height fields

2013-12-02 Thread Jason Ekstrand
This has a couple of additional implications for the internal weston API: 1) weston_view_configure no longer exists. Use weston_view_set_position instead. 2) The weston_surface.configure callback no longer takes a width and height. If you need these, surface.width/height are set before

Re: Protocol documentation

2013-12-02 Thread Peter Hutterer
On Wed, Nov 27, 2013 at 02:16:55PM -0800, Kristian Høgsberg wrote: > > On Tue, Nov 26, 2013 at 02:25:42PM +0100, Jonny Lamb wrote: > > Hi. > > > > I have recently been working on some Wayland protocol stuff and found > > referring to the XML tiresome. Telepathy's D-Bus protocol has a parser > > w

Re: weston never calls drmModeCrtcSetGamma() by default

2013-12-02 Thread Michel Dänzer
On Mon, 2013-12-02 at 10:36 +, Richard Hughes wrote: > On 2 December 2013 03:24, Michel Dänzer wrote: > > No colour management is fine, but a 16bpp gamma ramp (let alone an 8bpp > > palette) just doesn't look very good in 32bpp. :) > > If you can tell me how to adjust the color depth of the c

[RFC] Common layout library for surfaces in a shell

2013-12-02 Thread Tanibata, Nobuhiko (ADITJ/SWG)
Hi Wayland developers, In reply to, http://lists.freedesktop.org/archives/wayland-devel/2013-September/011026.html I realign comments. This is more or less a RFC and any input would be very much appreciated. When I think developing a shell referring Weston for ivi system, I face two difficultie

Re: Fortifying demo apps against running out of disk space

2013-12-02 Thread Kristian Høgsberg
On Fri, Nov 29, 2013 at 7:45 AM, Pekka Paalanen wrote: > Hi, > > I have been looking at RaspberryPi and especially how small the > filesystem for XDG_RUNTIME_DIR is. Well, Raspbian does not provide > XDG_RUNTIME_DIR, so you define that yourself. In any case, it is very > small, I am using /run/shm

Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-02 Thread Kristian Høgsberg
On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace

Re: [PATCH] Make the default desktop shell client configurable

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 02, 2013 at 09:19:46PM +, Bryce W. Harrington wrote: > Looks good to me > > Reviewed-by: Bryce Harrington Indeed, goes well with Neils change. Committed. Kristian > On Mon, Dec 02, 2013 at 12:53:32PM +0100, poch...@gmail.com wrote: > > From: Emilio Pozuelo Monfort > > > > Th

Re: weston never calls drmModeCrtcSetGamma() by default

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 02, 2013 at 10:36:28AM +, Richard Hughes wrote: > On 2 December 2013 03:24, Michel Dänzer wrote: > > No colour management is fine, but a 16bpp gamma ramp (let alone an 8bpp > > palette) just doesn't look very good in 32bpp. :) > > If you can tell me how to adjust the color depth o

Re: [PATCH weston 0/6] Input cleanup

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 02, 2013 at 10:05:01PM +0100, Jonas Ådahl wrote: > Hi, > > Here comes a patch series containing some input cleanup and fixes. > > The most drastic change is removal of udev handling code from > compositor-rpi.c making it use udev-seat.c. That patch is especially > drastic since I have

Re: Improve shell window stacking ordering

2013-12-02 Thread Kristian Høgsberg
On Mon, Nov 25, 2013 at 06:01:29PM +, Philip Withnall wrote: > Here’s a series of patches which work towards improving the shell window > stacking. They clean up the code and implement a more organised approach to > stacking. They add a new test client, weston-stacking, for testing window >

Re: [PATCH] rpi: Support opaque regions

2013-12-02 Thread Bill Spitzak
Bryce W. Harrington wrote: + ret = rpir_surface_set_opaque_rect(surface, update); + if (ret < 0) Other code here is just checking "if (ret)". rpir_surface_set_opaque_rect() only appears to return 0 or -1, so might be more consistent with existing code to do the same. Or do you i

Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-02 Thread Bryce W. Harrington
On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace

Re: [PATCH] rpi: Support opaque regions

2013-12-02 Thread Bryce W. Harrington
On Mon, Dec 02, 2013 at 05:18:58PM +0100, Tomeu Vizoso wrote: > This is needed for XWayland surfaces with alpha channel, as X will be > sending crap in there that should be discarded. > > This is currently done with a copy in the compositor, while we wait for > support in the VideoCore side. > ---

Re: [PATCH] Make the default desktop shell client configurable

2013-12-02 Thread Bryce W. Harrington
Looks good to me Reviewed-by: Bryce Harrington On Mon, Dec 02, 2013 at 12:53:32PM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > The default can be set by passing WESTON_SHELL_CLIENT as an argument > to configure, similarly to WESTON_NATIVE_BACKEND. > --- > configure.ac

Re: [PATCH/RFC] Scanner for tests

2013-12-02 Thread Bryce W. Harrington
On Fri, Nov 29, 2013 at 04:36:56PM +0200, Pekka Paalanen wrote: > On Fri, 29 Nov 2013 14:52:30 +0100 > Marek Ch wrote: > > > > > Hi! > > > > I was looking into wayland's code and I saw static wl_buffer_* > > functions and I thought: These would use a test.. But how to do it > > when they are st

[PATCH weston 6/6] input: Reset keyboard state when releasing last seat keyboard

2013-12-02 Thread Jonas Ådahl
Don't rely on the input driver to properly send button-up events for every pressed key. Signed-off-by: Jonas Ådahl --- src/input.c | 24 1 file changed, 24 insertions(+) diff --git a/src/input.c b/src/input.c index a186a4b..76b2698 100644 --- a/src/input.c +++ b/src/inp

[PATCH weston 4/6] input: Reset pointer state when last pointer device was removed

2013-12-02 Thread Jonas Ådahl
Reset pointer button count in case the driver did not emit appropriate number of number button released events. Signed-off-by: Jonas Ådahl --- src/input.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/input.c b/src/input.c index 34aa720..01eafc2 100644 --- a/src/input.c +++ b/sr

[PATCH weston 5/6] input: Move the xkb fields from weston_seat to weston_keyboard

2013-12-02 Thread Jonas Ådahl
XKB integration is a keyboard feature and should as such be kept track of in the keyboard struct. Signed-off-by: Jonas Ådahl --- src/compositor-wayland.c | 2 +- src/compositor-x11.c | 4 +- src/compositor.h | 14 ++--- src/input.c | 137 +---

[PATCH weston 3/6] input: Reset touch state when last touch device was removed

2013-12-02 Thread Jonas Ådahl
Reset the touch point count in case the driver did not emit appropriate number of touch up events. Signed-off-by: Jonas Ådahl --- src/input.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/input.c b/src/input.c index 1b8dbae..34aa720 100644 --- a/src/input.c +++ b/src/input.c @@

[PATCH weston 1/6] rpi: Use common udev_input for input device handling

2013-12-02 Thread Jonas Ådahl
Hi, This patch is only compile tested. It should not be applied and expected to work out of the box. However, the reason I created this patch is to remove all udev code from weston replacing it (and evdev) with libinput. In order to not have two separate kind of use cases of libinput inside westo

[PATCH weston 0/6] Input cleanup

2013-12-02 Thread Jonas Ådahl
Hi, Here comes a patch series containing some input cleanup and fixes. The most drastic change is removal of udev handling code from compositor-rpi.c making it use udev-seat.c. That patch is especially drastic since I have only compile tested it. More about that in that E-mail. Jonas Jonas Åda

[PATCH weston 2/6] input: Keep track of number of touch points inside touch struct

2013-12-02 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/bindings.c | 2 +- src/compositor.h | 4 ++-- src/input.c | 13 ++--- src/shell.c | 2 +- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/bindings.c b/src/bindings.c index fe21ed6..7d30024 100644 --- a/src/bindings.c +

Re: [PATCH weston 4/8] protocol: crop & scale RFC v3

2013-12-02 Thread Bill Spitzak
Pekka Paalanen wrote: You have read it right. Okay. I really have doubts this is correct but I guess I will go along with it and see. Can I suggest that it be an *error* if buffer_scale is any value other than 1 on a surface that the scaling extension is being used. Under the current desi

Re: [PATCH] rpi: Support opaque regions

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 02, 2013 at 05:18:58PM +0100, Tomeu Vizoso wrote: > This is needed for XWayland surfaces with alpha channel, as X will be > sending crap in there that should be discarded. > > This is currently done with a copy in the compositor, while we wait for > support in the VideoCore side. Look

[PATCH] rpi: Support opaque regions

2013-12-02 Thread Tomeu Vizoso
This is needed for XWayland surfaces with alpha channel, as X will be sending crap in there that should be discarded. This is currently done with a copy in the compositor, while we wait for support in the VideoCore side. --- src/compositor-rpi.c | 3 ++ src/compositor.c | 2 + src/rpi-bcm

[PATCH] Make the default desktop shell client configurable

2013-12-02 Thread pochu27
From: Emilio Pozuelo Monfort The default can be set by passing WESTON_SHELL_CLIENT as an argument to configure, similarly to WESTON_NATIVE_BACKEND. --- configure.ac | 9 + man/Makefile.am| 1 + man/weston.ini.man | 3 ++- src/shell.c| 2 +- 4 files changed, 13 insertion

Re: weston never calls drmModeCrtcSetGamma() by default

2013-12-02 Thread Richard Hughes
On 2 December 2013 03:24, Michel Dänzer wrote: > No colour management is fine, but a 16bpp gamma ramp (let alone an 8bpp > palette) just doesn't look very good in 32bpp. :) If you can tell me how to adjust the color depth of the console I can probably rustle up a patch to just set a linear ramp a