Re: [PATCH] weston: Allow r5g6b5 visuals for X11 backend SHM

2013-11-27 Thread Kristian Høgsberg
On Thu, Nov 28, 2013 at 05:24:21AM +, MoD wrote: > From: MoD > > The support is already present in the pixman renderer, so we can just check > and use it. Looks good, that's easy to add. I tweaked your commit message to wrap at 78 colums and changed the "weston" subject prefix to "composit

[PATCH] weston: Allow r5g6b5 visuals for X11 backend SHM

2013-11-27 Thread MoD
From: MoD The support is already present in the pixman renderer, so we can just check and use it. --- src/compositor-x11.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 1d1b6a4..d98e48d 100644 --- a/src/compositor-x11.c +++ b/src/com

Re: [PATCH] Remove dependency on by replacing GLfloat with float

2013-11-27 Thread Kristian Høgsberg
On Wed, Nov 27, 2013 at 01:22:42PM +0100, Tomeu Vizoso wrote: > --- > src/vertex-clipping.c| 70 > +++- > src/vertex-clipping.h| 30 ++--- > tests/vertex-clip-test.c | 12 - > 3 files changed, 54 insertions(+), 58 deletio

Re: [PATCH] gl-renderer: Fix support for Y_XUXV buffers

2013-11-27 Thread Kristian Høgsberg
On Wed, Nov 27, 2013 at 05:43:51PM +0200, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Due to a copy and paste error, the pointer to the vertex shader source > was NULL and the program failed to link. Yikes, thanks Ander. Patch commmitted. Kristian > src/gl-rend

Re: [PATCH 2/2] exposay: properly go away when the modifier is pressed

2013-11-27 Thread Kristian Høgsberg
On Wed, Nov 27, 2013 at 10:34:33AM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > We no longer receive an exposay_binding() call while exposay > is in-flight as we have grabbed the keyboard, so we need to > listen on the modifiers callback for the modifier press and > release.

Re: Protocol documentation

2013-11-27 Thread Kristian Høgsberg
On Tue, Nov 26, 2013 at 02:25:42PM +0100, Jonny Lamb wrote: > Hi. > > I have recently been working on some Wayland protocol stuff and found > referring to the XML tiresome. Telepathy's D-Bus protocol has a parser > which outputs pretty HTML from the XML[0] so I took said parser and > modified it

Re: [PATCH weston] rpi: avoid vc_dispmanx_set_wl_buffer_in_use without EGL

2013-11-27 Thread Kristian Høgsberg
On Sat, Nov 23, 2013 at 11:30:25AM +0200, Pekka Paalanen wrote: > On Fri, 22 Nov 2013 17:26:58 + > Daniel Stone wrote: > > > Hi, > > > > On 22 November 2013 15:30, wrote: > > > The symbol is needed only for the EGL buffer path. If --disable-egl is > > > given to ./configure, there is no ne

Re: [PATCH weston] Automatically generate weston.ini with the right paths

2013-11-27 Thread Kristian Høgsberg
On Sat, Nov 23, 2013 at 09:22:25AM +, Neil Roberts wrote: > Kristian Høgsberg writes: > > > That's a nice idea. Could we just generate it from configure.ac by > > listing it in AC_CONFIG_FILES? > > Sadly that doesn't work because the autoconf expansions still include > variables for make. E

Re: [PATCH] exposay: provide a cancel func to the ptr grab iface

2013-11-27 Thread Kristian Høgsberg
On Tue, Nov 26, 2013 at 01:32:08PM +0100, poch...@gmail.com wrote: > From: Emilio Pozuelo Monfort > > Fixes a crash when cancel is called while exposay is in progress. Yup, I was hitting that a lot, thanks. Kristian > --- > src/shell.c | 10 ++ > 1 file changed, 10 insertions(+) > >

Re: [PATCH weston 4/8] protocol: crop & scale RFC v3

2013-11-27 Thread Daniel Stone
Hi, On 27 November 2013 20:08, Bill Spitzak wrote: > On 11/27/2013 12:34 AM, Pekka Paalanen wrote: >> I have explained all this before. Nothing here has changed. > > I realize this but I still have to express my complete dumbfoundment that > you think this is ok. You're attempting to design for

Re: [PATCH 00/16] xdg-shell protocol, implementation and port of toytoolkit.

2013-11-27 Thread Thiago Macieira
On quarta-feira, 27 de novembro de 2013 15:50:16, Rafael Antognolli wrote: > As discussed previously, this patch series adds the xdg-shell protocol, its > implementation on weston, and the client implementation on toytoolkit. Nice to see this coming. Thanks, Rafael and Jasper! -- Thiago Macieira

Re: [PATCH weston 4/8] protocol: crop & scale RFC v3

2013-11-27 Thread Bill Spitzak
On 11/27/2013 12:34 AM, Pekka Paalanen wrote: On Tue, 26 Nov 2013 12:47:07 -0800 Bill Spitzak wrote: (swap order of clip+scale and buffer_scale) I have explained all this before. Nothing here has changed. I realize this but I still have to express my complete dumbfoundment that you thin

Re: Move wayland-drm protocol from Mesa to wayland-core

2013-11-27 Thread Jasper St. Pierre
Wasn't EGLStreams supposed to solve the use case of passing hardware buffers around in a standard way? On Wed, Nov 27, 2013 at 1:22 PM, Jason Ekstrand wrote: > > On Nov 27, 2013 10:53 AM, "Benjamin Gaignard" < > benjamin.gaign...@linaro.org> wrote: > > > > Hi all, > > > > I'm working for Linaro

Re: Move wayland-drm protocol from Mesa to wayland-core

2013-11-27 Thread Jason Ekstrand
On Nov 27, 2013 10:53 AM, "Benjamin Gaignard" wrote: > > Hi all, > > I'm working for Linaro on enabling a zero copy path in GStreamer by > using dmabuf. > To make this possible I have patched gst wayland sink to use wayland > drm protocol: https://bugzilla.gnome.org/show_bug.cgi?id=711155 > > Toda

[PATCH 09/16] xdg-shell: xdg_surface_set_output should only affect fullscreen.

2013-11-27 Thread Rafael Antognolli
--- src/shell.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index 7040acc..db8e815 100644 --- a/src/shell.c +++ b/src/shell.c @@ -303,6 +303,7 @@ struct shell_surface { struct weston_output *fullscreen_output; struct westo

[PATCH 16/16] xdg-shell: Add key bindings for setting maximized and fullscreen.

2013-11-27 Thread Rafael Antognolli
--- clients/window.c | 34 ++ src/shell.c | 46 ++ 2 files changed, 80 insertions(+) diff --git a/clients/window.c b/clients/window.c index 5cac1e1..52f6678 100644 --- a/clients/window.c +++ b/clients/window.c @@ -37

[PATCH 08/16] xdg-shell: Add surface size to configure.

2013-11-27 Thread Rafael Antognolli
Also emit configure on unset_maximized and unset_fullscreen. --- src/shell.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/shell.c b/src/shell.c index 0daa136..7040acc 100644 --- a/src/shell.c +++ b/src/shell.c @@ -267,7 +267,9 @@ struct shell_surf

[PATCH 01/16] xdg_shell: Adding a new shell protocol.

2013-11-27 Thread Rafael Antognolli
xdg_shell is a protocol aimed to substitute wl_shell in the long term, but will not be part of the wayland core protocol. It starts as a non-stable API, aimed to be used as a development place at first, and once features are defined as required by several desktop shells, we can finally make it stab

[PATCH 12/16] westoy: Remove fullscreen methods

2013-11-27 Thread Rafael Antognolli
From: "Jasper St. Pierre" These aren't supported under xdg_shell, at least not right now. If xdg_shell ever gets support for them, we can revert this commit and adapt it. --- clients/fullscreen.c | 19 +++ clients/transformed.c | 21 + clients/window.c |

[PATCH 15/16] xdg-shell: Use xdg-shell in simple-shm.

2013-11-27 Thread Rafael Antognolli
--- clients/Makefile.am | 4 +++- clients/simple-shm.c | 50 ++ 2 files changed, 33 insertions(+), 21 deletions(-) diff --git a/clients/Makefile.am b/clients/Makefile.am index 91174bf..10f0d2a 100644 --- a/clients/Makefile.am +++ b/clients/Makefil

[PATCH 07/16] xdg-shell: Implement xdg_popup.

2013-11-27 Thread Rafael Antognolli
--- src/shell.c | 159 ++-- 1 file changed, 155 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index 98fb0fe..0daa136 100644 --- a/src/shell.c +++ b/src/shell.c @@ -247,6 +247,12 @@ struct ping_timer { uint32_t

[PATCH 03/16] shell: Change set_maximized to receive internal structures.

2013-11-27 Thread Rafael Antognolli
Change the parameters of set_maximized from wl_resource and wl_client to shell_surface and weston_output. This will allow it to be used with xdg-shell too. --- src/shell.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/shell.c b/src/shell.c index cf89a

[PATCH 02/16] shell: Remove SHELL_SURFACE_FULLSCREEN and SHELL_SURFACE_MAXIMIZED.

2013-11-27 Thread Rafael Antognolli
These surface types don't exist anymore inside weston desktop shell implementation. They are just exposed as wl_shell surface types, but internally the implementation is done with surface states. The previous behavior (setting a surface type unsets another one) still happens when using wl_shell. T

[PATCH 13/16] westoy: Remove MAXIMIZED and FULLSCREEN as separate window types

2013-11-27 Thread Rafael Antognolli
From: "Jasper St. Pierre" xdg_shell changes this around so that they are flags on the remote object itself, not separate surface types. Move to a system where we calculate the state from the flags ourselves and set the appropriate wl_shell_surface type. When we port to xdg_shell, we'll drop thes

[PATCH 04/16] xdg-shell: Implement part of the interface.

2013-11-27 Thread Rafael Antognolli
Basic requests are implemented, enough to get a surface displayed. --- src/.gitignore | 2 + src/Makefile.am | 6 +- src/shell.c | 228 +--- 3 files changed, 223 insertions(+), 13 deletions(-) diff --git a/src/.gitignore b/src/.gitignor

[PATCH 10/16] westoy: Schedule a full resize when we add a subsurface

2013-11-27 Thread Rafael Antognolli
From: "Jasper St. Pierre" If a client adds a subsurface, we need to make sure it's allocated properly, so queue a resize and redraw on the parent window. --- clients/window.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clients/window.c b/clients/window.c index a201ebb..5734db6 100644

[PATCH 05/16] xdg-shell: Implementing maximized and fullscreen states.

2013-11-27 Thread Rafael Antognolli
--- src/shell.c | 87 + 1 file changed, 82 insertions(+), 5 deletions(-) diff --git a/src/shell.c b/src/shell.c index f775899..6cbb4bd 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2999,6 +2999,83 @@ xdg_surface_resize(struct wl_client

[PATCH 14/16] westoy: Port the toy toolkit over to xdg-shell

2013-11-27 Thread Rafael Antognolli
From: "Jasper St. Pierre" --- clients/.gitignore | 2 + clients/Makefile.am | 8 +- clients/window.c| 281 ++-- src/shell.c | 8 +- 4 files changed, 156 insertions(+), 143 deletions(-) diff --git a/clients/.gitignore b/clients/.

[PATCH 11/16] westoy: Use subsurfaces for tooltips instead of transient windows

2013-11-27 Thread Rafael Antognolli
From: "Jasper St. Pierre" Transient windows, at least not as they are today, don't exist in xdg_shell. Subsurfaces allow for specially placed surfaces relative to a window, so use these instead. --- clients/window.c | 46 -- 1 file changed, 8 insertion

[PATCH 06/16] xdg-shell: Implement set_transient_for request.

2013-11-27 Thread Rafael Antognolli
The implementation just sets a parent/child relationship between the xdg_surface and its parent, passed as argument of this request. Stacking might be affected (that's up to the compositor). This implementation does not affect the code that handles the previous transient surface type. It should st

[PATCH 00/16] xdg-shell protocol, implementation and port of toytoolkit.

2013-11-27 Thread Rafael Antognolli
As discussed previously, this patch series adds the xdg-shell protocol, its implementation on weston, and the client implementation on toytoolkit. Jasper St. Pierre (5): westoy: Schedule a full resize when we add a subsurface westoy: Use subsurfaces for tooltips instead of transient windows

Move wayland-drm protocol from Mesa to wayland-core

2013-11-27 Thread Benjamin Gaignard
Hi all, I'm working for Linaro on enabling a zero copy path in GStreamer by using dmabuf. To make this possible I have patched gst wayland sink to use wayland drm protocol: https://bugzilla.gnome.org/show_bug.cgi?id=711155 Today wayland drm protocol is limited to Mesa so I have decided to move it

Re: Protocol documentation

2013-11-27 Thread Jonny Lamb
Il giorno mar, 26/11/2013 alle 11.38 -0800, Bill Spitzak ha scritto: > Could the fact that the "reference" has "(new_id)" in it be used to > further put these into a different section called "constructors"? Good idea, done. > Could objects without constructors (like wl_shm or wl_seat) could also

[PATCH] gl-renderer: Fix support for Y_XUXV buffers

2013-11-27 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Due to a copy and paste error, the pointer to the vertex shader source was NULL and the program failed to link. --- src/gl-renderer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 7a535c7..4942

Re: Protocol documentation

2013-11-27 Thread Jonny Lamb
Il giorno mar, 26/11/2013 alle 12.26 -0600, Jason Ekstrand ha scritto: > Thanks! I think that's far easier to read than the stuff publican > dumps. The only problem is that your doc generator doesn't handle > paragraph breaks properly. For instance, the wl_surface.attach > request documentation

[PATCH] Remove dependency on by replacing GLfloat with float

2013-11-27 Thread Tomeu Vizoso
--- src/vertex-clipping.c| 70 +++- src/vertex-clipping.h| 30 ++--- tests/vertex-clip-test.c | 12 - 3 files changed, 54 insertions(+), 58 deletions(-) This was bothering me, so I just went ahead with Jasper's suggestion

Re: [PATCH weston] rpi: avoid vc_dispmanx_set_wl_buffer_in_use without EGL

2013-11-27 Thread Tomeu Vizoso
On 23 November 2013 10:30, Pekka Paalanen wrote: > On Fri, 22 Nov 2013 17:26:58 + > Daniel Stone wrote: > >> Hi, >> >> On 22 November 2013 15:30, wrote: >> > The symbol is needed only for the EGL buffer path. If --disable-egl is >> > given to ./configure, there is no need for it, so fix it

Re: RFC: surface crop and scale protocol extension

2013-11-27 Thread Pekka Paalanen
On Tue, 26 Nov 2013 18:19:40 +0100 Jonny Lamb wrote: > Hello. > > This is the initial version of the weston implementation of the > wl_scaler protocol extension for surface cropping and scaling. It is > based on the extension RFC version 3, written by Pekka Paalanen. > Earlier versions are: > >

[PATCH 2/2] exposay: properly go away when the modifier is pressed

2013-11-27 Thread pochu27
From: Emilio Pozuelo Monfort We no longer receive an exposay_binding() call while exposay is in-flight as we have grabbed the keyboard, so we need to listen on the modifiers callback for the modifier press and release. --- Sorry, I tweaked the braces before sending and missed one. Fixed and veri

Prevent multiple keybindings from running simultaneously

2013-11-27 Thread pochu27
From: Emilio Pozuelo Monfort The first patch here prevents modifier keybindings from running while the keyboard is grabbed. This can be seen by going to alt-tab and then pressing mod before releasing alt. That will call the exposay binding handler which will then start exposay and take the keyboa

[PATCH 2/2] exposay: properly go away when the modifier is pressed

2013-11-27 Thread pochu27
From: Emilio Pozuelo Monfort We no longer receive an exposay_binding() call while exposay is in-flight as we have grabbed the keyboard, so we need to listen on the modifiers callback for the modifier press and release. --- src/shell.c | 31 +++ 1 file changed, 27 inse

[PATCH 1/2] input: don't run modifier bindings when the kbd is grabbed

2013-11-27 Thread pochu27
From: Emilio Pozuelo Monfort We don't want bindings to be run while the keyboard is grabbed. Otherwise the binding handler may grab the keyboard too, making the old grab go away without even being cancelled. --- src/bindings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/bindings.c

Re: [PATCH weston 4/8] protocol: crop & scale RFC v3

2013-11-27 Thread Pekka Paalanen
On Tue, 26 Nov 2013 12:47:07 -0800 Bill Spitzak wrote: > Jonny Lamb wrote: > > > Changes in v3: > > > > Disallow zero values for dst_width and dst_height. > > This all looks a lot better. > > > + The coordinate transformations from buffer pixel coordinates up to > > + the surface-lo