Re: [PATCH 09/17] shell: Factor out code to set a shsurf’s parent

On 11/25/2013 10:01 AM, Philip Withnall wrote: From: Philip Withnall This is in preparation for unifying how surface layering works. It introduces the small functional change that fullscreen, maximized and top-level surfaces now explicitly have no parent surface. Only popup and transient surfac

Re: [PATCH 4/4] terminal: add touch screen selection support

On Mon, Nov 25, 2013 at 06:42:52PM +0800, Xiong Zhang wrote: > From: XiongZhang > > Signed-off-by: Xiong Zhang > Reviewed-by: Kristian Hogsberg Nice work, all committed. Kristian > --- > clients/terminal.c | 85 > ++ > 1 file changed, 67

Re: [PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

Hi Arnaud, On Fri, 2013-11-22 at 15:48 +0100, Arnaud Vrac wrote: > Wouldn't it be better to do this in compositor.c and call > renderer->attach(surface, NULL) when the buffer attached to a surface > is destroyed ? I don't think that's possible. A buffer does not keep track of the surface it's att

Re: [PATCH] src/Makefile.am: correct compile failure for launcher-util.c

On Mon, Nov 25, 2013 at 03:22:50PM +0800, Xiong Zhang wrote: > The following error message is generated during compile > In file included from launcher-util.c:43:0: > compositor.h:35:28: fatal error: wayland-server.h: No such file or directory > #include > > Signed-off-by: Xiong Zhang Thanks,

[PATCH 13/17] shell: Remove weston_view_restack()

From: Philip Withnall It’s tied too deeply into the shell’s window stacking and ordering code to legitimately be split out into compositor.c. Inline it in the shell, and refactor some code around it a little, tidying up the stacking behaviour for fullscreen surfaces. --- src/compositor.c | 9 --

[PATCH] Makefile.am: The rpi backend needs libsession-helper.la

Signed-off-by: Marco Barisione --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index 92afae8..f1c94f6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -216,6 +216,7 @@ rpi_backend_la_LDFLAGS = -module -avoid-version rpi_backend_la_LI

[PATCH 16/17] shell: Fix a potential NULL pointer dereference

From: Philip Withnall get_shell_surface() may return NULL. Found by scan-build. --- src/shell.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shell.c b/src/shell.c index 79ea463..1af687a 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1370,7 +1370,8 @@ take_surface_to_

[PATCH 10/17] shell: Don’t change popups’ window types until the next configure event

From: Philip Withnall This standardises their behaviour with that of the other window types, where the type change is only committed on configure. --- src/shell.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shell.c b/src/shell.c index 3ff395d..c503d4b 100644 --- a/s

[PATCH 11/17] shell: Factor out code to set the layer for a shsurf

From: Philip Withnall This will be used more extensively in the next few commits, where shsurf layering is handled more explicitly when changing the type of a surface. This commit introduces the minor functional change that map() will now always add the new surface to a layer list, as shell_surf

[PATCH 01/17] shell: Reorganise set/unset methods for fullscreen/maximize/popup/transient

From: Philip Withnall Move them to be next to each other, and standardise the naming scheme so they’re more greppable. This should make maintenance easier. --- src/shell.c | 348 +--- 1 file changed, 190 insertions(+), 158 deletions(-) dif

[PATCH 15/17] shell: Store parent–child links between shsurfs for window stacking

From: Philip Withnall This ensures transient surfaces are included in the layer of their parent, even if the parent later changes layers. It achieves this by recursively changing the layers of all children of a surface when that surface’s layer is changed. The recursion is unbounded unless transi

[PATCH 09/17] shell: Factor out code to set a shsurf’s parent

From: Philip Withnall This is in preparation for unifying how surface layering works. It introduces the small functional change that fullscreen, maximized and top-level surfaces now explicitly have no parent surface. Only popup and transient surfaces have a non-NULL parent. --- src/shell.c | 29

[PATCH 17/17] shell: Change stacking order calculation for popup surfaces

From: Philip Withnall Always put them as the top-most layer in the layer list of their parent. This ensures that, for example, the popup menu produced by right-clicking on a surface (which is not currently at the top of the stacking order in the current workspace) is displayed at the top of the s

[PATCH 06/17] shell: Factor out common code to set a shsurf’s output

From: Philip Withnall --- src/shell.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/shell.c b/src/shell.c index 17a64ae..15895e2 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2031,6 +2031,22 @@ get_output_panel_height(struct deskto

[PATCH 08/17] shell: Tidy up unset_fullscreen()

From: Philip Withnall No functional changes, merely some presentational cleanup. --- src/shell.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/shell.c b/src/shell.c index 209ed30..9d6a7c2 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2115,19 +2115,24 @@ static

[PATCH 04/17] clients: Add window_is_transient() helper to the toy toolkit window

From: Philip Withnall --- clients/window.c | 6 ++ clients/window.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/clients/window.c b/clients/window.c index d9f061d..6d82f17 100644 --- a/clients/window.c +++ b/clients/window.c @@ -3935,6 +3935,12 @@ window_is_fullscreen(struct windo

[PATCH 07/17] shell: Refactor workspace code to operate on shsurfs rather than views

From: Philip Withnall This is needed for the work to refactor window stacking and ordering, as window order operates on shsurfs, not views. --- src/shell.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/src/shell.c b/src/shell.c index 15895e2..2

[PATCH 02/17] shell: Add missing cases to switch statements for surface types

From: Philip Withnall This fixes a load of GCC warnings when compiling with -Wswitch-enum -Wswitch-default, and makes it clearer that those cases have been thought about explicitly when writing the code, rather than just being forgotten. --- src/shell.c | 24 +++- 1 file chan

[PATCH 05/17] clients: Add a new weston-stacking demo

From: Philip Withnall This allows creation of a variety of window types, for the purposes of testing window ordering and stacking in Weston. --- clients/Makefile.am | 4 + clients/stacking.c | 301 2 files changed, 305 insertions(+) create

[PATCH 14/17] shell: Factor out common code to create fullscreen black surfaces

From: Philip Withnall --- src/shell.c | 66 ++--- 1 file changed, 24 insertions(+), 42 deletions(-) diff --git a/src/shell.c b/src/shell.c index 96bfea0..a505bf5 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2446,6 +2446,29 @@ create_blac

[PATCH 03/17] shell: Add missing cases to switch statements for animations and fading

From: Philip Withnall This fixes two GCC warnings when compiling with -Wswitch-enum -Wswitch-default, and makes it clearer that those cases have been thought about explicitly when writing the code, rather than just being forgotten. --- src/shell.c | 3 +++ 1 file changed, 3 insertions(+) diff -

[PATCH 12/17] shell: Update a shsurf’s layer when its surface type changes

From: Philip Withnall --- src/shell.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/src/shell.c b/src/shell.c index 084d02c..25e00d9 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2080,6 +2080,25 @@ shell_surface_calculate_l

Improve shell window stacking ordering

Here’s a series of patches which work towards improving the shell window stacking. They clean up the code and implement a more organised approach to stacking. They add a new test client, weston-stacking, for testing window stacking and ordering. I don’t claim the ordering they impose is perfect

[PATCH] Fix the build for the rpi backend

Hi, Commit 989e9d5 (“Makefile.am: Move launcher helpers in to libsession-helper.la library”) broke the build for the rpi backend by removing launcher-util.[ch] from the sources, but not adding libsession-helper.la to LIBADD. Marco Barisione (1): Makefile.am: The rpi backend needs libsession-hel

[PATCH 2/4] client/dnd.c: add dnd support for touch screen in client

From: XiongZhang Adding the interface for touch screen event in clients/dnd.c, once user touch down on this app, it will trigger a touch and drag operation. Signed-off-by: Xiong Zhang Reviewed-by: Kristian Hogsberg --- clients/dnd.c| 56 +++-

[PATCH 4/4] terminal: add touch screen selection support

From: XiongZhang Signed-off-by: Xiong Zhang Reviewed-by: Kristian Hogsberg --- clients/terminal.c | 85 ++ 1 file changed, 67 insertions(+), 18 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index e7dcd91..94dcb4b 100644 -

[PATCH 1/4] src/data_device.c: add dnd support for touch screen

From: XiongZhang Adding the drag and drop grab interface for touch screen in src/data-device.c, so the server can handle touch screen drag and drop operation. Signed-off-by: Xiong Zhang Reviewed-by: Kristian Hogsberg --- src/compositor.h | 7 +- src/data-device.c | 347 ++

[PATCH 3/4] distinguish touch screen and pointer dnd in client

From: XiongZhang Data device interface in client just handle with pointer's dnd. If a touch screen trigger dnd, it will use pointer struct like i nput->sx, input->sy, input->pointer_focus. So if pointer is moving when touch screen trigeer a dnd, wrong behaviore will occur. Before touch screen sta