Re: [PATCH] tests: only build vertex-clip if egl support is enabled

2013-11-19 Thread Jasper St. Pierre
Is there any reason we can't make vertex-clipping.c take floats everywhere, and adapt our code to take floats as well? I don't think GLfloat will ever be a typedef for anything but float... On Tue, Nov 19, 2013 at 4:52 PM, Emilio Pozuelo Monfort wrote: > On 19/11/13 22:21, Kristian Høgsberg wrot

Re: [PATCH 0/9] exposay & alt-tab

2013-11-19 Thread Emilio Pozuelo Monfort
On 19/11/13 22:37, Kristian Høgsberg wrote: > On Tue, Nov 19, 2013 at 11:37:10AM +0100, Emilio Pozuelo Monfort wrote: >> Rebased on master and fixed a couple of conflicts with Giulio's recent >> input changes. Fixed the typo spotted by Bryce. > > I'm pushing these now so we can keep them up to dat

Re: [PATCH] tests: only build vertex-clip if egl support is enabled

2013-11-19 Thread Emilio Pozuelo Monfort
On 19/11/13 22:21, Kristian Høgsberg wrote: > On Tue, Nov 19, 2013 at 06:09:00PM +0100, Emilio Pozuelo Monfort wrote: >> And pass the right flags to build it. > > This test case only uses GLfloat, we should be able to figure out a > way to compile the test with typedef float GLfloat instead. We c

Re: [PATCH 0/9] exposay & alt-tab

2013-11-19 Thread Kristian Høgsberg
On Tue, Nov 19, 2013 at 11:37:10AM +0100, Emilio Pozuelo Monfort wrote: > Rebased on master and fixed a couple of conflicts with Giulio's recent > input changes. Fixed the typo spotted by Bryce. I'm pushing these now so we can keep them up to date in the tree, but there are still issues to work ou

Re: [PATCH 2/2] wayland-server: Improve error messages for bad globals

2013-11-19 Thread Kristian Høgsberg
On Tue, Nov 12, 2013 at 09:44:37PM -0500, Jasper St. Pierre wrote: > A bug in Weston's toytoolkit gave me an hour of debugging headaches. > Improve the error messages that we send if a client requests an invalid > global, either by name or by version. That's a good improvement, applied. Kristian

Re: [PATCH 1/2] Update .gitignore for protocol/

2013-11-19 Thread Kristian Høgsberg
On Tue, Nov 12, 2013 at 09:44:36PM -0500, Jasper St. Pierre wrote: > --- > protocol/.gitignore | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. Kristian > diff --git a/protocol/.gitignore b/protocol/.gitignore > index a67e944..78f49d2 100644 > --- a/protocol/.gitignore > +++ b/protocol/

Re: [PATCH] compositor-drm: Release the correct buffer in drm_output_release_fb

2013-11-19 Thread Kristian Høgsberg
On Thu, Nov 14, 2013 at 08:52:35PM -0600, Jason Ekstrand wrote: > --- > My knowledge of the DRM backend is rather small, so I don't know if this is > really the right fix. I hit this when the the mode fails to set. See also > compositor-drm.c:606 Right, that's better. Kristian > src/composito

Re: [PATCH] tests: only build vertex-clip if egl support is enabled

2013-11-19 Thread Kristian Høgsberg
On Tue, Nov 19, 2013 at 06:09:00PM +0100, Emilio Pozuelo Monfort wrote: > And pass the right flags to build it. This test case only uses GLfloat, we should be able to figure out a way to compile the test with typedef float GLfloat instead. Kristian > --- > tests/Makefile.am | 9 - > 1 f

Re: [PATCH weston] compositor: fix sub-surface view stacking order

2013-11-19 Thread Kristian Høgsberg
On Tue, Nov 19, 2013 at 02:03:35PM +0200, ppaala...@gmail.com wrote: > From: Pekka Paalanen > > If you opened a window with sub-surfaces, and then raised another window > on top of that, the underlaying window's main surface was stacked > properly, but the sub-surfaces remained on top of the rais

Re: [chromium-dev] Re: PSA: Chromium Wayland preview

2013-11-19 Thread Tiago Vignatti
I'm glad you could set up the environment in your machine :) Regarding the one-line change you mentioned, we indeed are having a few issues with the EGL headers and specifically the EGLNativeDisplayType type definition. In particular, Chromium is getting the EGL definitions from the wrong direc

Re: [PATCH] client: Introduce functions to allocate and marshal proxies atomically

2013-11-19 Thread Kristian Høgsberg
On Tue, Nov 19, 2013 at 07:38:52AM +0200, Kalle Vahlman wrote: > 2013/11/19 Bryce W. Harrington : > > On Fri, Nov 15, 2013 at 08:51:50PM -0800, Kristian Høgsberg wrote: > >> The server requires clients to only allocate one ID ahead of the previously > >> highest ID in order to keep the ID range tig

Re: [PATCH v2] Wayland backend: set the opaque region when starting fullscreen

2013-11-19 Thread Kristian Høgsberg
On Sun, Nov 17, 2013 at 09:34:16PM +0100, Axel Davy wrote: > The opaque region is not set when we start the nested > compositor fullscreen. This patch fixes this. > > Signed-off-by: Axel Davy > --- > Jason Ekstrand prefer we use wayland_output_set_fullscreen, > which will -besides other things- s

[PATCH] shell: monitor child client disconnects

2013-11-19 Thread Arnaud Vrac
From: Arnaud Vrac A crash could happen when killing weston, since the wayland client of the shell child process could be destroyed twice: once when the wayland client disconnects (before sigchld is caught), and then again when destroying the shell. --- src/shell.c| 21 +++

[PATCH] tests: only build vertex-clip if egl support is enabled

2013-11-19 Thread Emilio Pozuelo Monfort
And pass the right flags to build it. --- tests/Makefile.am | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 8e08375..e123c18 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -2,7 +2,7 @@ TESTS = $(shared_tests) $(modu

[PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-19 Thread Lubomir Rintel
While the pixman image might be attached, the underlying buffer might be already gone under certain circumstances. This is easily reproduced by attempting to resize gnome-terminal on a fbdev backend. $ WAYLAND_DEBUG=1 strace -emunmap weston --backend=fbdev-backend.so ... [1524826.942] wl_shm@7.cre

Re: [PATCH 2/3] compositor-drm: Add option to disable early buffer release

2013-11-19 Thread Pekka Paalanen
On Tue, 19 Nov 2013 14:51:42 +0200 Ander Conselvan de Oliveira wrote: > On 11/19/2013 01:05 PM, Pekka Paalanen wrote: > > On Tue, 19 Nov 2013 11:30:11 +0200 > > Ander Conselvan de Oliveira wrote: > > > >> From: Ander Conselvan de Oliveira > >> > >> This together with a follow up patch should ma

Re: [PATCH v2 wayland] pkg-config: scanner isn't arch-independent

2013-11-19 Thread Emilio Pozuelo Monfort
On 19/11/13 14:15, Arnaud Vrac wrote: > I'm wondering how you are supposed to use the .pc file when cross-compiling > weston for example. Typically you would have the following directory layout: > > wayland build for host: > > host/usr/bin/wayland-scanner > host/usr/lib/pkgconfig/wayland-scanner.

Re: Thoughts about decoration information in the xdg_shell

2013-11-19 Thread Jasper St. Pierre
If you (or anyone else) wants to write the code and spec for Qt/GTK+/EFL/westoy, go for it. I, personally, am not going to do any engineering effort to implement such a cross-toolkit theme definition. On Tue, Nov 19, 2013 at 5:09 AM, Jesse K wrote: > Hi, > > What about having a theme definitio

[PATCH 1/2] compositor-drm: Add key binding to switch from pixman to GL renderer

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When running with the pixman renderer, the debug binding 'W' (mod-shift-space W) will cause the compositor to load gl-renderer.so and start using it instead of the pixman renderer. --- src/compositor-drm.c | 83 +

[PATCH 2/2] gl-renderer: Attach buffer during surface state creation if possible

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When a renderer switch happens, it is possible that when the surface state is created, a buffer for the given surface is already available. In that case, run the attach routine so that the pixel contents are properly set. Otherwise, it would only be set when a ne

[PATCH 0/2 v2] Renderer switch

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira V2 of the series I sent earlier today, changed to not require an extra option to allow for seamless switch. Thanks, Ander Ander Conselvan de Oliveira (2): compositor-drm: Add key binding to switch from pixman to GL renderer gl-renderer: Attach buffer during

Re: [PATCH v2 wayland] pkg-config: scanner isn't arch-independent

2013-11-19 Thread Arnaud Vrac
I'm wondering how you are supposed to use the .pc file when cross-compiling weston for example. Typically you would have the following directory layout: wayland build for host: host/usr/bin/wayland-scanner host/usr/lib/pkgconfig/wayland-scanner.pc host/usr/share/aclocal/wayland-scanner.m4 host/us

Re: [PATCH v2 wayland] pkg-config: scanner isn't arch-independent

2013-11-19 Thread Emilio Pozuelo Monfort
Ping? wayland-scanner hasn't been dropped and the .pc location is still bogus. On 20/08/13 00:58, Kristian Høgsberg wrote: > On Fri, Aug 16, 2013 at 03:55:52PM +0100, Daniel Stone wrote: >> Hi, >> >> On 16 August 2013 15:50, David Herrmann wrote: >>> On Fri, Aug 16, 2013 at 2:26 PM, Daniel Stone

Re: [PATCH 2/3] compositor-drm: Add option to disable early buffer release

2013-11-19 Thread Ander Conselvan de Oliveira
On 11/19/2013 01:05 PM, Pekka Paalanen wrote: On Tue, 19 Nov 2013 11:30:11 +0200 Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira This together with a follow up patch should make it possible to do a runtime renderer switch without causing artifact on the screen. --- man

Re: [PATCH weston v2] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-19 Thread Pekka Paalanen
On Tue, 19 Nov 2013 12:57:10 +0100 Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace -emu

[PATCH weston] compositor: fix sub-surface view stacking order

2013-11-19 Thread ppaalanen
From: Pekka Paalanen If you opened a window with sub-surfaces, and then raised another window on top of that, the underlaying window's main surface was stacked properly, but the sub-surfaces remained on top of the raised window. IOW, the raised window was in between the other window and its sub-s

[PATCH weston v2] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-19 Thread Lubomir Rintel
While the pixman image might be attached, the underlying buffer might be already gone under certain circumstances. This is easily reproduced by attempting to resize gnome-terminal on a fbdev backend. $ WAYLAND_DEBUG=1 strace -emunmap weston --backend=fbdev-backend.so ... [1524826.942] wl_shm@7.cre

[PATCH] exposay: move the pointer in our motion handler

2013-11-19 Thread Emilio Pozuelo Monfort
This is necessary since commit 1959ab. --- src/shell.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/shell.c b/src/shell.c index bf5c704..82c3cd8 100644 --- a/src/shell.c +++ b/src/shell.c @@ -5232,11 +5232,14 @@ exposay_layout(struct desktop_shell *shell) } stati

Re: [PATCH 2/3] compositor-drm: Add option to disable early buffer release

2013-11-19 Thread Pekka Paalanen
On Tue, 19 Nov 2013 11:30:11 +0200 Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > This together with a follow up patch should make it possible to do a > runtime renderer switch without causing artifact on the screen. > --- > man/weston-drm.man |6 ++ > src

[PATCH 3/9] Add move/scale animation

2013-11-19 Thread Emilio Pozuelo Monfort
From: Daniel Stone Add an animation which moves a surface to a new location, at the same time as also rescaling it to a different size from the origin, rather than the existing scale animation which resizes from the centre. [pochu: rebased, ported to weston_view] --- src/animation.c | 62 +

[PATCH 4/9] Add Exposay

2013-11-19 Thread Emilio Pozuelo Monfort
From: Daniel Stone Exposay provides window overview functions which, when a key which produces the binding modifier is pressed on its own, scales all currently-open windows down to be shown overlaid on the desktop, providing keyboard and mouse navigation to be able to switch window focus. [pochu

[PATCH 6/9] shell: Implement alt-tab switcher

2013-11-19 Thread Emilio Pozuelo Monfort
Signed-off-by: Emilio Pozuelo Monfort --- src/shell.c | 248 1 file changed, 248 insertions(+) diff --git a/src/shell.c b/src/shell.c index b2bc74a..2a8c04c 100644 --- a/src/shell.c +++ b/src/shell.c @@ -3344,6 +3344,251 @@ terminate_b

[PATCH 1/9] animation, shell: add kbd focus change animation

2013-11-19 Thread Emilio Pozuelo Monfort
From: Louis-Francis Ratté-Boulianne When enabled, this will make all but the keyboard-focused window dim. Also the background gets dimmed, if there are any windows open. The panel is not dimmed. When the keyboard focus changes, the change in dimming is animated. The dimming is implemented with

[PATCH 2/9] Add modifier-only binding

2013-11-19 Thread Emilio Pozuelo Monfort
From: Daniel Stone Add the ability to bind to modifiers; the binding is armed when a key which sets the requested modifier is pressed, and triggered if the key is released with no other keys having been pressed in the meantime, as well as mouse buttons or scroll axes. This only works for direct

[PATCH 9/9] shell: Set output on the focus_surfaces' view

2013-11-19 Thread Emilio Pozuelo Monfort
Otherwise we crash when animating the view. Signed-off-by: Emilio Pozuelo Monfort --- src/shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shell.c b/src/shell.c index 09ff86c..bf5c704 100644 --- a/src/shell.c +++ b/src/shell.c @@ -615,6 +615,7 @@ create_focus_surface(struct weston

[PATCH 8/9] exposay: Activate a surface when hovering it

2013-11-19 Thread Emilio Pozuelo Monfort
This causes the surface to get the keyboard focus, which in turn causes focus-animation to nicely work with exposay, making the not focused surfaces to be dimmed. Signed-off-by: Emilio Pozuelo Monfort --- src/shell.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/shell

[PATCH 5/9] input: Don't send leave events to destroyed views

2013-11-19 Thread Emilio Pozuelo Monfort
If a view which has focus is destroyed, we would send a leave event while changing focus, causing a segfault. Prevent this by listening to the view's destroy signal and removing it from the pointer focus. Signed-off-by: Emilio Pozuelo Monfort --- src/compositor.h | 1 + src/input.c | 27 ++

[PATCH 7/9] exposay: add cancel impl to the kbd grab iface

2013-11-19 Thread Emilio Pozuelo Monfort
Otherwise we'll crash when cancel is called. Signed-off-by: Emilio Pozuelo Monfort --- src/shell.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/shell.c b/src/shell.c index 2a8c04c..dae31a0 100644 --- a/src/shell.c +++ b/src/shell.c @@ -5351,9 +5351,19 @@ exposay_modifier(s

[PATCH 0/9] exposay & alt-tab

2013-11-19 Thread Emilio Pozuelo Monfort
Rebased on master and fixed a couple of conflicts with Giulio's recent input changes. Fixed the typo spotted by Bryce. Daniel Stone (3): Add modifier-only binding Add move/scale animation Add Exposay Emilio Pozuelo Monfort (5): input: Don't send leave events to destroyed views shell: Im

Re: Thoughts about decoration information in the xdg_shell

2013-11-19 Thread Jesse K
Hi, What about having a theme definition service for graphical environment? This theme definition would contains "hints" about windows decorations, colors, fonts, textures, and much more. The hints could only be recommendations - not requirements. The toolkits, shells, CSD, SSD should ideally use

[PATCH 3/3] gl-renderer: Attach buffer during surface state creation if possible

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When a renderer switch happens, it is possible that when the surface state is created, a buffer for the given surface is already available. In that case, run the attach routine so that the pixel contents are properly set. Otherwise, it would only be set when a ne

[PATCH 2/3] compositor-drm: Add option to disable early buffer release

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira This together with a follow up patch should make it possible to do a runtime renderer switch without causing artifact on the screen. --- man/weston-drm.man |6 ++ src/compositor-drm.c | 27 +-- src/compositor.c |1 + 3

[PATCH 1/3] compositor-drm: Add key binding to switch from pixman to GL renderer

2013-11-19 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira When running with the pixman renderer, the debug binding 'W' (mod-shift-space W) will cause the compositor to load gl-renderer.so and start using it instead of the pixman renderer. --- src/compositor-drm.c | 83 +

Re: [PATCH 1/9] animation, shell: add kbd focus change animation

2013-11-19 Thread Emilio Pozuelo Monfort
On 19/11/13 04:27, Bryce W. Harrington wrote: > On Fri, Nov 15, 2013 at 05:53:30PM +0100, Emilio Pozuelo Monfort wrote: >> From: Louis-Francis Ratté-Boulianne >> >> When enabled, this will make all but the keyboard-focused window dim. >> Also the background gets dimmed, if there are any windows op

Re: [PATCH] pixman: Check whether the buffer still exists when the surface is redrawn

2013-11-19 Thread Pekka Paalanen
Hi Lubomir, On Mon, 18 Nov 2013 23:42:40 +0100 Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. Should there be a de