Re: [PATCH v2 2/6] shell: register output->destroy_signal handler

2013-10-23 Thread Kristian Høgsberg
On Wed, Oct 23, 2013 at 01:58:32PM +0800, Xiong Zhang wrote: > setup_output_destroy_handler() deal with output created at > drm backend initialize time. > handle_output_create() deal with output created by hot plug handler > output_destroy_handler is removed when output was unplugged or > shell is

Re: [PATCH v2 5/6] window, desktop-shell: deal with output unplug on client side

2013-10-23 Thread Kristian Høgsberg
On Wed, Oct 23, 2013 at 01:58:35PM +0800, Xiong Zhang wrote: > when output is removed, weston-desktop-shell should destroy panel > and background surface on destroyed output. > > Signed-off-by: Xiong Zhang > --- > clients/desktop-shell.c | 20 > clients/window.c| 32

Re: [PATCH v2 1/6] compositor: set surface->plane from destroyed plane to NULL

2013-10-23 Thread Kristian Høgsberg
On Wed, Oct 23, 2013 at 01:58:31PM +0800, Xiong Zhang wrote: > In drm backend, the cursor_surface->plane point to > drm_output->cursor_plane.when this output is removed, > drm_output->cursor_plane is destroyed, butcursor_surface->plane > still point to destroyed plane. So once mouse move to this >

Re: Buffer release events (was: Add support for eglSwapInterval)

2013-10-23 Thread Jason Ekstrand
Neil, Thanks for cracking away at this. I've been kicking it around and I'm wondering if we're going in the wrong direction. I apologize if what I'm about to say has already been thought about and discarded for some reason. I don't remember everything that was considered. It seems to me as if th

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

2013-10-23 Thread Bill Spitzak
Jason Ekstrand wrote: At this point, I think I can propose a solution which should allow for client control while still keeping the compositor in control: 1) The xdg_surface has a pare of activate/deactivate events. I think we need more than keyboard focus here because the user may not have a

Re: [RFC 1/5] Add a fullscreen shell protocol

2013-10-23 Thread Jason Ekstrand
Jonas, Thanks for the review! On Wed, Oct 23, 2013 at 3:56 PM, Jonas Ådahl wrote: > Hi, > > Using this protocol, how would the fullscreen shell client turn on and > off outputs? I can see how clone, next-to and modeset by controlling > what surface is presented and what fullscreen method is used

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

2013-10-23 Thread Jonas Ådahl
On Wed, Oct 23, 2013 at 03:20:52PM -0500, Jason Ekstrand wrote: > On Tue, Oct 22, 2013 at 10:46 PM, Bill Spitzak wrote: > > > On 10/22/2013 05:59 PM, Jason Ekstrand wrote: > > > > I see what you mean here. However, I think apps doing this will cause > >> more trouble than it's worth. One thing

Re: [RFC 1/5] Add a fullscreen shell protocol

2013-10-23 Thread Jonas Ådahl
Hi, Using this protocol, how would the fullscreen shell client turn on and off outputs? I can see how clone, next-to and modeset by controlling what surface is presented and what fullscreen method is used, but that is not enough for turning an output off, isn't it? Another question is synchronisi

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

2013-10-23 Thread Jason Ekstrand
On Tue, Oct 22, 2013 at 10:46 PM, Bill Spitzak wrote: > On 10/22/2013 05:59 PM, Jason Ekstrand wrote: > > I see what you mean here. However, I think apps doing this will cause >> more trouble than it's worth. One thing about current sloppy focus >> implementations is that you can click anywher

[PATCH weston 3/4] autotools: Move the path magic to configure.ac

2013-10-23 Thread Quentin Glidic
From: Quentin Glidic We provide them all in our pkg-config file for usage by external modules. Also use pkg-prefixed directories Signed-off-by: Quentin Glidic --- clients/Makefile.am | 2 +- clients/desktop-shell.c | 4 ++-- configure.ac | 32 +++

[PATCH weston 4/4] clients: Install to pkglibexecdir

2013-10-23 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- clients/Makefile.am | 2 +- src/Makefile.am | 2 +- src/screenshooter.c | 2 +- src/shell.c | 2 +- src/tablet-shell.c | 2 +- src/text-backend.c | 2 +- src/xwayland/Makefile.am | 2 -- 7 files c

[PATCH weston 1/4] tests: Use check_* variables but build by default

2013-10-23 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- tests/Makefile.am | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 5be52c6..d810d8a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -31,16 +31,19 @@ clean-local

[PATCH weston 2/4] weston.pc: Add dependencies for pixman-1 and xkbcommon

2013-10-23 Thread Quentin Glidic
From: Quentin Glidic Weston headers include pixman and libxkbcommon headers Using Requires.private means that CFLAGS from pixman-1 and xkbcommon are added to weston CFLAGS, while LIBS are added in case of static linking only. This way, plugins does not have to use them, but will need to do so exp

[PATCH weston 2/2] Add a test for wl_surface.set_release

2013-10-23 Thread Neil Roberts
The test attaches a buffer and then verifies that it doesn't get the release event until a roundtrip is issued causing the event queue to flush. It then sets the release mode to immediate and then verifies that it doesn't need to do a roundtrip to get the release event. The default mode is then use

Re: Buffer release events (was: Add support for eglSwapInterval)

2013-10-23 Thread Neil Roberts
Neil Roberts writes: > Currently the only proposed complete solution is just to add a request > to explicitly disable the queuing mechanism. I started writing this patch but I've hit a stumbling block while trying to make use of it in Mesa. Adding the new request requires altering the version of

[PATCH weston 1/2] Implement wl_surface.set_release

2013-10-23 Thread Neil Roberts
Implements the wl_surface.set_release request which just causes the buffer release events to be sent with wl_resource_post_event instead of wl_resource_queue_event. The release mode is part of the double-buffered surface state and gets reset to the default as soon as a commit is performed on the su

[PATCH] protocol: Add a request to disable queuing of buffer release events

2013-10-23 Thread Neil Roberts
Adds a request called wl_surface.set_release which provides a way for a client to explicitly disable the queuing mechanism for buffer release events so that it can get them as soon as the buffer is no longer being used. This is useful for example when doing eglSwapInterval(0) because in that case t

Re: [PATCH 2/2] compositor: finish frame if redraw fails

2013-10-23 Thread David Herrmann
Hi On Tue, Oct 22, 2013 at 9:45 PM, Kristian Høgsberg wrote: > On Tue, Oct 22, 2013 at 05:11:26PM +0200, David Herrmann wrote: >> If we are about to finish a frame, but a redraw is pending and we let the >> compositor redraw, we need to check for errors. If the redraw fails and >> the backend can

Re: [RFC wayland v2] libwayland-client: Add GLib main loop integration

2013-10-23 Thread sardemff7+wayland
Forgot to amend the commit message: libwayland-client: Add GLib main loop integration -- Quentin “Sardem FF7” Glidic ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[RFC wayland v2] Add libwayland-glib for GLib main loop integration

2013-10-23 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- Here is a new version of my GLib main loop integration for Wayland. Now everything is in libwayland-client (I didn’t work on the server side) and package detection can be done using the pkg-config file or the header if needed. configure.

Re: [PATCH] wayland: Don't race when releasing named buffers

2013-10-23 Thread Jonas Ådahl
Still needs review. On Wed, Oct 2, 2013 at 5:06 PM, Jonas Ådahl wrote: > This patch fixes a race when a client releases a named buffer before the > server had the time to handle 'wl_drm_create_buffer'. When triggered, > the server would fail to create the buffer since the client already > having