Re: [PATCH weston 0/4] Move decoration code from window.c to

2013-10-13 Thread Kristian Høgsberg
On Sun, Oct 13, 2013 at 07:08:37PM -0500, Jason Ekstrand wrote: > This splits the decorations code out from window.c so that it can also be > used by the xwayland WM and other weston components. > > Jason Ekstrand (4): > Rename frame_create and frame_set_child_size with a window_ prefix > Add

[PATCH weston 4/4] xwayland: Use decoration frame from cairo-util

2013-10-13 Thread Jason Ekstrand
In particular, this gives us a close button on xwayland windows. Signed-off-by: Jason Ekstrand --- In some applications (specifically GLXGears), the close button does not work. Unfortunately, my knowledge of X window managers is small, so I'm not sure what's wrong. src/xwayland/window-manager

[PATCH weston 3/4] Use cairo-util frame in tinytoolkit

2013-10-13 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- This does add a slight regression as I have not yet implemented touch support in the cairo-util frame. Beyond that, it works almost identically to the original version. clients/window.c | 583 ++- 1 file chan

[PATCH weston 2/4] Add decoration frame support to cairo-util

2013-10-13 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- shared/Makefile.am | 2 + shared/cairo-util.h | 111 + shared/frame.c | 670 3 files changed, 783 insertions(+) create mode 100644 shared/frame.c diff --git a/shared/Makefile.am b/shared/Makef

[PATCH weston 1/4] Rename frame_create and frame_set_child_size with a window_ prefix

2013-10-13 Thread Jason Ekstrand
This is to avoid a collision with an actual frame structure. Signed-off-by: Jason Ekstrand --- clients/clickdot.c | 2 +- clients/cliptest.c | 2 +- clients/desktop-shell.c | 2 +- clients/dnd.c | 4 ++-- clients/eventdemo.c | 2 +- clients/image.c | 2 +- c

[PATCH weston 0/4] Move decoration code from window.c to

2013-10-13 Thread Jason Ekstrand
This splits the decorations code out from window.c so that it can also be used by the xwayland WM and other weston components. Jason Ekstrand (4): Rename frame_create and frame_set_child_size with a window_ prefix Add decoration frame support to cairo-util Use cairo-util frame in tinytoolkit

Re: [PATCH weston 08/13] Remove support for text cursor position based output zooming

2013-10-13 Thread Bill Spitzak
Sorry, misunderstood your patch. You are not removing the text cursor position, just the ability of the demo shell to zoom in on it. On 10/13/2013 01:35 PM, Bill Spitzak wrote: On 10/12/2013 08:38 PM, Jason Ekstrand wrote: The entire concept of a text cursor position requires a concept of a "p

Re: [PATCH weston 08/13] Remove support for text cursor position based output zooming

2013-10-13 Thread Bill Spitzak
On 10/12/2013 08:38 PM, Jason Ekstrand wrote: The entire concept of a text cursor position requires a concept of a "primary view". While this could be implemented in a shell, the current implementation crosses the shell/compositor line in strange ways. For now, it is simplest to just remove sup

Re: [PATCH weston 05/13] Update the input code to handle views

2013-10-13 Thread Bill Spitzak
On 10/12/2013 08:38 PM, Jason Ekstrand wrote: In particular, weston_pointer and weston_touch both have a view as their focus instead of a surface while weston_keyboard, on the other hand, still has a surface as its focus. This is because a surface has no visual location while a view does. Are