RE: [PATCH weston 0/6] ivi-shell proposal

2013-09-15 Thread Michael.Schuldt
Hi all, we will come up with a new solution, at clarify what needs to be standardized and why. Regards Michael. >> Hi Michael-san, >> >> As Pekka and Jason suggests in feedback, shall we clearly explain two >> topics before stepping in details. - what ivi-shell tries to >> standardizes - why i

Re: [PATCH 1/2] utils: Document wl_container_of

2013-09-15 Thread Bill Spitzak
On 09/15/2013 11:09 AM, Aaron Faanes wrote: Modified this documentation to be much less verbose than before. I also added an example, used better doxygen style, and mentioned that wl_container_of is useful outside of just wl_list. --- src/wayland-util.h | 27 +++ 1 fil

Problems building Weston/demo applications on the Raspberry Pi

2013-09-15 Thread Silvan Jegen
Hi everyone I am trying to build libwayland, Weston and the demo programs on my Raspberry Pi following the guide at http://wayland.freedesktop.org/raspberrypi.html When compiling Weston and the demo programs however, I get the attached error and no Makefile is being created. What confuses me is

[PATCH 6/6] utils: Document wl_list methods

2013-09-15 Thread Aaron Faanes
--- As I understand it, a wl_list can be either content-bearing node or a list head. I believe this is correct, but if it isn't (in other words, there is no distinction between list heads and content-bearing elements), then this documentation is going to be tragically incorrect. src/wayland-ut

[PATCH 5/6] utils: Ensure wl_list's doxygen formats properly

2013-09-15 Thread Aaron Faanes
This changes the "struct foo" mentions to use , which appears as monospaced font. This also wraps code examples with \code tags to ensure they're detected as code. The code example uses C++ style // comments. I would have preferred to use /* */ comments for consistency, but this is not possible si

[PATCH 4/6] doc: Include wayland-util.* for doxygen output

2013-09-15 Thread Aaron Faanes
This commit creates a shared file list that is included by both the client and the server for the XML Makefile targets, as classes within util are used by both the client and the server. --- I must admit that I'm not too familiar with why these are separated into server and client XML files. As a

[PATCH 3/6] wayland-server: Improve wording for wl_signal_get's doc

2013-09-15 Thread Aaron Faanes
The old description was a bit vague; this commit hopefully improves describing what is returned. --- src/wayland-server.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.h b/src/wayland-server.h index 2e616c1..997e6c7 100644 --- a/src/wayland-server.h +++ b/s

[PATCH 2/6] utils: Add doxygen for wayland-util.h

2013-09-15 Thread Aaron Faanes
This is needed for doxygen to generate output for macro definitions, such as wl_container_of, that are contained by this file. Classes like wl_list would be documented regardless. --- src/wayland-util.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/wayland-util.h b/src/wayland-util.

[PATCH 1/6] utils: Reference some useful methods in wl_signal's doxygen

2013-09-15 Thread Aaron Faanes
This commit adds a bit more detail on the lifecycle of a signal. --- src/wayland-server.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/wayland-server.h b/src/wayland-server.h index f345d2a..2e616c1 100644 --- a/src/wayland-server.h +++ b/src/wayland-server.h @@ -18

[PATCH 0/6] More utils/wayland-server documentation

2013-09-15 Thread Aaron Faanes
Howdy, I went ahead and added some more documentation for some utils classes, the big one being wl_list. I know I have some patches still outstanding, so I apologize if it's rude to submit another batch before the previous ones have been resolved. These patches apply regardless of whether the oth

[PATCH 2/2] wayland-server: Document wl_listener

2013-09-15 Thread Aaron Faanes
This patch takes Kristian's comments into account, adding a demonstration and giving a more thorough idea of how wl_listener is used. --- src/wayland-server.h | 45 + 1 file changed, 45 insertions(+) diff --git a/src/wayland-server.h b/src/wayland-serv

[PATCH 1/2] utils: Document wl_container_of

2013-09-15 Thread Aaron Faanes
Modified this documentation to be much less verbose than before. I also added an example, used better doxygen style, and mentioned that wl_container_of is useful outside of just wl_list. --- src/wayland-util.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/wa

[PATCH] sanity-tests: Be even more aggressive in avoiding optimization

2013-09-15 Thread Aaron Faanes
clang optimizes the malloc away even when assert() is called. Printing the memory address should be side-effecty enough to avoid this optimization. --- tests/sanity-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/sanity-test.c b/tests/sanity-test.c index 46f4f85..0df2e98 100644

Re: [PATCH weston v2] xwm: set the shell_surface's title

2013-09-15 Thread Axel Davy
This patch makes XWayland often crash for me. Axel Davy Le 11/09/2013 18:20, Giulio Camuffo a écrit : add a new function pointer to the weston_shell_interface struct that shells will set accordingly. --- src/compositor.h | 2 ++ src/shell.c | 11 +--