Re: [PATCH weston] xwayland: Remove transform listener when destroying the wm

2013-08-14 Thread Daniel Stone
Hi, On 30 July 2013 00:15, Kristian Høgsberg wrote: > On Sat, Jul 20, 2013 at 05:16:45AM +0100, Louis-Francis Ratté-Boulianne wrote: >> Fix a segfault occuring after the last X window was closed. > > Thanks, that looks good. Did this get lost? Cheers, Daniel >> src/xwayland/window-manager.c |

[PATCH weston] Add more missing config.h includes

2013-08-14 Thread Daniel Stone
config.h includes were missing in a few files, including input.c, the lack of which caused the X11 backend to segfault instantly due to not having an xkbcommon context. Signed-off-by: Daniel Stone --- This is actually against 1.2 branch, but should apply fine to master. Please apply to unbreak

[Take 2][PATCH] Add touch support for wl_shell_surface_move

2013-08-14 Thread Rusty Lynch
>From 3c68e0e2aa98250c65a5d5e9658299904ccf34f1 Mon Sep 17 00:00:00 2001 From: Rusty Lynch Date: Wed, 14 Aug 2013 09:27:44 -0700 Subject: [PATCH] Add touch support for wl_shell_surface_move --- clients/calibrator.c| 4 +- clients/desktop-shell.c | 9 ++-- clients/flower.c| 11 +++

[Take 2][PATCH] protocol: make wl_shell_surface_move support touch

2013-08-14 Thread Rusty Lynch
>From 31c091b0de2d97b722b21a6bd0ad8c309fb3598a Mon Sep 17 00:00:00 2001 From: Rusty Lynch Date: Wed, 14 Aug 2013 15:41:43 -0700 Subject: [PATCH] protocol: make wl_shell_surface_move support touch Bump the version of the wl_shell_surface interface and specify that wl_shell_surface_move works with

Re: [PATCH] Add protocol support for wl_shell_surface_touch_move

2013-08-14 Thread Rusty Lynch
On Wed, 2013-08-14 at 22:24 +0100, Daniel Stone wrote: > Hi, > > On 14 August 2013 22:13, Rusty Lynch wrote: > > I couldn't find a way to determine if the move request was triggered for > > touch or mouse events. > > Serial numbers are unique per-display. So there's no possibility for > collisi

Re: [PATCH] Add protocol support for wl_shell_surface_touch_move

2013-08-14 Thread Daniel Stone
Hi, On 14 August 2013 22:13, Rusty Lynch wrote: > I couldn't find a way to determine if the move request was triggered for > touch or mouse events. Serial numbers are unique per-display. So there's no possibility for collision: a serial will either be for a button press, a key press, a touch do

Re: [PATCH] Add protocol support for wl_shell_surface_touch_move

2013-08-14 Thread Rusty Lynch
I couldn't find a way to determine if the move request was triggered for touch or mouse events. --rusty On Wed, 2013-08-14 at 16:09 -0500, Jason Ekstrand wrote: > Rusty, > Is there a particular reason for adding another request that's > basically identical to "move"? Couldn't we just bump the

Re: [PATCH] Add protocol support for wl_shell_surface_touch_move

2013-08-14 Thread Jason Ekstrand
Rusty, Is there a particular reason for adding another request that's basically identical to "move"? Couldn't we just bump the protocol version and allow the clients to respond to touch events with a move request? The compositor could sort out what kind of event it is based on the serial. --Jason

Re: [PATCH] add [xwayland] path weston.ini option

2013-08-14 Thread Maksim Melnikau
If compare with previous patch, this has a small documentation improvement. On Wed, Aug 14, 2013 at 10:33 PM, Maksim Melnikau wrote: > diff --git a/man/weston.ini.man b/man/weston.ini.man > index 9c22b3f..79743f0 100644 > --- a/man/weston.ini.man > +++ b/man/weston.ini.man > @@ -77,6 +77,7 @@ The

[PATCH] add [xwayland] path weston.ini option

2013-08-14 Thread Maksim Melnikau
It sets the path to the xserver to run. Signed-off-by: Maksim Melnikau --- man/weston.ini.man | 7 +++ src/xwayland/launcher.c | 10 -- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/man/weston.ini.man b/man/weston.ini.man index 9c22b3f..79743f0 100644 --- a/ma

[PATCH] Add support for wl_shell_surface_touch_move

2013-08-14 Thread Rusty Lynch
>From ad35f8b820c06f0ce93926ef43334f93d54e6f86 Mon Sep 17 00:00:00 2001 From: Rusty Lynch Date: Wed, 14 Aug 2013 09:27:44 -0700 Subject: [PATCH] Add support for wl_shell_surface_touch_move --- clients/calibrator.c| 4 +- clients/desktop-shell.c | 9 ++-- clients/flower.c| 11 +++

[PATCH] Add protocol support for wl_shell_surface_touch_move

2013-08-14 Thread Rusty Lynch
>From d1d0df0688650ea23a1c5c788f7d7bbf3e7e034c Mon Sep 17 00:00:00 2001 From: Rusty Lynch Date: Wed, 14 Aug 2013 08:06:39 -0700 Subject: [PATCH] Add protocol support for wl_shell_surface_touch_move --- protocol/wayland.xml | 12 1 file changed, 12 insertions(+) diff --git a/protoco

Re: [PATCH weston 1/2] compositor: Implement release request for input interfaces

2013-08-14 Thread Jason Ekstrand
On Aug 14, 2013 5:14 AM, "Daniel Stone" wrote: > > On 14 August 2013 10:03, Rob Bradford wrote: > > On 13 August 2013 20:11, Rob Bradford wrote: > >> +static void > >> +pointer_release(struct wl_client *client, struct wl_resource *resource) > >> +{ > >> + wl_resource_destroy(resource); > >

Re: [PATCH weston] compositor: ref-count weston_surface instances

2013-08-14 Thread Giulio Camuffo
Yeah. I'll do a destroy fade out animation in orbital now that this is in. Giulio 2013/8/14 Kristian Høgsberg > On Tue, Aug 13, 2013 at 11:10:14PM +0200, Giulio Camuffo wrote: > > this allows a surface to live on after its resource has been > > destroyed if the ref-count was increased by some

Re: [PATCH weston 1/2] compositor: Implement release request for input interfaces

2013-08-14 Thread Daniel Stone
On 14 August 2013 10:03, Rob Bradford wrote: > On 13 August 2013 20:11, Rob Bradford wrote: >> +static void >> +pointer_release(struct wl_client *client, struct wl_resource *resource) >> +{ >> + wl_resource_destroy(resource); >> +} >> + > > Wondering if we should also send leave events here

Re: [PATCH] autotools: Add configure summary

2013-08-14 Thread Rob Bradford
On 14 August 2013 04:48, Kristian Høgsberg wrote: > On Wed, Aug 14, 2013 at 03:13:53AM +0200, Armin K wrote: >> --- >> configure.ac | 43 ++- >> 1 file changed, 42 insertions(+), 1 deletion(-) > > That looks very nice, thanks. Cool patch - going to save me

Re: [PATCH weston 1/2] compositor: Implement release request for input interfaces

2013-08-14 Thread Rob Bradford
On 13 August 2013 20:11, Rob Bradford wrote: > +static void > +pointer_release(struct wl_client *client, struct wl_resource *resource) > +{ > + wl_resource_destroy(resource); > +} > + Wondering if we should also send leave events here if the pointer has a focus...The only other time we des

[PATCH] add [xwayland] path weston.ini option

2013-08-14 Thread Maksim Melnikau
It sets the path to the xserver to run. Signed-off-by: Maksim Melnikau --- man/weston.ini.man | 6 ++ src/xwayland/launcher.c | 10 -- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/man/weston.ini.man b/man/weston.ini.man index 9c22b3f..204c4ee 100644 --- a/man

Re: [PATCH] add ENV[XSERVER_PATH] to change xserver runtime

2013-08-14 Thread Kristian Høgsberg
On Wed, Aug 14, 2013 at 12:53:08AM +0300, Maksim Melnikau wrote: > Signed-off-by: Maksim Melnikau > --- > man/weston.man | 3 +++ > src/weston-launch.c | 4 > src/xwayland/launcher.c | 9 +++-- > 3 files changed, 14 insertions(+), 2 deletions(-) Could we make this a weston.

Re: [PATCH] autotools: Add configure summary

2013-08-14 Thread Kristian Høgsberg
On Wed, Aug 14, 2013 at 03:13:53AM +0200, Armin K wrote: > --- > configure.ac | 43 ++- > 1 file changed, 42 insertions(+), 1 deletion(-) That looks very nice, thanks. Kristian > diff --git a/configure.ac b/configure.ac > index e36b7f7..fab0b48 100644 > -