[PATCH weston v2] evdev: check for ABS_MT_POSITION_X/Y to determine mt devices

2013-08-07 Thread Peter Hutterer
mtdev as currently used in weston is a noop. mtdev's purpose is to convert Protocol A devices (without ABS_MT_SLOT) to Protocol B devices (slots). For Protocol B devices mtdev merely routes the events, so checking for slots and then using mtdev based on that adds no functionality. Check for ABS_MT

[PATCH weston 2/2] malloc + memset -> zalloc

2013-08-07 Thread Peter Hutterer
And for clients using the xmalloc helper, use xzalloc. Signed-off-by: Peter Hutterer --- clients/clickdot.c| 4 +--- clients/cliptest.c| 4 +--- clients/desktop-shell.c | 16 +--- clients/dnd.c | 4 +--- clients/gears.c |

[PATCH weston 1/2] Add zalloc(size_t) allocator function

2013-08-07 Thread Peter Hutterer
Same as calloc(1, len). --- Feel free to squash this with the follow-up, I just kept it separately to make changes easier, the second one is just search/replace. shared/zalloc.h | 40 src/Makefile.am | 1 + src/compositor.h | 1 + 3 files changed, 42 i

Fail to bind wayland interface after a shell surface is created

2013-08-07 Thread Zhao, Halley
Some debugs show, after a shell surface is created, the future registry_handle_global (of wl_registry_listener) doesn't receive any interface. There are some wl_registry_listener in the stack, if I skip wl_shell_get_shell_surface from the previous bind, it will be ok. It seems: after one shell s

Re: [PATCH] cms-colord: Don't redefine _GNU_SOURCE

2013-08-07 Thread Kristian Høgsberg
On Wed, Aug 07, 2013 at 05:45:23PM +0200, Armin K wrote: > warning: "_GNU_SOURCE" redefined [enabled by default] > > See commit c228e23b Thanks, patch applied. Kristian > --- > src/cms-colord.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/cms-colord.c b/src/cms-colord.c > index

Re: [PATCH weston 1/2] clients: use xmalloc in more places

2013-08-07 Thread Kristian Høgsberg
On Wed, Aug 07, 2013 at 03:34:59PM -0700, Brian Lovin wrote: > For the clients continue to use xmalloc() to simplify OOM-handling. Thanks, looks good, applied. Kristian > Signed-off-by: Brian Lovin > --- > clients/dnd.c | 6 ++ > clients/editor.c | 3 ++- > clients/keyboar

Re: [PATCH weston 2/2] terminal.c: check if fdopen() fails

2013-08-07 Thread Kristian Høgsberg
On Wed, Aug 07, 2013 at 03:35:00PM -0700, Brian Lovin wrote: > We never verify that fdopen() succeeds in terminal_send_selection(). > > Signed-off-by: Brian Lovin > --- > clients/terminal.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/clients/terminal.c b/clients/terminal.c > in

Re: [PATCH wayland 1/3] scanner: support help and --help

2013-08-07 Thread Kristian Høgsberg
On Wed, Aug 07, 2013 at 11:05:57AM +1000, Peter Hutterer wrote: > wayland-scanner without arguments prints out usage. With help or --help it > waits for stdin to supply something which isn't quite as informative as > printing out the help. > > This patch also moves the strcmp for args up to have a

[PATCH weston 1/2] clients: use xmalloc in more places

2013-08-07 Thread Brian Lovin
For the clients continue to use xmalloc() to simplify OOM-handling. Signed-off-by: Brian Lovin --- clients/dnd.c | 6 ++ clients/editor.c | 3 ++- clients/keyboard.c | 4 ++-- clients/resizor.c | 4 +--- clients/screenshot.c | 2 +- clients/subsurfaces.c | 8

[PATCH weston 2/2] terminal.c: check if fdopen() fails

2013-08-07 Thread Brian Lovin
We never verify that fdopen() succeeds in terminal_send_selection(). Signed-off-by: Brian Lovin --- clients/terminal.c | 4 1 file changed, 4 insertions(+) diff --git a/clients/terminal.c b/clients/terminal.c index 1cc26d0..5f9ee55 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @

[PATCH] weston-launch: make sure we are launched as root

2013-08-07 Thread Armin K
If running as normal user, it will check if binary is setuid root and fail if it is not. Running as root or through sudo when binary is not setuid root isn't affected and works as it always worked. --- src/weston-launch.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/weston

RE: [Wayland] wayland compilation fails

2013-08-07 Thread Eoff, Ullysses A
I'm seeing this issue too... fwiw. U. Artie Eoff Intel Open Source Technology Center > -Original Message- > From: wayland-devel-bounces+ullysses.a.eoff=intel@lists.freedesktop.org > [mailto:wayland-devel- > bounces+ullysses.a.eoff=intel@lists.freedesktop.org] On Behalf Of Na

[PATCH] cms-colord: Don't redefine _GNU_SOURCE

2013-08-07 Thread Armin K
warning: "_GNU_SOURCE" redefined [enabled by default] See commit c228e23b --- src/cms-colord.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/cms-colord.c b/src/cms-colord.c index 6056407..691b2e6 100644 --- a/src/cms-colord.c +++ b/src/cms-colord.c @@ -24,7 +24,6 @@ #include #endif

Re: [PATCH] cms-colord: Don't define _GNU_SOURCE if it's defined already

2013-08-07 Thread Armin K.
On 08/07/2013 05:11 PM, Daniel Stone wrote: > Hi, > > On 7 August 2013 16:02, Armin K wrote: >> warning: "_GNU_SOURCE" redefined [enabled by default] > > The _GNU_SOURCE define isn't needed at all, cf. c228e23b. > > Cheers, > Daniel > Okay, will send a new patch where it removes it completely

Re: [Wayland] wayland compilation fails

2013-08-07 Thread Nathan Reboud
> Message du 07/08/13 16:57 > De : "Armin K." > A : wayland-devel@lists.freedesktop.org > Copie à : > Objet : Re: [Wayland] wayland compilation fails > > On 08/07/2013 04:47 PM, Nathan Reboud wrote: > > Hi, > > > > Since the last commit on Wayland master, I have this compilation error : > >

Re: [PATCH] cms-colord: Don't define _GNU_SOURCE if it's defined already

2013-08-07 Thread Daniel Stone
Hi, On 7 August 2013 16:02, Armin K wrote: > warning: "_GNU_SOURCE" redefined [enabled by default] The _GNU_SOURCE define isn't needed at all, cf. c228e23b. Cheers, Daniel > src/cms-colord.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/cms-colord.c b/src/cms-colord.c > index

[PATCH] cms-colord: Don't define _GNU_SOURCE if it's defined already

2013-08-07 Thread Armin K
warning: "_GNU_SOURCE" redefined [enabled by default] --- src/cms-colord.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cms-colord.c b/src/cms-colord.c index 6056407..29f005d 100644 --- a/src/cms-colord.c +++ b/src/cms-colord.c @@ -24,7 +24,9 @@ #include #endif +#ifndef _GNU_SOUR

Re: [Wayland] wayland compilation fails

2013-08-07 Thread Armin K.
On 08/07/2013 04:47 PM, Nathan Reboud wrote: > Hi, > > Since the last commit on Wayland master, I have this compilation error : > > <~/source/wayland> make > make all-recursive > make[1]: Entering directory `/root/source/wayland' > Making all in src > make[2]: Entering directory `/root/source/wa

[Wayland] wayland compilation fails

2013-08-07 Thread Nathan Reboud
Hi, Since the last commit on Wayland master, I have this compilation error : <~/source/wayland> make make all-recursive make[1]: Entering directory `/root/source/wayland' Making all in src make[2]: Entering directory `/root/source/wayland/src' CC scanner.o CC connection.lo In file included from

Re: [PATCH weston 05/10] evdev: check for ABS_MT_POSITION_X/Y to determine mt devices

2013-08-07 Thread Daniel Stone
Hi, On 7 August 2013 02:04, Peter Hutterer wrote: > mtdev as currently used in weston is a noop. mtdev's purpose is to convert > Protocol A devices (without ABS_MT_SLOT) to Protocol B devices (slots). > For Protocol B devices mtdev merely routes the events, so checking for > slots and then using