Re: [PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

On Wed, Aug 07, 2013 at 07:46:43AM +0200, Daiki Ueno wrote: > Hi, > > Peter Hutterer writes: > > > AC_DEFUN([WAYLAND_SCANNER_RULES], [ > > PKG_PROG_PKG_CONFIG > > > > +PKG_CHECK_MODULES([WAYLAND_SCANNER], [wayland-scanner]) > > + > > With this change, configure will abort if wayland

Re: [PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

Hi, Peter Hutterer writes: > AC_DEFUN([WAYLAND_SCANNER_RULES], [ > PKG_PROG_PKG_CONFIG > > +PKG_CHECK_MODULES([WAYLAND_SCANNER], [wayland-scanner]) > + With this change, configure will abort if wayland-scanner.pc is not found. However, the current WAYLAND_SCANNER_RULES cannot be in

[PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

If wayland-scanner.pc can't be found the variables end up being set irrespectively, leaving the user with odd compiler errors about missing headers, etc. --- wayland-scanner.m4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wayland-scanner.m4 b/wayland-scanner.m4 index 2b87c5f..4e4222a 1006

[PATCH wayland 2/3] scanner: expand help string

Signed-off-by: Peter Hutterer --- src/scanner.c | 4 1 file changed, 4 insertions(+) diff --git a/src/scanner.c b/src/scanner.c index ace6633..5124000 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -34,6 +34,10 @@ static int usage(int ret) { fprintf(stderr, "usage: ./scanner [

[PATCH weston 10/10] evdev: log when a device is used as touchpad

--- src/evdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 7bacbd9..ab35582 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -495,8 +495,11 @@ evdev_handle_device(struct evdev_device *device) key_bits);

[PATCH wayland 1/3] scanner: support help and --help

wayland-scanner without arguments prints out usage. With help or --help it waits for stdin to supply something which isn't quite as informative as printing out the help. This patch also moves the strcmp for args up to have all of them in one location. --- src/scanner.c | 29 ++

[PATCH weston 09/10] evdev: call evdev_device_destroy on failure

Avoid keeping keeping what needs to be freed in sync in multiple places, make evdev_device_destroy do the right thing instead. --- src/evdev.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index bd3b025..7bacbd9 10064

[PATCH weston 08/10] evdev: plug a potential memleak

For touchpads, device->dispatch is set up when exiting evdev_handle_device() and a potential source for a memleak. This can't actually happen at the moment, as evdev_handle_device() won't fail for touchpads after setting up the dispatch but prevent this from happening in the future. --- src/evdev.

[PATCH weston 07/10] evdev: get the current slot value from the absinfo struct or mtdev

If touches are already present on the device, absinfo has the currently active touch slot. There's a race condition where the slot may change before we enable the fd and we thus miss out on the ABS_MT_SLOT event. It's still slightly more correct than assuming whatever comes next is slot 0. --- src

[PATCH weston 06/10] evdev: only use mtdev for Protocol A devices

For Protocol B devices, mtdev merely routes the events and is not needed. For Protocol A devices, mtdev is needed, so fail for those devices now if we mtdev fails. --- src/evdev.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/evdev.c b/src/evdev.c in

[PATCH weston 05/10] evdev: check for ABS_MT_POSITION_X/Y to determine mt devices

mtdev as currently used in weston is a noop. mtdev's purpose is to convert Protocol A devices (without ABS_MT_SLOT) to Protocol B devices (slots). For Protocol B devices mtdev merely routes the events, so checking for slots and then using mtdev based on that adds no functionality. Check for ABS_MT

[PATCH weston 04/10] evdev: malloc + memset -> calloc

--- src/evdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 96f3085..4f3f8cf 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -553,10 +553,9 @@ evdev_device_create(struct weston_seat *seat, const char *path, int device_fd) struct west

[PATCH weston 03/10] evdev: add comment why we're ignoring key value 2

--- src/evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev.c b/src/evdev.c index d7e416a..96f3085 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -65,6 +65,7 @@ evdev_led_update(struct evdev_device *device, enum weston_led leds) static inline void evdev_process_key(struct evdev

[PATCH weston 02/10] evdev: prevent unterminated device name

The kernel copies up to sizeof(devname) bytes but doesn't null-terminate the string if the device name exceeds the size of the supplied buffer. --- src/evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev.c b/src/evdev.c index 5ad4d6b..d7e416a 100644 --- a/src/evdev.c +++ b/src/ev

[PATCH weston 01/10] tty: fix typo in error message

--- src/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty.c b/src/tty.c index 38079a4..0ddf6e0 100644 --- a/src/tty.c +++ b/src/tty.c @@ -175,7 +175,7 @@ tty_create(struct weston_compositor *compositor, tty_vt_func_t vt_func, if (tty->starting_vt != tty->vt

Re: [PATCH] clients: Fix typo in simple-touch and simple-shm.

On Mon, Aug 05, 2013 at 01:50:50PM +0100, Stefan Schmidt wrote: > listenter -> listener. Better fix it now before it spreads further. Heh, oops, that might have been in there for a while. Thanks for fixing it. Kristian > Signed-off-by: Stefan Schmidt > --- > clients/simple-shm.c |4 ++--

Re: [PATCH] Drop extraneous duplicate header includes

On Mon, Aug 05, 2013 at 05:37:20PM -0700, Bryce Harrington wrote: > From: Bryce Harrington Nice cleanup, thanks. Kristian > Signed-off-by: Bryce Harrington > --- > clients/flower.c |1 - > clients/smoke.c|1 - > src/compositor-drm.c |1 - > src/compositor-fbdev.c |

Re: [wayland v3] shm: Add API for renderers to register additional pixel formats

On Tue, Aug 06, 2013 at 08:05:53PM +0200, Tomeu Vizoso wrote: > --- > src/wayland-private.h | 4 > src/wayland-server.c | 19 +++ > src/wayland-server.h | 3 +++ > src/wayland-shm.c | 45 - > 4 files changed, 58 insertions(+)

Re: Possible bug in compositor-rdp.c (Marek Romanowicz)

On 06/08/2013 17:28, Marek Romanowicz wrote: Hi all, I am not sure if compositor-rdp.c acts as authors intended it to. I managed to make it running after several attempts together with wayland and connect to it over RDP protocol using xfreerdp from another machine running Ubuntu 13.10. Xfree

[weston v3 4/4] rpi: Add support for SHM buffers in RGB565 format

--- src/rpi-bcm-stubs.h | 1 + src/rpi-renderer.c | 4 2 files changed, 5 insertions(+) diff --git a/src/rpi-bcm-stubs.h b/src/rpi-bcm-stubs.h index 4b89319..d3ffd4b 100644 --- a/src/rpi-bcm-stubs.h +++ b/src/rpi-bcm-stubs.h @@ -85,6 +85,7 @@ typedef enum /* these are not the right

[weston v3 3/4] pixman-renderer: Add support for SHM buffers in RGB565 format

--- src/pixman-renderer.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 25bffbe..31b7e58 100644 --- a/src/pixman-renderer.c +++ b/src/pixman-renderer.c @@ -560,6 +560,9 @@ pixman_renderer_attach(struct weston_surface *es, struct west

[weston v3 2/4] gl-renderer: Add support for SHM buffers in RGB565 format

--- src/gl-renderer.c | 57 --- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index d13781c..0d31cb7 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -1109,6 +1109,8 @@ gl_renderer_

[weston v3 1/4] window: Allow hinting of a preference for RGB565 when creating a window

And check if the renderer supports the RGB565 format for wl_shm buffers before creating the cairo surface and requesting the buffer. It can save quite some memory with big surfaces such as desktop backgrounds. --- clients/desktop-shell.c | 2 ++ clients/window.c| 52 +

[wayland v3] shm: Add API for renderers to register additional pixel formats

--- src/wayland-private.h | 4 src/wayland-server.c | 19 +++ src/wayland-server.h | 3 +++ src/wayland-shm.c | 45 - 4 files changed, 58 insertions(+), 13 deletions(-) diff --git a/src/wayland-private.h b/src/wayland-privat

Re: Support for remote desktop systems

Hi Andrew, Nice to hear from you. :) Unfortunately, the pretty blunt answer is that it's not the kind of interface we're intending to support at the moment. There are two primary reasons behind this: the first is that by design, we tend to put things like this in private, compositor-led, protocol

Possible bug in compositor-rdp.c (Marek Romanowicz)

Hi all, I am not sure if compositor-rdp.c acts as authors intended it to. I managed to make it running after several attempts together with wayland and connect to it over RDP protocol using xfreerdp from another machine running Ubuntu 13.10. Xfreerdp client obtained initial Wayland desktop imag