Re: Simplify a function

2013-07-29 Thread Kristian Høgsberg
On Thu, Jul 25, 2013 at 01:51:53AM +0300, Jiergir Ogoerg wrote: > Hi, > I think in wayland-client.c the function > wl_display_dispatch_queue_pending(...) > could be simplified > from this: > pthread_mutex_lock(&display->mutex); > if (dispatch_queue(display, queue) == -1) > goto err_

Re: [PATCH wayland 1/2] text-backend: remove the weston_seat destruction listener on destroy

2013-07-29 Thread Kristian Høgsberg
On Wed, Jul 24, 2013 at 04:57:32PM +0100, Rob Bradford wrote: > From: Rob Bradford > > Prior to freeing the memory in which the link node for the signal is > emedded we should remove the link node from the list to prevent the list > from being corrupted. > > https://bugs.freedesktop.org/show_bug

Re: [PATCH] screenshot: Drop extraneous 'is' to improve warning msg grammar

2013-07-29 Thread Kristian Høgsberg
On Tue, Jul 23, 2013 at 09:53:26PM +, Bryce W. Harrington wrote: > Signed-off-by: Bryce Harrington > --- > clients/screenshot.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/clients/screenshot.c b/clients/screenshot.c > index 1f73df6..7511ef7 100644 > --- a/clie

Re: [PATCH] reset touch focus in unmap

2013-07-29 Thread Kristian Høgsberg
On Tue, Jul 23, 2013 at 03:51:06PM +0800, wfu wrote: > From: wfu > > otherwise, there will be race condition of visiting invalid surface data Yes, that was missing. Thanks Michael, patch applied. Kristian > --- > src/compositor.c |2 ++ > src/compositor.h |3 +++ > src/input.c |

Re: [PATCH weston] xwayland: Remove transform listener when destroying the wm

2013-07-29 Thread Kristian Høgsberg
On Sat, Jul 20, 2013 at 05:16:45AM +0100, Louis-Francis Ratté-Boulianne wrote: > Fix a segfault occuring after the last X window was closed. Thanks, that looks good. Kristian > src/xwayland/window-manager.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/xwayland/window-manager

[PATCH v2] evdev-touchpad: Set some options using weston.ini

2013-07-29 Thread Armin K
This patch adds 3 new options to weston.ini to allow the user to change default constant_accel_factor, min_accel_factor and max_accel_factor. If no options are set, it falls back using defaults as it did before. v2: create weston_config_section_get_double and use it instead of manualy converting s

Re: [PATCH] evdev-touchpad: Set some options using weston.ini

2013-07-29 Thread Kristian Høgsberg
On Sat, Jul 13, 2013 at 11:26:00AM +0200, Armin K wrote: > This patch adds 3 new options to weston.ini to allow > the user to change default constant_accel_factor, > min_accel_factor and max_accel_factor. If no options > are set, it falls back using defaults as it did before. > --- > src/evdev-tou

Re: [wayland v2 2/2] shm: Add API for renderers to register additional pixel formats

2013-07-29 Thread Kristian Høgsberg
On Thu, Jul 11, 2013 at 04:08:23PM +0200, Tomeu Vizoso wrote: > --- > src/wayland-private.h | 4 > src/wayland-server.c | 17 + > src/wayland-server.h | 4 > src/wayland-shm.c | 45 - > 4 files changed, 57 insertions(+),

Re: [weston v2 1/4] window: Allow hinting of a preference for RGB565 when creating a window

2013-07-29 Thread Kristian Høgsberg
On Thu, Jul 11, 2013 at 04:08:21PM +0200, Tomeu Vizoso wrote: > And check if the renderer supports the RGB565 format for wl_shm buffers > before creating the cairo surface and requesting the buffer. > > It can save quite some memory with big surfaces such as desktop > backgrounds. That's a cool f

Re: [wayland v2 1/2] protocol: Copy missing pixel formats from wl_drm to wl_shm

2013-07-29 Thread Kristian Høgsberg
On Thu, Jul 11, 2013 at 04:08:20PM +0200, Tomeu Vizoso wrote: > --- > protocol/wayland.xml | 65 > +++- This looks good, applied. Kristian > 1 file changed, 64 insertions(+), 1 deletion(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland

Re: Add support to wl_shm for RGB565 buffers

2013-07-29 Thread Kristian Høgsberg
On Thu, Jul 11, 2013 at 04:08:19PM +0200, Tomeu Vizoso wrote: > This version allows renderers to advertise support for additional pixel > formats for shm buffers via new API: wl_display_set_additional_shm_formats > > Additionally, clients can hint when creating a window the preferred pixel > forma