Re: [PATCH weston 04/11] compositor-fbdev: Avoid dereferencing a pointer in freed memory

On 07/26/2013 08:29 AM, Rob Bradford wrote: From: Rob Bradford + device = output->device; fbdev_output_destroy(base); Are you sure this does not free the memory that is now at *device? ___ wayland-devel mailing list

Re: Should there be a way to query if an event queue is empty?

You can call dispatch_pending "last", ie as part of the dispatch function. It's in a loop, so doing something at the end of the loop is the same as doing it at the start. On 07/26/2013 05:30 AM, Neil Roberts wrote: Hi, [I sent this yesterday too, but I accidentally used the wrong address and

[PATCH weston 11/11] desktop-shell: Refactor launcher configuration reading to avoid leaking

From: Rob Bradford --- clients/desktop-shell.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index eb550c8..ad324ba 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -1205,15 +1205,13 @@ panel_add_laun

[PATCH weston 10/11] compositor-x11: Don't leak the looked up name for skipped outputs

From: Rob Bradford --- src/compositor-x11.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 6baf522..4a73253 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x11.c @@ -1525,8 +1525,10 @@ x11_compositor_create(struct w

[PATCH weston 09/11] window: Free the allocated display if we fail to setup libxkbcommon

From: Rob Bradford --- clients/window.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/clients/window.c b/clients/window.c index 8d956ae..d9f7d5a 100644 --- a/clients/window.c +++ b/clients/window.c @@ -4970,6 +4970,13 @@ display_create(int *argc, char *argv[])

[PATCH weston 08/11] tablet-shell: Avoid leaking the path on failed icon loading

From: Rob Bradford --- clients/tablet-shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/tablet-shell.c b/clients/tablet-shell.c index 3d5e79a..d7aac70 100644 --- a/clients/tablet-shell.c +++ b/clients/tablet-shell.c @@ -396,7 +396,6 @@ tablet_shell_add_launcher(

[PATCH weston 07/11] image: Free filename saved into structure on error path

From: Rob Bradford --- clients/image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/image.c b/clients/image.c index cbd466c..1f3c77c 100644 --- a/clients/image.c +++ b/clients/image.c @@ -373,6 +373,7 @@ image_create(struct display *display, const char *filename, if (!im

[PATCH weston 06/11] compositor-drm: Use a format width parameter for the modeline sscanf

From: Rob Bradford --- src/compositor-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index cf626ba..c7d6c04 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1673,7 +1673,7 @@ parse_modeline(const char *s, drmM

[PATCH weston 05/11] compositor-fbdev: Close fd used for re-enabling if that fails

From: Rob Bradford The device will be opened again in fbdev_output_create(). --- src/compositor-fbdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor-fbdev.c b/src/compositor-fbdev.c index 36631f3..10ba7db 100644 --- a/src/compositor-fbdev.c +++ b/src/compositor-fbdev.c @@

[PATCH weston 04/11] compositor-fbdev: Avoid dereferencing a pointer in freed memory

From: Rob Bradford fbdev_output_destroy will free the memory passed into in and since we want to pass the device name into fbdev_output_create we need to save this to an intermediate value --- src/compositor-fbdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compo

[PATCH weston 03/11] tty: Correctly check if the opening of the file descriptor failed

From: Rob Bradford --- src/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty.c b/src/tty.c index 2324f6c..38079a4 100644 --- a/src/tty.c +++ b/src/tty.c @@ -161,7 +161,7 @@ tty_create(struct weston_compositor *compositor, tty_vt_func_t vt_func, tt

[PATCH weston 02/11] wcap-decode: Close file descriptor when destroying the decoder

From: Rob Bradford --- wcap/wcap-decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/wcap/wcap-decode.c b/wcap/wcap-decode.c index f7cabe3..2b9304d 100644 --- a/wcap/wcap-decode.c +++ b/wcap/wcap-decode.c @@ -144,6 +144,7 @@ void wcap_decoder_destroy(struct wcap_decoder *decoder) {

[PATCH weston 01/11] drm: close the drm file descriptor when the compositor is destroyed

From: Rob Bradford --- src/compositor-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 5a5d79c..cf626ba 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -2260,6 +2260,8 @@ drm_destroy(struct weston_compositor *ec)

Should there be a way to query if an event queue is empty?

Hi, [I sent this yesterday too, but I accidentally used the wrong address and it got stuck in the moderator queue so I'm resending it] I was wondering whether we should add a function like wl_event_queue_empty() to query whether there are any pending events in the queue. This would make it easier

A simple drawing library and some wayland ports

Hi, A while back I was interested in porting dmenu[0] and st[1] to wayland. However, the available rendering stack (cairo + pango + glib + opengl/pixman) seemed a bit overkill to me when all I needed was two simple operations, "fill rectangle with color" and "draw monochrome text with color". So