Re: Simplify a function

2013-07-24 Thread Dennis Lan (dlan)
On Thu, Jul 25, 2013 at 6:51 AM, Jiergir Ogoerg wrote: > Hi, > I think in wayland-client.c the function > wl_display_dispatch_queue_pending(...) > could be simplified > from this: > pthread_mutex_lock(&display->mutex); > if (dispatch_queue(display, queue) == -1) > goto err_unlock;

Simplify a function

2013-07-24 Thread Jiergir Ogoerg
Hi, I think in wayland-client.c the function wl_display_dispatch_queue_pending(...) could be simplified from this: pthread_mutex_lock(&display->mutex); if (dispatch_queue(display, queue) == -1) goto err_unlock; pthread_mutex_unlock(&display->mutex); return 0; err_unlock:

Re: [PATCH weston 5/6] input: Emit events on all resources for a client

2013-07-24 Thread Daniel Stone
Hi, On 22 July 2013 17:31, Rob Bradford wrote: > The Wayland protocol permits a client to request the pointer, keyboard > and touch multiple times from the seat global. This is very useful in a > component like Clutter-GTK where we are combining two libraries that use > Wayland together. > > This

Re: [PATCH weston 1/6] input: For serial generation get the display from the compositor

2013-07-24 Thread Daniel Stone
Yep, makes a lot of sense - it was only in there originally due to the libwayland-server/weston input split. On 22 July 2013 17:31, Rob Bradford wrote: > From: Rob Bradford > > This removes the use of wl_client_get_display() where the client is > derived from the focussed resource. This starts t

Re: [PATCH wayland 1/2] text-backend: remove the weston_seat destruction listener on destroy

2013-07-24 Thread Rob Bradford
The eagle eyed amongst you will notice these are patches for weston..whoops :-) Rob On 24 July 2013 16:57, Rob Bradford wrote: > From: Rob Bradford > > Prior to freeing the memory in which the link node for the signal is > emedded we should remove the link node from the list to prevent the list

[PATCH wayland 2/2] clipboard: remove the weston_seat destruction listener on destroy

2013-07-24 Thread Rob Bradford
From: Rob Bradford Prior to freeing the memory in which the link node for the signal is emedded we should remove the link node from the list to prevent the list from being corrupted. https://bugs.freedesktop.org/show_bug.cgi?id=67231 --- src/clipboard.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH wayland 1/2] text-backend: remove the weston_seat destruction listener on destroy

2013-07-24 Thread Rob Bradford
From: Rob Bradford Prior to freeing the memory in which the link node for the signal is emedded we should remove the link node from the list to prevent the list from being corrupted. https://bugs.freedesktop.org/show_bug.cgi?id=67231 --- src/text-backend.c | 1 + 1 file changed, 1 insertion(+)