[PATCH weston] Remove weston_buffer_reference

2013-06-27 Thread Jason Ekstrand
This commit removes the weston_buffer_reference structure and replaces it's funtionality with weston_buffer_ref and weston_buffer_decref functions. NOTE: This patch needs thurough review before committing. I do not know the weston internals all that well and so I don't know if this will break an

Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-27 Thread Bill Spitzak
Jason Ekstrand wrote: That is exactly what this patch allows you to do. More particularly, this patch protects the compositor from bad clients that attempt to use requests that are not supported by the compositor. In the current implementation, the compositor simply crashes. I'm confused a

[PATCH weston 4/4] Use the versioned wl_global api and properly advertise versions

2013-06-27 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/compositor.c| 16 +--- src/data-device.c | 6 +++--- src/input.c | 4 ++-- src/screenshooter.c | 7 --- src/shell.c | 27 --- src/tablet-shell.c | 5 +++-- src/text-ba

[PATCH weston 3/4] Use versioned versions of wl_client_add/new_object calls

2013-06-27 Thread Jason Ekstrand
This commit sets the version numbers for all added/created objects. The wl_compositor.create_surface implementation was altered to create a surface with the same version as the underlying wl_compositor. Since no other "child interfaces" have version greater than 1, they were all hard-coded to ver

[PATCH weston 2/4] window: Request version 3 of wl_compositor

2013-06-27 Thread Jason Ekstrand
Originally window.c was requesting version 1 but several clients were calling version 2 and 3 events including the desktop shell itself. Signed-off-by: Jason Ekstrand --- clients/window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c inde

[PATCH weston 1/4] Add a MIN macro

2013-06-27 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/compositor.h | 4 1 file changed, 4 insertions(+) diff --git a/src/compositor.h b/src/compositor.h index 45a14d6..60da054 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -36,6 +36,10 @@ extern "C" { #include "matrix.h" #include "config-parser

[PATCH weston 0/4] Update weston to properly handle protocol versions

2013-06-27 Thread Jason Ekstrand
This series updates weston to use the new global and resource versioning API. Jason Ekstrand (4): Add a MIN macro window: Request version 3 of wl_compositor Use versioned versions of wl_client_add/new_object calls Use the versioned wl_global api and properly advertise versions clients/wi

[PATCH wayland 4/4] Add support for proper global versioning.

2013-06-27 Thread Jason Ekstrand
In previous versions of libwayland the version of the global that was advertised to the client was taken from the wl_interface object. This has two problems. First it makes it impossible for a compositor to only support a lower version than the version against which it was built. Second, since th

[PATCH wayland 3/4] Add a version field to wl_resource and verify request versions before calling them

2013-06-27 Thread Jason Ekstrand
This commit provides a layer of protection for the compositor in the form of message version checking. Version information is provided to libwayland as an aditional argument to wl_client_add_object and wl_client_new_object. libwayland then uses this version information to verify that a request exi

[PATCH wayland 2/4] Add version information to wl_message signatures.

2013-06-27 Thread Jason Ekstrand
This commit adds version information to wl_message signatures and a wl_message_get_since function to retrieve. The since version comes in the form of a (possible) integer at the begining of the message. If the message starts with an integer, then it specifies the "since" version of that message.

[PATCH wayland 1/4] server: Make wl_object and wl_resource opaque structs

2013-06-27 Thread Jason Ekstrand
From: Kristian Høgsberg With the work to add wl_resource accessors and port weston to use them, we're ready to make wl_resource and wl_object opaque structs. We keep wl_buffer in the header for EGL stacks to use, but don't expose it by default. In time we'll remove it completely, but for now it

[PATCH wayland 0/4] Add versioning to wl_resource and wl_global

2013-06-27 Thread Jason Ekstrand
This series adds version information to wl_resource and wl_global to allow for more correct versioning. In order to not break ABI with current EGL implementations, new versions of wl_display_add_global and wl_client_add/new_object were added instead of simply adding arguments to the old versions.

Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-27 Thread Jason Ekstrand
On Thu, Jun 27, 2013 at 1:19 PM, Bill Spitzak wrote: > > > Jason Ekstrand wrote: > >> This commit adds version information to wl_message signatures and a >> wl_message_get_since function to retrieve. The since version comes in the >> form of a (possible) integer at the begining of the message.

Re: [PATCH wayland 3/3] Add a version field to wl_resource and verify request versions before calling them

2013-06-27 Thread Jason Ekstrand
DISCARD THIS PATCH. NEW SERIES COMING This patch breaks ABI too badly. Specifically Mesa (and probably other EGL implementations) use wl_client_add_object internally. --Jason Ekstrand On Wed, Jun 26, 2013 at 10:18 PM, Jason Ekstrand wrote: > This commit provides a layer of protection for the

Re: [PATCH weston] compositor: rebuild the global list if we've removed a surface from it

2013-06-27 Thread Hardening
Le 26/06/2013 19:36, Eoff, Ullysses A a écrit : This patch also fixed https://bugs.freedesktop.org/show_bug.cgi?id=66173 Confirmed here too (my backtrace was a little different in #66173). Regards. ___ wayland-devel mailing list wayland-devel@list

Re: [ANNOUNCE] libevdev - a library to wrap the evdev kernel interface

2013-06-27 Thread Wander Lairson Costa
2013/6/27 Peter Hutterer : > On Thu, Jun 27, 2013 at 11:15:03AM -0300, Wander Lairson Costa wrote: >> 2013/6/27 Peter Hutterer : >> > For the last month or so I've been spending some time on a helper library >> > for evdev devices. The motivation is two-fold: >> > >> > * users of evdev currently is

Re: [ANNOUNCE] libevdev - a library to wrap the evdev kernel interface

2013-06-27 Thread Peter Hutterer
On Thu, Jun 27, 2013 at 11:15:03AM -0300, Wander Lairson Costa wrote: > 2013/6/27 Peter Hutterer : > > For the last month or so I've been spending some time on a helper library > > for evdev devices. The motivation is two-fold: > > > > * users of evdev currently issue ioctls directly, checking bit

Re: [PATCH wayland 2/3] Add version information to wl_message signatures.

2013-06-27 Thread Bill Spitzak
Jason Ekstrand wrote: This commit adds version information to wl_message signatures and a wl_message_get_since function to retrieve. The since version comes in the form of a (possible) integer at the begining of the message. If the message starts with an integer, then it specifies the "since"

Re: [ANNOUNCE] libevdev - a library to wrap the evdev kernel interface

2013-06-27 Thread Todd Showalter
On Thu, Jun 27, 2013 at 12:52 AM, Peter Hutterer wrote: > For the last month or so I've been spending some time on a helper library > for evdev devices. Looks nice! I assume this doesn't abstract away the need to be root to access events. Tod

Re: [ANNOUNCE] libevdev - a library to wrap the evdev kernel interface

2013-06-27 Thread Wander Lairson Costa
2013/6/27 Peter Hutterer : > For the last month or so I've been spending some time on a helper library > for evdev devices. The motivation is two-fold: > > * users of evdev currently issue ioctls directly, checking bit masks > manually. all this is a source for error, especially as there are some