Re: [PATCH weston v2 1/3] toytoolkit: Allow operation without a keymap

2013-06-21 Thread Bill Spitzak
Daniel Stone wrote: What I suspect is the minimum resulting xkb description where this client still works is going to be a LOT smaller, and will be much closer to the proposed gamepad evdev mapping. That doesn't fly for shortcuts, especially when you take into consideration things like Ctrl+Sh

Re: [PATCH weston v2 1/3] toytoolkit: Allow operation without a keymap

2013-06-21 Thread Daniel Stone
Hi, On 22 June 2013 01:54, Bill Spitzak wrote: > Daniel Stone wrote: >> If the only input API you need is the input method API, then you don't >> need other input APIs. >> >> wl_keyboard is pretty much for people who need to support non-textual >> keyboard input, e.g. hotkeys/media keys and short

Re: [PATCH weston v2 1/3] toytoolkit: Allow operation without a keymap

2013-06-21 Thread Bill Spitzak
Daniel Stone wrote: On 21 June 2013 23:02, Bill Spitzak wrote: If clients use the input method for all the text input, exactly how much is left of xkb keyboards? It looks like all this compiling is so that dead keys and all the shift states work for producing different characters. That can al

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread Marc Chalain
2013/6/21 David Herrmann > Hi Marc > > On Fri, Jun 21, 2013 at 2:17 PM, Marc Chalain > wrote: > > > > > > 2013/6/21 David Herrmann > >> > >> Hi > >> > >> On Fri, Jun 21, 2013 at 12:05 PM, Marc Chalain > >> wrote: > >> > > >> > > >> > 2013/6/21 David Herrmann > >> >> > >> >> Hi > >> >> > >> >>

Re: [PATCH weston v2 3/3] build: Make libxkbcommon build-time optional in the compositor

2013-06-21 Thread Daniel Stone
Hi, Couple of minor nitpicks: Firstly, it would be nice to see some help text alongside --disable-xkbcommon, explaining that it's not a thing you generally want to do. Also if you moved the use_xkbcommon assignment into weston_compositor_xkb_init(), and defined that to just do nothing in the !HAV

Re: [PATCH weston v2 1/3] toytoolkit: Allow operation without a keymap

2013-06-21 Thread Daniel Stone
On 21 June 2013 23:02, Bill Spitzak wrote: > If clients use the input method for all the text input, exactly how much is > left of xkb keyboards? It looks like all this compiling is so that dead keys > and all the shift states work for producing different characters. That can > all be done by the

Re: [PATCH weston 1/7] weston.pc: Add dependencies for pixman-1 and xkbcommon

2013-06-21 Thread Kristian Høgsberg
On Fri, Jun 21, 2013 at 06:43:36AM +0200, Quentin Glidic wrote: > On 20/06/2013 21:05, Kristian Høgsberg wrote: > >On Tue, Jun 18, 2013 at 09:11:28AM +0200, Quentin Glidic wrote: > >>From: Quentin Glidic > >> > >>Weston headers include pixman and libxkbcommon headers > >> > >>Signed-off-by: Quenti

Re: [PATCH weston v2 1/3] toytoolkit: Allow operation without a keymap

2013-06-21 Thread Bill Spitzak
If clients use the input method for all the text input, exactly how much is left of xkb keyboards? It looks like all this compiling is so that dead keys and all the shift states work for producing different characters. That can all be done by the input method and thus only the input method has

[PATCH weston v2 3/3] build: Make libxkbcommon build-time optional in the compositor

2013-06-21 Thread Rob Bradford
From: Rob Bradford --- configure.ac | 9 - src/compositor.c | 6 +- src/input.c | 20 +++- 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b625221..5e5e7bb 100644 --- a/configure.ac +++ b/configure.ac @@ -54

[PATCH weston v2 2/3] input: Add support for making libxkbcommon optional

2013-06-21 Thread Rob Bradford
From: Matt Roper In embedded environments, devices that appear as evdev "keyboards" often have no resemblence to PC-style keyboards. It is not uncommon for such environments to have no concept of modifier keys and no need for XKB key mapping; in these cases libxkbcommon initialization becomes un

[PATCH weston v2 1/3] toytoolkit: Allow operation without a keymap

2013-06-21 Thread Rob Bradford
From: Matt Roper In preparation for upcoming changes, we want to make sure that apps written with the toy toolkit continue to operate properly if no XKB keymap is received. If there's no XKB keymap, then we shouldn't try to figure out keyboard modifier states (since we probably don't even have e

[PATCH weston v2 3/3] build: Make libxkbcommon build-time optional in the compositor

2013-06-21 Thread Rob Bradford
From: Rob Bradford --- configure.ac | 9 - src/compositor.c | 6 +- src/input.c | 20 +++- 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b625221..5e5e7bb 100644 --- a/configure.ac +++ b/configure.ac @@ -54

[PATCH weston v2 2/3] input: Add support for making libxkbcommon optional

2013-06-21 Thread Rob Bradford
From: Matt Roper In embedded environments, devices that appear as evdev "keyboards" often have no resemblence to PC-style keyboards. It is not uncommon for such environments to have no concept of modifier keys and no need for XKB key mapping; in these cases libxkbcommon initialization becomes un

[PATCH weston v2 1/3] toytoolkit: Allow operation without a keymap

2013-06-21 Thread Rob Bradford
From: Matt Roper In preparation for upcoming changes, we want to make sure that apps written with the toy toolkit continue to operate properly if no XKB keymap is received. If there's no XKB keymap, then we shouldn't try to figure out keyboard modifier states (since we probably don't even have e

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread David Herrmann
Hi Marc On Fri, Jun 21, 2013 at 2:17 PM, Marc Chalain wrote: > > > 2013/6/21 David Herrmann >> >> Hi >> >> On Fri, Jun 21, 2013 at 12:05 PM, Marc Chalain >> wrote: >> > >> > >> > 2013/6/21 David Herrmann >> >> >> >> Hi >> >> >> >> On Fri, Jun 21, 2013 at 11:43 AM, Marc Chalain >> >> wrote: >>

[PATCH V2] fbdev: initialize yoffset of varinfo

2013-06-21 Thread mchalain [marc.chal...@gmail.com]
From: mchalain it initializes varinfo.yoffset. varinfo.yoffset has to point on the beginning of the video memory. The card uses this value to push on the screen a part of the video memory when this one is larger than the screen. --- weston/src/compositor-fbdev.c |6 ++ 1 file changed

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread Marc Chalain
2013/6/21 David Herrmann > Hi > > On Fri, Jun 21, 2013 at 12:05 PM, Marc Chalain > wrote: > > > > > > 2013/6/21 David Herrmann > >> > >> Hi > >> > >> On Fri, Jun 21, 2013 at 11:43 AM, Marc Chalain > >> wrote: > >> > > >> > 2013/6/21 David Herrmann > >> >> > >> >> Hi > >> >> > >> >> On Fri, Ju

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread David Herrmann
Hi On Fri, Jun 21, 2013 at 12:05 PM, Marc Chalain wrote: > > > 2013/6/21 David Herrmann >> >> Hi >> >> On Fri, Jun 21, 2013 at 11:43 AM, Marc Chalain >> wrote: >> > >> > 2013/6/21 David Herrmann >> >> >> >> Hi >> >> >> >> On Fri, Jun 21, 2013 at 10:49 AM, mchalain [marc.chal...@gmail.com] >> >

Re: [PATCH 03/18] evdev: automatic configuration of mtdev library support

2013-06-21 Thread Marc Chalain
2013/6/21 > On 21/06/2013 11:52, Marc Chalain wrote: > >> 2013/6/21 >> >> > >> >> On 21/06/2013 10:39, mchalain [marc.chal...@gmail.com] wrote: >>> >>> From: mchalain it allows the --disable-mtdev option at configuration. evdev.c creates empty macros for mtdev functions

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread Marc Chalain
2013/6/21 David Herrmann > Hi > > On Fri, Jun 21, 2013 at 11:43 AM, Marc Chalain > wrote: > > > > 2013/6/21 David Herrmann > >> > >> Hi > >> > >> On Fri, Jun 21, 2013 at 10:49 AM, mchalain [marc.chal...@gmail.com] > >> wrote: > >> > From: mchalain > >> > > >> > it initializes varinfo.yoffset

Re: [PATCH 03/18] evdev: automatic configuration of mtdev library support

2013-06-21 Thread sardemff7+wayland
On 21/06/2013 11:52, Marc Chalain wrote: 2013/6/21 On 21/06/2013 10:39, mchalain [marc.chal...@gmail.com] wrote: From: mchalain it allows the --disable-mtdev option at configuration. evdev.c creates empty macros for mtdev functions not availlables --- weston/configure.ac | 17 +

Re: [PATCH 03/18] evdev: automatic configuration of mtdev library support

2013-06-21 Thread Marc Chalain
2013/6/21 > On 21/06/2013 10:39, mchalain [marc.chal...@gmail.com] wrote: > >> From: mchalain >> >> it allows the --disable-mtdev option at configuration. >> evdev.c creates empty macros for mtdev functions not availlables >> >> --- >> weston/configure.ac | 17 ++--- >> west

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread David Herrmann
Hi On Fri, Jun 21, 2013 at 11:43 AM, Marc Chalain wrote: > > 2013/6/21 David Herrmann >> >> Hi >> >> On Fri, Jun 21, 2013 at 10:49 AM, mchalain [marc.chal...@gmail.com] >> wrote: >> > From: mchalain >> > >> > it initializes varinfo.yoffset. varinfo.yoffset has to >> > point on the beginning

Re: [PATCH 1/2] Handle SYN_DROPPED, filter keys with a bitmap

2013-06-21 Thread David Herrmann
Hi On Tue, Jun 4, 2013 at 8:47 PM, Martin Minarik wrote: > Since evdev keys are unreliable, they might randomly get dropped, such > as, on SYN_DROPPED. Even SYN_DROPPED is sometimes not delivered. Ugh, if events are dropped but SYN_DROPPED is missing, it's a kernel bug. Please report it to linux

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread Marc Chalain
2013/6/21 David Herrmann > Hi > > On Fri, Jun 21, 2013 at 10:49 AM, mchalain [marc.chal...@gmail.com] > wrote: > > From: mchalain > > > > it initializes varinfo.yoffset. varinfo.yoffset has to > > point on the beginning of the video memory. > > The card uses this value to push on the screen

Re: [PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread David Herrmann
Hi On Fri, Jun 21, 2013 at 10:49 AM, mchalain [marc.chal...@gmail.com] wrote: > From: mchalain > > it initializes varinfo.yoffset. varinfo.yoffset has to > point on the beginning of the video memory. > The card uses this value to push on the screen a part of > the video memory when this one

Re: [PATCH 03/18] evdev: automatic configuration of mtdev library support

2013-06-21 Thread sardemff7+wayland
On 21/06/2013 10:39, mchalain [marc.chal...@gmail.com] wrote: From: mchalain it allows the --disable-mtdev option at configuration. evdev.c creates empty macros for mtdev functions not availlables --- weston/configure.ac | 17 ++--- weston/src/evdev.c | 11 ---

[PATCH] compositor: "idle-time" option inside "core" section

2013-06-21 Thread mchalain [marc.chal...@gmail.com]
From: mchalain it reads the value of "idle-time" inside weston.ini to set the compositor->idle_time. This value continues to be updated by --idle-time argument. The manpage of weston.ini explains the use of this option --- weston/man/weston.ini.man |4 +++- weston/src/compositor.c |

[PATCH] fbdev: accept DIRECTCOLOR devices

2013-06-21 Thread mchalain [marc.chal...@gmail.com]
From: mchalain This patch allows TRUECOLOR and DIRECTCOLOR devices By default the color map is not set --- weston/src/compositor-fbdev.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/weston/src/compositor-fbdev.c b/weston/src/co

[PATCH 05/18] fbdev: initialize yoffset of varinfo

2013-06-21 Thread mchalain [marc.chal...@gmail.com]
From: mchalain it initializes varinfo.yoffset. varinfo.yoffset has to point on the beginning of the video memory. The card uses this value to push on the screen a part of the video memory when this one is larger than the screen. --- weston/src/compositor-fbdev.c |6 ++ 1 file change

[PATCH 03/18] evdev: automatic configuration of mtdev library support

2013-06-21 Thread mchalain [marc.chal...@gmail.com]
From: mchalain it allows the --disable-mtdev option at configuration. evdev.c creates empty macros for mtdev functions not availlables --- weston/configure.ac | 17 ++--- weston/src/evdev.c | 11 --- 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/west