Re: [PATCH weston 2/7] autotools: Define paths in configure.ac

2013-06-20 Thread Quentin Glidic
On 20/06/2013 21:09, Kristian Høgsberg wrote: On Tue, Jun 18, 2013 at 09:11:29AM +0200, Quentin Glidic wrote: -pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = weston.pc I'm not sure we want this, it's convention to define the *dir variable in the Makefile.am along with the dependent vari

Re: [PATCH weston 1/7] weston.pc: Add dependencies for pixman-1 and xkbcommon

2013-06-20 Thread Quentin Glidic
On 20/06/2013 21:05, Kristian Høgsberg wrote: On Tue, Jun 18, 2013 at 09:11:28AM +0200, Quentin Glidic wrote: From: Quentin Glidic Weston headers include pixman and libxkbcommon headers Signed-off-by: Quentin Glidic --- src/weston.pc.in | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCH weston] Add a weston_buffer structure to replace wl_buffer

2013-06-20 Thread Jason Ekstrand
This commit adds a weston_buffer structure to replace wl_buffer. This way we can hold onto buffers by just their resource. In order to do this, the every renderer.attach function has to fill in the weston_buffer.width and weston_buffer.height fields. Signed-off-by: Jason Ekstrand --- NOTE: Whi

[PATCH wayland 3/3] Change wl_shm_buffer to use a resource pointer

2013-06-20 Thread Jason Ekstrand
This commit also has the effect of making wl_shm_buffer no longer a wl_buffer derivative. Signed-off-by: Jason Ekstrand --- src/wayland-server.h | 5 + src/wayland-shm.c| 51 ++- 2 files changed, 19 insertions(+), 37 deletions(-) diff --g

[PATCH wayland 2/3] Change SHM wl_buffer functions to use the wl_shm_buffer structure

2013-06-20 Thread Jason Ekstrand
This commit does not break ABI. It merely changes the types of some things and adds a wl_shm_buffer_get function. Signed-off-by: Jason Ekstrand --- src/wayland-server.h | 15 ++- src/wayland-shm.c| 36 +++- 2 files changed, 25 insertions(+), 26 de

[PATCH wayland 1/3] Add a wl_resource_instance_of function

2013-06-20 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/connection.c | 8 src/wayland-private.h | 3 +++ src/wayland-server.c | 9 + src/wayland-server.h | 5 + 4 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/connection.c b/src/connection.c index b26402f..95edd6e 10

[PATCH wayland 0/3] Convert SHM buffers to a wl_shm_buffer opaque

2013-06-20 Thread Jason Ekstrand
This series converts the SHM buffers over to an opaque wl_shm_buffer structure that does NOT derive from wl_buffer. In particular, it has a resource pointer instead of using the legacy wl_buffer with inline resource. The first two patches do NOT break ABI; the third one does. Jason Ekstrand (3):

Re: [PATCH] Add a weston_buffer structure to replace wl_buffer

2013-06-20 Thread Jason Ekstrand
NEGLECT THIS PATCH New one to come On Thu, Jun 20, 2013 at 8:16 PM, Jason Ekstrand wrote: > This commit adds a weston_buffer structure to replace wl_buffer. This way > we can hold onto buffers by just their resource. In order to do this, the > every renderer.attach function has to fill in the

[PATCH] Add a weston_buffer structure to replace wl_buffer

2013-06-20 Thread Jason Ekstrand
This commit adds a weston_buffer structure to replace wl_buffer. This way we can hold onto buffers by just their resource. In order to do this, the every renderer.attach function has to fill in the weston_buffer.width and weston_buffer.height fields. --- NOTE: While this patch touches compositor

Re: [PATCH weston v2] input: check if the focus surface has a valid resource

2013-06-20 Thread Kristian Høgsberg
On Thu, Jun 20, 2013 at 06:13:07PM +0200, Giulio Camuffo wrote: > the resource can be NULL in some cases, like when the focus is > taken by the black_surface used in shell.c as fullscreen background. Yes, that looks right, it's something that would regress silently with the wl_resource changes. C

Re: [PATCH weston] compositor-drm: select the highest possible mode frequency

2013-06-20 Thread Kristian Høgsberg
On Wed, Jun 19, 2013 at 03:19:19PM +0200, Giulio Camuffo wrote: > the mode list is ordered so that the lower frequencies come > before the higher ones, so traverse the list from the end > to the beginning That seems like a better heuristic indeed, thanks. Kristian > --- > src/compositor-drm.c |

Re: [PATCH wayland] Free non-legacy resources inside wl_resource_destroy

2013-06-20 Thread Kristian Høgsberg
On Tue, Jun 18, 2013 at 12:42:40PM -0500, Jason Ekstrand wrote: > This commit makes wl_resource_destroy automatically free all non-legacy > resource structures. Since wl_resource is now an opaque structure it > doesn't make sense for the clients to be freeing it. This checks to make > sure that i

Re: [PATCH weston 2/7] autotools: Define paths in configure.ac

2013-06-20 Thread Kristian Høgsberg
On Tue, Jun 18, 2013 at 09:11:29AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > configure.ac | 26 ++ > man/Makefile.am | 2 +- > src/Makefile.am | 2 -- > src/weston.pc.in | 4 ++--

Re: [PATCH weston] shell: Free temporary strings

2013-06-20 Thread Kristian Høgsberg
On Tue, Jun 18, 2013 at 09:11:03AM +0200, Quentin Glidic wrote: > From: Quentin Glidic Thanks, applied. > Signed-off-by: Quentin Glidic > --- > src/shell.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/shell.c b/src/shell.c > index ceb963c..4447995 100644 > --- a/src/shell.c

Re: [PATCH weston 1/7] weston.pc: Add dependencies for pixman-1 and xkbcommon

2013-06-20 Thread Kristian Høgsberg
On Tue, Jun 18, 2013 at 09:11:28AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Weston headers include pixman and libxkbcommon headers > > Signed-off-by: Quentin Glidic > --- > src/weston.pc.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/weston.pc.in b/src/weston.p

Re: [PATCH weston v2] input: check if the focus surface has a valid resource

2013-06-20 Thread Jason Ekstrand
All, This looks good as far as I'm concerned. --Jason Ekstrand On Jun 20, 2013 11:15 AM, "Giulio Camuffo" wrote: > the resource can be NULL in some cases, like when the focus is > taken by the black_surface used in shell.c as fullscreen background. > --- > > sorry for the noise, v1 has spaces ins

Re: [PATCH weston 1/3] gl-renderer: Track the buffer type in gl_surface_state

2013-06-20 Thread Giulio Camuffo
This also fixes the attach of a valid buffer after attaching a NULL one. Currently the surface is showing the wrong buffer. 2013/6/11 Pekka Paalanen > On Fri, 7 Jun 2013 16:52:44 +0300 > Ander Conselvan de Oliveira > wrote: > > > Checking for gs->num_images for determining the previous buffer

[PATCH weston v2] input: check if the focus surface has a valid resource

2013-06-20 Thread Giulio Camuffo
the resource can be NULL in some cases, like when the focus is taken by the black_surface used in shell.c as fullscreen background. --- sorry for the noise, v1 has spaces instead of tabs src/input.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/input.c b/src/input.c index e670eb6.

[PATCH weston] input: check if the focus surface has a valid resource

2013-06-20 Thread Giulio Camuffo
the resource can be NULL in some cases, like when the focus is taken by the black_surface used in shell.c as fullscreen background. --- src/input.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/input.c b/src/input.c index e670eb6..9f241d5 100644 --- a/src/input.c ++

Re: [GSoC] Color management support in Wayland

2013-06-20 Thread Rafael Fonseca
Hello Kai-Uwe, On Thu, Jun 20, 2013 at 8:04 AM, Kai-Uwe Behrmann wrote: > Hello Rafael, > > Am 17.06.2013 17:28, schrieb Rafael Fonseca: > >> I'll be working on porting the color management done in Gnome (and X) >> to Wayland. I'm still on the studying and understanding the problem > > Will Gnome

Re: Wayland color management protocol proposal

2013-06-20 Thread Kai-Uwe Behrmann
(taking Richard out of CC as he replied on list) Am 19.06.2013 04:52, schrieb John Kåre Alsaker: Here is my current color management protocol for Wayland clients. The basic idea is that the compositor sends two color spaces to the clients. A compositing color space which the compositor prefers s

Re: [GSoC] Color management support in Wayland

2013-06-20 Thread Kai-Uwe Behrmann
Hello Rafael, Am 17.06.2013 17:28, schrieb Rafael Fonseca: I'll be working on porting the color management done in Gnome (and X) to Wayland. I'm still on the studying and understanding the problem Will Gnome rely on Weston as it's compositor? In other words, will your changes become available