Re: [PATCH 1/2] Handle SYN_DROPPED, filter keys with a bitmap

2013-06-11 Thread Bill Spitzak
I feel like this unreliability can be passed on to the clients. Clients are probably going to be written to assume there may be bugs in the compositor and that events will get mangled. Even if the compositor is perfect, most toolkits can mangle events themselves (ie they skip events when no wi

[PATCH 3/3] xwm: Don't set opaque region to cover window contents from X

2013-06-11 Thread MoD
Window contents cannot be assumed to be fully opaque for windows drawn with a RGBA visual. Later the optimization of setting a full opaque region can be reimplemented after checking that the windows involved aren't using RGBA visuals. The comment mentioning sampling of undefined alpha channel was

[PATCH 2/3] xwm: Check result of xcb_get_atom_name_reply

2013-06-11 Thread MoD
When printing debug information about atoms, the XWM would crash if the X server failed to respond to a request about atom names. In practice this occurred when the server itself crashed, e.g. when starting mplayer with the "xv" vo. --- src/xwayland/window-manager.c | 12 +--- 1 file chang

[PATCH 1/3] xwm: Define SEND_EVENT_MASK and EVENT_TYPE macros to clarify xcb event type checks

2013-06-11 Thread MoD
--- src/xwayland/window-manager.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c index 366f2e0..a021c76 100644 --- a/src/xwayland/window-manager.c +++ b/src/xwayland/window-manager.c @@ -89,6 +89,9 @@ struct

Things that killed my motivation to play with wayland

2013-06-11 Thread darxus
1) This mesa bug: https://bugs.freedesktop.org/show_bug.cgi?id=61919 make fails without C_INCLUDE_PATH set. It pretty much destroyed my build testing setup (I was build testing 46 related repos every few hours). I never managed to work out the obvious workaround of just setting C_INCLUDE_PATH for

[PATCH] Wayland: Add how wl_keyboard represents more keyboards

2013-06-11 Thread Martin Minarik
This has been discussed. If the user wants to be able to track multiple keyboards, they need multiple seats. The enter keys attribute means it's pressed on one or multiple seat-attached keyboards. The keys never contains duplicate keys. --- protocol/wayland.xml | 14 +- 1 file chan

[PATCH 2/2] weston input: Add the key states counters

2013-06-11 Thread Martin Minarik
This fixes the compositor, so that it delivers the correct events, when attached multiple keyboards to the same seat. This is tested under the evdev backend, perhaps it works under multiseat X. The way to verify this: 1. press A on keyboard 1 2. press A on keyboard 2 3. release A on keyboard 1 4.

[PATCH 1/2] Handle SYN_DROPPED, filter keys with a bitmap

2013-06-11 Thread Martin Minarik
Since evdev keys are unreliable, they might randomly get dropped, such as, on SYN_DROPPED. Even SYN_DROPPED is sometimes not delivered. Clients, compositor are not able to recover from duplicate press/release. This fixes this bug, thereby making the compositor and clients useable even under critica

Re: minimized and stick windows

2013-06-11 Thread Rafael Antognolli
On Thu, Jun 6, 2013 at 3:50 PM, Kristian Høgsberg wrote: > On Tue, May 28, 2013 at 1:10 PM, Rafael Antognolli > wrote: >> On Thu, May 16, 2013 at 2:12 PM, Bill Spitzak wrote: >>> >>> >>> Pekka Paalanen wrote: >>> > For example the floating shared toolbox with 2 main windows. It should >

Re: [fbdev_backend]: support of DIRECTCOLOR Frame buffer

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 16:31:17 +0200 Marc Chalain wrote: > Theoretically you have right. > But the pixel formats are defined to contains the same amounts of values > for each colors except for 16bpp format (r5g6b5 and b5g6r5 one value more > for green) and the alpha. My code is optimized for a lot

RE: The way to use system cursor and custom(client) cursor

2013-06-11 Thread 이광웅
> -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Tuesday, June 11, 2013 12:25 AM > To: Elvis Lee ("이광웅") > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: The way to use system cursor and custom(client) cursor > > On Mon, 10 Jun 2013 10:52:34 -0700 >

Re: [PATCH wayland] doc: Add a small contributing guide

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 18:21:32 +0300 Ander Conselvan de Oliveira wrote: > Document what we expect in terms of commit messages and coding style. > New contributors are usually unaware of this, so it is good to have a > document to point them too. > --- > > I probably haven't captured everything her

[PATCH wayland] doc: Add a small contributing guide

2013-06-11 Thread Ander Conselvan de Oliveira
Document what we expect in terms of commit messages and coding style. New contributors are usually unaware of this, so it is good to have a document to point them too. --- I probably haven't captured everything here and some might be my opinion and not a rule, but I think it would be good to have

Re: [compositor] idle-time configuration inside weston.ini

2013-06-11 Thread Marc Chalain
idle-time: manpage update --- man/weston.ini.man |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/man/weston.ini.man b/man/weston.ini.man index c3e5747..ae94d9b 100644 --- a/man/weston.ini.man +++ b/man/weston.ini.man @@ -103,8 +103,10 @@ directory are: .BR xwayland.so

Re: [fbdev_backend]: support of DIRECTCOLOR Frame buffer

2013-06-11 Thread Marc Chalain
Theoretically you have right. But the pixel formats are defined to contains the same amounts of values for each colors except for 16bpp format (r5g6b5 and b5g6r5 one value more for green) and the alpha. My code is optimized for a lot of cases. For the use of rcols instead cols, you have right. It's

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 15:53:42 +0200 Marc Chalain wrote: > OK I used macro instead inline function. It's the same for the compiler (in > this case). > evdev: add --disable-mtdev option to configure and bypass the mtdev > functions when the library is not available. > > --- > configure.ac | 17 +

Re: [fbdev_backend]: support of DIRECTCOLOR Frame buffer

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 15:15:29 +0200 Marc Chalain wrote: > Hello, > OK this patch now checks FB_VISUAL_DIRECTCOLOR twice but set the cmap > inside the fbdev_query_screen_info function. > I use "malloc" instead "table" declaration because it takes less memory and > it's used only once, it's useless

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Marc Chalain
OK I used macro instead inline function. It's the same for the compiler (in this case). evdev: add --disable-mtdev option to configure and bypass the mtdev functions when the library is not available. --- configure.ac | 17 ++--- src/evdev.c |9 - 2 files changed, 22 in

Re: [PATCH] weston.pc: Added libexecdir and pkglibexecdir variables

2013-06-11 Thread Eduardo Lima (Etrunko)
On 06/11/2013 04:40 AM, sardemff7+wayl...@sardemff7.net wrote: > On 11/06/2013 08:05, Pekka Paalanen wrote: >> On Mon, 10 Jun 2013 14:40:19 -0300 >> "Eduardo Lima (Etrunko)" wrote: >>> >>> I have added the pkglibexedir in an attempt to avoid crowding libexecdir >>> too much. Other than that, no sp

Re: [fbdev_backend] initialization of the first frame buffer

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 14:35:05 +0200 Marc Chalain wrote: > [PATCH] [compositor-fbdev]: set the yoffset value to 0 > The memory buffer could be twice larger than the screen size to use > double buffering. > The application writes alternatively inside each middle of the memory. > The 'yoffset' field

Re: [compositor] idle-time configuration inside weston.ini

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 14:43:46 +0200 Marc Chalain wrote: > You have right, it's the smallest of my patches, and the worst. > > [PATCH] [compositor]: add "idle-time" entry support in "core" > section of weston.ini > > --- > src/compositor.c |2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [fbdev_backend]: support of DIRECTCOLOR Frame buffer

2013-06-11 Thread Marc Chalain
Hello, OK this patch now checks FB_VISUAL_DIRECTCOLOR twice but set the cmap inside the fbdev_query_screen_info function. I use "malloc" instead "table" declaration because it takes less memory and it's used only once, it's useless to be faster. After I set the same values for each colors, because

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 14:41:18 +0200 Marc Chalain wrote: > Hello > The detection of the library is automatically done during the > configuration. The option is not useful. > > And the use #ifdef HAVE_MTDEV seems to be simpler, if in the future this > feature will disappear. > > What I do ? I send

Re: [PATCH weston 3/4] compositor-drm: Enable seat constraining when configured in weston.ini

2013-06-11 Thread Ander Conselvan de Oliveira
On 06/10/2013 05:17 PM, Rob Bradford wrote: From: Rob Bradford --- src/compositor-drm.c | 16 src/compositor.h | 2 ++ src/input.c | 2 ++ src/udev-seat.c | 3 +++ 4 files changed, 23 insertions(+) diff --git a/src/compositor-drm.c b/src/compositor-d

Re: [compositor] idle-time configuration inside weston.ini

2013-06-11 Thread Marc Chalain
You have right, it's the smallest of my patches, and the worst. [PATCH] [compositor]: add "idle-time" entry support in "core" section of weston.ini --- src/compositor.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 099600d..2002812 100644 ---

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Marc Chalain
Hello The detection of the library is automatically done during the configuration. The option is not useful. And the use #ifdef HAVE_MTDEV seems to be simpler, if in the future this feature will disappear. What I do ? I send again or I increase the complexity. Marc. 2013/6/11 Benjamin Tissoires

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Tue, Jun 11, 2013 at 12:40 PM, Pekka Paalanen wrote: > On Tue, 11 Jun 2013 12:10:05 +0200 > Benjamin Tissoires wrote: > >> On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: >> > On Tue, 11 Jun 2013 09:01:48 +0200 >> > Benjamin Tissoires wrote: >> > >> >> On Mon, Jun 10, 2013 at 8:42 AM,

Re: [fbdev_backend] initialization of the first frame buffer

2013-06-11 Thread Marc Chalain
[PATCH] [compositor-fbdev]: set the yoffset value to 0 The memory buffer could be twice larger than the screen size to use double buffering. The application writes alternatively inside each middle of the memory. The 'yoffset' field of varinfo, is used to switch from a memory part to the other. Th

Re: [PATCH weston 3/4] compositor-drm: Enable seat constraining when configured in weston.ini

2013-06-11 Thread Pekka Paalanen
Hi Rob, I think patches 2, 3, and 4 should be all squashed, and I would like to know more of what is the use case here. More questions below. On Mon, 10 Jun 2013 15:17:30 +0100 Rob Bradford wrote: > From: Rob Bradford > > --- > src/compositor-drm.c | 16 > src/compositor.h

[PATCH] cursor in editor.c now goes to a newline

2013-06-11 Thread blackwolf12333
--- clients/editor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index bfb6fe1..3786e40 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -946,8 +946,8 @@ text_entry_draw_cursor(struct text_entry *entry, cairo_t *cr)

Re: [PATCH weston 2/4] input: Add a weston_pointer_output_center

2013-06-11 Thread Pekka Paalanen
On Mon, 10 Jun 2013 15:17:29 +0100 Rob Bradford wrote: > From: Rob Bradford > > Centre the pointer on a the provided output. This function provides the > basis of ensuring that the pointer starts on the output when we start to > constrain a seat to a given output. > --- > src/compositor.h | 3

Re: [PATCH weston 1/3] gl-renderer: Track the buffer type in gl_surface_state

2013-06-11 Thread Pekka Paalanen
On Fri, 7 Jun 2013 16:52:44 +0300 Ander Conselvan de Oliveira wrote: > Checking for gs->num_images for determining the previous buffer type > when attaching is not reliable. The number of images is never cleared > in the SHM path, so after a switch from an EGL buffer to SHM, every > following at

Re: Compositor for eink device

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 12:28:21 +0200 Claudius Marpa Heine wrote: > Am Dienstag, den 11.06.2013, 12:38 +0300 schrieb Pekka Paalanen: > > On Tue, 11 Jun 2013 08:44:15 +0200 > > Claudius Marpa Heine > > wrote: > > > > Hi Claudius, > > > > that is a very cool idea for a project! > > Thank, I like t

Re: Compositor for eink device

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 12:37:33 +0200 Claudius Marpa Heine wrote: > Am Dienstag, den 11.06.2013, 13:16 +0300 schrieb Pekka Paalanen: > > On Tue, 11 Jun 2013 10:56:49 +0100 > > martin brook wrote: > > > > > Guys Hi, > > > > > > An interesting area which I've done some work on with a kobo touch, so

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 12:10:05 +0200 Benjamin Tissoires wrote: > On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: > > On Tue, 11 Jun 2013 09:01:48 +0200 > > Benjamin Tissoires wrote: > > > >> On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen > >> wrote: > >> > On Fri, 7 Jun 2013 12:11:14 +0

Re: Compositor for eink device

2013-06-11 Thread Claudius Marpa Heine
Am Dienstag, den 11.06.2013, 13:16 +0300 schrieb Pekka Paalanen: > On Tue, 11 Jun 2013 10:56:49 +0100 > martin brook wrote: > > > Guys Hi, > > > > An interesting area which I've done some work on with a kobo touch, some > > useful links at > > > > https://wiki.merproject.org/wiki/Community_Work

Re: Compositor for eink device

2013-06-11 Thread Claudius Marpa Heine
Am Dienstag, den 11.06.2013, 12:38 +0300 schrieb Pekka Paalanen: > On Tue, 11 Jun 2013 08:44:15 +0200 > Claudius Marpa Heine > wrote: > > Hi Claudius, > > that is a very cool idea for a project! Thank, I like to hear that ;) > > Someone from the mobileread forum already implemented a open sour

Re: Compositor for eink device

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 10:56:49 +0100 martin brook wrote: > Guys Hi, > > An interesting area which I've done some work on with a kobo touch, some > useful links at > > https://wiki.merproject.org/wiki/Community_Workspace/kobo Ok, only static pseudocolor, of course. Hopefully that matches PIXMAN_g

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: > On Tue, 11 Jun 2013 09:01:48 +0200 > Benjamin Tissoires wrote: > >> On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: >> > On Fri, 7 Jun 2013 12:11:14 +0200 >> > Marc Chalain wrote: >> > >> >> mtdev is not necessary on some device (d

Re: [PATCH] cursor in editor.c now goes to a newline

2013-06-11 Thread Pekka Paalanen
On Mon, 10 Jun 2013 22:18:12 +0200 blackwolf12333 wrote: > --- > clients/editor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/clients/editor.c b/clients/editor.c > index d4e4e92..df82ed0 100644 > --- a/clients/editor.c > +++ b/clients/editor.c > @@ -946,8 +946,8

Re: Compositor for eink device

2013-06-11 Thread martin brook
Guys Hi, An interesting area which I've done some work on with a kobo touch, some useful links at https://wiki.merproject.org/wiki/Community_Workspace/kobo On Tue, Jun 11, 2013 at 10:38 AM, Pekka Paalanen wrote: > On Tue, 11 Jun 2013 08:44:15 +0200 > Claudius Marpa Heine > wrote: > > > Hi f

Re: [ISSUE] shadow buffer not copied inside the frame buffer

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 11:29:30 +0200 Marc Chalain wrote: > Hello > Then when I start weston with: > --backend=fbdev-backend.so --modules=tablet-shell.so --device=/dev/fb0 > desktop-shell.so and tablet-shell.so seem to be started in the same time > and tablet-shell.so cover some parts of desktop-sh

Re: Compositor for eink device

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 08:44:15 +0200 Claudius Marpa Heine wrote: > Hi folks, > > for my master thesis in computer science I am looking into implementing > a wayland-compositor for eink devices (specifically for a Kobo Glo > Reader I own). For the record I am currently only looking into it, so > n

Re: [ISSUE] shadow buffer not copied inside the frame buffer

2013-06-11 Thread Marc Chalain
Hello Then when I start weston with: --backend=fbdev-backend.so --modules=tablet-shell.so --device=/dev/fb0 desktop-shell.so and tablet-shell.so seem to be started in the same time and tablet-shell.so cover some parts of desktop-shell.so. if I start weston with: --backend=fbdev-backend.so --devic

[ISSUE] shadow buffer not copied inside the frame buffer

2013-06-11 Thread Marc Chalain
Hi, Since Monday, my screen is black. I make test and when I write some colors directly inside the frame buffer, they appear. To be clearer I added inside fbdev_output_repaint { unsigned short color=0xA55A; int i; for (i = 0; i < output->fb_info.buffer_length / 2; i+=2)

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 09:01:48 +0200 Benjamin Tissoires wrote: > On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: > > On Fri, 7 Jun 2013 12:11:14 +0200 > > Marc Chalain wrote: > > > >> mtdev is not necessary on some device (desktop or set-top-box). For > >> embedded solution the minimum of

Re: [PATCH] weston.pc: Added libexecdir and pkglibexecdir variables

2013-06-11 Thread sardemff7+wayland
On 11/06/2013 08:05, Pekka Paalanen wrote: On Mon, 10 Jun 2013 14:40:19 -0300 "Eduardo Lima (Etrunko)" wrote: I have added the pkglibexedir in an attempt to avoid crowding libexecdir too much. Other than that, no special reason. Ok, so should the weston install paths be adjusted to pkglibex

Re: [PATCH weston v2 4/4] weston.pc: Provide moduledir

2013-06-11 Thread sardemff7+wayland
On 10/06/2013 18:23, Othman, Ossama wrote: Hi, --- a/src/Makefile.am +++ b/src/Makefile.am @@ -94,7 +94,6 @@ westoninclude_HEADERS = \ ../shared/matrix.h \ ../shared/config-parser.h -moduledir = $(libdir)/weston module_LTLI

Re: The way to use system cursor and custom(client) cursor

2013-06-11 Thread Pekka Paalanen
On Mon, 10 Jun 2013 10:52:34 -0700 Elvis Lee(이광웅) wrote: > > -Original Message- > > From: wayland-devel-bounces+kwangwoong.lee=lge@lists.freedesktop.org > > [mailto:wayland-devel-bounces+kwangwoong.lee=lge@lists.freedesktop.org] > > On Behalf Of Pekka Paalanen > > Sent: Sunday, Ju

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: > On Fri, 7 Jun 2013 12:11:14 +0200 > Marc Chalain wrote: > >> mtdev is not necessary on some device (desktop or set-top-box). For >> embedded solution the minimum of dependencies is required. "configure" >> accepts the --disable-mtdev option