Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Pekka Paalanen
On Mon, 15 Apr 2013 12:39:21 -0700 Bill Spitzak wrote: > Pekka Paalanen wrote: > > > Alright. I'm not too familiar with toolkits, so could you explain > > why toolkits need to access the selection at arbitrary times > > (specifically while unfocused), instead of only as a response to > > direct

1.1 Released

2013-04-15 Thread Kristian Høgsberg
Hello, It's now a week ago that I tagged the 1.0.90 release candidate for wayland and weston and not much happened in the interim. Philipp sent a couple of good weston fixes, which I've merged as well as the fix from Hardening for extended RDP keycodes. For wayland I commited a docs dist fix, bu

Wayland cut/copy/paste better than in X11?

2013-04-15 Thread Jiergir Ogoerg
Hi, Between application running on X11 apparently there's no standard way to tell if file(s) (their URIs) have been "cut" or "copied" into the clipboard, so you don't know what to do on "Paste", so people invented (silly) workarounds as explained here [1]: "Since there is no standard way to copy a

Re: [PATCH] Override modules list and don't always load desktop-shell.so

2013-04-15 Thread Kristian Høgsberg
On Sun, Apr 14, 2013 at 07:17:40PM +0200, Pier Luigi Fiorini wrote: > Let --modules override modules list and load desktop-shell.so as a > fallback if a modules list is not specified neither by passing > --modules nor with weston.ini. > > Signed-off-by: Pier Luigi Fiorini > --- > man/weston.man

Re: [PATCH weston v2] shell: clear popup grab interface on remove_popup_grab and popup_grab_end

2013-04-15 Thread Kristian Høgsberg
On Mon, Apr 15, 2013 at 09:09:54PM +0200, Philipp Brüschweiler wrote: > Fixes a segfault. Steps to reproduce: > > * start weston with the x11 backend > * open a terminal > * click on the icon in the top left corner, choose close > * close the x11 window containing weston > --- > src/shell.c | 3 +

Re: [PATCH weston v2] desktop-shell: better error logging

2013-04-15 Thread Kristian Høgsberg
On Mon, Apr 15, 2013 at 08:10:40PM +0200, Philipp Brüschweiler wrote: > v2: only call cairo_surface_status once > --- > clients/desktop-shell.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Thanks, applied. > diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c > index

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Bill Spitzak
Pekka Paalanen wrote: Alright. I'm not too familiar with toolkits, so could you explain why toolkits need to access the selection at arbitrary times (specifically while unfocused), instead of only as a response to direct user input (which in all relevant cases assigns the focus first)? I sure

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Bill Spitzak
Pekka Vuorela wrote: What I mean is it breaks the api, the api provided by toolkits to access clipboard will not work at any time, a constraint that doesn't exist in any other systems. Breaks how? On Qt you get clipboard by instantiating QClipboard which takes mode (global clipboard, selection

Re: [PATCH weston v2] shell: clear popup grab interface on remove_popup_grab and popup_grab_end

2013-04-15 Thread Giulio Camuffo
Thanks, looks good to me. 2013/4/15 Philipp Brüschweiler > Fixes a segfault. Steps to reproduce: > > * start weston with the x11 backend > * open a terminal > * click on the icon in the top left corner, choose close > * close the x11 window containing weston > --- > src/shell.c | 3 +++ > 1 fi

Re: [PATCH 0/5] Improve text protocol

2013-04-15 Thread Bill Spitzak
Jan Arne Petersen wrote: * Changes offsets to be Unicode character instead of byte based No, PLEASE DON'T DO THIS!!! You think you are making things "easier" but you are making it much much harder. You may not believe it, but "how many characters are in this UTF-8" will generate dozens of d

[PATCH weston v2] shell: clear popup grab interface on remove_popup_grab and popup_grab_end

2013-04-15 Thread Philipp Brüschweiler
Fixes a segfault. Steps to reproduce: * start weston with the x11 backend * open a terminal * click on the icon in the top left corner, choose close * close the x11 window containing weston --- src/shell.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shell.c b/src/shell.c index de5d

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Bill Spitzak
Yichao Yu wrote: I think a request that says "send me the next change the the clipboard" would work and match how Wayland is designed more than an api where the client turns "send me clipboard changes" on/off. Send next change will not work since it won't allow the client to know the content r

Re: [PATCH weston] shell: clear popup grab interface on remove_popup_grab

2013-04-15 Thread Giulio Camuffo
Right, that was needed, thanks. I have a comment below, other than that it looks good to me. 2013/4/15 Philipp Brüschweiler > Fixes a segfault. Steps to reproduce: > > * start weston with the x11 backend > * open a terminal > * click on the icon in the top left corner, choose close > * close th

[PATCH weston] shell: clear popup grab interface on remove_popup_grab

2013-04-15 Thread Philipp Brüschweiler
Fixes a segfault. Steps to reproduce: * start weston with the x11 backend * open a terminal * click on the icon in the top left corner, choose close * close the x11 window containing weston --- src/shell.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shell.c b/src/shell.c index de5d6

[PATCH weston v2] desktop-shell: better error logging

2013-04-15 Thread Philipp Brüschweiler
v2: only call cairo_surface_status once --- clients/desktop-shell.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index 41e7daa..38af6c6 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -519,13 +519

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Pekka Vuorela
On ma, 2013-04-15 at 10:05 -0400, Yichao Yu wrote: > On Mon, Apr 15, 2013 at 9:44 AM, Pekka Paalanen wrote: > >> > >> Clipboard manager (or all other programs that need clipboard > >> monitoring) may be special, but I don't see why it is necessary to > >> break every single toolkits' api by don't

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Pekka Paalanen
On Mon, 15 Apr 2013 10:05:44 -0400 Yichao Yu wrote: > On Mon, Apr 15, 2013 at 9:44 AM, Pekka Paalanen wrote: > > On Mon, 15 Apr 2013 09:08:44 -0400 > > Yichao Yu wrote: > > > >> On Mon, Apr 15, 2013 at 5:00 AM, Pekka Paalanen > >> wrote: > >> > On Mon, 15 Apr 2013 04:03:43 -0400 > >> > Yichao

Re: [PATCH 1/5] text: Fix serials handling and use Unicode offsets

2013-04-15 Thread Rob Bradford
On Mon, Apr 15, 2013 at 01:37:15PM +0200, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Simplify the serial handling and document it better. > > Also use Unicode character offsets instead of byte offsets. Could this perhaps be two patches? Cheers, Rob

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Rob Bradford
On Mon, Apr 15, 2013 at 10:05:44AM -0400, Yichao Yu wrote: > > Alright. I'm not too familiar with toolkits, so could you explain why > > toolkits need to access the selection at arbitrary times (specifically > > while unfocused), instead of only as a response to direct user input > > (which in all

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Yichao Yu
On Mon, Apr 15, 2013 at 9:44 AM, Pekka Paalanen wrote: > On Mon, 15 Apr 2013 09:08:44 -0400 > Yichao Yu wrote: > >> On Mon, Apr 15, 2013 at 5:00 AM, Pekka Paalanen >> wrote: >> > On Mon, 15 Apr 2013 04:03:43 -0400 >> > Yichao Yu wrote: >> > >> >> On Mon, Apr 15, 2013 at 3:45 AM, Pekka Paalanen

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Pekka Paalanen
On Mon, 15 Apr 2013 09:08:44 -0400 Yichao Yu wrote: > On Mon, Apr 15, 2013 at 5:00 AM, Pekka Paalanen > wrote: > > On Mon, 15 Apr 2013 04:03:43 -0400 > > Yichao Yu wrote: > > > >> On Mon, Apr 15, 2013 at 3:45 AM, Pekka Paalanen > >> wrote: > >> > On Sun, 14 Apr 2013 21:45:37 -0400 > >> > Yicha

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Yichao Yu
On Mon, Apr 15, 2013 at 5:00 AM, Pekka Paalanen wrote: > On Mon, 15 Apr 2013 04:03:43 -0400 > Yichao Yu wrote: > >> On Mon, Apr 15, 2013 at 3:45 AM, Pekka Paalanen >> wrote: >> > On Sun, 14 Apr 2013 21:45:37 -0400 >> > Yichao Yu wrote: >> > >> >> On Sun, Apr 14, 2013 at 9:33 PM, Matthias Clasen

[PATCH 5/5] text: Rename input_method to wl_input_method

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Also rename input_method_context to wl_input_method_context, input_panel to wl_input_panel and input_panel_surface to wl_input_panel_surface. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 162 ++--- clients/wes

[PATCH 4/5] text: Improve protocol documentation.

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 87 +++ protocol/text.xml | 6 ++-- 2 files changed, 70 insertions(+), 23 deletions(-) diff --git a/protocol/input-method.xml b/protocol/input-method.xm

[PATCH 2/5] text: Rename text_input to wl_text_input

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Signed-off-by: Jan Arne Petersen --- clients/editor.c | 118 ++--- clients/keyboard.c | 10 ++--- protocol/text.xml | 8 ++-- src/control.c | 2 +- src/text-backend.c | 34 +++ tests/text-test.c |

[PATCH 3/5] text: Rename ::set_panel to ::set_overlay_panel

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen Also add documentation to input_panel_surface::set_overlay_panel. Signed-off-by: Jan Arne Petersen --- protocol/input-method.xml | 8 ++-- src/input-panel.c | 6 +++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/protocol/input-method.xml

[PATCH 0/5] Improve text protocol

2013-04-15 Thread Jan Arne Petersen
From: Jan Arne Petersen This patch series: * Fixes serials handling in text protocol * Changes offsets to be Unicode character instead of byte based * Adds documentation to the protocols * Adds wl_ prefixes to the interfaces. It is based on the previous "Extend text protocol for IBus support" J

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Rob Bradford
On 15 April 2013 02:33, Matthias Clasen wrote: > On Fri, Apr 12, 2013 at 1:33 PM, Yichao Yu wrote: >> A lot of useful features require clipboard access and monitoring >> without having a keyboard focus, e.g. clipboard action (klipper[1] and >> some download agents), command line access (IPython's

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Pekka Paalanen
On Mon, 15 Apr 2013 04:03:43 -0400 Yichao Yu wrote: > On Mon, Apr 15, 2013 at 3:45 AM, Pekka Paalanen > wrote: > > On Sun, 14 Apr 2013 21:45:37 -0400 > > Yichao Yu wrote: > > > >> On Sun, Apr 14, 2013 at 9:33 PM, Matthias Clasen > >> wrote: > >> > On Fri, Apr 12, 2013 at 1:33 PM, Yichao Yu >

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread nil
Yichao Yu writes: > On Mon, Apr 15, 2013 at 3:45 AM, Pekka Paalanen wrote: > > Allowing command line utilities the access to clipboard contents (or > > to take screenshots, equivalently), is a problem. Enabling them enables > > all spy programs, too. I'm not sure we can both enable them and stay

Re: [PATCH weston] desktop-shell: better error logging

2013-04-15 Thread Siddharth Heroor
On Sat, Apr 13, 2013 at 1:15 PM, Philipp Brüschweiler wrote: > --- > clients/desktop-shell.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c > index 41e7daa..ce2366d 100644 > --- a/clients/desktop-shell.c > +++ b/client

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Yichao Yu
On Mon, Apr 15, 2013 at 3:45 AM, Pekka Paalanen wrote: > On Sun, 14 Apr 2013 21:45:37 -0400 > Yichao Yu wrote: > >> On Sun, Apr 14, 2013 at 9:33 PM, Matthias Clasen >> wrote: >> > On Fri, Apr 12, 2013 at 1:33 PM, Yichao Yu >> > wrote: >> >> A lot of useful features require clipboard access and

Re: [PATCH] selection: send selection events to all connected clients

2013-04-15 Thread Pekka Paalanen
On Sun, 14 Apr 2013 21:45:37 -0400 Yichao Yu wrote: > On Sun, Apr 14, 2013 at 9:33 PM, Matthias Clasen > wrote: > > On Fri, Apr 12, 2013 at 1:33 PM, Yichao Yu > > wrote: > >> A lot of useful features require clipboard access and monitoring > >> without having a keyboard focus, e.g. clipboard ac