glmark2 ported to wayland by Rafał Mielniczuk

2013-04-04 Thread darxus
An open source GLES2 / GL benchmark. It's been accepted upstream: https://code.launchpad.net/~kruk87/glmark2/glmark2-wayland/+merge/156907 https://launchpad.net/glmark2 https://afrantzis.wordpress.com/2011/12/16/glmark2-more-than-a-benchmark/ I just successfully tested it. Although on EGL the fr

Re: [PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 11:24:42PM +0200, Giulio Camuffo wrote: > Nowhere in Weston. But i thought it was the accepted policy to not have > around links not initted. But if it not it's no problem. No, it depends on the link. In some cases we want to be able to remove a link without worrying about

Re: [PATCH weston 3/4] shell: Use pid when binding the client shell

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 06:07:39PM -0300, Tiago Vignatti wrote: > If a shell client decides to call wl_display_connect more than once and only > later bind the desktop_shell interface, then the logic that uses the client > pointer fails, because the current client trying to connect won't match with

Re: [PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Giulio Camuffo
Nowhere in Weston. But i thought it was the accepted policy to not have around links not initted. But if it not it's no problem. Giulio 2013/4/4 Kristian Høgsberg > On Thu, Apr 04, 2013 at 11:08:22PM +0200, Giulio Camuffo wrote: > > --- > > src/compositor.c | 1 + > > 1 file changed, 1 insert

Re: [PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 11:08:22PM +0200, Giulio Camuffo wrote: > --- > src/compositor.c | 1 + > 1 file changed, 1 insertion(+) When is this needed? I don't think we rely on layer_link being valid when a surface is not mapped (not in any layer). Kristian > diff --git a/src/compositor.c b/src/

Re: [PATCH] protocol: input documentation fixes

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 11:06:02AM +1000, Peter Hutterer wrote: > Fix summary for wl_touch::motion, extend summary for wl_touch::down to match > up/motion a bit better. > > Fix a typo in wl_touch, and claim that it's zero or more update events, not > one or more. > > Signed-off-by: Peter Hutterer

[PATCH weston] compositor: init the layer_link after removing it

2013-04-04 Thread Giulio Camuffo
--- src/compositor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compositor.c b/src/compositor.c index 3645b04..88f083c 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -977,6 +977,7 @@ weston_surface_unmap(struct weston_surface *surface) weston_surface_damage_below(surf

[PATCH weston 3/4] shell: Use pid when binding the client shell

2013-04-04 Thread Tiago Vignatti
If a shell client decides to call wl_display_connect more than once and only later bind the desktop_shell interface, then the logic that uses the client pointer fails, because the current client trying to connect won't match with the first one assigned there. In special, GTK+ is connecting twice e

[PATCH weston 2/4] shell: Add config options to set the client shell

2013-04-04 Thread Tiago Vignatti
We're now able to set "client-path=path" in "shell-plugin" section for picking a particular shell client. Signed-off-by: Tiago Vignatti --- man/weston.ini.man |3 +++ src/shell.c|9 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/man/weston.ini.man b/man/

[PATCH weston 1/4] shell: Split plugin and client configure sections

2013-04-04 Thread Tiago Vignatti
Before we were using 'shell' section for both the plugin and client configurations. This commit separates in 'shell-plugin' and 'shell-client', for organization matters. Signed-off-by: Tiago Vignatti --- clients/desktop-shell.c |2 +- clients/window.c|2 +- man/weston.ini.man

[PATCH weston 4/4] shell: Fix client shell pointer assignment

2013-04-04 Thread Tiago Vignatti
weston_client_launch() might return a client pointer that will not be the actual one the shell client is binding. Therefore, assign the pointer only later after the interface is already bound. Signed-off-by: Tiago Vignatti --- src/shell.c |9 +++-- 1 file changed, 3 insertions(+), 6 dele

Re: [PATCH RFC] doc: coerce doxygen into grouping man pages more sensibly

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 11:18:33AM +1000, Peter Hutterer wrote: > The \file comment at the top is required to tell doxygen that this file > actually has members (or use EXTRACT_ALL, which in our setup has the same > effect since we restrict the source files) > > By default, all function's man page

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Matthias Clasen
On Thu, Apr 4, 2013 at 3:01 PM, Bill Spitzak wrote: > Kristian Høgsberg wrote: > > I was completely confusing corners of surfaces with corners of outputs, > sorry. He is talking about fixed locations on the screen that are usually > called "hot corners" and other terms. > > I think however that "

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Matthias Clasen
On Thu, Apr 4, 2013 at 2:58 AM, John Kåre Alsaker wrote: > I don't see a GLib event loop, so I'm curious to how the signals work. Just ftr (and without actually looking at the patch): glib signals don't need an event loop, they're entirely synchronous. ___

Re: [PATCH] tweak rounding on weston-terminal resize

2013-04-04 Thread Jason Woofenden
Thank you Pekka Paalanen and Kristian Høgsberg for your review and feedback. I can't believe I forgot to compile and test again before sending in that patch. I played with it a bit before refactoring, and I like the way it looked/responded while resizing. But now (thanks to Kristian) that I think

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Giulio Camuffo
2013/4/4 Bill Spitzak > Kristian Høgsberg wrote: > > I'm not sure if this is what Bill is getting at, but there is a >> problem with just unconditionally triggering motion bindings. If >> you're moving or resizing a window and move the pointer to the corner, >> you don't want to make that trigg

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Richard Hughes
On 4 April 2013 19:52, Bill Spitzak wrote: > These gamma ramps are an attempt to simulate a color conversion from some > color space (sRGB?) to the color space of the output device. Not really, the gamma ramps just affect the gamma response and the display whitepoint. You can't do color gamut map

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Bill Spitzak
Kristian Høgsberg wrote: I'm not sure if this is what Bill is getting at, but there is a problem with just unconditionally triggering motion bindings. If you're moving or resizing a window and move the pointer to the corner, you don't want to make that trigger an expose effect or such. I was

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Giulio Camuffo
2013/4/4 Kristian Høgsberg > On Thu, Apr 4, 2013 at 1:54 PM, Giulio Camuffo > wrote: > > There is no protocol for the client to tell the server if it used a > motion > > event. > > But even if there was i don't think it should. The event is still > delivered > > to the client, it isn't eaten, so

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Bill Spitzak
Richard Hughes wrote: On 4 April 2013 19:08, Bill Spitzak wrote: Are clients supposed to tell the compositor what color space their buffer is, and the compositor then converts to the output's color space as part of the compositing step? At the moment I'm just implementing the calibration st

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 4, 2013 at 1:54 PM, Giulio Camuffo wrote: > There is no protocol for the client to tell the server if it used a motion > event. > But even if there was i don't think it should. The event is still delivered > to the client, it isn't eaten, so the client can still do whatever it wants, >

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Richard Hughes
On 4 April 2013 19:08, Bill Spitzak wrote: > Are clients supposed to tell the compositor what color space their buffer > is, and the compositor then converts to the output's color space as part of > the compositing step? At the moment I'm just implementing the calibration state setting, i.e. sett

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Richard Hughes
On 4 April 2013 19:21, Kai-Uwe Behrmann wrote: > Parsing of ICC profiles inside weston is not nice. That would be better > abstracted out to lay inside the CMS plugins. Those CMS plugins can link > against lcms or whatever CMM they prefere. Well, we could certainly add some abstraction to get 3 a

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Kai-Uwe Behrmann
Am 03.04.2013 21:47, schrieb Richard Hughes: Patch 1 adds the framework code, patch 2 adds the ability to load CMS modules, and patch 3 adds a CMS module written for colord. With those People have a hard time to understand ICC and colour termininology. So some annotations to that first. A CMS

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Bill Spitzak
Giulio Camuffo wrote: There is no protocol for the client to tell the server if it used a motion event. But even if there was i don't think it should. The event is still delivered to the client, it isn't eaten, so the client can still do whatever it wants, but what's more important is that n

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Bill Spitzak
How is this intended to work in Wayland? Are clients supposed to tell the compositor what color space their buffer is, and the compositor then converts to the output's color space as part of the compositing step? Problems with this: * We need a reliable way for clients to tell compositor wha

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Giulio Camuffo
There is no protocol for the client to tell the server if it used a motion event. But even if there was i don't think it should. The event is still delivered to the client, it isn't eaten, so the client can still do whatever it wants, but what's more important is that no client should change the sh

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Bill Spitzak
No this is the right message. The problem is that only the client knows "when the mouse hits an output corner" (or more accurately, the client is the only one that knows "the mouse is not pointing at something of mine that should do something other than a shell effect"). Therefore any "effect

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Giulio Camuffo
Hmm, did you reply to the right mail? This has nothing to do with resizing. 2013/4/4 Bill Spitzak > > > Giulio Camuffo wrote: > >> when a mouse is moved the binding handler is called, passing it the >> mouse position and the timestamp. a shell plugin can use this to >> activate an effect when t

Re: [PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Bill Spitzak
Giulio Camuffo wrote: when a mouse is moved the binding handler is called, passing it the mouse position and the timestamp. a shell plugin can use this to activate an effect when the mouse hits an output corner. Any preview of resize must be after the client tells the compositor that it will

Re: [PATCH] tweak rounding on weston-terminal resize

2013-04-04 Thread Kristian Høgsberg
On Thu, Apr 04, 2013 at 11:00:50AM -0400, Jason Woofenden wrote: > --- > clients/terminal.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/clients/terminal.c b/clients/terminal.c > index e80e0e5..81edd25 100644 > --- a/clients/terminal.c > +++ b/clients/termin

Re: [PATCH] tweak rounding on weston-terminal resize

2013-04-04 Thread Pekka Paalanen
On Thu, 4 Apr 2013 11:00:50 -0400 Jason Woofenden wrote: > --- > clients/terminal.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/clients/terminal.c b/clients/terminal.c > index e80e0e5..81edd25 100644 > --- a/clients/terminal.c > +++ b/clients/terminal.c

[PATCH wayland] wayland-client: Avoid null dereference when handling deletion

2013-04-04 Thread Rob Bradford
From: Rob Bradford If an unknown id is deleted then the lookup in the map will return NULL and so we should avoid dereferencing that. As this is unexpected behaviour log a message about the problem too. --- src/wayland-client.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --

Re: [patches] Add a color management framework to weston

2013-04-04 Thread John Kåre Alsaker
You can move the output->base.updated_color_profile assignment down to the other of the vfunc initializations. You should remove the destroy and user_data fields from weston_color_profile. weston_cms_create_profile and weston_cms_load_profile should just return a pointer to weston_color_profile.

Re: [patches] Add a color management framework to weston

2013-04-04 Thread Richard Hughes
On 4 April 2013 07:58, John Kåre Alsaker wrote: > The weston_color_manager struct could lose the state field All fixed in the newest patchset, thanks for your detailed review. > I don't see a GLib event loop, so I'm curious to how the signals work. As discussed on IRC, I've used a thread fo

[PATCH] tweak rounding on weston-terminal resize

2013-04-04 Thread Jason Woofenden
--- clients/terminal.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index e80e0e5..81edd25 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @@ -757,11 +757,13 @@ resize_handler(struct widget *widget, i

Hello, and a small patch

2013-04-04 Thread Jason Woofenden
Hello all, I've recently decided to join this project. I've been been quite vocal on IRC these last few days (nick: JasonWoof) and now I'm finally on the mailing list. My intention is to work on a tiling window environment and participate in discussions with the primary goal of making sure that w

Re: More about clipboard and selection in wayland

2013-04-04 Thread Yichao Yu
Anyone know about clipboard? On Sat, Mar 30, 2013 at 11:39 PM, Yichao Yu wrote: > Hi, > > I have already sent a email about the clipboard and selection in > wayland a few weeks ago[1] (mainly about middle button paste). After > reading more about clipboard and selection protocol in wayland, I h

[PATCH weston] compositor: add a mouse motion binding type

2013-04-04 Thread Giulio Camuffo
when a mouse is moved the binding handler is called, passing it the mouse position and the timestamp. a shell plugin can use this to activate an effect when the mouse hits an output corner. --- src/bindings.c | 36 src/compositor.c | 8 src/composit