Re: [PATCH v2 weston] evdev: Mouse speed and acceleration

2013-04-01 Thread Peter Hutterer
On Sun, Mar 31, 2013 at 10:04:44PM +0200, Martin Minarik wrote: > Computes an accurate velocity instead of approximation. > > Changes: > Add disclaimer. Implements 8 acceleration profiles taken from X ptrveloc.c. > The sampling has been fixed to handle eventual time overflow. Since we added them

Re: Setting the display calibration ramps using weston

2013-04-01 Thread Graeme Gill
Kristian Høgsberg wrote: So for something like weston, where we store our configuration in weston.ini, I'd expect that we add a config key to set the gamma (is this just a number like what xgamma takes? or one for red, green and blue?) per output in weston.ini. In general it's not a number, it

Re: protocol questions

2013-04-01 Thread Kristian Høgsberg
On Sat, Mar 30, 2013 at 06:17:30PM -0700, Thiago Macieira wrote: > On sábado, 30 de março de 2013 17.52.33, Nick Kisialiou wrote: > > What about "long int" type to store the time stamps? Even in microseconds > > it will take longer than 100 years to overflow 2^63. > > That requires changing the pr

Re: Setting the display calibration ramps using weston

2013-04-01 Thread Kristian Høgsberg
On Sun, Mar 31, 2013 at 06:24:30PM +0100, Richard Hughes wrote: > krh mentioned in a G+ post that I should add to weston functionality > to set the output gamma ramps for color calibration. Does anyone have > any ideas on where I should start? I'm familiar with color stuff, but > the Weston interna

[PATCH 3/4] doc: create a fake make target to de-duplicate the xml merging process

2013-04-01 Thread Peter Hutterer
The only difference between the server and client xml files is the directories and files being named *server* and *client*, respectively. Add a new make target to get that process done to avoid duplication Signed-off-by: Peter Hutterer --- doc/Wayland/Makefile.am | 37 ---

[PATCH 2/4] doc: generate server documentation from XML too

2013-04-01 Thread Peter Hutterer
Same as WaylandClientAPI.xml we now also generate WaylandServerAPI.xml for publication. Most of this hunk is just adding a client/ or server/ into the xml path to keep the two separate. The change in wayland.doxygen now causes a standard doxygen call to not generate anything - what is generated is

[PATCH 1/4] doc: generate man pages from doxygen

2013-04-01 Thread Peter Hutterer
Create client-side and server-side man pages from doxygen. The doxygen config options are virtually the same as for the XML output, but we do pass in the specific options via stdin. WL_EXPORT is predefined to the empty string, it makes the man page look confusing and provides no value here anyway.

[PATCH 0/4] doc: auto-generate man pages and server documentation

2013-04-01 Thread Peter Hutterer
Patches 2 and 3 can be merged into one, I just left them separate because it makes them easier to understand. As for the server man pages - not overly useful at the moment since there's not enough doxygen info in the source files. Cheers, Peter ___ w

Re: [PATCH 00/21] Documentation improvements

2013-04-01 Thread Kristian Høgsberg
On Sat, Mar 30, 2013 at 01:11:26AM -0400, matthias.cla...@gmail.com wrote: > From: Matthias Clasen > > Hi, I spent some time going over the documentation, trying > to fill gaps in my understanding - and in the documentation. Thanks Matthias, that all looks good to me. The only thing I spotted w

Re: [PATCH 2/3] protocol: document wl_pointer, wl_keyboard, wl_touch

2013-04-01 Thread Peter Hutterer
On Tue, Apr 02, 2013 at 09:58:17AM +1000, Peter Hutterer wrote: > Most of this should be clear, but let's spell a few things out. > > Signed-off-by: Peter Hutterer > --- ok, now seeing that Matthias has worked on this as well, there's going to be some overlap so best to ignore this one I guess.

[PATCH 18/18] doc: don't start a variable list if we have no sub-elements

2013-04-01 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- doc/Wayland/doxygen-to-publican.xsl | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/doc/Wayland/doxygen-to-publican.xsl b/doc/Wayland/doxygen-to-publican.xsl index 864237c..160b124 100644 --- a/doc/Wayland/doxygen-to-publican.xsl

[PATCH 17/18] doc: improve formatting of client-side documentation

2013-04-01 Thread Peter Hutterer
A bunch of changes to the xsl transformation stylesheet to make Chapter 4 (Client API) look nicer and more readable. Main changes: - function synopsis listed - lists for parameters and return values - long function descriptions - misc other hooks for "see also", "note", etc The long description i

[PATCH 16/18] doc: change wording in section introduction

2013-04-01 Thread Peter Hutterer
If we don't have descriptions of classes, the "And" is awkward. Signed-off-by: Peter Hutterer --- doc/Wayland/doxygen-to-publican.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Wayland/doxygen-to-publican.xsl b/doc/Wayland/doxygen-to-publican.xsl index 5e5d6f4..2e3e

[PATCH 15/18] doc: add wayland.doxygen as target dependency

2013-04-01 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- doc/doxygen/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am index 957aa3d..fdbb246 100644 --- a/doc/doxygen/Makefile.am +++ b/doc/doxygen/Makefile.am @@ -6,7 +6,7 @@ scanned_src_fil

[PATCH 13/18] doc: explain the publican build process

2013-04-01 Thread Peter Hutterer
This makefile is a bit hard to read due to some publican requirements and the need to generate some files through XSLT. Explain the lot, so that those looking at this roughly know what will hit them. Signed-off-by: Peter Hutterer --- doc/Wayland/Makefile.am | 17 + 1 file changed

[PATCH 12/18] doc: clarify how ClientAPI.xml is built

2013-04-01 Thread Peter Hutterer
I found the comment a bit confusing and it's quite hard to read. re-explain with a simple step-by-step list Signed-off-by: Peter Hutterer --- doc/Wayland/Makefile.am | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/Wayland/Makefile.am b/doc/Wayland/Makefile.am ind

[PATCH 11/18] doc: Format Chapter 4 paragraphs correctly

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti Signed-off-by: Tiago Vignatti --- doc/Wayland/doxygen-to-publican.xsl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/Wayland/doxygen-to-publican.xsl b/doc/Wayland/doxygen-to-publican.xsl index 3ddcbd3..5e5d6f4 100644 --- a/doc/Wayland/doxygen-

[PATCH 10/18] doc: Add our own Legal Notice

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti Previously, Publican was auto-generating a file with it and systems that don't have such tool can't benefit from it. This patch adds our own copy of Legal Notice. Signed-off-by: Tiago Vignatti Signed-off-by: Peter Hutterer --- doc/Wayland/en_US/Book_Info.xml | 11

[PATCH 09/18] doc: minor title wording fix

2013-04-01 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- doc/Wayland/en_US/Introduction.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Wayland/en_US/Introduction.xml b/doc/Wayland/en_US/Introduction.xml index 51e451e..b3b89e7 100644 --- a/doc/Wayland/en_US/Introduction.xml +++ b/doc/Waylan

[PATCH 08/18] doc: Capitalize all Wayland occurrences

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti Signed-off-by: Tiago Vignatti Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- doc/Wayland/en_US/Architecture.xml | 10 +- doc/Wayland/en_US/Book_Info.xml| 2 +- doc/Wayland/en_US/Compositors.xml | 12 ++-- doc/Wayland/en_US/Protocol.xml

[PATCH 07/18] doc: Improve "Library" chapter, moving "Types of Compositor" as its section

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti It was added a "Server API" section and "Types of Compositor" was moved there also. I hope this gives a better structure for the documentation. Signed-off-by: Tiago Vignatti Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- doc/Wayland/en_US/Compositors.xml |

[PATCH 06/18] doc: Change chapter title to a more descriptive one

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti Signed-off-by: Tiago Vignatti Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- doc/Wayland/en_US/Protocol.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Wayland/en_US/Protocol.xml b/doc/Wayland/en_US/Protocol.xml index b5cd7a1..ec

[PATCH 05/18] doc: Rename Overview.xml to Introduction.xml

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti Rename Overview.xml to Introduction.xml, reflecting the previous commit. Organize also Wayland.xml order of the includes. Signed-off-by: Tiago Vignatti Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- doc/Wayland/Makefile.am| 8 +-- doc/Wayland

[PATCH 04/18] doc: Improve the first chapter text and definitions

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti In the beginning of the chapter, it was defined what is the so called "X" thing and was removed the "Wayland" and "Weston" definitions cause we're defining later at 1.2 anyway. "Introduction", "Motivation" and "Compositing manager as the display server" names sound better a

[PATCH 02/18] doc: Add a Foreword and a Preface

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti In particular, the preface defines the scope of this document we're building -- is the definition there enough with respect to what we want with this? Signed-off-by: Tiago Vignatti Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- doc/Wayland/Makefile.am

[PATCH 03/18] doc: Set book edition number to the "1"

2013-04-01 Thread Peter Hutterer
From: Tiago Vignatti "1" sounds better when we mention about the "first" edition or say the "publishing" edition. If needed, we might want to increase the edition numbers automatically later, for instance based on the micro version of the protocol or something like that. Signed-off-by: Tiago Vi

[PATCH 01/18] doc: don't add a para for an empty summary

2013-04-01 Thread Peter Hutterer
Removes enough empty lines to cut the PDF down by 4 pages. Signed-off-by: Peter Hutterer --- doc/Wayland/protocol-to-docbook.xsl | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/Wayland/protocol-to-docbook.xsl b/doc/Wayland/protocol-to-docbook.xsl index ca00efb..9

[PATCH 00/18] doc: misc improvements

2013-04-01 Thread Peter Hutterer
About half of those are Tiago's patches that I took from the list/his repo that hadn't been merged yet. The rest are largely style fixes to improve on the html/pdf output generated by publican. Possibly controversial: 14/18, renaming the source directory but imo it makes things a lot more obvious.

Re: [PATCH 21/21] docs: Add details about grabs

2013-04-01 Thread Kristian Høgsberg
On Sat, Mar 30, 2013 at 01:11:47AM -0400, matthias.cla...@gmail.com wrote: > From: Matthias Clasen > > Mention implicit grabs, (lack of) explicit grabs, and popup > windows. > --- > doc/Wayland/en_US/Protocol.xml | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/Wayland/en_US

[PATCH 3/3] protocol: fix two protocol description 'typos'

2013-04-01 Thread Peter Hutterer
Remove "mice, for example", it's described in the wl_pointer interface in detail. And remove space before the full stop. wl_seat_caps_mask doesn't exist anymore, rename accordingly. Signed-off-by: Peter Hutterer --- protocol/wayland.xml | 9 + 1 file changed, 5 insertions(+), 4 deletion

[PATCH 2/3] protocol: document wl_pointer, wl_keyboard, wl_touch

2013-04-01 Thread Peter Hutterer
Most of this should be clear, but let's spell a few things out. Signed-off-by: Peter Hutterer --- protocol/wayland.xml | 69 1 file changed, 54 insertions(+), 15 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 4750

[PATCH 1/3] protocol: use "summary", not "description" for xkb_v1 format

2013-04-01 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- protocol/wayland.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 9d276f8..4750115 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -1132,7 +1132,7 @@ This enum speci

Re: [PATCH 14/21] docs: Improve the wl_seat protocol docs

2013-04-01 Thread Kristian Høgsberg
On Sat, Mar 30, 2013 at 01:11:40AM -0400, matthias.cla...@gmail.com wrote: > From: Matthias Clasen > > Expand the main description and tell if requests don't have > an effect. > --- > protocol/wayland.xml | 35 ++- > 1 file changed, 22 insertions(+), 13 deletions(

Re: [PATCH] RDP compositor take 6

2013-04-01 Thread Jason Ekstrand
Looks good! Ship it! --Jason Ekstrand On Mon, Apr 1, 2013 at 4:43 PM, Hardening wrote: > This patch is the 6th version of the FreeRDP based compositor. > Changes from last version: > * use pixman_image_get_stride() when appropriate > * always realloc > > Reviewed-by: Jason Ekstrand > --- > co

[PATCH] RDP compositor take 6

2013-04-01 Thread Hardening
This patch is the 6th version of the FreeRDP based compositor. Changes from last version: * use pixman_image_get_stride() when appropriate * always realloc Reviewed-by: Jason Ekstrand --- configure.ac |7 + src/Makefile.am | 16 +- src/compositor-rdp.c | 1004 +++

Re: [PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

2013-04-01 Thread Kristian Høgsberg
On Thu, Mar 28, 2013 at 08:28:27PM +0100, Jonas Ådahl wrote: > On Thu, Mar 28, 2013 at 7:48 PM, Rob Bradford > wrote: > > From: Rob Bradford > > > > If an unknown id is deleted then the lookup in the map will return NULL and > > so we should avoid dereferencing that. > > Hi Rob, > > I think th

Re: [PATCH] RDP compositor take 5

2013-04-01 Thread Hardening
On 30/03/2013 21:34, Jason Ekstrand wrote: [...] >> + cmd->codecID = peer->settings->RemoteFxCodecId; >> + cmd->width = width; >> + cmd->height = height; >> + >> + ptr = pixman_image_get_data(image) + damage->extents.x1 + >> + damage->extents.y1

[PATCH v2 weston] evdev: Mouse speed and acceleration

2013-04-01 Thread Martin Minarik
Computes an accurate velocity instead of approximation. Changes: Add disclaimer. Implements 8 acceleration profiles taken from X ptrveloc.c. The sampling has been fixed to handle eventual time overflow. Configuration: Tune the values in mouse_init(). The tune_constant_coefficient is simply a mul

Re: [PATCH] Add new config parser

2013-04-01 Thread Kristian Høgsberg
On Mon, Apr 01, 2013 at 07:29:08PM +0200, Giulio Camuffo wrote: > Sorry, i was a bit too rushing. I made a couple of comments below. > > > 2013/4/1 Kristian Høgsberg > > > The current config parser, parses the ini file and pulls out the values > > specified by the struct config_section passed t

Re: [PATCH] Override modules list and don't always load desktop-shell.so

2013-04-01 Thread Emilio Pozuelo Monfort
On 04/01/2013 07:10 PM, Bill Spitzak wrote: > Emilio Pozuelo Monfort wrote: > >> I would rather do something like this to simplify the code (at least it looks >> clearer to me but YMMV): >> >> if (load_modules(ec, option_modules != NULL ? option_modules : modules, >> &argc, argv, c

Re: [PATCH] Add new config parser

2013-04-01 Thread Emilio Pozuelo Monfort
Hi, On 04/01/2013 06:42 PM, Kristian Høgsberg wrote: > The current config parser, parses the ini file and pulls out the values > specified by the struct config_section passed to parse_config_file() and > then throw the rest away. This means that every place we want to get > info out of the ini fi

[ANNOUNCE] xkbcommon 0.3.0

2013-04-01 Thread Daniel Stone
Hi, It gives me great pleasure etc to announce xkbcommon 0.3.0. This is mostly a bugfix and consolidation release, with no fun new features (and no API/ABI breaks), aside from: * a new xkb_keymap_new_from_buffer entrypoint, to support non-NULL-terminated strings courtesy of David Herrmann, which

Re: [PATCH] Add new config parser

2013-04-01 Thread Giulio Camuffo
Sorry, i was a bit too rushing. I made a couple of comments below. 2013/4/1 Kristian Høgsberg > The current config parser, parses the ini file and pulls out the values > specified by the struct config_section passed to parse_config_file() and > then throw the rest away. This means that every p

Re: [PATCH] Add new config parser

2013-04-01 Thread Giulio Camuffo
Seems good to me! But shouldn't weston_config_get_section() and all the weston_config_section_get_*() be WL_EXPORT? 2013/4/1 Kristian Høgsberg > The current config parser, parses the ini file and pulls out the values > specified by the struct config_section passed to parse_config_file() and > t

Re: [PATCH] Override modules list and don't always load desktop-shell.so

2013-04-01 Thread Bill Spitzak
Emilio Pozuelo Monfort wrote: I would rather do something like this to simplify the code (at least it looks clearer to me but YMMV): if (load_modules(ec, option_modules != NULL ? option_modules : modules, &argc, argv, config_file) < 0) goto out; That's bett

Re: [PATCH] Override modules list and don't always load desktop-shell.so

2013-04-01 Thread Emilio Pozuelo Monfort
Hi, The patch looks good to me, but it should come with an update of the --help output, which currently states: --modules Load the comma-separated list of modules This should state that it will override any modules listed in weston.ini. And the manpage says: --modules=module1.so,

Re: [PATCH] Override modules list and don't always load desktop-shell.so

2013-04-01 Thread Bill Spitzak
How about this, which reduces duplicate code (note I assume modules is a local variable, if it isn't and it needs to be preserved then a local copy of it should be used): if (option_modules) modules = option_modules; if (load_modules(ec, modules, &argc, argv, config_file) < 0)

Re: [PATCH 19/21] docs: Improve wl_region protocol docs

2013-04-01 Thread Jason Ekstrand
Looks good! --Jason Ekstrand On Mar 30, 2013 12:30 AM, wrote: > From: Matthias Clasen > > Just cosmetic changes, a few missing periods, and ID was > not capitalized. > --- > protocol/wayland.xml | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/protocol/waylan

[PATCH] Add new config parser

2013-04-01 Thread Kristian Høgsberg
The current config parser, parses the ini file and pulls out the values specified by the struct config_section passed to parse_config_file() and then throw the rest away. This means that every place we want to get info out of the ini file, we have to parse the whole thing again. It's not a big ov

Re: [PATCH 13/21] docs: Improve wl_surface protocol docs

2013-04-01 Thread Jason Ekstrand
Looks good! --Jason Ekstrand On Mar 30, 2013 12:24 AM, wrote: > From: Matthias Clasen > > Use NULL consistently. And add some more information in a few > places. > --- > protocol/wayland.xml | 123 > +-- > 1 file changed, 69 insertions(+), 54 dele

Re: [PATCH 00/21] Documentation improvements

2013-04-01 Thread Matthias Clasen
On Mon, Apr 1, 2013 at 10:43 AM, Jason Ekstrand wrote: > Matthias, > First, I would like to apologize for a) being a bit harsh and > overbearing in my comments and b) getting too caught up in stylistic > issues. I really should have read through it for content first and > just kept a tally for st

Re: Hawaii is usable now

2013-04-01 Thread Michael Hasselmann
On Mon, 2013-04-01 at 16:46 +0200, Pier Luigi wrote: > Hi, > > Hawaii is a lightweight desktop environment for Wayland written using > QtQuick 2.x. Very nice! Do you have a recent screencast for http://www.youtube.com/user/mauidesktop perhaps? ciao Michael __

Re: Hawaii is usable now

2013-04-01 Thread darxus
So are you actually using this as your primary UI now? The reason I stopped using weston as my primary UI in September was this segfault bug which I hit maybe a few times a day, triggered by xwayland: https://bugs.freedesktop.org/show_bug.cgi?id=59983 And I believe not using xwayland still pretty

Re: [PATCH weston] compositor: don't let weston terminate with dpms set to off if possible

2013-04-01 Thread Giulio Camuffo
Looks good to me. 2013/3/30 Philipp Brüschweiler > This will not catch the cases where weston crashes, but it's at least > better than the current state. > --- > src/compositor.c | 28 +++- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/src/composit

Re: protocol questions

2013-04-01 Thread Jason Ekstrand
On Sat, Mar 30, 2013 at 8:44 PM, Daniel Stone wrote: > Hi, > > On 30 March 2013 16:55, Thiago Macieira wrote: >> >> On sábado, 30 de março de 2013 09.34.24, Matthias Clasen wrote: >> > > Monotonic (ideally) time in an undefined domain, i.e. they're only >> > > meaningful on relation to each other

Hawaii is usable now

2013-04-01 Thread Pier Luigi
Hi, Hawaii is a lightweight desktop environment for Wayland written using QtQuick 2.x. One of my goals is to provide shells for different form factors, although at the moment only the traditional desktop is implemented (mouse + keyboard). I'm writing this email to inform you that the Hawaii deskt

Re: [PATCH 00/21] Documentation improvements

2013-04-01 Thread Jason Ekstrand
Matthias, First, I would like to apologize for a) being a bit harsh and overbearing in my comments and b) getting too caught up in stylistic issues. I really should have read through it for content first and just kept a tally for style things. At some point here (probably not till at least the we

Re: [PATCH] Override modules list and don't always load desktop-shell.so

2013-04-01 Thread Giulio Camuffo
Oh thanks, i needed this. I can now stop modifying weston.ini back and forth. :) Looks good to me. 2013/4/1 Pier Luigi Fiorini > Let --modules override modules list and load desktop-shell.so as a > fallback if a modules list is not specified neither by passing > --modules nor with weston.ini.

Re: [PATCH weston] compositor: Support notifying with absolute position too

2013-04-01 Thread Daniel Stone
Hi, On 1 April 2013 15:02, Eoff, Ullysses A wrote: > > I already submitted > http://lists.freedesktop.org/archives/wayland-devel/2013-March/008103.html > that does this same thing... except that it preserved the relative > "move_pointer" logic. One problem I can see with this is co-ordinate s

[PATCH] Override modules list and don't always load desktop-shell.so

2013-04-01 Thread Pier Luigi Fiorini
Let --modules override modules list and load desktop-shell.so as a fallback if a modules list is not specified neither by passing --modules nor with weston.ini. --- src/compositor.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/compositor.c b/src/compositor.c

RE: [PATCH weston] compositor: Support notifying with absolute position too

2013-04-01 Thread Eoff, Ullysses A
I already submitted http://lists.freedesktop.org/archives/wayland-devel/2013-March/008103.html that does this same thing... except that it preserved the relative "move_pointer" logic. -Original Message- From: wayland-devel-bounces+ullysses.a.eoff=intel@lists.freedesktop.org [mailto