On Sat, Mar 30, 2013 at 6:32 PM, Jason Ekstrand wrote
>
> 1. I said this in one of the e-mails, but avoid unneeded
> documentation. The documentation as is is fairly sparse and needs to
> be filled in. However, too much documentation can sometimes be a bad
> thing too. For example, on events c
Hi,
I have already sent a email about the clipboard and selection in
wayland a few weeks ago[1] (mainly about middle button paste). After
reading more about clipboard and selection protocol in wayland, I have
more questions about the limitation of the protocol.
1, as mentioned in my previous emai
Hi,
On 30 March 2013 16:55, Thiago Macieira wrote:
> On sábado, 30 de março de 2013 09.34.24, Matthias Clasen wrote:
> > > Monotonic (ideally) time in an undefined domain, i.e. they're only
> > > meaningful on relation to each other.
> >
> > What can you do with them ? For the use case that Giul
Hi,
On 30 March 2013 22:37, Jason Ekstrand wrote:
> I think this should be re-worded. It's correct, it just seems
> awkward. For example:
>
> Input events also carry timestamps in milliseconds. The base for
> these timestamps is left up to the compositor. Therefore, they should
> not be comp
Hi,
On 30 March 2013 20:48, Jason Ekstrand wrote:
> Some of this stuff has been somewhat re-defined lately and may not be
> up-to-date. You may want to talk to Kristian or Daniel and see what
> the current line-of-thought on types of compositors is. I like the
> fact that you expanded on thing
Hi,
On 30 March 2013 20:40, Jason Ekstrand wrote:
> On Fri, Mar 29, 2013 at 12:02 PM, Daniel Stone
> wrote:
> > Yeah, we need to define API here. For EGL, it'd be a matter of the EGL
> > implementation sending an event in between register_buffer and
> > buffer_available, such that when you cal
On sábado, 30 de março de 2013 17.52.33, Nick Kisialiou wrote:
> What about "long int" type to store the time stamps? Even in microseconds
> it will take longer than 100 years to overflow 2^63.
That requires changing the protocol.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Arch
What about "long int" type to store the time stamps? Even in microseconds
it will take longer than 100 years to overflow 2^63.
NK
On Sat, Mar 30, 2013 at 9:55 AM, Thiago Macieira
wrote:
> On sábado, 30 de março de 2013 09.34.24, Matthias Clasen wrote:
> > >> - Various input events have a time f
I don't know that these extra comments are needed. This information
is provided in the protocol documentation. Also, if we do want them,
"timestamp in milliseconds" seems nicer to read than "timestamp with
millisecond granularity".
--Jason Ekstrand
On Sat, Mar 30, 2013 at 1:09 PM, wrote:
> Fro
Looks Good!
--Jason Ekstrand
On Sat, Mar 30, 2013 at 1:36 PM, wrote:
> From: Matthias Clasen
>
> Explanation received on wayland-devel indicates that it is
> expected compositor behaviour to unmap surfaces without content.
> ---
> protocol/wayland.xml | 3 +++
> 1 file changed, 3 insertions(+)
On Sat, Mar 30, 2013 at 1:09 PM, wrote:
> From: Matthias Clasen
>
> Add some information about serials, timestamps and their uses
> to the Input section in the protocol overview.
> ---
> doc/Wayland/en_US/Protocol.xml | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/do
Matthias,
First, I want to reiterate my thanks for working on this. There's a
lot that could use some filling in. In general, I think you're doing
a great job. There are a lot of little consistency things that you're
fixing as well as grammar problems etc.
That said, I think I'm done reading yo
Matthias,
A few general comments about this one. First, there are several
places where you change the name of an argument to a function. While
I think this technically doesn't break anything, we need to be careful
here. The wayland protocol definition is a public API so we can't
just go around c
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> Reword some paragraphs, and spell out 'file descriptor'.
> ---
> protocol/wayland.xml | 73
> +++-
> 1 file changed, 49 insertions(+), 24 deletions(-)
>
> diff --git a/protocol/
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> Add some information about wl_callback and its done event.
> ---
> protocol/wayland.xml | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index ad72f
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> Reword a few things, and add some details.
> ---
> protocol/wayland.xml | 44 ++--
> 1 file changed, 26 insertions(+), 18 deletions(-)
>
> diff --git a/protocol/wayland.xml b/protocol/wa
On 30/03/2013 21:34, Jason Ekstrand wrote:
> Hardening,
> This is looking really good. I only have a couple comments on the
> code below that should take all of 5 minutes to address.
>
> That said, It's segfaulting on me a lot. Most of them seem to have to
> do with wl_seat. I really don't know
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> This adds a bit of information about in-order event delivery,
> removes extraneous formatting, and adds a missing period.
> ---
> protocol/wayland.xml | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
Looks Good!
--Jason Ekstrand
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> Say 'object ID' throughout.
> ---
> doc/Wayland/en_US/Protocol.xml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/doc/Wayland/en_US/Protocol.xml b/doc/Wayland/en_US
Looks Good!
--Jason Ekstrand
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> ---
> doc/Wayland/en_US/Protocol.xml | 71
> ++
> 1 file changed, 31 insertions(+), 40 deletions(-)
>
> diff --git a/doc/Wayland/en_US/Protocol.xml b/doc/W
Looks Good!
--Jason Ekstrand
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> Turn the bullet-point list into complete sentences.
> ---
> doc/Wayland/en_US/Protocol.xml | 19 ---
> 1 file changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/doc/Wayland
Some of this stuff has been somewhat re-defined lately and may not be
up-to-date. You may want to talk to Kristian or Daniel and see what
the current line-of-thought on types of compositors is. I like the
fact that you expanded on things quite a bit.
--Jason Ekstrand
On Sat, Mar 30, 2013 at 12:1
Looks Good!
--Jason Ekstrand
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> The Wayland Protocol -> Wayland Protocol Overview, to align
> better with the subsequent Wayland Protocol Specification.
> ---
> doc/Wayland/en_US/Protocol.xml | 2 +-
> 1 file changed, 1 insertio
Ok, so I like moving "Compositors" up a bit but I'm thinking a more
natural place to put it would be after "Architecture" so that the
reader has a better idea of what we mean by a compositor before they
start reading about types of compositors.
--Jason Ekstrand
On Sat, Mar 30, 2013 at 12:11 AM,
Matthias,
Thanks for working on this! My brief reading indicates that you've
done a pretty good job over-all. I'm going throgh your patches now
and so you can expect patch-by-patch comments shortyly.
--Jason Ekstrand
On Sat, Mar 30, 2013 at 12:11 AM, wrote:
> From: Matthias Clasen
>
> Hi, I s
On Fri, Mar 29, 2013 at 12:02 PM, Daniel Stone wrote:
> Hi Jason,
>
> On 29 March 2013 16:55, Jason Ekstrand wrote:
>>
>> A few quick thoughts, more to come. First, your get_export_surface has
>> two new_id arguments. I don't think that's intended.
>
> Oops, thanks!
>>
>> Second, we currently ha
Hardening,
This is looking really good. I only have a couple comments on the
code below that should take all of 5 minutes to address.
That said, It's segfaulting on me a lot. Most of them seem to have to
do with wl_seat. I really don't know why. Also, it works with
freerdp, but doesn't work wi
Hi,
Looks good to me. It would be good to add this to man /weston.man too.
Thanks,
Emilio
On 03/30/2013 03:18 PM, Philipp Brüschweiler wrote:
> ---
> src/compositor.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/compositor.c b/src/compositor.c
> index c3e
On sábado, 30 de março de 2013 09.34.24, Matthias Clasen wrote:
> >> - Various input events have a time field. The spec doesn't really say
> >> anything about this. What is it good for, and what units are these -
> >> monotonic time ?
> >
> > Monotonic (ideally) time in an undefined domain, i.e. th
From: Matthias Clasen
Explanation received on wayland-devel indicates that it is
expected compositor behaviour to unmap surfaces without content.
---
protocol/wayland.xml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 718a4a5..548b1b9 100
From: Matthias Clasen
Add some information about serials, timestamps and their uses
to the Input section in the protocol overview.
---
doc/Wayland/en_US/Protocol.xml | 16
1 file changed, 16 insertions(+)
diff --git a/doc/Wayland/en_US/Protocol.xml b/doc/Wayland/en_US/Protocol.
From: Matthias Clasen
This information is necessary to make any use of these fields.
---
protocol/wayland.xml | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 2a27b1b..718a4a5 100644
--- a/protocol/wayland
From: Matthias Clasen
I've received some clarifications on questions I asked
about the protocol. These patches add that information
to the docs, so it isn't lost.
Matthias Clasen (2):
docs: Document granularity of timestamps
docs: Add information about serials and timestamps
doc/Wayland/en
Hi,
On 30 March 2013 13:34, Matthias Clasen wrote:
> On Sat, Mar 30, 2013 at 7:56 AM, Daniel Stone wrote:
>
>> - Various input events have a time field. The spec doesn't really say
>>> anything about this. What is it good for, and what units are these -
>>> monotonic time ?
>>>
>>
>> Monotonic (
This will not catch the cases where weston crashes, but it's at least
better than the current state.
---
src/compositor.c | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/src/compositor.c b/src/compositor.c
index a3d1ede..7a656e7 100644
--- a/src/co
---
src/compositor.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/compositor.c b/src/compositor.c
index c3e6bed..7a656e7 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -3467,7 +3467,8 @@ usage(int error_code)
"Core options:\n\n"
You are right, thanks.
On Sat, Mar 30, 2013 at 9:16 AM, renoX wrote:
> I think that there is a typo in the text, you wrote "But there is way for
> clients to take an explicit grab. Instead," instead of "But there is NO
> way.."
>
> BR,
> renoX
>
___
w
On Sat, Mar 30, 2013 at 7:56 AM, Daniel Stone wrote:
>
>
>
>> - Various input events have a time field. The spec doesn't really say
>> anything about this. What is it good for, and what units are these -
>> monotonic time ?
>>
>
> Monotonic (ideally) time in an undefined domain, i.e. they're only
I think that there is a typo in the text, you wrote "But there is way for
clients to take an explicit grab. Instead," instead of "But there is NO
way.."
BR,
renoX
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop
Hi,
On 30 March 2013 05:31, Matthias Clasen wrote:
> Here are a few questions/observations I had while studying the protocol
> docs:
>
> - The use of serials in events seems a bit inconsistent. Most
> wl_pointer events have serials, but axis doesn't. wl_keyboard
> enter/leave events do. wl_data_
2013/3/30 Matthias Clasen
> Here are a few questions/observations I had while studying the protocol
> docs:
>
> - The use of serials in events seems a bit inconsistent. Most
> wl_pointer events have serials, but axis doesn't. wl_keyboard
> enter/leave events do. wl_data_offer.enter does, but the
41 matches
Mail list logo
