[PATCH] RDP compositor take 5

Sorry, my previous post was broken. This patch is the 5th version of the FreeRDP based compositor. Changes from last version: * dropped tiling for raw surfaces (not required) * corrected remoteFx encoding to have all rects of a damage event into a single remoteFx frame * added a mode to read

[PATCH] This patch is the 5th version of the FreeRDP based compositor.

--- configure.ac |7 + src/Makefile.am | 16 +- src/compositor-rdp.c | 1007 ++ 3 files changed, 1029 insertions(+), 1 deletion(-) create mode 100644 src/compositor-rdp.c diff --git a/configure.ac b/configure.ac index 355063d..ed

Re: [PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

On Mar 28, 2013 2:29 PM, "Jonas Ådahl" wrote: > > On Thu, Mar 28, 2013 at 7:48 PM, Rob Bradford wrote: > > From: Rob Bradford > > > > If an unknown id is deleted then the lookup in the map will return NULL and > > so we should avoid dereferencing that. > > Hi Rob, > > I think the patch looks goo

Re: [PATCH weston 2/2] wayland-server: Avoid deferencing a NULL pointer in error case

Both patches in this series look good to me. --Jason Ekstrand On Mar 28, 2013 1:49 PM, "Rob Bradford" wrote: > From: Rob Bradford > > Reorder the error handling in the case that closure is NULL due to ENOMEM > to > ensure that we can safely call wl_closure_lookup_objects on the second > test. >

Re: [PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

On Thu, Mar 28, 2013 at 7:48 PM, Rob Bradford wrote: > From: Rob Bradford > > If an unknown id is deleted then the lookup in the map will return NULL and > so we should avoid dereferencing that. Hi Rob, I think the patch looks good, but I have one comment below. Thanks, Jonas > --- > src/way

[PATCH weston 2/2] wayland-server: Avoid deferencing a NULL pointer in error case

From: Rob Bradford Reorder the error handling in the case that closure is NULL due to ENOMEM to ensure that we can safely call wl_closure_lookup_objects on the second test. Prior to this reordering the closure would be deferenced in the ENOMEM case due to the invocation of the second half of the

[PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

From: Rob Bradford If an unknown id is deleted then the lookup in the map will return NULL and so we should avoid dereferencing that. --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 0873835..e8d3240 10

Re: [PATCH 0/2] Fix the documentation build

On Thu, Mar 28, 2013 at 09:10:30AM -0400, matthias.cla...@gmail.com wrote: > From: Matthias Clasen > > Trying to write some review comments on the Wayland docs, I found > that the docs wouldn't build here, with publican 3.1.5. These two > patches make things work for me. Thanks, both applied. K

Re: [PATCH] gitignore: Ignore test-driver

On Thu, Mar 28, 2013 at 05:28:22PM +, Damien Lespiau wrote: > Automake (1.12 here) parallel-tests installs a test-driver file, another > file to add to .gitignore. > > While at it, remove the duplicate cscope.out entry and add TAGS (the > result of automake's "make tag") > --- > .gitignore |

Re: [PATCH weston] sdk: be C++ friendly

On Thu, Mar 28, 2013 at 06:02:42PM +0100, Giulio Camuffo wrote: > This renames the weston_surface's private member to configure_private > and externs "C" the headers of the SDK. > --- > shared/config-parser.h | 8 > shared/matrix.h| 8 > src/compositor.c | 6 +++-

[PATCH] gitignore: Ignore test-driver

Automake (1.12 here) parallel-tests installs a test-driver file, another file to add to .gitignore. While at it, remove the duplicate cscope.out entry and add TAGS (the result of automake's "make tag") --- .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore

[PATCH weston] sdk: be C++ friendly

This renames the weston_surface's private member to configure_private and externs "C" the headers of the SDK. --- shared/config-parser.h | 8 shared/matrix.h| 8 src/compositor.c | 6 +++--- src/compositor.h | 10 +- src/shell.c| 28

Re: [PATCH] build: Make the X11 compositor explicitely depend on xcb-shm

On Thu, Mar 28, 2013 at 03:20:54PM +, Damien Lespiau wrote: > Otherwise, it means the X11 compositor depends on another library to > pull xcb-shm (cairo?), which is not always the case. Here I end up with: > > [01:54:38.970] Failed to load module: > $prefix/lib/weston/x11-backend.so: undefined

Re: [PATCH] client: Add acquire-fd API to avoid requiring a polling main thread

On Mon, Mar 25, 2013 at 09:42:11PM +0100, Uli Schlachter wrote: > On 25.03.2013 21:33, Thiago Macieira wrote: > > On segunda-feira, 25 de março de 2013 19.49.32, Uli Schlachter wrote: > >> So wl_display_acquire_fd() would do: > >> > >> if (old_state == VOLUNTEER_READER) { > >> write(dis

Re: [PATCH] client: Add acquire-fd API to avoid requiring a polling main thread

On Mon, Mar 25, 2013 at 01:24:53PM -0700, Thiago Macieira wrote: > On segunda-feira, 25 de março de 2013 13.42.31, Kristian Høgsberg wrote: > > which returns the display fd and blocks any thread trying to read from > > the fd. Calling wl_display_dispatch() will read events, release the fd > > and

[PATCH] build: Make the X11 compositor explicitely depend on xcb-shm

Otherwise, it means the X11 compositor depends on another library to pull xcb-shm (cairo?), which is not always the case. Here I end up with: [01:54:38.970] Failed to load module: $prefix/lib/weston/x11-backend.so: undefined symbol: xcb_shm_id --- configure.ac | 2 +- 1 file changed, 1 insertion(

Re: [PATCH wayland] server: use void* instead of function pointer for wl_object.implementation

On quinta-feira, 28 de março de 2013 14.55.51, Giulio Camuffo wrote: > use a union { void *obj; void (* const *func)(); }; in wl_resource_init() > in wayland-server.h to convert between the two (really ugly imho) or > uninline wl_resource_init() and put the implementation somewhere the c++ > compil

Re: [PATCH wayland] server: use void* instead of function pointer for wl_object.implementation

Looks good to me. Ship it! This was part of some of my defunct dispatcher patches at one point. I think this is a lot cleaner than casting all the time anyway. --Jason On Mar 28, 2013 8:58 AM, "Giulio Camuffo" wrote: > This is needed to make C++ programs that include wayland-server.h build: > C

[PATCH wayland] server: use void* instead of function pointer for wl_object.implementation

This is needed to make C++ programs that include wayland-server.h build: C++ does not allow conversions from data pointers to function pointers. --- This is the cleanest solution, imho. But if there are problems related to Wayland internals, or libffi, or something else, there are two other options

[PATCH 2/2] docs: Fix the documentation build

From: Matthias Clasen The publican man page says that the options are actually called --formats and --langs, and with this, the doc build succeeds. --- doc/Wayland/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Wayland/Makefile.am b/doc/Wayland/Makefile.am in

[PATCH 1/2] docs: Add a revision history

From: Matthias Clasen Publican complains if it can't find this file. --- doc/Wayland/Makefile.am| 1 + doc/Wayland/en_US/Revision_History.xml | 7 +++ 2 files changed, 8 insertions(+) create mode 100644 doc/Wayland/en_US/Revision_History.xml diff --git a/doc/Wayland/Makefil

[PATCH 0/2] Fix the documentation build

From: Matthias Clasen Trying to write some review comments on the Wayland docs, I found that the docs wouldn't build here, with publican 3.1.5. These two patches make things work for me. Matthias Clasen (2): docs: Add a revision history docs: Fix the documentation build doc/Wayland/Makefil

Re: [PATCH weston] evdev: Handle SYN_DROPPED, atomically count buttons

On Wed, Mar 27, 2013 at 3:26 AM, Martin Minarik wrote: > When the kernel event queue overruns, the evdev.c will: > 1. Skip events until and up to the next SYN_REPORT > 2. Count depressed grab buttons on seat devices. > 3. If the depressed grab button count is different, update >it atomically.