Re: [PATCH weston v2] Added handler for SIGABRT

2013-03-27 Thread Kristian Høgsberg
On Wed, Mar 27, 2013 at 10:38:53PM +0100, Peter Maatman wrote: > --- > src/compositor.c | 29 ++--- > 1 file changed, 18 insertions(+), 11 deletions(-) I added the void in catch_signal() as Giulio mentioned, other than that it all looks good. Thanks, and thanks Giulio for

[PATCH] build: Make the X11 compositor explicitely depend on xcb-shm

2013-03-27 Thread Damien Lespiau
From: Damien Lespiau Otherwise, it means the X11 compositor depends on another library to pull xcb-shm (cairo?), which is not always the case. Here I end up with: [01:54:38.970] Failed to load module: $prefix/lib/weston/x11-backend.so: undefined symbol: xcb_shm_id --- configure.ac | 2 +- 1 fil

[RFC] Language Bindings Guide

2013-03-27 Thread Jason Ekstrand
Wayland Devs, I spent the last couple of evenings writing a short language bindings guide for libwayland based on my experience with the java bindings. If a couple of you wouldn't mind looking it over for mistakes, that would be appreciated. I will eventually send out a website patch. For how, it

[PATCH libxkbcommon v2] keymap: add xkb_keymap_new_from_buffer()

2013-03-27 Thread David Herrmann
The current API doesn't allow the caller to create keymaps from mmap()'ed files. The problem is, xkb_keymap_new_from_string() requires a terminating 0 byte. However, there is no way to guarantee that when using mmap() so a user currently has to copy the whole file just to get the terminating zero b

Re: [PATCH weston v2] Added handler for SIGABRT

2013-03-27 Thread Giulio Camuffo
Awesome, thanks, this was badly needed. Looks good to me. 2013/3/27 Peter Maatman : > --- > src/compositor.c | 29 ++--- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index a2860fd..e750cbe 100644 > --- a/src/com

[PATCH weston v2] Added handler for SIGABRT

2013-03-27 Thread Peter Maatman
--- src/compositor.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index a2860fd..e750cbe 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -3221,17 +3221,17 @@ print_backtrace(void) #endif static v

Re: [PATCH weston v2] Added handler for SIGABRT

2013-03-27 Thread Giulio Camuffo
Sorry to keep annoying you, but the commit's author name is still blackwolf12333. There are also some of trailing whitespaces, i've put inline comments for them. 2013/3/27 Peter Maatman : > From: blackwolf12333 > > This handler will do exactly the same as the SIGSEGV handler > but now for the SIG

[PATCH weston v2] Added handler for SIGABRT

2013-03-27 Thread Peter Maatman
From: blackwolf12333 This handler will do exactly the same as the SIGSEGV handler but now for the SIGABRT signal. --- src/compositor.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index a2860fd..5d4c

Re: [PATCH weston] evdev-touchpad: Disable tap FSM by default on touchpads with button pads

2013-03-27 Thread Kristian Høgsberg
On Fri, Mar 22, 2013 at 08:41:42AM +0100, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > > Hi, > > Haven't tested this on a clickpad, but it should disable the tapping > feature for clickpads and other touchpads that advertise the existance > of a buttonpad. That works for here, thanks

Re: [PATCH weston v2] removed extra sigemptyset and updated documentation

2013-03-27 Thread Kristian Høgsberg
On Wed, Mar 27, 2013 at 03:45:39PM +0100, Peter Maatman wrote: > From: blackwolf12333 Thanks, this is a useful feature. However, following up to a patch review typically means taking the suggested changes and adding them into the original patch, using something like git commit --amend -a to upda

Re: [PATCH v2] compositor-drm: ensure we run drm-backend using weston-launch

2013-03-27 Thread Kristian Høgsberg
On Wed, Mar 27, 2013 at 06:39:28PM +0100, Rafal Mielniczuk wrote: > We do this by checking if launcher_sock != -1 > > This fixes https://bugs.freedesktop.org/show_bug.cgi?id=60926 That looks good, committed. Kristian > src/compositor-drm.c | 7 +++ > 1 file changed, 7 insertions(+) > > di

Re: [PATCH weston] compositor: Support notifying with absolute position too

2013-03-27 Thread Bill Spitzak
Looks like there is a lot of duplicated code between notify_motion and notify_motion_absolute. It might be better to have notify_motion just add pointer->x and pointer->y and call notify_motion_absolute, and put all the shared logic, and possibly all of move_pointer(), into that. Rob Bradfor

Re: [PATCH web 1/3] gtk: We now have accessors for wl_ data structures

2013-03-27 Thread darxus
Thanks, committed these three. (HTML validated.) On 03/27, Rob Bradford wrote: > From: Rob Bradford > > --- > gtk.html | 4 > 1 file changed, 4 deletions(-) > > diff --git a/gtk.html b/gtk.html > index 70d6b27..6278f10 100644 > --- a/gtk.html > +++ b/gtk.html > @@ -95,10 +95,6 @@ applica

[PATCH web 3/3] gtk: Provide a link to the GNOME Wayland wiki page

2013-03-27 Thread Rob Bradford
From: Rob Bradford --- gtk.html | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk.html b/gtk.html index 6aa9cba..d246238 100644 --- a/gtk.html +++ b/gtk.html @@ -106,6 +106,9 @@ applications makes API calls that will not function under Wayland. positioned in the correct location.

[PATCH web 2/3] gtk: Update the errata list - lots of things work now!

2013-03-27 Thread Rob Bradford
From: Rob Bradford --- gtk.html | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/gtk.html b/gtk.html index 6278f10..6aa9cba 100644 --- a/gtk.html +++ b/gtk.html @@ -97,26 +97,12 @@ applications makes API calls that will not function under Wayland. Kno

[PATCH web 1/3] gtk: We now have accessors for wl_ data structures

2013-03-27 Thread Rob Bradford
From: Rob Bradford --- gtk.html | 4 1 file changed, 4 deletions(-) diff --git a/gtk.html b/gtk.html index 70d6b27..6278f10 100644 --- a/gtk.html +++ b/gtk.html @@ -95,10 +95,6 @@ applications makes API calls that will not function under Wayland. application. -API to access the und

[PATCH weston] compositor: Support notifying with absolute position too

2013-03-27 Thread Rob Bradford
From: Rob Bradford With evdev input devices that generate absolute positions we need to provide an infrastructure in the compositor for supporting those. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=61997 --- src/compositor.c | 25 - src/compositor.h | 5 - s

Re: [RFC] add a shutdown event

2013-03-27 Thread Hardening
On 22/03/2013 13:42, Pekka Paalanen wrote: > On Mon, 18 Mar 2013 21:43:32 +0100 > Hardening wrote: > >> On 18/03/2013 13:48, Uli Schlachter wrote: >>> Hi, >>> >>> On 18.03.2013 00:30, Hardening wrote: On 17/03/2013 23:59, Sylvain BERTRAND wrote: > On Sun, Mar 17, 2013 at 11:32:21PM +0100

[PATCH v2] compositor-drm: ensure we run drm-backend using weston-launch

2013-03-27 Thread Rafal Mielniczuk
We do this by checking if launcher_sock != -1 This fixes https://bugs.freedesktop.org/show_bug.cgi?id=60926 --- src/compositor-drm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index fa21495..3d200dd 100644 --- a/src/compositor-drm.c +++

Re: [PATCH weston v2] shell: set the popup grab button as pressed only if it actually is

2013-03-27 Thread Kristian Høgsberg
On Wed, Mar 27, 2013 at 06:05:26PM +0100, Giulio Camuffo wrote: > This ensures the popup_grab.initial_up field isn't reset to 0 > if the popup was not opened because of a mouse press but because > of moving the mouse with a popup already open. Not doing so will > make the first click outside the cl

Re: [PATCH] compositor: block running drm backend using weston binary

2013-03-27 Thread Kristian Høgsberg
On Wed, Mar 27, 2013 at 05:14:24PM +0100, Rafal Mielniczuk wrote: > While running weston with drm-backend, we check if its parent executable > name was weston-launch. In case it wasn't, we print error message and > quit. > > This fixes https://bugs.freedesktop.org/show_bug.cgi?id=60926 Thanks for

[PATCH weston v2] shell: set the popup grab button as pressed only if it actually is

2013-03-27 Thread Giulio Camuffo
This ensures the popup_grab.initial_up field isn't reset to 0 if the popup was not opened because of a mouse press but because of moving the mouse with a popup already open. Not doing so will make the first click outside the client area go ignored. --- src/shell.c | 6 +- 1 file changed, 5 ins

Re: [PATCH weston] shell: set the popup grab button as pressed only if it actually is

2013-03-27 Thread Kristian Høgsberg
On Wed, Mar 27, 2013 at 04:44:03PM +0100, Giulio Camuffo wrote: > --- > src/shell.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Nice, I see the problem with gtk+ too. If I click to open, mosue around to other menus or submenus (resets initial_up) and then click outside any client s

[PATCH] compositor: block running drm backend using weston binary

2013-03-27 Thread Rafal Mielniczuk
While running weston with drm-backend, we check if its parent executable name was weston-launch. In case it wasn't, we print error message and quit. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=60926 --- src/compositor.c | 16 1 file changed, 16 insertions(+) diff --g

[PATCH weston] shell: set the popup grab button as pressed only if it actually is

2013-03-27 Thread Giulio Camuffo
--- src/shell.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shell.c b/src/shell.c index da9193c..899db8c 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2008,7 +2008,8 @@ add_popup_grab(struct shell_surface *shsurf, struct shell_seat *shseat) if (wl_list_empty

Re: Helping in reviewing

2013-03-27 Thread Thiago Macieira
On quarta-feira, 27 de março de 2013 14.15.14, Siddharth Heroor wrote: > > Recent circumstances have shown that patch reviewing in Wayland and Weston > > is becoming a bottleneck for development (at least, it is perceived to > > be). This email is intended to begin addressing that. > > Would settin

Re: [PATCH weston v2] removed extra sigemptyset and updated documentation

2013-03-27 Thread Siddharth Heroor
On Wed, Mar 27, 2013 at 8:15 PM, Peter Maatman wrote: > From: blackwolf12333 > > --- > src/compositor.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index ec3d0e3..5d4c9b2 100644 > --- a/src/compositor.c > +++ b/src/compositor.c > @@ -3401,8 +34

[PATCH weston v2] removed extra sigemptyset and updated documentation

2013-03-27 Thread Peter Maatman
From: blackwolf12333 --- src/compositor.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index ec3d0e3..5d4c9b2 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -3401,8 +3401,6 @@ catch_signals() action.sa_sigaction = on_caught_signal;

Re: [PATCH weston] Added general signal handling and added sig_abrt

2013-03-27 Thread Pekka Paalanen
On Wed, 27 Mar 2013 16:20:27 +0200 Pekka Paalanen wrote: > Hi, > > this looks mostly fine, few comments below, and we want a v2 after > those. > > Oh, could you put your real name in the sender field, so we get it in > the git history properly? > > On Wed, 27 Mar 2013 14:59:28 +0100 > blackwol

Re: [PATCH weston] Added general signal handling and added sig_abrt

2013-03-27 Thread Pekka Paalanen
Hi, this looks mostly fine, few comments below, and we want a v2 after those. Oh, could you put your real name in the sender field, so we get it in the git history properly? On Wed, 27 Mar 2013 14:59:28 +0100 blackwolf12333 wrote: > --- > src/compositor.c | 58 > +

[PATCH weston] Added general signal handling and added sig_abrt

2013-03-27 Thread blackwolf12333
--- src/compositor.c | 58 +--- 1 file changed, 51 insertions(+), 7 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index a2860fd..92e9cbe 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -3220,7 +3220,7 @@ print_backtrace(v

Re: [PATCH weston] evdev: Handle SYN_DROPPED, atomically count buttons

2013-03-27 Thread Giulio Camuffo
Hi Martin, Apart some style issues this seems good to me, but i'ts the first time i look into evdev.c, so i might have missed something. I could not reproduce the two issues you describe, with 20 mpv instances running a full hd movie in the background. 2013/3/27 Martin Minarik : > When the kernel

Re: Helping in reviewing

2013-03-27 Thread Siddharth Heroor
On Tue, Mar 26, 2013 at 11:22 PM, Thiago Macieira wrote: > Recent circumstances have shown that patch reviewing in Wayland and Weston is > becoming a bottleneck for development (at least, it is perceived to be). This > email is intended to begin addressing that. Would setting patchwork help in im

Re: Helping in reviewing

2013-03-27 Thread Gwenole Beauchesne
Hi, 2013/3/27 Pekka Paalanen : > On Tue, 26 Mar 2013 14:09:48 -0700 > Thiago Macieira wrote: > >> So whenever you see a change that you think you can provide input on, do so. >> If you don't feel like saying it's completely fine, say so too. The initial >> review you provide on simpler things (co

Re: Helping in reviewing

2013-03-27 Thread Pekka Paalanen
On Tue, 26 Mar 2013 14:09:48 -0700 Thiago Macieira wrote: > So whenever you see a change that you think you can provide input on, do so. > If you don't feel like saying it's completely fine, say so too. The initial > review you provide on simpler things (coding style, thread-safety, etc.) is >