Re: Clipboard and selection in wayland.

2013-03-16 Thread Yichao Yu
On Tue, Mar 12, 2013 at 7:19 PM, Yichao Yu wrote: > On Tue, Mar 12, 2013 at 12:51 PM, Bill Spitzak wrote: >> On 03/11/2013 07:56 PM, Yichao Yu wrote: >> >>> It may depends on how you define selecting but the point here is the >>> content you start dragging should never clear the current PRIMARY >

Re: [PATCH] Eat scroll event if a key binding function is executed because of it.

2013-03-16 Thread Scott Moreau
Hi Rune, I almost forgot about this one, thanks for reminding me. Pushed to gh next. - Scott On Thu, Mar 7, 2013 at 1:50 PM, Rune K. Svendsen wrote: > From: "Rune K. Svendsen" > > When an axis (scroll) event results in a key binding function > being executed, eat the scroll event so the underl

Re: [PATCH wayland 0/6] Add wl_object based custom dispatchers support

2013-03-16 Thread Scott Moreau
Hi Jason, I appreciate your work here. These patches can potentially lower the entry barrier to writing other language bindings. Unfortunately, I don't not feel that this is something suitable for gh next. It adds a dependency on a mesa patch, which makes it more difficult to build the next stack,

Re: [PATCH wayland 0/6] Add wl_object based custom dispatchers support

2013-03-16 Thread Jason Ekstrand
Kristian, Working with Scott Moreau to get this applied to his "next" branch demonstrated that this series is a bit tricky to apply. In order to do everything correctly, it needs to be applied in three stages: First, apply the following 4 patches (in order): http://lists.freedesktop.org/archives/

Re: [PATCH weston 1/2] weston-launch: move function calls out of assert()

2013-03-16 Thread Jonas Ådahl
On Sat, Mar 9, 2013 at 7:38 PM, Philipp Brüschweiler wrote: > --- > src/weston-launch.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/src/weston-launch.c b/src/weston-launch.c > index bc7f8a2..98f0111 100644 > --- a/src/weston-launch.c > +++ b/src/weston-laun

Re: [PATCH weston 1/2] weston-launch: move function calls out of assert()

2013-03-16 Thread Scott Moreau
This looks better, applied to gh next. - Scott On Sat, Mar 9, 2013 at 11:38 AM, Philipp Brüschweiler wrote: > --- > src/weston-launch.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/src/weston-launch.c b/src/weston-launch.c > index bc7f8a2..98f0111 100644 >

Re: [PATCH 0/4] improve window maximize handling

2013-03-16 Thread Scott Moreau
Hi Rafal, These all look good, merged with gh next. Thanks for the fixes! - Scott On Mon, Mar 11, 2013 at 12:26 PM, Rafal Mielniczuk wrote: > Hi > > This series of patches improves a bit handling of maximized windows in desktop > shell. > > There were some inconsistencies like window could be m

Re: [PATCH] compositor-drm: Inspect result of gbm_create_device.

2013-03-16 Thread Scott Moreau
Hi John, Thanks, committed to gh next. - Scott On Sat, Mar 2, 2013 at 4:27 AM, John Kåre Alsaker wrote: > --- > src/compositor-drm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > index 3c44f7a..f60fce9 100644 > --- a/src/compositor-dr

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-03-16 Thread Scott Moreau
I picked this one up for gh next, since a lot of people were having a problem with this. Animations stalling, especially. - Scott On Wed, Feb 13, 2013 at 7:06 AM, Ander Conselvan de Oliveira wrote: > The page flip event timestamps comes from the monotonic clock, while > idle_repaint() gets the t

Re: [PATCH wayland] client: Invoke new_id closure arguments as pointers instead of integers

2013-03-16 Thread Scott Moreau
Committed in gh next. - Scott On Fri, Mar 15, 2013 at 8:47 AM, Michael Hasselmann wrote: > Could we get this merged please? It fixes an annoying crasher bug for us > (see FDO#62367). > > Thanks, > Michael > > On Fri, 2013-03-08 at 18:44 +0100, Jonas Ådahl wrote: >> This commit adds a flags param

Re: [PATCH weston] Fix memory leaks

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Thu, Mar 7, 2013 at 10:15 AM, Scott Moreau wrote: > Fix a couple leaks caught by valgrind. > --- > src/gl-renderer.c |2 ++ > src/shell.c |1 + > 2 files changed, 3 insertions(+) > > diff --git a/src/gl-renderer.c b/src/gl-renderer.c > index a5dc2f3..3dfcd15 1

Re: Introduce panel window list and surface minimize protocol

2013-03-16 Thread Scott Moreau
This entire series committed to gh next. On Thu, Mar 7, 2013 at 9:47 PM, Scott Moreau wrote: > This series implements a window list for the panel. It introduces protocol for > minimize/maximize control of shell_surfaces. It also provides a basic > minimize implementation. > > Admittedly I am a li

Re: [PATCH] pixman-renderer: don't forget to initialize the debug fields

2013-03-16 Thread Scott Moreau
Pushed to gh next. - Scott On Fri, Mar 8, 2013 at 12:35 PM, Philipp Brüschweiler wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61930 > --- > src/pixman-renderer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c > index 9571f

Re: [PATCH weston 1/2] compositor: remove unused field option_idle_time

2013-03-16 Thread Scott Moreau
Pushed to gh next. - Scott On Sun, Mar 10, 2013 at 7:37 AM, Philipp Brüschweiler wrote: > --- > src/compositor.c | 1 - > src/compositor.h | 3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index a2860fd..7df9658 100644 > --- a/src/

Re: [PATCH 2/3 v3] compositor: turn off the idle timer when sleeping

2013-03-16 Thread Scott Moreau
Hi Philipp, Thanks for your attention to this. Pushed to gh next. - Scott On Sun, Mar 10, 2013 at 9:08 AM, Philipp Brüschweiler wrote: > Also updates the drm, fbdev and rpi backend to use > weston_compositor_set_sleeping() and not set the state manually. > > Fixes https://bugs.freedesktop.org/s

Re: [PATCH] Revert "weston.ini: Use 'modeline' key for modeline example"

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Sun, Mar 10, 2013 at 9:30 AM, Scott Moreau wrote: > This reverts commit 97a56145636316fdb431b91ec64adff217287cd9. > > The current code detects the mode key, not modeline. Reference: > http://cgit.freedesktop.org/wayland/weston/tree/src/compositor-drm.c#n2464 > --- > > I'm no

Re: [PATCH gtk+] wayland: Attach buffer before committing

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Sun, Mar 10, 2013 at 10:55 AM, Scott Moreau wrote: > With recent changes in attach semantics, we always need to attach before > committing. This fixes the problem with wayland gtk clients not updating > surface contents correctly since latest changes regarding attach. > ---

Re: [PATCH gtk+] wayland: Remove unneeded semicolons.

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Sun, Mar 10, 2013 at 12:17 PM, Scott Moreau wrote: > > > On Wed, Oct 24, 2012 at 9:38 PM, Scott Moreau wrote: >> >> --- >> gdk/wayland/gdkdevice-wayland.c | 2 +- >> gdk/wayland/gdkdisplay-wayland.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --

Re: [PATCH v3] shell: grab the parent popup when a sub popup window is deleted or hidden

2013-03-16 Thread Scott Moreau
Thanks for rebasing this to next, pushed. - Scott On Sat, Mar 16, 2013 at 4:59 AM, Giulio Camuffo wrote: > If the client opens a popup menu and submenu, when it closes or hides the > submenu the pointer grab should return to the parent menu. > Furthermore, when clicking outside the client area t

[PATCH] weston evdev: Filter double press, double release

2013-03-16 Thread Martin Minarik
Track mouse button values. When the kernel drops, don't send notify again about a button, that's already pressed or released. --- src/evdev.c | 32 ++-- src/evdev.h |3 +++ 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c i

[PATCH v3] shell: grab the parent popup when a sub popup window is deleted or hidden

2013-03-16 Thread Giulio Camuffo
If the client opens a popup menu and submenu, when it closes or hides the submenu the pointer grab should return to the parent menu. Furthermore, when clicking outside the client area the popup_done event is sent to the active popup surface and recursively to its parent. --- src/shell.c | 73 +