Re: [PATCH 2/2 v3] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Pekka Paalanen
On Tue, 26 Feb 2013 16:24:32 +0100 Giulio Camuffo wrote: > We must calculate the bounding box of the surface + subsurfaces set and use > that when maximizing the window or going fullscreen. > --- > src/shell.c | 89 > ++--- > 1 file change

Re: [PATCH wayland] Clean up and refactor wl_closure and associated functions

2013-02-26 Thread Jason Ekstrand
On Tue, Feb 26, 2013 at 12:37 PM, Kristian Høgsberg wrote: > On Sat, Feb 23, 2013 at 12:57:09PM -0600, Jason Ekstrand wrote: >> The primary purpose of this patch is to clean up wl_closure and separate >> closure storage, libffi, and the wire format. To that end, a number of >> changes >> have be

Re: [PATCH 2/2] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Pekka Paalanen
On Tue, 26 Feb 2013 12:10:18 -0800 Bill Spitzak wrote: > Pekka Paalanen wrote: > > > Do I understand correctly, that you would like to add protocol, so > > that clients could provide information, that the server can > > easily compute from the information it already has? > > Yes you understand

Re: [PATCH 2/2] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Bill Spitzak
Pekka Paalanen wrote: Do I understand correctly, that you would like to add protocol, so that clients could provide information, that the server can easily compute from the information it already has? Yes you understand correctly, except that it is *not* information the server has and I sure

Re: [PATCH wayland] Clean up and refactor wl_closure and associated functions

2013-02-26 Thread Kristian Høgsberg
On Sat, Feb 23, 2013 at 12:57:09PM -0600, Jason Ekstrand wrote: > The primary purpose of this patch is to clean up wl_closure and separate > closure storage, libffi, and the wire format. To that end, a number of > changes > have been made: > > - The maximum number of closure arguments has been

Re: [PATCH 2/2] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Pekka Paalanen
On Tue, 26 Feb 2013 09:22:44 -0800 Bill Spitzak wrote: > On 02/25/2013 09:59 AM, Giulio Camuffo wrote: > > We must calculate the bounding box of the surface + subsurfaces set and use > > that when maximizing the window or going fullscreen. > > I think it would be much better for the client to ju

Re: [PATCH 2/2] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Bill Spitzak
On 02/25/2013 09:59 AM, Giulio Camuffo wrote: We must calculate the bounding box of the surface + subsurfaces set and use that when maximizing the window or going fullscreen. I think it would be much better for the client to just be able to say "pretend this shell surface is this big, even tho

Re: [PATCH 3/4] protocol: Introduce pointer_lock interface

2013-02-26 Thread Bill Spitzak
On 02/26/2013 09:01 AM, Kristian Høgsberg wrote: You're confusing keyboard and pointer focus. The pointer_lock kicks in when the surface receive keyboard focus, not pointer focus. It would be very nasty if just mousing over a surface would lock the pointer. Kristian Okay that makes a lot mo

Re: [PATCH 3/4] protocol: Introduce pointer_lock interface

2013-02-26 Thread Kristian Høgsberg
On Tue, Feb 26, 2013 at 11:55 AM, Bill Spitzak wrote: > On 02/25/2013 09:28 PM, Daniel Stone wrote: > >> I suppose there still is a race if the user hits the lock-cursor >> button and then moves the mouse out so fast that it exits before the >> client sends the lock request. But this i

Re: [PATCH 3/4] protocol: Introduce pointer_lock interface

2013-02-26 Thread Bill Spitzak
On 02/25/2013 09:28 PM, Daniel Stone wrote: I suppose there still is a race if the user hits the lock-cursor button and then moves the mouse out so fast that it exits before the client sends the lock request. But this is a lot harder to hit that the quick enter+exit one. That's

Re: [PATCH wayland] client: add wl_proxy_get_class()

2013-02-26 Thread Kristian Høgsberg
On Tue, Feb 26, 2013 at 03:19:44PM +0200, Pekka Paalanen wrote: > This is a useful shorthand for client application debugging macros, > since you can ask the object class from the object itself. > > Signed-off-by: Pekka Paalanen > --- > src/wayland-client.c | 12 > src/wayland-clien

Re: [PATCH weston] update .gitignores for src/ and man/

2013-02-26 Thread Kristian Høgsberg
On Tue, Feb 26, 2013 at 03:19:02PM +0200, Pekka Paalanen wrote: > Signed-off-by: Pekka Paalanen > --- > man/.gitignore | 1 + > src/.gitignore | 1 + > 2 files changed, 2 insertions(+) Thanks, applied. Kristian > diff --git a/man/.gitignore b/man/.gitignore > index dfabd62..6138c7d 100644 > --

Re: [PATCH weston] compositor-drm: Fix a crash with a fullscreen surface with driver mode

2013-02-26 Thread Kristian Høgsberg
On Tue, Feb 26, 2013 at 01:44:58PM +0200, Ander Conselvan de Oliveira wrote: > If there was a fullscreen surface using driver mode when a vt switch is > triggered, but something caused it to be gone when switching back (such > as the client being killed), a call to drm_output_switch_mode() is made

[PATCH 2/2 v3] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Giulio Camuffo
We must calculate the bounding box of the surface + subsurfaces set and use that when maximizing the window or going fullscreen. --- src/shell.c | 89 ++--- 1 file changed, 68 insertions(+), 21 deletions(-) diff --git a/src/shell.c b/src/she

Re: [PATCH 1/2 v4] shell: enable moving and resizing of a surface when clicking on a subsurface

2013-02-26 Thread Giulio Camuffo
Great, thanks. :) Giulio 2013/2/26 Pekka Paalanen : > On Tue, 26 Feb 2013 15:59:57 +0100 > Giulio Camuffo wrote: > >> --- >> src/shell.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/src/shell.c b/src/shell.c >> index c8f20ec..da41efa 100644 >> --- a/src/sh

Re: [PATCH 1/2 v4] shell: enable moving and resizing of a surface when clicking on a subsurface

2013-02-26 Thread Pekka Paalanen
On Tue, 26 Feb 2013 15:59:57 +0100 Giulio Camuffo wrote: > --- > src/shell.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/shell.c b/src/shell.c > index c8f20ec..da41efa 100644 > --- a/src/shell.c > +++ b/src/shell.c > @@ -1092,10 +1092,12 @@ shell_surface

[PATCH 1/2 v4] shell: enable moving and resizing of a surface when clicking on a subsurface

2013-02-26 Thread Giulio Camuffo
--- src/shell.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/shell.c b/src/shell.c index c8f20ec..da41efa 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1092,10 +1092,12 @@ shell_surface_move(struct wl_client *client, struct wl_resource *resource, { str

[PATCH 1/2 v3] shell: enable moving and resizing of a surface when clicking on a subsurface

2013-02-26 Thread Giulio Camuffo
--- src/shell.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/shell.c b/src/shell.c index c8f20ec..70fd575 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1092,10 +1092,12 @@ shell_surface_move(struct wl_client *client, struct wl_resource *resource, { str

Re: [PATCH 3/4] protocol: Introduce pointer_lock interface

2013-02-26 Thread Pekka Paalanen
On Tue, 26 Feb 2013 14:57:12 +0200 Pekka Paalanen wrote: > On Mon, 25 Feb 2013 21:24:47 -0500 > Kristian Høgsberg wrote: > > > The pointer_lock interface is modelled after the HTML5 pointer lock > > extension: > > > > https://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html > > > > Th

[PATCH 2/2 v2] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Giulio Camuffo
We must calculate the bounding box of the surface + subsurfaces set and use that when maximizing the window or going fullscreen. --- src/shell.c | 83 + 1 file changed, 62 insertions(+), 21 deletions(-) diff --git a/src/shell.c b/src/she

[PATCH 1/2 v2] shell: enable moving and resizing of a surface when clicking on a subsurface

2013-02-26 Thread Giulio Camuffo
This uses weston_surface_get_parent() as suggested by Pekka. --- src/shell.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/shell.c b/src/shell.c index c8f20ec..6960fcd 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1092,10 +1092,12 @@ shell_surface_move(struct wl

Re: [PATCH wayland] client: add wl_proxy_get_class()

2013-02-26 Thread Pekka Paalanen
On Tue, 26 Feb 2013 15:19:44 +0200 Pekka Paalanen wrote: > This is a useful shorthand for client application debugging macros, > since you can ask the object class from the object itself. > > Signed-off-by: Pekka Paalanen > --- > src/wayland-client.c | 12 > src/wayland-client.h |

[PATCH wayland] client: add wl_proxy_get_class()

2013-02-26 Thread Pekka Paalanen
This is a useful shorthand for client application debugging macros, since you can ask the object class from the object itself. Signed-off-by: Pekka Paalanen --- src/wayland-client.c | 12 src/wayland-client.h | 1 + 2 files changed, 13 insertions(+) diff --git a/src/wayland-client

[PATCH weston] update .gitignores for src/ and man/

2013-02-26 Thread Pekka Paalanen
Signed-off-by: Pekka Paalanen --- man/.gitignore | 1 + src/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/man/.gitignore b/man/.gitignore index dfabd62..6138c7d 100644 --- a/man/.gitignore +++ b/man/.gitignore @@ -1,3 +1,4 @@ weston.1 weston-drm.7 +weston.ini.5 diff --git a

Re: [PATCH 4/5] compositor: Implement pointer_lock

2013-02-26 Thread Pekka Paalanen
On Mon, 25 Feb 2013 21:33:24 -0500 Kristian Høgsberg wrote: > The pointer lock extension lets a client lock pointer motion and receive > relative pointer motion events. This patch implements the weston side > of the extension. > --- > src/compositor.c | 184 > ++

Re: [PATCH 3/4] protocol: Introduce pointer_lock interface

2013-02-26 Thread Pekka Paalanen
On Mon, 25 Feb 2013 21:24:47 -0500 Kristian Høgsberg wrote: > The pointer_lock interface is modelled after the HTML5 pointer lock > extension: > > https://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html > > The extension allows a wayland client to lock the pointer while a surface > is

Re: [PATCH 5/5] resizor: Lock pointer on click

2013-02-26 Thread Pekka Paalanen
On Mon, 25 Feb 2013 21:33:25 -0500 Kristian Høgsberg wrote: > We add a resize mode to resizor where you can click to resize it using > pointer lock and relative motion. > --- > clients/resizor.c | 74 > +++ > 1 file changed, 74 insertions(+) >

Re: [PATCH 4/5] compositor: Implement pointer_lock

2013-02-26 Thread Pekka Paalanen
On Mon, 25 Feb 2013 21:33:24 -0500 Kristian Høgsberg wrote: > The pointer lock extension lets a client lock pointer motion and receive > relative pointer motion events. This patch implements the weston side > of the extension. > --- > src/compositor.c | 184 > ++

[PATCH weston] compositor-drm: Fix a crash with a fullscreen surface with driver mode

2013-02-26 Thread Ander Conselvan de Oliveira
If there was a fullscreen surface using driver mode when a vt switch is triggered, but something caused it to be gone when switching back (such as the client being killed), a call to drm_output_switch_mode() is made to restore the old mode, and that sets the output's current drm_fb to NULL, so that

Re: [PATCH 2/2] shell: account for the subsurfaces when going fullscreen or maximizing

2013-02-26 Thread Pekka Paalanen
On Mon, 25 Feb 2013 18:59:51 +0100 Giulio Camuffo wrote: > We must calculate the bounding box of the surface + subsurfaces set and use > that when maximizing the window or going fullscreen. > --- > src/shell.c | 118 > ++-- > 1 file change

Re: [PATCH 1/2] shell: enable moving and resizing of a surface when clicking on a subsurface

2013-02-26 Thread Pekka Paalanen
On Mon, 25 Feb 2013 18:59:50 +0100 Giulio Camuffo wrote: > --- > src/shell.c | 36 > 1 file changed, 32 insertions(+), 4 deletions(-) > > diff --git a/src/shell.c b/src/shell.c > index c8f20ec..5273bc1 100644 > --- a/src/shell.c > +++ b/src/shell.c > @@ -109

Re: [PATCH weston] toytoolkit: avoid redrawing a window between when it asks to be maximized and when it gets the configure

2013-02-26 Thread Pekka Paalanen
On Mon, 25 Feb 2013 18:37:05 -0800 Bill Spitzak wrote: > I think that has to be a bug in toytoolkit. It is actually drawing the > frame and buttons in different places. I don't think that is a > compositor or wayland api problem. Yes, I think so, too. > However more searching and I think you