RE: Weston SDK

2013-02-15 Thread Eoff, Ullysses A
I do have some test extension scenarios in mind that would greatly benefit from having the “x11_compositor” and “x11_output” structures partially exported: struct x11_compositor { struct weston_compositor base; Display *dpy; xcb_connection_t *conn;

[PATCH] Install header files and pkg-config file for external modules

2013-02-15 Thread Kristian Høgsberg
This patch installs the three header files that define the compositor plugin interface as well as a pkg-config file. This allows building weston plugins outside the weston tree. We currently don't make any guarantees about the plugin API/ABI except that within a stable branch we won't break it. -

Patch queue update

2013-02-15 Thread Kristian Høgsberg
Hi all, Here's the patch queue update for today. Since last time, I've merge Tiagos non-blocking auth for xwayland and Jans input method patches. New on the list is the FreeBSD porting patches from Philip. I was hoping to go through Jonas' per-output workspace series this week, but the 1.0.5 rel

Re: [PATCH 0/5] Input method support cleanup

2013-02-15 Thread Kristian Høgsberg
On Thu, Jan 31, 2013 at 03:52:18PM +0100, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Another series of input method support patches. Mostly some > cleanups in the protocol: > > * Remove some unused requests events (set_preedit etc) > > * Add a commit request to allow to batch differ

Re: [PATCH 00/18] Input method support patches

2013-02-15 Thread Kristian Høgsberg
On Wed, Jan 16, 2013 at 09:26:37PM +0100, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > There are some penfing input method support patches. I rebased them on master. I grabbed this series, it mostly looks good. There's still some discussion about these and the other series, but for no

Re: [PATCH] shell: Set the DPMS state if the screensaver fails to launch or dies

2013-02-15 Thread Kristian Høgsberg
On Fri, Feb 15, 2013 at 06:44:19PM +0200, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > The lock hook in desktop-shell only changes the DPMS state the second > time it is called, because during the first time it launches the > screensaver and wakes the compositor agai

Re: Weston SDK

2013-02-15 Thread Daniel Stone
Hi, On 15 February 2013 16:02, Fred Ollinger wrote: > Surely there is functionality that plugin authors will want which will > not change? > Yes, but exactly what that is is a far more difficult question. Help welcome. Cheers, Daniel ___ wayland-dev

Re: [PATCH 05/12] event-loop-test: Add some more assertions and work around a FreeBSD bug

2013-02-15 Thread Dima Ryazanov
Ah, got it, sorry. On Fri, Feb 15, 2013 at 10:20 AM, Pekka Paalanen wrote: > On Fri, 15 Feb 2013 09:48:35 -0500 > Dima Ryazanov wrote: > > > On Fri, Feb 15, 2013 at 7:56 AM, Philip Withnall >wrote: > > > > > There’s a bug in FreeBSD’s handling of timer events which means we > have to > > > be m

[PATCH] shell: Set the DPMS state if the screensaver fails to launch or dies

2013-02-15 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira The lock hook in desktop-shell only changes the DPMS state the second time it is called, because during the first time it launches the screensaver and wakes the compositor again when the screensaver surface is configured. However, if the screensaver fails to laun

Re: Weston SDK

2013-02-15 Thread Fred Ollinger
Why not have an external api which does not change? Surely there is functionality that plugin authors will want which will not change? I know that one objection is that there's the question of who is going to maintain the glue b/w the external and internal. Perhaps we can leave that to the plugin

Re: [PATCH 02/12] event-loop: Add support for BSD???s kevent() instead of epoll()

2013-02-15 Thread Jason Ekstrand
I'm a little worried that we're going to make event-loop too much of a mess of #defines without covering all the cases. My use-case, Android, is Linux but not GNU/Linux; it uses something called Bionic. Same kernel, different standard library and a different set of system calls. Specifically, tim

Re: [PATCH 05/12] event-loop-test: Add some more assertions and work around a FreeBSD bug

2013-02-15 Thread Pekka Paalanen
On Fri, 15 Feb 2013 09:48:35 -0500 Dima Ryazanov wrote: > On Fri, Feb 15, 2013 at 7:56 AM, Philip Withnall > wrote: > > > There’s a bug in FreeBSD’s handling of timer events which means we have to > > be more relaxed about how we check when timer events have happened because > > FreeBSD can’t m

Re: [PATCH 05/12] event-loop-test: Add some more assertions and work around a FreeBSD bug

2013-02-15 Thread Dima Ryazanov
On Fri, Feb 15, 2013 at 7:56 AM, Philip Withnall wrote: > There’s a bug in FreeBSD’s handling of timer events which means we have to > be more relaxed about how we check when timer events have happened because > FreeBSD can’t manage enough precision on scheduling the events. > > Signed-off-by: Phi

[PATCH 12/12] wayland-server.c: Fix dereferencing types of new objects

2013-02-15 Thread Philip Withnall
The type should be stored in the same location as the argument. This fixes the test suite on FreeBSD. Signed-off-by: Philip Withnall --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 8eef048..a6966e1 100

[PATCH 11/12] queue-test: Add another assertion

2013-02-15 Thread Philip Withnall
Ensure that the round trip succeeds. Signed-off-by: Philip Withnall --- tests/queue-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/queue-test.c b/tests/queue-test.c index c9d3668..da2b237 100644 --- a/tests/queue-test.c +++ b/tests/queue-test.c @@ -86,7 +86,7 @@

[PATCH 10/12] tests: Use /dev/fd on FreeBSD to determine open FDs

2013-02-15 Thread Philip Withnall
FreeBSD doesn’t have /proc/self/fd; it uses fdescfs instead, which must be mounted explicitly before the test suite can be run, using: mount -f fdescfs fdescfs /dev/fd Signed-off-by: Philip Withnall --- tests/test-helpers.c | 22 +++--- 1 file changed, 19 insertions(+), 3 del

[PATCH 09/12] tests: Update test suite to work on FreeBSD

2013-02-15 Thread Philip Withnall
• Add missing #includes which FreeBSD needs. • Disable leak checking because malloc() and friends can’t be overridden. • Use waitpid() instead of waitid() (which doesn’t exist on FreeBSD). Signed-off-by: Philip Withnall --- configure.ac| 7 +++ tests/queue-test.c | 5 + tes

[PATCH 08/12] wayland-server: Abort if a read from a client gives 0 length

2013-02-15 Thread Philip Withnall
This happens if the socket has been gracefully closed. Signed-off-by: Philip Withnall --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 614dd2f..8eef048 100644 --- a/src/wayland-server.c +++ b/src/waylan

[PATCH 07/12] wayland-os: Always use CLOEXEC fallbacks on FreeBSD

2013-02-15 Thread Philip Withnall
FreeBSD doesn’t support useful flags like SOCK_CLOEXEC, so we have to suffer the race condition and always use the fcntl(F_SETFD, FD_CLOEXEC) fallback on FreeBSD. This also requires disabling some tests which test whether the fallbacks have been hit. Signed-off-by: Philip Withnall --- src/wayla

[PATCH 06/12] event-loop.c: Use correct OS abstraction function for dupfd()

2013-02-15 Thread Philip Withnall
Signed-off-by: Philip Withnall --- src/event-loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index 05baa48..6330763 100644 --- a/src/event-loop.c +++ b/src/event-loop.c @@ -220,7 +220,7 @@ wl_event_loop_add_fd(struct wl_event_loop *lo

[PATCH 05/12] event-loop-test: Add some more assertions and work around a FreeBSD bug

2013-02-15 Thread Philip Withnall
There’s a bug in FreeBSD’s handling of timer events which means we have to be more relaxed about how we check when timer events have happened because FreeBSD can’t manage enough precision on scheduling the events. Signed-off-by: Philip Withnall --- tests/event-loop-test.c | 22 --

[PATCH 04/12] configure: Use AC_CHECK_LIB() to find libdl

2013-02-15 Thread Philip Withnall
This is necessary on FreeBSD. Signed-off-by: Philip Withnall --- configure.ac | 4 tests/Makefile.am | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 3ad39ab..35b89c8 100644 --- a/configure.ac +++ b/configure.ac @@ -52,6 +52,10 @@

[PATCH 03/12] server: Add support for BSD’s xucred credentials

2013-02-15 Thread Philip Withnall
This is an alternative to the traditional ucred on Linux. Signed-off-by: Philip Withnall --- configure.ac | 3 ++ src/wayland-server.c | 33 +++ src/wayland-shm.c| 91 +++- 3 files changed, 126 insertions(+), 1 deletion

[PATCH 02/12] event-loop: Add support for BSD???s kevent() instead of epoll()

2013-02-15 Thread Philip Withnall
This is a large step towards supporting the BSDs. There’s quite a lot of little in the test suite). Signed-off-by: Philip Withnall --- configure.ac | 8 ++ src/event-loop.c | 361 +-- src/wayland-os.c | 23 ++- src/waylan

[PATCH 01/12] connection: Fix sendmsg() on FreeBSD

2013-02-15 Thread Philip Withnall
It expects ((msg_controllen == 0) == (msg_control == NULL)), and returns EINVAL otherwise. It can’t hurt to be tidy about things on other platforms either though. See: http://www.freebsd.org/cgi/query-pr.cgi?pr=docs/99356#reply2 Signed-off-by: Philip Withnall --- src/connection.c | 13 +

Re: Weston SDK

2013-02-15 Thread Pekka Paalanen
On Thu, 14 Feb 2013 11:27:22 -0500 Kristian Høgsberg wrote: > Hi, > > I made a little experiment last night: > > http://cgit.freedesktop.org/~krh/overlay-plugin > > It's an out-of-tree weston plugin. It's just a silly little overlay > that you can pop up with mod-space, but the interesting

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-15 Thread Pekka Paalanen
On Thu, 14 Feb 2013 11:51:15 -0500 Kristian Høgsberg wrote: > On Wed, Feb 13, 2013 at 04:06:38PM +0200, Ander Conselvan de Oliveira wrote: > > The page flip event timestamps comes from the monotonic clock, while > > idle_repaint() gets the time with gettimeofday(). That leads to > > inconsistent