Re: [PATCH v2 wayland 1/2] protocol: Add a request and event to identify the visible area for a surface

2013-02-08 Thread Bill Spitzak
Scott Moreau wrote: Wouldn't a client then be able to compute its absolute position in global coordinates using this protocol and the output information? Not if the compositor returns something other than the output's bounds for the clipping, for instance it could remove the area covered by a

Re: [PATCH v2 wayland 1/2] protocol: Add a request and event to identify the visible area for a surface

2013-02-08 Thread Scott Moreau
On Fri, Feb 8, 2013 at 8:11 AM, Rob Bradford wrote: > From: Rob Bradford > > Add a probe_area request to the wl_shell_surface interface along with a > visible_area event to communicate the result of the probe. > > The intention of this request and event is to allow the client to try and > refine

Re: [PATCH v2 wayland 1/2] protocol: Add a request and event to identify the visible area for a surface

2013-02-08 Thread Bill Spitzak
You may need to replicate the "flags" argument from A.13.1.5. wl_shell_surface::set_transient http://wayland.freedesktop.org/docs/html/protocol-spec-interface-wl_shell_surface.html The description is vague and I thought maybe this was intended to control automatic positioning, but I now think i

Re: [PATCH weston 1/3] tests: add frame callback waiting helpers

2013-02-08 Thread Kristian Høgsberg
On Fri, Feb 08, 2013 at 05:01:25PM +0200, Pekka Paalanen wrote: > To avoid duplicating the code for setting and waiting for a frame > callback, add helpers for it. > > Convert move_client() to use the new helpers. All three look good, committed. Thanks, Kristian > Signed-off-by: Pekka Paalanen

Re: [PATCH v5 xserver] xwayland: Don't block in DRI2 authentication mechanism

2013-02-08 Thread Kristian Høgsberg
On Fri, Feb 08, 2013 at 02:57:01PM +0200, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Cool, this all looks good now, all three patches committed. Thanks, Kristian > v2: - added AuthMagic3, for passing ClientPtr > - fixed server internal ABI issue, by maintaining DRI2Authenticate i

[PATCH v2 weston 2/2] window: Use probe area to position popup window so it always visible

2013-02-08 Thread Rob Bradford
From: Rob Bradford With this change the popup menu will not go beyond the borders of the output. --- clients/window.c | 66 +--- 1 file changed, 58 insertions(+), 8 deletions(-) diff --git a/clients/window.c b/clients/window.c index 9c21f06..4

[PATCH v2 weston 1/2] shell: Implement the probe_area request on the shell surface

2013-02-08 Thread Rob Bradford
From: Rob Bradford --- src/shell.c | 86 - 1 file changed, 85 insertions(+), 1 deletion(-) diff --git a/src/shell.c b/src/shell.c index 368fa5b..5bddf12 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1917,6 +1917,89 @@ shell_surface_se

[PATCH v2 wayland 2/2] protocol: Make it clear that returned "one-shot" objects are destroyed

2013-02-08 Thread Rob Bradford
From: Rob Bradford The objects returned by the frame and sync request are destroyed by the compositor after the "done" event on the wl_callback interface is fired. --- protocol/wayland.xml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/

[PATCH v2 wayland 1/2] protocol: Add a request and event to identify the visible area for a surface

2013-02-08 Thread Rob Bradford
From: Rob Bradford Add a probe_area request to the wl_shell_surface interface along with a visible_area event to communicate the result of the probe. The intention of this request and event is to allow the client to try and refine the placement of popup windows that would otherwise be unusable.

[PATCH weston 3/3] tests: add test for buffer release event

2013-02-08 Thread Pekka Paalanen
Tests especially, that attach-attach-commit does not result in a release of the first buffer. Also tests, that the old buffer is released when a new buffer has been attached, committed, and displayed (frame callback). Signed-off-by: Pekka Paalanen --- tests/event-test.c | 69 +++

[PATCH weston 2/3] tests: export create_shm_buffer() helper

2013-02-08 Thread Pekka Paalanen
Lets the tests create additional buffers easily. Signed-off-by: Pekka Paalanen --- tests/weston-test-client-helper.c | 35 +++ tests/weston-test-client-helper.h | 3 +++ 2 files changed, 22 insertions(+), 16 deletions(-) diff --git a/tests/weston-test-client-hel

[PATCH weston 1/3] tests: add frame callback waiting helpers

2013-02-08 Thread Pekka Paalanen
To avoid duplicating the code for setting and waiting for a frame callback, add helpers for it. Convert move_client() to use the new helpers. Signed-off-by: Pekka Paalanen --- tests/weston-test-client-helper.c | 33 - tests/weston-test-client-helper.h | 6 ++

Re: [PATCH wayland 0/7] Add support for custom dispatchers

2013-02-08 Thread Jason Ekstrand
A couple of questions: 1) How would you like to handle the ABI issues? If we create version 0 wl_interface objects in the scanner, everything seems to work fine. The clients complain a bit a bout sizes of objects changing in the version they were originally linked against, but the still work. How

[PATCH v5] xwayland: Use new DRI2 AuthMagic3

2013-02-08 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- v3: (nil) v4: (nil) v5: - rebase against correct branch. src/intel_dri.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel_dri.c b/src/intel_dri.c index 038940e..f1a686c 100644 --- a/src/intel_dri.c +++ b/src/intel_dri.c @

[PATCH v5 xserver] xwayland: Don't block in DRI2 authentication mechanism

2013-02-08 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- v2: - added AuthMagic3, for passing ClientPtr - fixed server internal ABI issue, by maintaining DRI2Authenticate intact - fixed multiple clients accesses to DRI2 authenticate, using Wayland callback mechanism to ensure they all go atomically v3: - f

[PATCH v5 weston] tests: Add XWayland test

2013-02-08 Thread Tiago Vignatti
By default enabled but one can disable it by passing --disable-xwayland-test to the configure script. Also, the weston-tests-env script is trying to load xwayland.so in either case, but it behaves resilient in the absence of that meaning all the other tests are still going to be kicked for running.

Re: Getting valgrind/callgrind dumps for weston.

2013-02-08 Thread Pekka Paalanen
On Fri, 8 Feb 2013 11:33:40 +0530 ashjas wrote: > Hello, > > I am not able to produce any valid callgrind dumps for weston. > > i am giving the following command: > valgrind --tool=callgrind ./weston-launch -- > --modules=xwayland.so,desktop-shell.so > > i get a fully functional weston compos

Re: How to create pixmap or pixmap surface in wayland?

2013-02-08 Thread Pekka Paalanen
On Fri, 8 Feb 2013 02:16:39 + "Wang, Quanxian" wrote: > Sorry Pq. I confused you so much. > > Just one requirement not related with architecture. You can imagine write a > simple program for example glxgears. No compositor manager, no architecture, > no window manager. Just has x server, o

Re: [PATCH] connection: Add some documentation to wl_connection_demarshal()

2013-02-08 Thread Philip Withnall
On Thu, 2013-02-07 at 21:13 -0500, Kristian Høgsberg wrote: > On Mon, Feb 04, 2013 at 11:21:46AM +, Philip Withnall wrote: > > Signed-off-by: Philip Withnall > > --- > > src/connection.c | 62 > > > > 1 file changed, 62 insertions(+) >