Re: [PATCH 3/3] Make EGL/GLESv2 dependencies optional

2013-01-10 Thread Vasily Khoruzhick
On Fri, Jan 11, 2013 at 1:33 AM, David Herrmann wrote: > Hi > > On Wed, Jan 9, 2013 at 10:44 AM, Vasily Khoruzhick wrote: >> On Wed, Jan 9, 2013 at 12:03 AM, Vasily Khoruzhick >> wrote: >>> On Wed, Jan 9, 2013 at 12:01 AM, John Kåre Alsaker >>> wrote: EGLDisplay, EGLSurface, EGLNativeDisp

Re: [PATCH 3/3] Make EGL/GLESv2 dependencies optional

2013-01-10 Thread David Herrmann
Hi On Wed, Jan 9, 2013 at 10:44 AM, Vasily Khoruzhick wrote: > On Wed, Jan 9, 2013 at 12:03 AM, Vasily Khoruzhick wrote: >> On Wed, Jan 9, 2013 at 12:01 AM, John Kåre Alsaker >> wrote: >>> EGLDisplay, EGLSurface, EGLNativeDisplayType and EGLNativeWindowType >>> should all be void *. With that c

Planning weston 1.0.4 release next week

2013-01-10 Thread Kristian Høgsberg
Hi, As I wrote in the reply to Ning Tang, let's do a 1.0.4 release a week from now to get the disable_unused_sprites fix out. If anybody else has fixes or other material for a 1.0.4 release, please let me know in the next few days. Kristian ___ wayland

Re: [PATCH weston 1.0] compositor-drm: Remove drm_disable_unused_sprites()

2013-01-10 Thread Kristian Høgsberg
On Thu, Dec 27, 2012 at 03:36:35PM +0800, ning.t...@intel.com wrote: > From: Ning Tang > > If a sprite is no longer used, it is disabled on the call to > drmModeSetPlane() when doing the output repaint, since its > pending_fb_id is 0. > > This patch is a backport patch on weston 1.0. > Originall

Re: Some more static analysis fixes for Weston

2013-01-10 Thread Kristian Høgsberg
On Thu, Jan 10, 2013 at 07:48:51PM +, Rob Bradford wrote: > Here are a few more patches to fix issues identified from our Coverity scan. Thanks Rob, looks good, all applied. > Cheers, > > Rob > ___ > wayland-devel mailing list > wayland-devel@lists

Re: [PATCH weston] gl: fix read-back format reporting in the log

2013-01-10 Thread Kristian Høgsberg
On Thu, Jan 10, 2013 at 04:50:42PM +0200, Pekka Paalanen wrote: > weston_compositor::read_format is in Pixman values now, so comparing to > a GL value does not work. Compare to the right value. > > This fix affects only the log output of the GL renderer. Thanks, applied. > Signed-off-by: Pekka P

Re: [RFC] Sub-surface protocol and implementation v1

2013-01-10 Thread John Kåre Alsaker
On Thu, Jan 10, 2013 at 9:49 AM, Pekka Paalanen wrote: > On Wed, 9 Jan 2013 18:14:12 +0100 > John Kåre Alsaker wrote: > >> On Wed, Jan 9, 2013 at 10:53 AM, Pekka Paalanen wrote: >> > On Tue, 8 Jan 2013 21:50:20 +0100 >> > John Kåre Alsaker wrote: >> > >> >> My goals for a subsurface implementat

[PATCH 5/6] backlight: Avoid passing an invalid fd into close()

2013-01-10 Thread Rob Bradford
From: Rob Bradford --- src/libbacklight.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/libbacklight.c b/src/libbacklight.c index add89b2..98a20be 100644 --- a/src/libbacklight.c +++ b/src/libbacklight.c @@ -68,7 +68,8 @@ static long backlight_get(struct backli

[PATCH 6/6] xwayland/window-manager: Avoid doing work for unknown window

2013-01-10 Thread Rob Bradford
From: Rob Bradford In particular if the hash table lookup fails and returns NULL then that value would be passed into weston_wm_window_schedule_repaint which does not accept a NULL value. --- src/xwayland/window-manager.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/

[PATCH 3/6] window: Free allocated memory on error path

2013-01-10 Thread Rob Bradford
From: Rob Bradford --- clients/window.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/window.c b/clients/window.c index 2baf4d9..0701981 100644 --- a/clients/window.c +++ b/clients/window.c @@ -4241,6 +4241,7 @@ display_create(int argc, char *argv[]) d->display = wl_display

[PATCH 4/6] image: Free allocated memory on error path

2013-01-10 Thread Rob Bradford
From: Rob Bradford --- clients/image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/image.c b/clients/image.c index 6a2bda3..e25a665 100644 --- a/clients/image.c +++ b/clients/image.c @@ -373,6 +373,7 @@ image_create(struct display *display, const char *filename, if (!im

[PATCH 2/6] tests/setbacklight: Close filedescriptor on return paths

2013-01-10 Thread Rob Bradford
From: Rob Bradford --- tests/setbacklight.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/setbacklight.c b/tests/setbacklight.c index 8c7eb27..92bd4bf 100644 --- a/tests/setbacklight.c +++ b/tests/setbacklight.c @@ -74,9 +74,11 @@ get_drm_connector_type(struct udev_device *drm_devi

[PATCH 1/6] screenshooter: Free allocated memory where missing from some return paths

2013-01-10 Thread Rob Bradford
From: Rob Bradford --- src/screenshooter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/screenshooter.c b/src/screenshooter.c index 4f6599f..c8da376 100644 --- a/src/screenshooter.c +++ b/src/screenshooter.c @@ -417,6 +417,7 @@ weston_recorder_create(struct weston_output *output, co

Some more static analysis fixes for Weston

2013-01-10 Thread Rob Bradford
Here are a few more patches to fix issues identified from our Coverity scan. Cheers, Rob ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston] gl: fix read-back format reporting in the log

2013-01-10 Thread Pekka Paalanen
weston_compositor::read_format is in Pixman values now, so comparing to a GL value does not work. Compare to the right value. This fix affects only the log output of the GL renderer. Signed-off-by: Pekka Paalanen --- src/gl-renderer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [RFC] Sub-surface protocol and implementation v1

2013-01-10 Thread Pekka Paalanen
On Wed, 9 Jan 2013 18:14:12 +0100 John Kåre Alsaker wrote: > On Wed, Jan 9, 2013 at 10:53 AM, Pekka Paalanen wrote: > > On Tue, 8 Jan 2013 21:50:20 +0100 > > John Kåre Alsaker wrote: > > > >> My goals for a subsurface implementation are these: > >> - Allow nesting to ease interoperability for c