Re: [PATCH] shell: Implement wl_shell_surface_set_notification

2012-12-29 Thread Gregory Merchan
On Sat, Dec 29, 2012 at 7:55 PM, Bill Spitzak wrote: > Oh sh.. it is a "layer". > >> + struct weston_layer notification_layer; > > This is not good. Please figure out a way so that clients can control the > window stacking without having to copy every idea that a client needs into > the compos

Re: [PATCH] shell: Implement wl_shell_surface_set_notification

2012-12-29 Thread Bill Spitzak
Oh sh.. it is a "layer". > + struct weston_layer notification_layer; This is not good. Please figure out a way so that clients can control the window stacking without having to copy every idea that a client needs into the compositor. Recommendation: Each surface has a "parent", if it is no

Re: [PATCH] protocol: Add wl_shell_surface_set_notification

2012-12-29 Thread Bill Spitzak
I hope and pray this is not just "keep this surface on top" but instead an indication that the compositor should actually move it to some "notification area". You do not need "window classes" to keep windows on top. Please don't do this as it is detrimental to getting proper floating window su