Hi Tiago,
I have some questions below. Sorry for this being the only patch of the
series I can look at for now.
On Wed, 12 Dec 2012 13:26:33 -0200
Tiago Vignatti wrote:
> X11 apps use global coordinates most of the time for window placement and the
> current approach we have, where transient wi
On Wed, Dec 12, 2012 at 02:44:52PM +0200, Pekka Paalanen wrote:
> On Wed, 12 Dec 2012 14:26:38 +0200
> Pekka Paalanen wrote:
>
> > This cleans up the 'make check' output considerably. When all goes well,
> > you will only see the "PASS" line for each of $TESTS.
> >
> > Weston logs into a separat
X11 apps use global coordinates most of the time for window placement and the
current approach we have, where transient windows is placed parent relative,
is not sufficient. IOW we can't use the relation of parent <-> child
coordinates because we can't go out there and fix all the clients to place
No functional changes on X side.
Signed-off-by: Tiago Vignatti
---
hw/xfree86/xwayland/xserver.xml | 43 ++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/hw/xfree86/xwayland/xserver.xml b/hw/xfree86/xwayland/xserver.xml
index 3779d1a..eef687
Previously, windows were all positioned at (0, 0). Now, with this new
protocol, Wayland can forward the global position to map them correctly.
Signed-off-by: Tiago Vignatti
---
hw/xfree86/xwayland/xserver.xml| 33 +
hw/xfree86/xwayland/xwayland-input.c |8 +++--
h
Warning: selection is broken!
Signed-off-by: Tiago Vignatti
---
hw/xfree86/xwayland/xserver.xml | 104 -
hw/xfree86/xwayland/xwayland-window.c |2 +-
hw/xfree86/xwayland/xwayland.c| 23 +++-
3 files changed, 110 insertions(+), 19 deletions
Signed-off-by: Tiago Vignatti
---
hw/xfree86/xwayland/xwayland-drm.c | 35
hw/xfree86/xwayland/xwayland-input.c | 42
hw/xfree86/xwayland/xwayland-output.c | 38 --
hw/xfree86/xwayland/xwayland-private.h | 21 +++
This commit implements the selection proxy to connect XWayland copy-paste with
the Wayland one, bringing back the last remaining feature we had before the
xwm was split as a client (#2 selection support).
It connects the clipboard also for dealing with clients that go away. Worth to
note that this
The file was changed, moved to client side and a few variable names were
changed (like s/weston_wm/xwm_wm).
There's no functional changes yet, meaning that XWayland selection code is
completely disable still. But this will help to track the changes on the
following commit.
Signed-off-by: Tiago Vi
This patch brings back a feature we removed previously (#1 opaque region box)
Signed-off-by: Tiago Vignatti
---
clients/xwm.c | 57 ++
protocol/xserver.xml | 26 ++
src/xwayland/window-manager.c | 61 +
Warning: this removes functionality (#2)
In preparation for split xwm as a client; this will be re-implemented later.
Signed-off-by: Tiago Vignatti
---
src/xwayland/Makefile.am |1 -
src/xwayland/window-manager.c |9 -
src/xwayland/window-manager.h |1 -
3 files changed
This patch solves the window positioning problem through forwarding its global
coordinates to X. A change in desktop-shell protocol is needed for doing so
and to add a new type of surface, the xwayland (description and details of it
are on the previous commit and also in the protocol).
The approac
XWayland compositor counter-part is not implemented yet; next commit will
bring it on.
Signed-off-by: Tiago Vignatti
---
src/compositor.h |3 +--
src/shell.c | 39 +--
2 files changed, 38 insertions(+), 4 deletions(-)
diff --git a/src/compositor.h
It brings back a feature we removed previously:
#4 drawing scheduling and window activation
Signed-off-by: Tiago Vignatti
---
clients/xwm.c | 40 +++-
src/xwayland/window-manager.c | 12 +---
2 files changed, 36 insertions(+), 16
No functional changes.
Signed-off-by: Tiago Vignatti
---
clients/xwm.c | 251 -
clients/xwm.h | 12 +--
2 files changed, 131 insertions(+), 132 deletions(-)
diff --git a/clients/xwm.c b/clients/xwm.c
index 7d681f1..0e59f7c 100644
--- a/
The new protocol features the separation of the X Window Manager from Wayland
compositor. Compared with the previous protocol, it aims to avoid mutual
deadlock where Weston waits for a reply to get xcb_get_property(), while X is
waiting in some wl_display_roundtrip(). Other advantages exist also li
In preparation for split xwm as a client, we'll need the hash on both
compositor and client side.
At this point, X clients are still being mapped okay on the screen and in some
way are useful.
Signed-off-by: Tiago Vignatti
---
shared/Makefile.am|4 +-
shared/xwayland-hash.c
In preparation for split xwm as a client.
Signed-off-by: Tiago Vignatti
---
src/xwayland/window-manager.c | 68 -
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c
index 806cf8d.
Warning: this removes functionality (#4)
In preparation for split xwm as a client, we want to get rid of all
interactions of the compositor event loop here. Decorations and configure
mechanisms will be overhauled later anyway.
Signed-off-by: Tiago Vignatti
---
src/xwayland/window-manager.c |
Warning: this removes functionality (#3)
In preparation for split xwm as a client. In any case this wasn't functioning
properly and we need to change with a different scheme of forwarding the
global coordinates to X instead:
http://lists.freedesktop.org/archives/wayland-devel/2012-July/004537.
Warning: this removes functionality (#1)
In preparation for split xwm as a client, xwm client won't be able to modify
or access weston_surface directly like that. This will be re-implemented later
using set_opaque_region instead, so we disable for now.
Signed-off-by: Tiago Vignatti
---
src/xway
xwayland.h now has only private declarations to be shared between launcher.c,
selection.c and window-manager.c. window-manager.h is a new header containing
WM specific declarations.
The real motivate for this patch though is to serve in preparation for split
xwm as a client; in the future window-m
Hi all! Here's the remaining work:
http://cgit.freedesktop.org/~vignatti/wayland/log/?h=xwm-client
http://cgit.freedesktop.org/~vignatti/weston/log/?h=xwm-client
http://cgit.freedesktop.org/~vignatti/xserver/log/?h=xwm-client
In general I'm feeling quite comfortable with it and we now have in pla
Hi,
On 6 December 2012 01:32, Pekka Paalanen wrote:
> Clipping
>
> The term sub-surface sounds like a sub-window, which may cause one to
> think, that it will be clipped to the parent surface area. I do not
> think we should force or even allow such clipping.
>
> Forcing the clipping would waste
Hi,
On 6 December 2012 04:43, Tiago Vignatti wrote:
> indeed. On my "less intrusive" draft of subsurface, I've first started
> brainstorming the input focus behavior [0]. That's quite useful for the
> video player example that wants some kind of input control or a dialog
> stick window that might
On Wed, 12 Dec 2012 14:26:38 +0200
Pekka Paalanen wrote:
> This cleans up the 'make check' output considerably. When all goes well,
> you will only see the "PASS" line for each of $TESTS.
>
> Weston logs into a separate file than stdout and stderr, so server logs
> end up in one file per test, a
Add a macro that wraps wl_display_roundtrip() and check for errors. It
is a macro, so that the assert would show the relevant file and line
number.
This will also catch protocol errors, that would go unnoticed otherwise.
All roundtrips in tests are replaced with the check.
Signed-off-by: Pekka P
Otherwise we cannot normally see protocol errors etc. in the test
output.
Signed-off-by: Pekka Paalanen
---
tests/weston-test-client-helper.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/tests/weston-test-client-helper.c
b/tests/weston-test-client-helper.c
in
Signed-off-by: Pekka Paalanen
---
clients/.gitignore |2 ++
tests/.gitignore |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/clients/.gitignore b/clients/.gitignore
index 3e7cd6c..dcd4564 100644
--- a/clients/.gitignore
+++ b/clients/.gitignore
@@ -1,3 +1,4 @@
+cali
This cleans up the 'make check' output considerably. When all goes well,
you will only see the "PASS" line for each of $TESTS.
Weston logs into a separate file than stdout and stderr, so server logs
end up in one file per test, and other output to another file per test.
'make distclean' does not
The need for wl_display_update_func_t was removed in
commit 53d24713a31d59d9534c1c1a84a7ad46f44ee95f
Author: Kristian Høgsberg
Date: Thu Oct 4 16:54:22 2012 -0400
Change filedescriptor API to be thread safe
and wl_callback_func_t does not seem to have ever been used in the first place.
S
>-Original Message-
>From: wayland-devel-
>bounces+ullysses.a.eoff=intel@lists.freedesktop.org [mailto:wayland-
>devel-bounces+ullysses.a.eoff=intel@lists.freedesktop.org] On Behalf
>Of Kristian Høgsberg
>Sent: Tuesday, December 11, 2012 8:32 PM
>To: Eoff, Ullysses A
>Cc: wayland-de
32 matches
Mail list logo
