[PATCH 5/9] xwayland: Close fd opened for lockfile on error path

From: Rob Bradford --- src/xwayland/launcher.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xwayland/launcher.c b/src/xwayland/launcher.c index 59154a3..ddd9640 100644 --- a/src/xwayland/launcher.c +++ b/src/xwayland/launcher.c @@ -247,6 +247,9 @@ create_lockfile(int display, char

[PATCH 2/9] screenshooter: Report an error if we fail to open the file

From: Rob Bradford --- src/screenshooter.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/screenshooter.c b/src/screenshooter.c index 24999f3..840dfb8 100644 --- a/src/screenshooter.c +++ b/src/screenshooter.c @@ -404,9 +404,6 @@ weston_recorder_create(struct

[PATCH 9/9] weston-launch: Add some error reporting for weston-launch

From: Rob Bradford This also avoids us passing (size_t)(-1 * sizeof(gid_t)) into malloc --- src/weston-launch.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/weston-launch.c b/src/weston-launch.c index cb69968..6d1f7c3 100644 --- a/src/weston-launch.c +++ b/src/weston-launch.c @

[PATCH 8/9] compositor: Cleanup if we can't find the symbol in the module

From: Rob Bradford --- src/compositor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compositor.c b/src/compositor.c index b29d697..9f8fed6 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -3089,6 +3089,7 @@ load_module(const char *name, const char *entrypoint) init = d

[PATCH 7/9] backlight: Revamp error handling code to not leak the directory

From: Rob Bradford To neatly free the directory pointer allocated by opendir(), adjust the error handling paths to go through to the err label. --- src/libbacklight.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/libbacklight.c b/src/libbacklight.c ind

[PATCH 4/9] backlight: Remove unnecessary and confusing NULL checks

From: Rob Bradford At this point path must point to an allocated string since otherwise the asprintf that makes the allocation would have failed and we would have returned earlier. --- src/libbacklight.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/libbacklight.c

[PATCH 6/9] tty: Clean up completely if switching vt fails

From: Rob Bradford The code under the "err" label closes the file descriptor and frees the allocated memory. --- src/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty.c b/src/tty.c index 6d58aa5..05e5e20 100644 --- a/src/tty.c +++ b/src/tty.c @@ -174,7 +174,7 @@ t

[PATCH 3/9] compositor: Avoid sending event for invalid point

From: Rob Bradford Avoid sending a touch down event using uninitialised surface x/y co-ordinates. Instead present a log message about this unexpected case. --- src/compositor.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 565212d..b29d697 1

[PATCH 1/9] screenshooter: Abandon recording rather than use unitialised format

From: Rob Bradford Abandon the recording if the format is not known - this prevents the use of an unitialised member is the header struct. --- src/screenshooter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/screenshooter.c b/src/screenshooter.c index 422c2a9..24999f3

[weston] Some static analysis fixes

Here are some patches for some issues found with a static analysis tool. These issues are all pretty minor (the more serious issues were dealt with under my previous patch set and also a set from John Kåre Alsaker.) For some of these issues the added complexity / code-churn may not be worth it - b

Re: [PATCH wayland 3/5 v2] man: Properly handle multiple man page aliases

Hi Jonas On Sat, Dec 1, 2012 at 6:12 PM, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > > v2: Properly specify dependencies. Without this make -j8 fails. > > doc/man/Makefile.am |9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/doc/man/Makefile.am b/d

Re: Sub-surface protocol

Hi, On 12/05/2012 12:32 PM, Pekka Paalanen wrote: I have not even thought about sub-surfaces' implications to input handling or the shell yet. Sub-surfaces probably need to be able to receive input. The shell perhaps needs a bounding box of the set of surfaces to be able to pick an initial posi

Sub-surface protocol

Hi all, I am currently looking into sub-surfaces, first to sketch the protocol extension, and I have some open questions. I decided to write an exhaustive document, so we would all be on the same page, and also to clarify my own thoughts. Introduction Sub-surfaces are additional wl_surface obje

Re: [PATCH weston] rpi: Don't assign planes for surfaces with transformed buffers

Hi Kristian, Seems like you skipped this one. Thanks, Ander On 11/27/2012 05:34 PM, Ander Conselvan de Oliveira wrote: Reported-by: Pekka Paalanen --- Hi, Pekka noted that we also need this for correctness. Cheers, Ander src/compositor-rpi.c |6 ++ 1 file changed, 6 insertions(+

[PATCH weston 3/3] transformed: Use an opaque window

This allows us to use this client to test overlays with transformed buffers. --- clients/transformed.c |1 + 1 file changed, 1 insertion(+) diff --git a/clients/transformed.c b/clients/transformed.c index af77e18..4be3bca 100644 --- a/clients/transformed.c +++ b/clients/transformed.c @@ -228,

[PATCH weston 2/3] window: Bring back support for rgb windows

This let us test overlays with toytoolkit applications. We can't just rely on the opaque region, because a drmModeSetPlane() call will fail if we use an ARGB bo because of the format check. This reverts commits 067fd605345355094953d8e355fcfd0935304039, fedc527723128ee08f443c8955d75d7cd0d956a6 and

[PATCH weston 1/3] compositor-drm: Support overlays with transformed buffers

Make overlays work when the client uses a buffer with the same transformation as the output. In order to calculate the destination rectangle, the same logic in weston_surface_to_buffer_float() is needed, but with the output dimensions instead. For that reason, this patch generalizes this function

Re: [PATCH weston 5/9] tests: Add weston test client helper methods

On Tue, 4 Dec 2012 14:22:11 -0800 "U. Artie Eoff" wrote: > From: "U. Artie Eoff" > > Add client boiler plate methods to simplify writing tests that use > the weston test extension. > > Signed-off-by: U. Artie Eoff > --- > tests/weston-test-client-helper.c | 488 > ++

Re: Wayland and Weston 1.0

On Tue, 4 Dec 2012 16:33:56 +0100 (CET) Jan Engelhardt wrote: > > On Wednesday 2012-10-24 13:51, Pekka Paalanen wrote: > > > >>A few folks around me, and myself included, have pondered... > >> > >>It would seem that wayland and its possible compositors all require > >>3D support, which may requ