Re: [PATCH weston 04/17] xwayland: Staticize weston_wm_set_selection and read_and_dump_property

On Fri, Nov 30, 2012 at 05:19:59PM -0200, Tiago Vignatti wrote: Committed. Kristian > Signed-off-by: Tiago Vignatti > --- > src/xwayland/selection.c |2 +- > src/xwayland/window-manager.c |2 +- > src/xwayland/xwayland.h |6 -- > 3 files changed, 2 insertions(+), 8 de

Re: [PATCH weston 03/17] xwayland: Remove useless structure

On Fri, Nov 30, 2012 at 05:19:58PM -0200, Tiago Vignatti wrote: Right, that's a bit pointless. Kristian > Signed-off-by: Tiago Vignatti > --- > src/xwayland/xwayland.h |4 > 1 file changed, 4 deletions(-) > > diff --git a/src/xwayland/xwayland.h b/src/xwayland/xwayland.h > index a1ffa

Re: [PATCH weston 02/17] xwm: Rename get_resources function

On Fri, Nov 30, 2012 at 05:19:57PM -0200, Tiago Vignatti wrote: > It's pure WM-related function, so use the same 'weston_wm_' prefix that others > in the same file are already using. Makes sense, committed. Kristian > Signed-off-by: Tiago Vignatti > --- > src/xwayland/window-manager.c |4 ++

Re: [PATCH weston 01/17] xwayland: Standardize 'wxs' for weston_xserver variables

On Fri, Nov 30, 2012 at 05:19:56PM -0200, Tiago Vignatti wrote: > It was already being used in most of launcher.c and window-manager.c, so let's > make a standard everywhere now. Yeah, the mxs was a left-over from when it was meego xserver briefly. thanks, Kristian > Signed-off-by: Tiago Vignatt

Re: [PATCH mesa] egl/wayland: Dispatch the event queue before get_buffers

On Fri, Nov 30, 2012 at 05:15:44PM -0500, Kristian Høgsberg wrote: > On Fri, Nov 23, 2012 at 09:49:58PM -0500, Kristian Høgsberg wrote: > > On Thu, Nov 22, 2012 at 03:34:49PM +0200, Ander Conselvan de Oliveira wrote: > > > When a client frame callback is executed and the client starts rendering > >

Re: [PATCH mesa] egl/wayland: Dispatch the event queue before get_buffers

On Fri, Nov 23, 2012 at 09:49:58PM -0500, Kristian Høgsberg wrote: > On Thu, Nov 22, 2012 at 03:34:49PM +0200, Ander Conselvan de Oliveira wrote: > > When a client frame callback is executed and the client starts rendering > > again, the egl event queue might not have been dispatched so that the >

New Wayland and Weston 1.0.2 releases

Hi all, I was planning to do 1.0.2 once we landed the revised weston test suite, but we're sitting on a couple of important bugfixes and stable releases are cheap... f99bb1f4eb9d45df7d15875b7bcf0c8152e10901 wayland-1.0.2.tar.xz 64e37842983349dcb3bfd102885669db0c01b16c wayland 1.0.2 tag

Re: [PATCH weston 0/5] Convert transformed buffer test client to toytoolkit

On Fri, Nov 30, 2012 at 05:34:21PM +0200, Ander Conselvan de Oliveira wrote: > Hi, > > This series converts the transformed buffer test client to use toytoolkit. > > The first patch is a resend of a patch that fell through the cracks. With > the change to use toytoolkit, there's no way to allocat

[PATCH weston 17/17] xwayland: Fix window positioning

This patch solves the window positioning problem through forwarding its global coordinates to X. A change in desktop-shell protocol is needed for doing so and to add a new type of surface, the xwayland (description and details of it are on the previous commit and also in the protocol). The approac

[PATCH xserver 3/3] xwayland: Attach and configure window only when asked by Wayland

Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xserver.xml| 33 + hw/xfree86/xwayland/xwayland-private.h |3 ++ hw/xfree86/xwayland/xwayland-window.c |7 +--- hw/xfree86/xwayland/xwayland.c | 62 +++- 4 files changed,

[PATCH weston 16/17] shell: Implement XWayland shell surfaces

XWayland compositor counter-part is not implemented yet; next commit will bring it on. Signed-off-by: Tiago Vignatti --- src/compositor.h |3 +-- src/shell.c | 39 +-- 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/src/compositor.h

[PATCH wayland] protocol: Add set_xwayland request for new shell surface type

X11 apps use global coordinates most of the time for window placement and the current approach we have, where transient windows is placed parent relative, is not sufficient. IOW we can't use the relation of parent <-> child coordinates because we can't go out there and fix all the clients to place

[PATCH weston 15/17] clients: xwm: Fix frame repaint

It brings back a feature we removed previously: #4 drawing scheduling and window activation (21c685d9) Signed-off-by: Tiago Vignatti --- clients/xwm.c | 40 +++- src/xwayland/window-manager.c | 12 +--- 2 files changed, 36 insert

[PATCH weston 14/17] clients: xwm: Remove all references for weston

No functional changes. Signed-off-by: Tiago Vignatti --- clients/xwm.c | 251 - clients/xwm.h | 12 +-- 2 files changed, 131 insertions(+), 132 deletions(-) diff --git a/clients/xwm.c b/clients/xwm.c index 0d0a413..41d446b 100644 --- a/

[PATCH xserver 2/3] xwayland: Track new protocol for xwm split

Warning: selection is broken! Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xserver.xml | 104 - hw/xfree86/xwayland/xwayland-window.c |2 +- hw/xfree86/xwayland/xwayland.c| 23 +++- 3 files changed, 110 insertions(+), 19 deletions

[PATCH xserver 1/3] xwayland: Cache globals to avoid multiple registry objects

Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-drm.c | 35 hw/xfree86/xwayland/xwayland-input.c | 42 hw/xfree86/xwayland/xwayland-output.c | 38 -- hw/xfree86/xwayland/xwayland-private.h | 21 +++

[PATCH weston 13/17] Introduce new XWayland protocol and implementation

The new protocol features the separation of the X Window Manager from Wayland compositor. Compared with the previous protocol, it aims to avoid mutual deadlock where Weston waits for a reply to get xcb_get_property(), while X is waiting in some wl_display_roundtrip(). Other advantages exist also li

[PATCH weston 11/17] xwayland: Move hash implementation to shared

In preparation for split xwm as a client, we'll need the hash on both compositor and client side. At this point, X clients are still being mapped okay on the screen and in some way are useful. Signed-off-by: Tiago Vignatti --- shared/Makefile.am|4 +- shared/xwayland-hash.c

[PATCH weston 10/17] xwm: Change weston_log by fprintf

In preparation for split xwm as a client. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c | 68 - 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c index 806cf8d.

[PATCH weston 09/17] xwm: Get rid of compositor loop handlers

Warning: this removes functionality (#4) In preparation for split xwm as a client, we want to get rid of all interactions of the compositor event loop here. Decorations and configure mechanisms will be overhauled later anyway. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c |

[PATCH weston 08/17] xwm: Remove support for transient windows

Warning: this removes functionality (#3) In preparation for split xwm as a client. In any case this wasn't functioning properly and we need to change with a different scheme of forwarding the global coordinates to X instead: http://lists.freedesktop.org/archives/wayland-devel/2012-July/004537.

[PATCH weston 07/17] xwayland: Drop selection support

Warning: this removes functionality (#2) In preparation for split xwm as a client; this will be re-implemented later. Signed-off-by: Tiago Vignatti --- src/xwayland/Makefile.am |1 - src/xwayland/window-manager.c |9 - src/xwayland/window-manager.h |1 - 3 files changed

[PATCH weston 06/17] xwm: Disable opaque_rect settings

Warning: this removes functionality (#1) In preparation for split xwm as a client, xwm client won't be able to modify or access weston_surface directly like that. This will be re-implemented later using set_opaque_region instead, so we disable for now. Signed-off-by: Tiago Vignatti --- src/xway

[PATCH weston 05/17] xwayland: Split header file in WM specific and XWayland internals

xwayland.h now has only private declarations to be shared between launcher.c, selection.c and window-manager.c. window-manager.h is a new header containing WM specific declarations. The real motivate for this patch though is to serve in preparation for split xwm as a client; in the future window-m

[PATCH weston 04/17] xwayland: Staticize weston_wm_set_selection and read_and_dump_property

Signed-off-by: Tiago Vignatti --- src/xwayland/selection.c |2 +- src/xwayland/window-manager.c |2 +- src/xwayland/xwayland.h |6 -- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/xwayland/selection.c b/src/xwayland/selection.c index cd49289..edc7ce

[PATCH weston 03/17] xwayland: Remove useless structure

Signed-off-by: Tiago Vignatti --- src/xwayland/xwayland.h |4 1 file changed, 4 deletions(-) diff --git a/src/xwayland/xwayland.h b/src/xwayland/xwayland.h index a1ffa2a..dde1bf6 100644 --- a/src/xwayland/xwayland.h +++ b/src/xwayland/xwayland.h @@ -27,10 +27,6 @@ #include "../compos

[PATCH weston 02/17] xwm: Rename get_resources function

It's pure WM-related function, so use the same 'weston_wm_' prefix that others in the same file are already using. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xwayland/window-manager.c b/src/xwayla

[PATCH weston 01/17] xwayland: Standardize 'wxs' for weston_xserver variables

It was already being used in most of launcher.c and window-manager.c, so let's make a standard everywhere now. Signed-off-by: Tiago Vignatti --- src/xwayland/launcher.c | 102 +++ 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/src/xwa

xwm-client patches

Hi, I've tried to organize the patches in a way to "just" move xwm to client side. I'd say we can discuss & review these for now and once we agree with something, I'll submit the remaining work -- to draw window frame using cairo surface backed by Wayland buffer instead XCB, then introduce the sub

Re: [PATCH weston 2/2] Fix build warnings from image_loader

On Fri, Nov 30, 2012 at 01:37:28PM +0200, Pekka Paalanen wrote: > Fix the following build warnings, and the build failures due to the > warning fixes: > > CC libshared_cairo_la-image-loader.lo > image-loader.c:369:1: warning: no previous prototype for 'load_image' > > CC x11_backend_l

Re: [PATCH weston 1/2] window: change boolean to flags in toysurface::prepare()

On Fri, Nov 30, 2012 at 01:37:27PM +0200, Pekka Paalanen wrote: > Change the boolean parameter 'resize_hint' into a bitmask 'flags'. > > Note, that this flags is very different to the other flags used in > creating the toysurface implementations. They do not make sense to mix > one way or the othe

Re: [PATCH weston] compositor: Fix rendering with shm transformed buffers

On Wed, Nov 28, 2012 at 05:10:26PM +0200, Ander Conselvan de Oliveira wrote: > The implementation of buffer transformation didn't handle transformed > shm buffers properly. The partial texture upload was broken since the > damage is in surface coordinates that don't necessarily match the > buffer's

Re: [PATCH weston] Fix a crash when opening two terminal windows and closing the first one.

On Thu, Nov 29, 2012 at 12:27:09AM -0800, Dima Ryazanov wrote: > To reproduce, launch the terminal, open a second window using Ctrl-Shift-N, > go back to the first window, and press Ctrl-D. The terminal's master FD gets > events even after being closed, causing terminal_destroy to be called twice >

Re: [PATCH mesa] egl/wayland: Don't invalidate drawable on swap buffers

On Fri, Nov 30, 2012 at 11:07:09AM -0500, Kristian Høgsberg wrote: > On Fri, Nov 30, 2012 at 05:41:02PM +0200, Ander Conselvan de Oliveira wrote: > > We used to invalidate the drawable after a call to eglSwapBuffers(), > > so that a wl_egl_window_resize() would take effect for the next frame. > > H

Re: [PATCH mesa] egl/wayland: Don't invalidate drawable on swap buffers

On Fri, Nov 30, 2012 at 05:41:02PM +0200, Ander Conselvan de Oliveira wrote: > We used to invalidate the drawable after a call to eglSwapBuffers(), > so that a wl_egl_window_resize() would take effect for the next frame. > However, that leads to calling dri2_get_buffers() when eglMakeCurrent() > is

[PATCH 5/5] editor: add support for pre-edit styling

From: Jan Arne Petersen Add pango dependency to the example and use pango for text handling. Signed-off-by: Jan Arne Petersen --- clients/Makefile.am | 8 +- clients/editor.c| 444 +++- configure.ac| 3 + 3 files changed, 170 inse

[PATCH 1/5] text: add pre-edit styling support to protocol

From: Jan Arne Petersen Also add a separate preedit-cursor event and add a commit argument to preedit-string to allow to support commit on reset. Fix editor and keyboard example to adapt to the protocol changes. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 73 +

[PATCH 2/5] text: add serial argument to text protocol

From: Jan Arne Petersen The serial argument will allow to ignore outdated events from before a reset request. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 13 - clients/keyboard.c | 20 ++-- clients/weston-simple-im.c | 21 ++

[PATCH 0/5] Add pre-edit styling support

From: Jan Arne Petersen Add pre-edit styling support to the text protocol and the keyboard and editor examples. The editor example client depends on pango (for text layout) now. Also add support for commit on reset, so that a pending composing (pre-edit) text is commited on unfocus or cursor pos

[PATCH 3/5] editor: support commit on reset

From: Jan Arne Petersen Commit pending pre-edit text when focus-out or changing the cursor location. Signed-off-by: Jan Arne Petersen --- clients/editor.c | 46 +- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/clients/editor.c b/clie

[PATCH 4/5] keyboard: Add support for pre-edit styling

From: Jan Arne Petersen Adds a button to the keyboard to support different styles of pre-edit styling. Signed-off-by: Jan Arne Petersen --- clients/keyboard.c | 85 +++--- 1 file changed, 61 insertions(+), 24 deletions(-) diff --git a/clients/ke

Re: [PATCH weston 1/5] compositor-drm: Allow scanning out of opaque ARGB surfaces

Looks like I screwed up git send-email. Sorry for the noise. On 11/30/2012 04:48 PM, a wrote: From: Ander Conselvan de Oliveira --- src/compositor-drm.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/src/compositor-drm.c b/src/compo

[PATCH mesa] egl/wayland: Don't invalidate drawable on swap buffers

We used to invalidate the drawable after a call to eglSwapBuffers(), so that a wl_egl_window_resize() would take effect for the next frame. However, that leads to calling dri2_get_buffers() when eglMakeCurrent() is called with the current context and surface, and a later call to wl_egl_window_resiz

[PATCH weston 3/5] window: Let clients set buffer transformations

When a window's buffer transformation is set, its buffers are reallocated with the appropriate size (i.e., with width and height swapped in case of 90 or 270 degree rotation). --- clients/window.c | 36 clients/window.h |7 +++ 2 files changed, 39 ins

[PATCH weston 1/5] compositor-drm: Allow scanning out of opaque ARGB surfaces

From: Ander Conselvan de Oliveira --- src/compositor-drm.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 2066dd4..24a71f1 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -

[PATCH weston 5/5] clients: Replace transformed with a toytoolkit implementation

--- clients/Makefile.am | 11 +- clients/transformed.c | 812 + 2 files changed, 145 insertions(+), 678 deletions(-) diff --git a/clients/Makefile.am b/clients/Makefile.am index fd83a29..26a5c60 100644 --- a/clients/Makefile.am +++ b/clients/Ma

[PATCH weston 4/5] window: Add a way to retrieve a window's output transform

Add the output_get_transform() entry point and an output handler hook. --- clients/window.c | 23 +++ clients/window.h |9 + 2 files changed, 32 insertions(+) diff --git a/clients/window.c b/clients/window.c index 1f34c4c..d7acedd 100644 --- a/clients/window.c ++

[PATCH weston 2/5] window: Honour opaque field for windows without a frame

Since the opaque region was set in frame_resize_handler(), if a client created a frameless window setting the toplevel widget as opaque would have no effect. This patch fixes this by moving the call wl_surface_set_opaque_region() to idle_resize(), and changing the latter function to set the whole

[PATCH weston 0/5] Convert transformed buffer test client to toytoolkit

Hi, This series converts the transformed buffer test client to use toytoolkit. The first patch is a resend of a patch that fell through the cracks. With the change to use toytoolkit, there's no way to allocate an XRGB buffer, so this is needed to test rotated scan out of client buffers. (There wa

[PATCH weston 2/2] Fix build warnings from image_loader

Fix the following build warnings, and the build failures due to the warning fixes: CC libshared_cairo_la-image-loader.lo image-loader.c:369:1: warning: no previous prototype for 'load_image' CC x11_backend_la-compositor-x11.lo compositor-x11.c: In function 'x11_output_set_icon': compo

[PATCH weston 1/2] window: change boolean to flags in toysurface::prepare()

Change the boolean parameter 'resize_hint' into a bitmask 'flags'. Note, that this flags is very different to the other flags used in creating the toysurface implementations. They do not make sense to mix one way or the other. Prepare() cannot change the surface type, and surface constructors do n