Since the XKB says that support for detectable repeat is in fact
optional:
http://www.x.org/releases/current/doc/kbproto/xkbproto.html#Querying_and_Changing_Per_Client_Flags
we might as well be good citizens and check that it was really set. With
the X server this would never happen, though.
Signe
In order to use XKB capabilities (as we do), the client must issue an
XkbUseExtension request:
http://www.x.org/releases/current/doc/kbproto/xkbproto.html#Initializing_the_X_Keyboard_Extension
The reason this succeeds currently is that XOpenDisplay from Xlib does
this for us. But it is better not
Where we don't look at the error details, pass NULL to the 'error'
argument and test using the reply return value instead.
Where we do need it, remember to free it.
Signed-off-by: Ran Benita
---
src/compositor-x11.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --gi
On Wed, Oct 31, 2012 at 11:29:07AM -0400, Kristian Høgsberg wrote:
> On Wed, Oct 31, 2012 at 12:13:09AM +0200, Ran Benita wrote:
> > In order to use XKB capabilities (as we do), the client must issue an
> > XkbUseExtension request:
> > http://www.x.org/releases/current/doc/kbproto/xkbproto.html#Ini
On Wed, Oct 31, 2012 at 05:55:45PM +0200, Ander Conselvan de Oliveira wrote:
> Culling of the repaint of a surface behind an opaque surface on the
> same plane was broken by commit 547149a9 [1]. The idea of that commit
> is that the damage obscured by an overlay would remain on the primary
> plane
On Wed, Oct 31, 2012 at 05:55:46PM +0200, Ander Conselvan de Oliveira wrote:
> Pressing ctrl-alt-o will cause the overlays to be hidden, but surfaces
> will still be assigned to different planes. This helps with debugging
> of repaint culling below surfaces in other planes.
> ---
>
> This was usef
On 31.10.2012 16:31, Kristian Høgsberg wrote:
> On Wed, Oct 31, 2012 at 12:13:08AM +0200, Ran Benita wrote:
>> In order to use xcb_request_check(), given a request without a reply,
>> you need to use the _checked() variant of the request function.
>> See xcb-requests(3).
>
> Applied. Did not know
Oops, seems like I sent this patch twice. Didn't notice I had -1 in the
command line together with *.patch.
Sorry for the noise.
Ander
On 10/31/2012 05:55 PM, Ander Conselvan de Oliveira wrote:
Pressing ctrl-alt-o will cause the overlays to be hidden, but surfaces
will still be assigned to di
Culling of the repaint of a surface behind an opaque surface on the
same plane was broken by commit 547149a9 [1]. The idea of that commit
is that the damage obscured by an overlay would remain on the primary
plane damage and be repainted when the overlay moved. However, in the
case the two surfaces
Pressing ctrl-alt-o will cause the overlays to be hidden, but surfaces
will still be assigned to different planes. This helps with debugging
of repaint culling below surfaces in other planes.
---
src/compositor-drm.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff
Pressing ctrl-alt-o will cause the overlays to be hidden, but surfaces
will still be assigned to different planes. This helps with debugging
of repaint culling below surfaces in other planes.
---
This was useful for testing the previous patch. I could not figure out
a way for not having a hardcode
On Wed, Oct 31, 2012 at 12:13:08AM +0200, Ran Benita wrote:
> In order to use xcb_request_check(), given a request without a reply,
> you need to use the _checked() variant of the request function.
> See xcb-requests(3).
Applied. Did not know there was a xcb-requests man page, that would
have sav
On Wed, Oct 31, 2012 at 12:13:09AM +0200, Ran Benita wrote:
> In order to use XKB capabilities (as we do), the client must issue an
> XkbUseExtension request:
> http://www.x.org/releases/current/doc/kbproto/xkbproto.html#Initializing_the_X_Keyboard_Extension
>
> The reason this succeeds currently
13 matches
Mail list logo
